ti-st: no need to check return value of debugfs_create functions
Greg Kroah-Hartman
maintainerPATCH 1/1 ti-st: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Arnd Bergmann <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/misc/ti-st/st_kim.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/misc/ti-st/st_kim.c +0 -4
@@ -761,10 +761,6 @@ static int kim_probe(struct platform_device *pdev)pr_info ("sysfs entries created\n" ); kim_debugfs_dir =debugfs_create_dir ("ti-st" ,NULL ); -if (!kim_debugfs_dir) { -pr_err (" debugfs entries creation failed " ); -return 0 ; - }debugfs_create_file ("version" ,S_IRUGO , kim_debugfs_dir, kim_gdata, &version_fops);
Signature · 1 line
2.22.0
Quoted 8 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Reviewed-by Arnd Bergmann <[email protected]>