Skip to contentSkip to conversation

net: dsa: tag_sja1105: Select CONFIG_PACKING

PATCH Applied Vladimir Oltean 3 participants 3 messages Jun 11, 2019 – Jun 14, 2019

Subsystems (4)
lore
Share & tools
lore

Vladimir Oltean

author maintainer
#0 lore raw

PATCH 1/1 net: dsa: tag_sja1105: Select CONFIG_PACKING

The packing facility is needed to decode Ethernet meta frames containing source port and RX timestamping information.

The DSA driver selects CONFIG_PACKING, but the tagger did not, and since taggers can be now compiled as modules independently from the drivers themselves, this is an issue now, as CONFIG_PACKING is disabled by default on all architectures.

Fixes e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
---
 net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
net/dsa/Kconfig +1 -0
index d449f78c1bd0..6e942dda1bcd 100644
@@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
 config NET_DSA_TAG_SJA1105
 	tristate "Tag driver for NXP SJA1105 switches"
 	select NET_DSA_TAG_8021Q
+	select PACKING
 	help
 	  Say Y or M if you want to enable support for tagging frames with the
 	  NXP SJA1105 switch family. Both the native tagging protocol (which
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Vladimir Oltean

The packing facility is needed to decode Ethernet meta frames containing source port and RX timestamping information.

The DSA driver selects CONFIG_PACKING, but the tagger did not, and since taggers can be now compiled as modules independently from the drivers themselves, this is an issue now, as CONFIG_PACKING is disabled by default on all architectures.

Fixes e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")

Thanks.

Quoted 17 lines
---
 net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
net/dsa/Kconfig +1 -0
index d449f78c1bd0..6e942dda1bcd 100644
@@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
 config NET_DSA_TAG_SJA1105
 	tristate "Tag driver for NXP SJA1105 switches"
 	select NET_DSA_TAG_8021Q
+	select PACKING
 	help
 	  Say Y or M if you want to enable support for tagging frames with the
 	  NXP SJA1105 switch family. Both the native tagging protocol (which
Signature · 1 line
~Randy
maintainer Applied
#2 lore raw
In reply to Vladimir Oltean

From: Vladimir Oltean <[email protected]>
Date: Tue, 11 Jun 2019 21:47:45 +0300

Quoted 11 lines

The packing facility is needed to decode Ethernet meta frames containing source port and RX timestamping information.

The DSA driver selects CONFIG_PACKING, but the tagger did not, and since taggers can be now compiled as modules independently from the drivers themselves, this is an issue now, as CONFIG_PACKING is disabled by default on all architectures.

Fixes e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")

Applied.