migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS
PATCH 1/1 migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS
On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel's sem_sync semaphore. This semaphore is triggered by a packet with MULTIFD_FLAG_SYNC flag. While in current implementation, we don't do multifd_send_sync_main() to send such packet when blk_mig_bulk_active() is true.
This will leads to the receive threads won't notify multifd_recv_sync_main() by sem_sync. And multifd_recv_sync_main() will always wait there.
[Note]: normal migration test works, while didn't test the blk_mig_bulk_active() case. Since not sure how to produce this situation.
--- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
migration/ram.c +1 -1
@@ -3458,8 +3458,8 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)*/ ram_control_after_iterate (f,RAM_CONTROL_ROUND ); -multifd_send_sync_main (); out: +multifd_send_sync_main ();qemu_put_be64 (f,RAM_SAVE_FLAG_EOS );qemu_fflush (f); ram_counters.transferred +=8 ;
Signature · 1 line
2.19.1
Quoted 11 lines · Wei Yang
On receiving
RAM_SAVE_FLAG_EOS,multifd_recv_sync_main()is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel'ssem_syncsemaphore. This semaphore is triggered by a packet withMULTIFD_FLAG_SYNCflag. While in current implementation, we don't domultifd_send_sync_main()to send such packet whenblk_mig_bulk_active()is true.This will leads to the receive threads won't notify
multifd_recv_sync_main()bysem_sync. Andmultifd_recv_sync_main()will always wait there.
Quoted 5 lines
[Note]: normal migration test works, while didn't test the
blk_mig_bulk_active()case. Since not sure how to produce this situation.Signed-off-by Wei Yang <[email protected]>
Block migration is weird.
Block migration is weird.
....
Quoted 16 lines · Juan Quintela
Quoted 15 lines · Wei Yang
On receiving
RAM_SAVE_FLAG_EOS,multifd_recv_sync_main()is called to synchronize receive threads. Current synchronization mechanism is to wait for each channel'ssem_syncsemaphore. This semaphore is triggered by a packet withMULTIFD_FLAG_SYNCflag. While in current implementation, we don't domultifd_send_sync_main()to send such packet whenblk_mig_bulk_active()is true.This will leads to the receive threads won't notify
multifd_recv_sync_main()bysem_sync. Andmultifd_recv_sync_main()will always wait there.[Note]: normal migration test works, while didn't test the
blk_mig_bulk_active()case. Since not sure how to produce this situation.
Quoted 7 lines
Quoted 1 line
Signed-off-by Wei Yang <[email protected]>Reviewed-by Juan Quintela <[email protected]>Block migration is weird.
Block migration is weird.
....
Block migration means migrate a whole disk?
Signature · 2 lines
Wei Yang Help you, Help me