Skip to contentSkip to conversation

ARM: dts: am335x-baltos: Fix PHY mode for ethernet

PATCH In review [email protected] 2 participants 4 messages Jun 11, 2019 – Jun 12, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am335x-baltos: Fix PHY mode for ethernet

From: Yegor Yefremov <[email protected]>

The PHY must add both tx and rx delay and not only on the tx clock.

---
 arch/arm/boot/dts/am335x-baltos-ir2110.dts | 2 +-
 arch/arm/boot/dts/am335x-baltos-ir3220.dts | 2 +-
 arch/arm/boot/dts/am335x-baltos-ir5221.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/am335x-baltos-ir2110.dts +1 -1
index 2f650a736b44..f127af2afd00 100644
@@ -68,7 +68,7 @@
 };
 
 &cpsw_emac1 {
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii-id";
 	dual_emac_res_vlan = <2>;
 	phy-handle = <&phy1>;
 };
arch/arm/boot/dts/am335x-baltos-ir3220.dts +1 -1
index 1ba66d5e21e8..058d9eb96cff 100644
@@ -110,7 +110,7 @@
 };
 
 &cpsw_emac1 {
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii-id";
 	dual_emac_res_vlan = <2>;
 	phy-handle = <&phy1>;
 };
arch/arm/boot/dts/am335x-baltos-ir5221.dts +1 -1
index eed65fc0e8e6..7b99c8ed3c3a 100644
@@ -128,7 +128,7 @@
 };
 
 &cpsw_emac1 {
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii-id";
 	dual_emac_res_vlan = <2>;
 	phy-handle = <&phy1>;
 };
Signature · 1 line
2.17.0
#1 lore raw

Hi,

Quoted 3 lines · * [email protected] <[email protected]> [190611 02:31]:

From: Yegor Yefremov <[email protected]>

The PHY must add both tx and rx delay and not only on the tx clock.

As we're close to -rc5, I applied this against v5.2-rc1 and merged into omap-for-v5.3/dt as it seems it's optional or has been broken for a while with no fixes tag. After it hits the mainline kernel during the merge window you can request it be applied into the stable trees as needed.

However, if this is urgent, let me know what regression it fixes and I'll merge it into my fixes branch too.

Regards,

Tony

#2 lore raw

Hi Tony,

Quoted 8 lines · Tony Lindgren

Hi,

Quoted 3 lines · * [email protected] <[email protected]> [190611 02:31]:

From: Yegor Yefremov <[email protected]>

The PHY must add both tx and rx delay and not only on the tx clock.

Quoted 7 lines

As we're close to -rc5, I applied this against v5.2-rc1 and merged into omap-for-v5.3/dt as it seems it's optional or has been broken for a while with no fixes tag. After it hits the mainline kernel during the merge window you can request it be applied into the stable trees as needed.

However, if this is urgent, let me know what regression it fixes and I'll merge it into my fixes branch too.

This is the same fix as 759c962d3c9bb1a60e3b4b780daa66ee6d4be13a:

ARM: dts: am335x-evmsk: Fix PHY mode for ethernet

The PHY must add both tx and rx delay and not only on the tx clock. The board uses AR8031_AL1A PHY where the rx delay is enabled by default, the tx dealy is disabled.

The reason why rgmii-txid worked because the rx delay was not disabled by the driver so essentially we ended up with rgmii-id PHY mode.

It seems to be working in 4.19. So I think kernels 5.0, 5.1 are the first to be affected. Without this patch eth1 is not working on Baltos devices.

Thanks.

Best regards,
Yegor

#3 lore raw
Quoted 27 lines · Yegor Yefremov

Hi Tony,

Quoted 8 lines · Tony Lindgren

Hi,

Quoted 3 lines · * [email protected] <[email protected]> [190611 02:31]:

From: Yegor Yefremov <[email protected]>

The PHY must add both tx and rx delay and not only on the tx clock.

Quoted 7 lines

As we're close to -rc5, I applied this against v5.2-rc1 and merged into omap-for-v5.3/dt as it seems it's optional or has been broken for a while with no fixes tag. After it hits the mainline kernel during the merge window you can request it be applied into the stable trees as needed.

However, if this is urgent, let me know what regression it fixes and I'll merge it into my fixes branch too.

This is the same fix as 759c962d3c9bb1a60e3b4b780daa66ee6d4be13a:

ARM: dts: am335x-evmsk: Fix PHY mode for ethernet

The PHY must add both tx and rx delay and not only on the tx clock. The board uses AR8031_AL1A PHY where the rx delay is enabled by default, the tx dealy is disabled.

Quoted 6 lines

The reason why rgmii-txid worked because the rx delay was not disabled by the driver so essentially we ended up with rgmii-id PHY mode.

It seems to be working in 4.19. So I think kernels 5.0, 5.1 are the first to be affected. Without this patch eth1 is not working on Baltos devices.

OK thanks so it's pretty regression recent then, I'll merge it into fixes too.

Regards,

Tony