mmc: host: s3cmci: no need to check return value of debugfs_create functions
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 4/4 mmc: host: s3cmci: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Also, because there is no need to save the file dentries, remove them from the host-specific structure and just recursively delete the directory that the driver created, when shutting down.
Cc Ben Dooks <[email protected]>
Cc Ulf Hansson <[email protected]>
Cc <[email protected]>
Cc <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/mmc/host/s3cmci.c | 27 ++++++--------------------- drivers/mmc/host/s3cmci.h | 2 -- 2 files changed, 6 insertions(+), 23 deletions(-)
drivers/mmc/host/s3cmci.c +6 -21
@@ -1452,33 +1452,18 @@ DEFINE_SHOW_ATTRIBUTE(s3cmci_regs);static void s3cmci_debugfs_attach (struct s3cmci_host *host) {struct device *dev = &host->pdev->dev; +struct dentry *root; - host->debug_root =debugfs_create_dir (dev_name (dev),NULL ); -if (IS_ERR (host->debug_root)) { -dev_err (dev,"failed to create debugfs root\n" ); -return ; - } - - host->debug_state =debugfs_create_file ("state" ,0444 , - host->debug_root, host, - &s3cmci_state_fops); - -if (IS_ERR (host->debug_state)) -dev_err (dev,"failed to create debug state file\n" ); - - host->debug_regs =debugfs_create_file ("regs" ,0444 , - host->debug_root, host, - &s3cmci_regs_fops); + root =debugfs_create_dir (dev_name (dev),NULL ); + host->debug_root = root; -if (IS_ERR (host->debug_regs)) -dev_err (dev,"failed to create debug regs file\n" ); +debugfs_create_file ("state" ,0444 , root, host, &s3cmci_state_fops); +debugfs_create_file ("regs" ,0444 , root, host, &s3cmci_regs_fops); }static void s3cmci_debugfs_remove (struct s3cmci_host *host) { -debugfs_remove (host->debug_regs); -debugfs_remove (host->debug_state); -debugfs_remove (host->debug_root); +debugfs_remove_recursive (host->debug_root); }#else
drivers/mmc/host/s3cmci.h +0 -2
@@ -70,8 +70,6 @@ struct s3cmci_host {#ifdef CONFIG_DEBUG_FS struct dentry *debug_root; -struct dentry *debug_state; -struct dentry *debug_regs;#endif #ifdef CONFIG_ARM_S3C24XX_CPUFREQ
Signature · 1 line
2.22.0