Skip to contentSkip to conversation

mpls: fix af_mpls dependencies for real

PATCH Applied Matteo Croce 2 participants 2 messages Jun 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpls: fix af_mpls dependencies for real

Randy reported that selecting MPLS_ROUTING without PROC_FS breaks the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select doesn't recursively handle dependencies.
Change the select into a dependency.

Fixes c1a9d65954c6 ("mpls: fix af_mpls dependencies")
---
 net/mpls/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/mpls/Kconfig +1 -1
index 2b802a48d5a6..d1ad69b7942a 100644
@@ -26,7 +26,7 @@ config NET_MPLS_GSO
 config MPLS_ROUTING
 	tristate "MPLS: routing support"
 	depends on NET_IP_TUNNEL || NET_IP_TUNNEL=n
-	select PROC_SYSCTL
+	depends on PROC_SYSCTL
 	---help---
 	 Add support for forwarding of mpls packets.
 
Signature · 1 line
2.21.0
maintainer Applied
#1 lore raw

From: Matteo Croce <[email protected]>
Date: Wed, 12 Jun 2019 11:50:37 +0200

Quoted 9 lines

Randy reported that selecting MPLS_ROUTING without PROC_FS breaks the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select doesn't recursively handle dependencies.
Change the select into a dependency.

Fixes c1a9d65954c6 ("mpls: fix af_mpls dependencies")

Applied.