Skip to contentSkip to conversation

sysctl: fix build error

PATCH In review Matteo Croce 2 participants 2 messages Jun 13, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysctl: fix build error

Commit cefdca0a86be ("userfaultfd/sysctl: add vm.unprivileged_userfaultfd") reintroduces a reference to 'zero' and 'one'.
Use the SYSCTL_{ZERO,ONE} symbols instead.

---
 kernel/sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sysctl.c +2 -2
index c77174336d16..4dce89d74a40 100644
@@ -1735,8 +1735,8 @@ static struct ctl_table vm_table[] = {
 		.maxlen		= sizeof(sysctl_unprivileged_userfaultfd),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= &zero,
-		.extra2		= &one,
+		.extra1		= SYSCTL_ZERO,
+		.extra2		= SYSCTL_ONE,
 	},
 #endif
 	{ }
Signature · 1 line
2.21.0
#1 lore raw
Quoted 3 lines · On Thu, 13 Jun 2019 00:01:20 +0200 Matteo Croce <[email protected]> wrote:

Commit cefdca0a86be ("userfaultfd/sysctl: add vm.unprivileged_userfaultfd") reintroduces a reference to 'zero' and 'one'.
Use the SYSCTL_{ZERO,ONE} symbols instead.

proc-sysctl-add-shared-variables-for-range-check-fix.patch (which has been in linux-next for over a week) already fixed that.

Quoted 1 line

Some robot glitch I guess?