Add cafe and wlroots packages
v2 cover Add cafe and wlroots packages
Hello,
This is a patch series which adds the Cage Wayland compositor, and the wlroots library which is a dependency.
I find Cage well suited for kiosks and in general "single-application, fullscreen" use cases. I find it particularly suitable to use in combination with Cog (the WPE WebKit launcher), for many cases in which a full-fledged compositor like Weston is not really needed. A typical example is generating a small image to run a single Web application from a Raspberry Pi right after bootup.
Cheers,
?Adri?n
Adrian Perez de Castro (2):
package/wlroots: new package
package/cage: new package
package/Config.in | 2 + package/cage/Config.in | 32 ++++++++ package/cage/cage.hash | 5 ++ package/cage/cage.mk | 19 +++++ ...onfig-to-find-wayland-scanner-when-c.patch | 45 +++++++++++ package/wlroots/Config.in | 62 ++++++++++++++ package/wlroots/wlroots.hash | 5 ++ package/wlroots/wlroots.mk | 80 +++++++++++++++++++ 8 files changed, 250 insertions(+) create mode 100644 package/cage/Config.in create mode 100644 package/cage/cage.hash create mode 100644 package/cage/cage.mk create mode 100644 package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch create mode 100644 package/wlroots/Config.in create mode 100644 package/wlroots/wlroots.hash create mode 100644 package/wlroots/wlroots.mk
Signature · 1 line
2.22.0
PATCH v2 1/2 package/wlroots: new package
wlroots is a modular library which provides building blocks to implement Wayland compositors. wlroots is a dependency of the Cage Wayland compositor.
https://github.com/swaywm/wlroots/
---
Changes v1 -> v2:
- Review dependencies (as per Thomas' comments)
- Add patch to use wayland-scanner from host tools dir (pointed out by Fran?ois)
--- package/Config.in | 1 + ...onfig-to-find-wayland-scanner-when-c.patch | 45 +++++++++++ package/wlroots/Config.in | 62 ++++++++++++++ package/wlroots/wlroots.hash | 5 ++ package/wlroots/wlroots.mk | 80 +++++++++++++++++++ 5 files changed, 193 insertions(+) create mode 100644 package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch create mode 100644 package/wlroots/Config.in create mode 100644 package/wlroots/wlroots.hash create mode 100644 package/wlroots/wlroots.mk
package/Config.in +1 -0
@@ -1347,6 +1347,7 @@ menu "Graphics" source "package/waylandpp/Config.in" source "package/webkitgtk/Config.in" source "package/webp/Config.in" + source "package/wlroots/Config.in" source "package/woff2/Config.in" source "package/wpebackend-fdo/Config.in" source "package/wpewebkit/Config.in"
package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch new file +45 -0
45 lines not on this page · raw message
package/wlroots/Config.in new file +62 -0
62 lines not on this page · raw message
package/wlroots/wlroots.hash new file +5 -0
@@ -0,0 +1,5 @@ +# Generated locally +sha256 9cf3716f3683d800df8b150f256ff66dad65faf13a9d67c284f67a9444d28c70 0.6.0.tar.gz + +# Hashes for license files: +sha256 ffd3737a478b83a8b51b42757d3bf909ef36694508355879722e11fc1fa6736b LICENSE
package/wlroots/wlroots.mk new file +80 -0
80 lines not on this page · raw message
Signature · 1 line
2.22.0
PATCH v2 1/2 package/wlroots: new package
Hi Adrian,
Quoted 3 lines · Adrian Perez de Castro
wlroots is a modular library which provides building blocks to implement Wayland compositors. wlroots is a dependency of the Cage Wayland compositor.
[snip]
Quoted 4 lines
package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch new file +4
-0+When cross-compiling it is still needed to run a native wayland-scanner, +but many tools for the task will still have pkg-config return the +location of wayland-scanner for the target in some location which may +be the same as for some native installation of wayland-scanner; but
package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch line 20
Quoted 10 lines
package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch new file +10
-0+which is not the copy of the program that the compilation system wants +packages to use (which are typically in a "host tools" directory +elsewhere). + +This disables usage of pkg-config to find wayland-scanner when +cross-compiling because most tools for the job will set $PATH in a way +that the correct installation of the tool will be found first. + +Signed-off-by: Adrian Perez de Castro <[email protected]> +[Upstream status: https://github.com/swaywm/wlroots/pull/1722]
I looked at this PR, and the feedback refers to a similar PR in weston, which
gives me an interesting hint. According to Maarten ter Hurne [1], the current state is correct...
[snip]
Quoted 1 line
+-wayland_scanner_dep =
dependency('wayland-scanner', required: false, native: true)
The native: true tells meson to look for a host .pc file, not a target one.
Indeed, in the log we see:
Trying pkg-config binary pkg-config for machine MachineChoice.BUILD at ['../output/host/bin/pkg-config']
(Note that in Buildroot we use wrong terminology; BUILD is what we call host, and HOST is what we call target, or maybe staging is more accurate.)
So it does try to use the pkg-config for the host. Only, we don't tell meson what the pkg-config for the host is, we just tell it where the pkg-config binary is. Our pkg-config binary is actually a wrapper script that set the search directories to STAGING_DIR.
How we normally handle this for host builds is that we explicitly setPKG_CONFIG_LIBDIR etc. in HOST_MAKE_ENV.
Ideally, though, we'd like to be able to tell meson how to call pkg-config for
the target and how to call it for the host, so it can do the right thing. We can *almost* get away with calling pkgconf directly instead of the pkg-config wrapper - except that we also should set PKG_CONFIG_ALLOW_SYSTEM_CFLAGS/LIBS=1 (not for wayland-scanner, but to be able to use host libraries).
So, bottom line, I think we should generate a second wrapper script that sets
the environment variables we currently set in HOST_MAKE_ENV, and tell meson to use that one for MachineChoice.BUILD. Note that I have no idea how to do the latter.
I'm adding a few people who have been involved in meson somehow in Cc to get
their input.
Quoted 18 lines
++if
meson.is_cross_build()
++wayland_scanner_dep=disabler()
++else
++wayland_scanner_dep=dependency('wayland-scanner', required: false, native: true)
++endif
++
+ ifwayland_scanner_dep.found()package/wlroots/0001-Do-not-use-pkg-config-to-find-wayland-scanner-when-c.patch new file +5
-0+ wayland_scanner = find_program( + wayland_scanner_dep.get_pkgconfig_variable('wayland_scanner'), +-- +2.22.0 +package/wlroots/Config.in new file +0
-0
package/wlroots/Config.in line 8
Quoted 8 lines
package/wlroots/Config.in new file +8
-0@@ -0,0 +1,62 @@ +config BR2_PACKAGE_WLROOTS + bool "wlroots" + depends on !BR2_STATIC_LIBS # wayland + depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm, wayland + depends on BR2_ENABLE_LOCALE # libinput + depends on BR2_PACKAGE_HAS_UDEV # libinput + depends on BR2_PACKAGE_MESA3D_OPENGL_EGL + depends on BR2_PACKAGE_MESA3D_OPENGL_ES
Why don't you select mesa instead of depending on it? It is almost what you did
in v1, only you forgot to add 'select BR2_PACKAGE_MESA3D'.
I would also add here a comment that mesa is not strictly needed, only gbm, but
that mesa is the only provider. Either here or in the commit message.
package/wlroots/Config.in line 21
Quoted 13 lines
package/wlroots/Config.in new file +13
-0+ select BR2_PACKAGE_LIBDRM + select BR2_PACKAGE_LIBINPUT + select BR2_PACKAGE_LIBXKBCOMMON + select BR2_PACKAGE_PIXMAN + select BR2_PACKAGE_WAYLAND + select BR2_PACKAGE_WAYLAND_PROTOCOLS + help + wlroots is a modular Wayland library for building compositors + which implements many of their common features. + + https://github.com/swaywm/wlroots + +comment "wlroots requires udev, mesa3d w/ EGL and GLES support"
We use "needs", not "requires" (it's shorter and horizontal space is at a
premium in comments).
package/wlroots/Config.in line 23
Quoted 2 lines
package/wlroots/Config.in new file +2
-0+ depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL || \ + !BR2_PACKAGE_MESA3D_OPENGL_ES || !BR2_PACKAGE_HAS_UDEV
You're missing the comment for !static, threads and locale.
package/wlroots/Config.in line 25
Quoted 2 lines
package/wlroots/Config.in new file +2
-0+ +if BR2_PACKAGE_WLROOTS
There should be nothing between the top symbol and the condition. That way, the
sub-options get properly indented in menuconfig.
package/wlroots/Config.in line 28
Quoted 3 lines
package/wlroots/Config.in new file +3
-0+ +config BR2_PACKAGE_WLROOTS_RDP + bool "RDP backend support"
Remove "support", i.e. just "RDP backend". Or maybe "RDP support". With
"backend", it sounds like you would need at least one backend, and you don't enforce that.
package/wlroots/Config.in line 29
Quoted 1 line
package/wlroots/Config.in new file +1
-0+ depends on BR2_PACKAGE_FREERDP
Why not select freerdp?
package/wlroots/Config.in line 38
Quoted 9 lines
package/wlroots/Config.in new file +9
-0+ help + Support Wayland sessions served using the RDP protocol + +comment "RDP backend support needs freerdp" + depends on !BR2_PACKAGE_FREERDP + +config BR2_PACKAGE_WLROOTS_X11 + bool "X11 backend support" + depends on BR2_PACKAGE_XORG7
We don't do select of XORG7 so this is fine.
Quoted 30 lines
package/wlroots/Config.in new file +24
-0+ select BR2_PACKAGE_LIBXCB + select BR2_PACKAGE_XLIB_LIBX11 + help + Support Wayland sessions nested inside a X11 window + +comment "X11 backend support needs X.org enabled" + depends on !BR2_PACKAGE_XORG7 + +config BR2_PACKAGE_WLROOTS_XWAYLAND + bool "XWayland support" + depends on BR2_PACKAGE_XORG7 + select BR2_PACKAGE_LIBXCB + help + Enable support for XWayland + +comment "XWayland support needs X.org enabled" + depends on !BR2_PACKAGE_XORG7 + +config BR2_PACKAGE_WLROOTS_ROOTSTON + bool "rootston" + help + Build and install the rootston example compositor + +endifpackage/wlroots/wlroots.hash new file +0
-0
package/wlroots/wlroots.hash line 1
Quoted 1 line
package/wlroots/wlroots.hash new file +1
-0@@ -0,0 +1,5 @@ +# Generated locally
There's an .asc for the release, so please verify the tarball with it and add:
# Generated locally, after checking
https://github.com/swaywm/wlroots/releases/download/0.6.0/wlroots-0.6.0.tar.gz.sig
Quoted 10 lines
package/wlroots/wlroots.hash new file +4
-0+sha256 9cf3716f3683d800df8b150f256ff66dad65faf13a9d67c284f67a9444d28c70 0.6.0.tar.gz + +# Hashes for license files: +sha256 ffd3737a478b83a8b51b42757d3bf909ef36694508355879722e11fc1fa6736b LICENSEpackage/wlroots/wlroots.mk new file +0
-0
package/wlroots/wlroots.mk line 9
Quoted 9 lines
package/wlroots/wlroots.mk new file +9
-0@@ -0,0 +1,80 @@ +################################################################################ +# +# wlroots +# +################################################################################ + +WLROOTS_VERSION = 0.6.0 +WLROOTS_SITE = https://github.com/swaywm/wlroots/archive +WLROOTS_SOURCE = $(WLROOTS_VERSION).tar.gz
This is not an uploaded tarball, so please use the github helper.
package/wlroots/wlroots.mk line 15
Quoted 6 lines
package/wlroots/wlroots.mk new file +6
-0+WLROOTS_LICENSE = MIT +WLROOTS_INSTALL_STAGING = YES + +WLROOTS_DEPENDENCIES = host-pkgconf host-wayland libegl libinput \ + libxkbcommon mesa3d pixman udev \ + wayland wayland-protocols
Indent these with just one tab.
Thanks!
Regards,
Arnout
[1] https://gitlab.freedesktop.org/wayland/weston/merge_requests/157#note_154283
[snip]
PATCH v2 2/2 package/cage: new package
In reply to Adrian Perez de CastroCage is a "kiosk" Wayland compositor, which shows a single maximized application at a time and limits user interaction to that application.
https://www.hjdskes.nl/projects/cage/
---
Changes v1 -> v2:
- Reviewed dependencies (as per Thomas' suggestions)
- Switched to Cage 0.1.1, which does not require patching to build
with wlroots 0.6.0
--- package/Config.in | 1 + package/cage/Config.in | 32 ++++++++++++++++++++++++++++++++ package/cage/cage.hash | 5 +++++ package/cage/cage.mk | 19 +++++++++++++++++++ 4 files changed, 57 insertions(+) create mode 100644 package/cage/Config.in create mode 100644 package/cage/cage.hash create mode 100644 package/cage/cage.mk
package/Config.in +1 -0
@@ -329,6 +329,7 @@ comment "QT libraries and helper libraries" source "package/quazip/Config.in" source "package/qwt/Config.in" endif + source "package/cage/Config.in" source "package/tekui/Config.in" source "package/weston/Config.in" source "package/x11r7/Config.in"
package/cage/Config.in new file +32 -0
@@ -0,0 +1,32 @@ +config BR2_PACKAGE_CAGE + bool "cage" + depends on !BR2_STATIC_LIBS # wlroots + depends on BR2_INSTALL_LIBSTDCPP # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS # wlroots + depends on BR2_TOOLCHAIN_HAS_SYNC_1 # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # wlroots + depends on BR2_ENABLE_LOCALE # wlroots + depends on BR2_PACKAGE_HAS_UDEV # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wlroots + depends on BR2_PACKAGE_HAS_LIBGLES # wlroots + select BR2_PACKAGE_WLROOTS + help + Kiosk compositor for Wayland, which displays a single + maximized application at a time. + + https://www.hjdskes.nl/projects/cage/ + +if BR2_PACKAGE_CAGE + +config BR2_PACKAGE_CAGE_XWAYLAND + bool "XWayland support" + depends on BR2_PACKAGE_XORG7 # wlroots + depends on BR2_PACKAGE_WLROOTS_XWAYLAND + help + Enable support for running X11 applications through XWayland + +comment "XWayland supports needs X.org and support in wlroots enabled" + depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_WLROOTS_XWAYLAND + +endif
package/cage/cage.hash new file +5 -0
@@ -0,0 +1,5 @@ +# Generated locally +sha256 63efbe96cf307381f2bedf9b80153343e255970a70d612515da7dc325dd49478 v0.1.1.tar.gz + +# Hashes for license files: +sha256 1fd28695090b961ed2846627365489228d84f784bff60a90e933febcedaeb65d LICENSE
package/cage/cage.mk new file +19 -0
@@ -0,0 +1,19 @@ +################################################################################ +# +# cage +# +################################################################################ + +CAGE_VERSION = 0.1.1 +CAGE_SITE = https://github.com/Hjdskes/cage/archive +CAGE_SOURCE = v$(CAGE_VERSION).tar.gz +CAGE_LICENSE = MIT +CAGE_DEPENDENCIES = host-pkgconf wlroots + +ifeq ($(BR2_PACKAGE_CAGE_XWAYLAND),y) +CAGE_CONF_OPTS = -Dxwayland=true +else +CAGE_CONF_OPTS = -Dxwayland=false +endif + +$(eval $(meson-package))
Signature · 1 line
2.22.0
PATCH v2 2/2 package/cage: new package
Quoted 41 lines · Adrian Perez de Castro
Cage is a "kiosk" Wayland compositor, which shows a single maximized application at a time and limits user interaction to that application.
https://www.hjdskes.nl/projects/cage/
Signed-off-by Adrian Perez de Castro <[email protected]>---
Changes v1 -> v2:
- Reviewed dependencies (as per Thomas' suggestions)
- Switched to Cage 0.1.1, which does not require patching to buildwith wlroots 0.6.0--- package/Config.in | 1 + package/cage/Config.in | 32 ++++++++++++++++++++++++++++++++ package/cage/cage.hash | 5 +++++ package/cage/cage.mk | 19 +++++++++++++++++++ 4 files changed, 57 insertions(+) create mode 100644 package/cage/Config.in create mode 100644 package/cage/cage.hash create mode 100644 package/cage/cage.mkpackage/Config.in +1
-0@@ -329,6 +329,7 @@ comment "QT libraries and helper libraries" source "package/quazip/Config.in" source "package/qwt/Config.in" endif + source "package/cage/Config.in" source "package/tekui/Config.in" source "package/weston/Config.in" source "package/x11r7/Config.in"package/cage/Config.in new file +0
-0
package/cage/Config.in line 3
Quoted 3 lines
package/cage/Config.in new file +3
-0@@ -0,0 +1,32 @@ +config BR2_PACKAGE_CAGE + bool "cage" + depends on !BR2_STATIC_LIBS # wlroots
Not so important, but we usually do # wlroots -> wayland
package/cage/Config.in line 12
Quoted 9 lines
package/cage/Config.in new file +9
-0+ depends on BR2_INSTALL_LIBSTDCPP # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS # wlroots + depends on BR2_TOOLCHAIN_HAS_SYNC_1 # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # wlroots + depends on BR2_ENABLE_LOCALE # wlroots + depends on BR2_PACKAGE_HAS_UDEV # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wlroots + depends on BR2_PACKAGE_HAS_LIBGLES # wlroots
You didn't update these after updating wlroots...
package/cage/Config.in line 25
Quoted 13 lines
package/cage/Config.in new file +13
-0+ select BR2_PACKAGE_WLROOTS + help + Kiosk compositor for Wayland, which displays a single + maximized application at a time. + + https://www.hjdskes.nl/projects/cage/ + +if BR2_PACKAGE_CAGE + +config BR2_PACKAGE_CAGE_XWAYLAND + bool "XWayland support" + depends on BR2_PACKAGE_XORG7 # wlroots + depends on BR2_PACKAGE_WLROOTS_XWAYLAND
I forgot to mention for wlroots: does it make sense to make Xwayland support
optional? If you have Xorg enabled and you also select a wayland compositor, you're bound to want xwayland, no? And I can't imagine that it would add much to the build size anyway.
Quoted 13 lines
package/cage/Config.in new file +7
-0+ help + Enable support for running X11 applications through XWayland + +comment "XWayland supports needs X.org and support in wlroots enabled" + depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_WLROOTS_XWAYLAND + +endifpackage/cage/cage.hash new file +0
-0
package/cage/cage.hash line 1
Quoted 1 line
package/cage/cage.hash new file +1
-0@@ -0,0 +1,5 @@ +# Generated locally
Same story about checking .asc.
Quoted 10 lines
package/cage/cage.hash new file +4
-0+sha256 63efbe96cf307381f2bedf9b80153343e255970a70d612515da7dc325dd49478 v0.1.1.tar.gz + +# Hashes for license files: +sha256 1fd28695090b961ed2846627365489228d84f784bff60a90e933febcedaeb65d LICENSEpackage/cage/cage.mk new file +0
-0
package/cage/cage.mk line 8
Quoted 8 lines
package/cage/cage.mk new file +8
-0@@ -0,0 +1,19 @@ +################################################################################ +# +# cage +# +################################################################################ + +CAGE_VERSION = 0.1.1 +CAGE_SITE = https://github.com/Hjdskes/cage/archive
Same story about using github helper.
Regards,
Arnout
Quoted 12 lines
package/cage/cage.mk new file +11
-0+CAGE_SOURCE = v$(CAGE_VERSION).tar.gz +CAGE_LICENSE = MIT +CAGE_DEPENDENCIES = host-pkgconf wlroots + +ifeq ($(BR2_PACKAGE_CAGE_XWAYLAND),y) +CAGE_CONF_OPTS = -Dxwayland=true +else +CAGE_CONF_OPTS = -Dxwayland=false +endif + +$(eval $(meson-package))
PATCH v2 2/2 package/cage: new package
Hello Arnout,
Thanks for the thorough review ? I am finally getting round to applying the suggested changes. Also, v3 of the patch set will include wlroots 0.8.1, which has been released in the meantime.
I also have a couple of comments inline below.
Quoted 39 lines · Arnout Vandecappelle
Quoted 38 lines · Adrian Perez de Castro
Cage is a "kiosk" Wayland compositor, which shows a single maximized application at a time and limits user interaction to that application.
https://www.hjdskes.nl/projects/cage/
Signed-off-by Adrian Perez de Castro <[email protected]>---
Changes v1 -> v2:
- Reviewed dependencies (as per Thomas' suggestions)
- Switched to Cage 0.1.1, which does not require patching to buildwith wlroots 0.6.0--- package/Config.in | 1 + package/cage/Config.in | 32 ++++++++++++++++++++++++++++++++ package/cage/cage.hash | 5 +++++ package/cage/cage.mk | 19 +++++++++++++++++++ 4 files changed, 57 insertions(+) create mode 100644 package/cage/Config.in create mode 100644 package/cage/cage.hash create mode 100644 package/cage/cage.mkpackage/Config.in +1
-0@@ -329,6 +329,7 @@ comment "QT libraries and helper libraries" source "package/quazip/Config.in" source "package/qwt/Config.in" endif + source "package/cage/Config.in" source "package/tekui/Config.in" source "package/weston/Config.in" source "package/x11r7/Config.in"package/cage/Config.in new file +0
-0
Quoted 8 lines
package/cage/Config.in line 3
Quoted 6 lines
package/cage/Config.in new file +3
-0@@ -0,0 +1,32 @@ +config BR2_PACKAGE_CAGE + bool "cage" + depends on !BR2_STATIC_LIBS # wlrootsNot so important, but we usually do # wlroots -> wayland
I'll add the ?-> foo? part, to me it makes clearer where the dependency came from :)
Quoted 22 lines
package/cage/Config.in line 12
Quoted 9 lines
package/cage/Config.in new file +9
-0+ depends on BR2_INSTALL_LIBSTDCPP # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS # wlroots + depends on BR2_TOOLCHAIN_HAS_SYNC_1 # wlroots + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # wlroots + depends on BR2_ENABLE_LOCALE # wlroots + depends on BR2_PACKAGE_HAS_UDEV # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL # wlroots + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wlroots + depends on BR2_PACKAGE_HAS_LIBGLES # wlrootsYou didn't update these after updating wlroots...
Quoted 10 lines
package/cage/Config.in new file +10
-0+ select BR2_PACKAGE_WLROOTS + help + Kiosk compositor for Wayland, which displays a single + maximized application at a time. + + https://www.hjdskes.nl/projects/cage/ + +if BR2_PACKAGE_CAGE + +config BR2_PACKAGE_CAGE_XWAYLAND
Quoted 8 lines
package/cage/Config.in line 25
Quoted 3 lines
package/cage/Config.in new file +3
-0+ bool "XWayland support" + depends on BR2_PACKAGE_XORG7 # wlroots + depends on BR2_PACKAGE_WLROOTS_XWAYLANDI forgot to mention for wlroots: does it make sense to make Xwayland support
optional? If you have Xorg enabled and you also select a wayland compositor, you're bound to want xwayland, no? And I can't imagine that it would add much to the build size anyway.
The difference in code size is a few tens of kilobytes on 64-bit ARM. That's peanuts compared with the size of X.org itself, so I think you are right and XWayland support can be automatically enabled in wlroots (and Cage) if the BR2_PACKAGE_XORG7=y symbol is defined.
Quoted 29 lines
Quoted 13 lines
package/cage/Config.in new file +7
-0+ help + Enable support for running X11 applications through XWayland + +comment "XWayland supports needs X.org and support in wlroots enabled" + depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_WLROOTS_XWAYLAND + +endifpackage/cage/cage.hash new file +0
-0package/cage/cage.hash line 1
Quoted 1 line
package/cage/cage.hash new file +1
-0@@ -0,0 +1,5 @@ +# Generated locallySame story about checking .asc.
Quoted 12 lines
package/cage/cage.hash new file +4
-0+sha256 63efbe96cf307381f2bedf9b80153343e255970a70d612515da7dc325dd49478 v0.1.1.tar.gz + +# Hashes for license files: +sha256 1fd28695090b961ed2846627365489228d84f784bff60a90e933febcedaeb65d LICENSEpackage/cage/cage.mk new file +2
-0@@ -0,0 +1,19 @@ +################################################################################ +#
Quoted 8 lines
package/cage/cage.mk line 8
Quoted 6 lines
package/cage/cage.mk new file +6
-0+# cage +# +################################################################################ + +CAGE_VERSION = 0.1.1 +CAGE_SITE = https://github.com/Hjdskes/cage/archiveSame story about using github helper.
It won't be needed anymore for wlroots, as proper (uploded) tarballs are available in the GitHub releases for the newer releases. Let's use the helper for Cage anyway, of course!
Cheers,
?Adri?n
Quoted 19 lines
Regards,
Arnoutpackage/cage/cage.mk line 19
Quoted 12 lines
package/cage/cage.mk new file +11
-0+CAGE_SOURCE = v$(CAGE_VERSION).tar.gz +CAGE_LICENSE = MIT +CAGE_DEPENDENCIES = host-pkgconf wlroots + +ifeq ($(BR2_PACKAGE_CAGE_XWAYLAND),y) +CAGE_CONF_OPTS = -Dxwayland=true +else +CAGE_CONF_OPTS = -Dxwayland=false +endif + +$(eval $(meson-package))_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191110/ff2426b4/attachment.asc>
PATCH v2 2/2 package/cage: new package
Quoted 5 lines · Adrian Perez de Castro
Thanks for the thorough review ? I am finally getting round to applying the suggested changes. Also, v3 of the patch set will include wlroots 0.8.1, which has been released in the meantime.
[...]
Version 3 posted: https://patchwork.ozlabs.org/project/buildroot/list/?series=141961
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191110/34d07fcf/attachment.asc>