Skip to contentSkip to conversation

selftests/bpf: signedness bug in enable_all_controllers()

PATCH Applied Dan Carpenter 3 participants 3 messages Jun 13, 2019 – Jun 14, 2019

Subsystems (4)
Kselftest Kernel janitors BPF BPF selftests
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 selftests/bpf: signedness bug in enable_all_controllers()

The "len" variable needs to be signed for the error handling to work properly.

Fixes 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers")
Signed-off-by Dan Carpenter <[email protected]>
---
 tools/testing/selftests/bpf/cgroup_helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/cgroup_helpers.c +1 -1
index 0d89f0396be4..e95c33e333a4 100644
@@ -47,7 +47,7 @@ int enable_all_controllers(char *cgroup_path)
 	char buf[PATH_MAX];
 	char *c, *c2;
 	int fd, cfd;
-	size_t len;
+	ssize_t len;
 
 	snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path);
 	fd = open(path, O_RDONLY);
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Dan Carpenter

The "len" variable needs to be signed for the error handling to work properly.

Fixes 596092ef8bea ("selftests/bpf: enable all available cgroup v2 controllers")
Signed-off-by Dan Carpenter <[email protected]>

---

Thanks for the fix!

Acked-by Andrii Nakryiko <[email protected]>
Quoted 19 lines
 tools/testing/selftests/bpf/cgroup_helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/cgroup_helpers.c +1 -2
index 0d89f0396be4..e95c33e333a4 100644
@@ -47,7 +47,7 @@ int enable_all_controllers(char *cgroup_path)
        char buf[PATH_MAX];
        char *c, *c2;
        int fd, cfd;
-       size_t len;
+       ssize_t len;
 
        snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path);
        fd = open(path, O_RDONLY);
--

2.20.1