bpf: selftests: Fix warning in flow_dissector
Subsystems (5)
PATCH 1/1 bpf: selftests: Fix warning in flow_dissector
Building the userspace part of the flow_dissector resulted in:
prog_tests/flow_dissector.c: In function ‘tx_tap’:prog_tests/flow_dissector.c:176:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]
return writev(fd, iov, ARRAY_SIZE(iov));
^~~~~~
writeInclude <sys/uio.h> to fix this.
--- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/prog_tests/flow_dissector.c +1 -0
@@ -3,6 +3,7 @@#include <error.h> #include <linux/if.h> #include <linux/if_tun.h> +#include <sys/uio.h> #define CHECK_FLOW_KEYS (desc, got, expected) \ CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \
Signature · 1 line
2.20.1
Quoted 10 lines · Arthur Fabre
Building the userspace part of the
flow_dissectorresulted in:
prog_tests/flow_dissector.c: In function ‘tx_tap’:prog_tests/flow_dissector.c:176:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]return writev(fd, iov, ARRAY_SIZE(iov)); ^~~~~~ writeInclude <
sys/uio.h> to fix this.
Wasn't it fixed already?
See
https://lore.kernel.org/netdev/20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal/
Quoted 20 lines
Signed-off-by Arthur Fabre <[email protected]>--- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + 1 file changed, 1 insertion(+)tools/testing/selftests/bpf/prog_tests/flow_dissector.c +1
-0@@ -3,6 +3,7 @@#include <error.h> #include <linux/if.h> #include <linux/if_tun.h> +#include <sys/uio.h> #define CHECK_FLOW_KEYS (desc, got, expected) \ CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \Signature · 1 line
2.20.1
Ah yes good catch. I guess it hasn't made it into bpf-next yet.
Quoted 37 lines · Stanislav Fomichev
Quoted 10 lines · Arthur Fabre
Building the userspace part of the
flow_dissectorresulted in:
prog_tests/flow_dissector.c: In function ‘tx_tap’:prog_tests/flow_dissector.c:176:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]return writev(fd, iov, ARRAY_SIZE(iov)); ^~~~~~ writeInclude <
sys/uio.h> to fix this.Wasn't it fixed already?
See
https://lore.kernel.org/netdev/20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal/Quoted 20 lines
Signed-off-by Arthur Fabre <[email protected]>--- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + 1 file changed, 1 insertion(+)tools/testing/selftests/bpf/prog_tests/flow_dissector.c +1
-1@@ -3,6 +3,7 @@#include <error.h> #include <linux/if.h> #include <linux/if_tun.h> +#include <sys/uio.h> #define CHECK_FLOW_KEYS (desc, got, expected) \ CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \ --2.20.1