msm: dpu1: no need to check return value of debugfs_create functions
PATCH 1/1 msm: dpu1: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jeykumar Sankaran <[email protected]>
Cc Jordan Crouse <[email protected]>
Cc Abhinav Kumar <[email protected]>
Cc Bruce Wang <[email protected]>
Cc Sravanthi Kollukuduru <[email protected]>
Cc Fritz Koenig <[email protected]>
Cc Chandan Uddaraju <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 -- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 12 +++--------- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 6 +----- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 4 ---- 7 files changed, 4 insertions(+), 28 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +0 -2
@@ -506,8 +506,6 @@ int dpu_core_perf_debugfs_init(struct dpu_kms *dpu_kms, struct dentry *parent)struct dentry *entry; entry =debugfs_create_dir ("core_perf" , parent); -if (IS_ERR_OR_NULL (entry)) -return -EINVAL ;debugfs_create_u64 ("max_core_clk_rate" ,0600 , entry, &perf->max_core_clk_rate);
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +0 -3
@@ -1266,10 +1266,7 @@ static int _dpu_crtc_init_debugfs(struct drm_crtc *crtc) dpu_crtc->debugfs_root =debugfs_create_dir (dpu_crtc->name, crtc->dev->primary->debugfs_root); -if (!dpu_crtc->debugfs_root) -return -ENOMEM ; -/* don't error check these */ debugfs_create_file ("status" ,0400 , dpu_crtc->debugfs_root, dpu_crtc, &debugfs_status_fops);
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -2
@@ -1985,8 +1985,6 @@ static int _dpu_encoder_init_debugfs(struct drm_encoder *drm_enc)/* create overall sub-directory for the encoder */ dpu_enc->debugfs_root =debugfs_create_dir (name, drm_enc->dev->primary->debugfs_root); -if (!dpu_enc->debugfs_root) -return -ENOMEM ;/* don't error check these */ debugfs_create_file("status", 0600,
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +3 -9
@@ -142,8 +142,6 @@ static void dpu_debugfs_danger_init(struct dpu_kms *dpu_kms, struct dentry *parent) {struct dentry *entry =debugfs_create_dir ("danger" , parent); -if (IS_ERR_OR_NULL (entry)) -return ;debugfs_create_file ("danger_status" ,0600 , entry, dpu_kms, &dpu_debugfs_danger_stats_fops);
@@ -218,17 +216,16 @@ void dpu_debugfs_setup_regset32(struct dpu_debugfs_regset32 *regset, } } -void *dpu_debugfs_create_regset32 (const char *name,umode_t mode, +void dpu_debugfs_create_regset32 (const char *name,umode_t mode,void *parent,struct dpu_debugfs_regset32 *regset) {if (!name || !regset || !regset->dpu_kms || !regset->blk_len) -return NULL ; +return ;/* make sure offset is a multiple of 4 */ regset->offset =round_down (regset->offset,4 ); -return debugfs_create_file (name, mode, parent, - regset, &dpu_fops_regset32); +debugfs_create_file (name, mode, parent, regset, &dpu_fops_regset32); }static int _dpu_debugfs_init (struct dpu_kms *dpu_kms)
@@ -240,10 +237,7 @@ static int _dpu_debugfs_init(struct dpu_kms *dpu_kms)return -EINVAL ; entry =debugfs_create_dir ("debug" , dpu_kms->dev->primary->debugfs_root); -if (IS_ERR_OR_NULL (entry)) -return -ENODEV ; -/* allow root to be NULL */ debugfs_create_x32 (DPU_DEBUGFS_HWMASKNAME ,0600 , entry, p);dpu_debugfs_danger_init (dpu_kms, entry);
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h +1 -5
@@ -197,12 +197,8 @@ void dpu_debugfs_setup_regset32(struct dpu_debugfs_regset32 *regset,* @mode: File mode within debugfs * @parent: Parent directory entry within debugfs, can be NULL * @regset: Pointer to persistent register block definition -* -* Return: dentry pointer for newly created file, use either debugfs_remove() -* or debugfs_remove_recursive() (on a parent directory) to remove the -* file */ -void *dpu_debugfs_create_regset32 (const char *name,umode_t mode, +void dpu_debugfs_create_regset32 (const char *name,umode_t mode,void *parent,struct dpu_debugfs_regset32 *regset);/**
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +0 -3
@@ -1329,9 +1329,6 @@ static int _dpu_plane_init_debugfs(struct drm_plane *plane)debugfs_create_dir (pdpu->pipe_name, plane->dev->primary->debugfs_root); -if (!pdpu->debugfs_root) -return -ENOMEM ; -/* don't error check these */ debugfs_create_x32 ("features" ,0600 , pdpu->debugfs_root, &pdpu->features);
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c +0 -4
@@ -318,8 +318,6 @@ void dpu_debugfs_vbif_init(struct dpu_kms *dpu_kms, struct dentry *debugfs_root)int i, j; entry =debugfs_create_dir ("vbif" , debugfs_root); -if (IS_ERR_OR_NULL (entry)) -return ;for (i =0 ; i < dpu_kms->catalog->vbif_count; i++) {struct dpu_vbif_cfg *vbif = &dpu_kms->catalog->vbif[i];
@@ -327,8 +325,6 @@ void dpu_debugfs_vbif_init(struct dpu_kms *dpu_kms, struct dentry *debugfs_root)snprintf (vbif_name,sizeof (vbif_name),"%d" , vbif->id); debugfs_vbif =debugfs_create_dir (vbif_name, entry); -if (IS_ERR_OR_NULL (debugfs_vbif)) -continue ;debugfs_create_u32 ("features" ,0600 , debugfs_vbif, (u32 *)&vbif->features);
Signature · 6 lines
2.22.0 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno