Skip to contentSkip to conversation

fs/proc: add VmTaskSize field to /proc/$$/status

PATCH In review Joel Savitz 2 participants 3 messages Jun 13, 2019 – Jun 15, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 fs/proc: add VmTaskSize field to /proc/$$/status

The kernel provides no architecture-independent mechanism to get the size of the virtual address space of a task (userspace process) without brute-force calculation. This patch allows a user to easily retrieve this value via a new VmTaskSize entry in /proc/$$/status.

---
 Documentation/filesystems/proc.txt | 2 ++
 fs/proc/task_mmu.c                 | 2 ++
 2 files changed, 4 insertions(+)
Documentation/filesystems/proc.txt +2 -0
index 66cad5c86171..1c6a912e3975 100644
@@ -187,6 +187,7 @@ read the file /proc/PID/status:
   VmLib:      1412 kB
   VmPTE:        20 kb
   VmSwap:        0 kB
+  VmTaskSize:	137438953468 kB
   HugetlbPages:          0 kB
   CoreDumping:    0
   THP_enabled:	  1
@@ -263,6 +264,7 @@ Table 1-2: Contents of the status files (as of 4.19)
  VmPTE                       size of page table entries
  VmSwap                      amount of swap used by anonymous private data
                              (shmem swap usage is not included)
+ VmTaskSize                  size of task (userspace process) vm space
  HugetlbPages                size of hugetlb memory portions
  CoreDumping                 process's memory is currently being dumped
                              (killing the process may lead to a corrupted core)
fs/proc/task_mmu.c +2 -0
index 95ca1fe7283c..0af7081f7b19 100644
@@ -74,6 +74,8 @@ void task_mem(struct seq_file *m, struct mm_struct *mm)
 	seq_put_decimal_ull_width(m,
 		    " kB\nVmPTE:\t", mm_pgtables_bytes(mm) >> 10, 8);
 	SEQ_PUT_DEC(" kB\nVmSwap:\t", swap);
+	seq_put_decimal_ull_width(m,
+		    " kB\nVmTaskSize:\t", mm->task_size >> 10, 8);
 	seq_puts(m, " kB\n");
 	hugetlb_report_usage(m, mm);
 }
Signature · 1 line
2.18.1
maintainer
#1 lore raw
Quoted 4 lines · On Thu, 13 Jun 2019 10:54:50 -0400 Joel Savitz <[email protected]> wrote:

The kernel provides no architecture-independent mechanism to get the size of the virtual address space of a task (userspace process) without brute-force calculation. This patch allows a user to easily retrieve this value via a new VmTaskSize entry in /proc/$$/status.

Why is access to ->task_size required? Please fully describe the use case.

Quoted 11 lines
Documentation/filesystems/proc.txt +1 -0
@@ -187,6 +187,7 @@ read the file /proc/PID/status:
   VmLib:      1412 kB
   VmPTE:        20 kb
   VmSwap:        0 kB
+  VmTaskSize:	137438953468 kB
   HugetlbPages:          0 kB
   CoreDumping:    0
   THP_enabled:	  1

Documentation/filesystems/proc.txt Table 1-2: Contents of the status files (as of 4.19) · line 267

Quoted 4 lines
Documentation/filesystems/proc.txt +1 -0
@@ -263,6 +264,7 @@ Table 1-2: Contents of the status files (as of 4.19)
  VmPTE                       size of page table entries
  VmSwap                      amount of swap used by anonymous private data
                              (shmem swap usage is not included)
+ VmTaskSize                  size of task (userspace process) vm space

This is rather vague. Is it the total amount of physical memory? The sum of all vma sizes, populated or otherwise? Something else?

#2 lore raw

The most immediate use case is the optimization of an internal test, but upon closer examination neither this patch nor the test itself turn out to be worth pursuing.

Thank you for your time and constructive comments.

Best,
Joel Savitz

Quoted 31 lines · Andrew Morton
Quoted 4 lines · On Thu, 13 Jun 2019 10:54:50 -0400 Joel Savitz <[email protected]> wrote:

The kernel provides no architecture-independent mechanism to get the size of the virtual address space of a task (userspace process) without brute-force calculation. This patch allows a user to easily retrieve this value via a new VmTaskSize entry in /proc/$$/status.

Why is access to ->task_size required? Please fully describe the use case.

Quoted 11 lines
Documentation/filesystems/proc.txt +1 -0
@@ -187,6 +187,7 @@ read the file /proc/PID/status:
   VmLib:      1412 kB
   VmPTE:        20 kb
   VmSwap:        0 kB
+  VmTaskSize:        137438953468 kB
   HugetlbPages:          0 kB
   CoreDumping:    0
   THP_enabled:         1

Documentation/filesystems/proc.txt Table 1-2: Contents of the status files (as of 4.19) · line 267

Quoted 4 lines
Documentation/filesystems/proc.txt +1 -0
@@ -263,6 +264,7 @@ Table 1-2: Contents of the status files (as of 4.19)
  VmPTE                       size of page table entries
  VmSwap                      amount of swap used by anonymous private data
                              (shmem swap usage is not included)
+ VmTaskSize                  size of task (userspace process) vm space

This is rather vague. Is it the total amount of physical memory? The sum of all vma sizes, populated or otherwise? Something else?