Skip to contentSkip to conversation

staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

PATCH In review Shobhit Kukreti 3 participants 4 messages Jun 14, 2019 – Jun 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

Cleaned up code to resolve the checkpatch error
ERROR: space prohibited before that close parenthesis ')' from the file:

fbtft/fbtft-bus.c

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
index 2ea814d..2b43bc2 100644
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 16 lines · Shobhit Kukreti

Cleaned up code to resolve the checkpatch error
ERROR: space prohibited before that close parenthesis ')' from the file:

fbtft/fbtft-bus.c

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index 2ea814d..2b43bc2 100644

drivers/staging/fbtft/fbtft-bus.c out: \ · line 67

Quoted 8 lines
drivers/staging/fbtft/fbtft-bus.c +2 -2
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

Will this still build? I thought I remember some old versions of gcc not liking this...

Did you test this patch out?

thanks,

greg k-h

#2 lore raw
Quoted 20 lines · Greg Kroah-Hartman
Quoted 19 lines · Shobhit Kukreti

Cleaned up code to resolve the checkpatch error
ERROR: space prohibited before that close parenthesis ')' from the file:

fbtft/fbtft-bus.c

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index 2ea814d..2b43bc2 100644
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
Quoted 8 lines

drivers/staging/fbtft/fbtft-bus.c out: \ · line 67

Quoted 5 lines
drivers/staging/fbtft/fbtft-bus.c +2 -2
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

Will this still build? I thought I remember some old versions of gcc not liking this...

I was able to build it with Ubuntu/Linaro GCC-5.4.0

Quoted 2 lines

Did you test this patch out?

I booted the kernel on qemu-2.12 and insmod of fbtft drivers did not return any errors. I did not test on actual display hardware. If that is mandatory, I can drop the patch.

Quoted 4 lines

thanks,

greg k-h

Thank you for your patience and feedback.

Shobhit Kukreti

#3 lore raw
In reply to Shobhit Kukreti

Hi Shobhit,

Thanks for your patch!

Quoted 5 lines · Shobhit Kukreti

Cleaned up code to resolve the checkpatch error
ERROR: space prohibited before that close parenthesis ')' from the file:

fbtft/fbtft-bus.c

IMHO that is a bogus checkpatch error...

Quoted 10 lines
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index 2ea814d..2b43bc2 100644

drivers/staging/fbtft/fbtft-bus.c out: \ · line 67

Quoted 8 lines
drivers/staging/fbtft/fbtft-bus.c +2 -2
@@ -62,9 +62,9 @@ out:                                                                        \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

... as the space is the (mandatory) separator between the comma and the (empty) last parameter value.

Checkpatch has some limitations when parsing the C preprocessor macro languagage.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds