l2tp: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/1 l2tp: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Also, there is no need to store the individual debugfs file name, just remove the whole directory all at once, saving a local variable.
--- net/l2tp/l2tp_debugfs.c | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-)
net/l2tp/l2tp_debugfs.c +3 -18
@@ -31,7 +31,6 @@#include "l2tp_core.h" static struct dentry *rootdir; -static struct dentry *tunnels;struct l2tp_dfs_seq_data {struct net *net;
@@ -326,32 +325,18 @@ static const struct file_operations l2tp_dfs_fops = {static int __init l2tp_debugfs_init (void ) { -int rc =0 ; - rootdir =debugfs_create_dir ("l2tp" ,NULL ); -if (IS_ERR (rootdir)) { - rc =PTR_ERR (rootdir); - rootdir =NULL ; - goto out; - } - tunnels =debugfs_create_file ("tunnels" ,0600 , rootdir,NULL , &l2tp_dfs_fops); -if (tunnels ==NULL ) - rc = -EIO ; +debugfs_create_file ("tunnels" ,0600 , rootdir,NULL , &l2tp_dfs_fops);pr_info ("L2TP debugfs support\n" ); -out: -if (rc) -pr_warn ("unable to init\n" ); - -return rc; +return 0 ; } static void __exit l2tp_debugfs_exit(void) { -debugfs_remove (tunnels); -debugfs_remove (rootdir); +debugfs_remove_recursive (rootdir); }module_init (l2tp_debugfs_init);
Signature · 1 line
2.22.0
Quoted 7 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Also, there is no need to store the individual debugfs file name, just remove the whole directory all at once, saving a local variable.
From: Greg Kroah-Hartman <[email protected]>
Date: Fri, 14 Jun 2019 09:04:38 +0200
Quoted 11 lines
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Also, there is no need to store the individual debugfs file name, just remove the whole directory all at once, saving a local variable.
Cc "David S. Miller" <[email protected]>Cc Guillaume Nault <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Applied.