thermal: tegra: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/1 thermal: tegra: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Wei Ni <[email protected]>
Cc Yangtao Li <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/thermal/tegra/soctherm.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)
drivers/thermal/tegra/soctherm.c +2 -12
@@ -1485,23 +1485,13 @@ DEFINE_SHOW_ATTRIBUTE(regs);static void soctherm_debug_init (struct platform_device *pdev) {struct tegra_soctherm *tegra =platform_get_drvdata (pdev); -struct dentry *root, *file; +struct dentry *root; root =debugfs_create_dir ("soctherm" ,NULL ); -if (!root) { -dev_err (&pdev->dev,"failed to create debugfs directory\n" ); -return ; - } tegra->debugfs_dir = root; - file =debugfs_create_file ("reg_contents" ,0644 , root, - pdev, ®s_fops); -if (!file) { -dev_err (&pdev->dev,"failed to create debugfs file\n" ); -debugfs_remove_recursive (tegra->debugfs_dir); - tegra->debugfs_dir =NULL ; - } +debugfs_create_file ("reg_contents" ,0644 , root, pdev, ®s_fops); }#else static inline void soctherm_debug_init (struct platform_device *pdev) {}
Signature · 1 line
2.22.0
Quoted 13 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Zhang Rui <[email protected]>Cc Eduardo Valentin <[email protected]>Cc Daniel Lezcano <[email protected]>Cc Thierry Reding <[email protected]>Cc Jonathan Hunter <[email protected]>Cc Wei Ni <[email protected]>Cc Yangtao Li <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 3 lines
--- drivers/thermal/tegra/soctherm.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)
Acked-by Thierry Reding <[email protected]>