Skip to contentSkip to conversation

i915: no need to check return value of debugfs_create functions

PATCH RESEND In review Jani Nikula 2 participants 4 messages Jun 13, 2019 – Jun 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 i915: no need to check return value of debugfs_create functions

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

---
 drivers/gpu/drm/i915/i915_debugfs.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +7 -13
index 323863504111..41386c86ea65 100644
@@ -4442,23 +4442,17 @@ static const struct i915_debugfs_files {
 int i915_debugfs_register(struct drm_i915_private *dev_priv)
 {
 	struct drm_minor *minor = dev_priv->drm.primary;
-	struct dentry *ent;
 	int i;
 
-	ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
-				  minor->debugfs_root, to_i915(minor->dev),
-				  &i915_forcewake_fops);
-	if (!ent)
-		return -ENOMEM;
+	debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
+			    to_i915(minor->dev), &i915_forcewake_fops);
 
 	for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
-		ent = debugfs_create_file(i915_debugfs_files[i].name,
-					  S_IRUGO | S_IWUSR,
-					  minor->debugfs_root,
-					  to_i915(minor->dev),
-					  i915_debugfs_files[i].fops);
-		if (!ent)
-			return -ENOMEM;
+		debugfs_create_file(i915_debugfs_files[i].name,
+				    S_IRUGO | S_IWUSR,
+				    minor->debugfs_root,
+				    to_i915(minor->dev),
+				    i915_debugfs_files[i].fops);
 	}
 
 	return drm_debugfs_create_files(i915_debugfs_list,
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

✓ Fi.CI.BAT: success for i915: no need to check return value of debugfs_create functions (rev2)

== Series Details ==

== Series Details ==

Series: i915: no need to check return value of debugfs_create functions (rev2)
URL : https://patchwork.freedesktop.org/series/62040/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6265 -> Patchwork_13273
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/

Known issues
------------

Here are the changes found in Patchwork_13273 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_create@basic-files:
- fi-icl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/fi-icl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/fi-icl-guc/igt@[email protected]

#### Possible fixes ####

* igt@gem_cpu_reloc@basic:
- fi-icl-dsi: [INCOMPLETE][3] ([fdo#107713] / [fdo#110246]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/fi-icl-dsi/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/fi-icl-dsi/igt@[email protected]

* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [DMESG-FAIL][5] ([fdo#110917]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/fi-icl-y/igt@i915_selftest@live_hangcheck.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#109485]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/fi-kbl-7500u/igt@[email protected]

* igt@vgem_basic@unload:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/fi-icl-u3/igt@[email protected]

[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110246]: https://bugs.freedesktop.org/show_bug.cgi?id=110246
[fdo#110917]: https://bugs.freedesktop.org/show_bug.cgi?id=110917

Participating hosts (53 -> 47)
------------------------------

Additional (1): fi-byt-j1900
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_6265 -> Patchwork_13273

CI_DRM_6265: 657b9f601946cab518d8911ea92dc0f437a1f4b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5055: 495287320225e7f180d384cad7b207b77154438f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13273: 0be13d1795a47e9385fec5bc075d4156b4e812a5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

0be13d1795a4 i915: no need to check return value of debugfs_create functions

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for i915: no need to check return value of debugfs_create functions (rev2)

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: i915: no need to check return value of debugfs_create functions (rev2)
URL : https://patchwork.freedesktop.org/series/62040/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6265_full -> Patchwork_13273_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_13273_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@in-flight-contexts-10ms:
- shard-skl: ([PASS][1], [PASS][2]) -> [DMESG-WARN][3] ([fdo#110913 ])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl5/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl10/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrashing:
- shard-hsw: ([PASS][4], [PASS][5]) -> [DMESG-WARN][6] ([fdo#110789] / [fdo#110913 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw6/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw6/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-glk: ([PASS][7], [PASS][8]) -> [DMESG-WARN][9] ([fdo#108686])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-glk1/igt@[email protected]
- shard-kbl: ([PASS][10], [PASS][11]) -> [DMESG-WARN][12] ([fdo#108686])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl2/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-kbl: ([PASS][13], [PASS][14]) -> [DMESG-WARN][15] ([fdo#110913 ]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl6/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: ([PASS][16], [PASS][17]) -> [DMESG-WARN][18] ([fdo#108566]) +4 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl3/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-hsw: ([PASS][19], [PASS][20]) -> [SKIP][21] ([fdo#109271]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw6/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw4/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

* igt@kms_flip@2x-blocking-absolute-wf_vblank:
- shard-hsw: [PASS][22] -> [SKIP][23] ([fdo#109271]) +9 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw5/igt@kms_flip@2x-blocking-absolute-wf_vblank.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw1/igt@kms_flip@2x-blocking-absolute-wf_vblank.html

* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: ([PASS][24], [PASS][25]) -> [FAIL][26] ([fdo#105363])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-glk9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-iclb7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-iclb1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
- shard-skl: ([PASS][29], [PASS][30]) -> [FAIL][31] ([fdo#103166])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl4/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl2/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-skl: ([PASS][32], [PASS][33]) -> [DMESG-WARN][34] ([fdo#106885])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl7/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl3/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl3/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html

* igt@tools_test@tools_test:
- shard-snb: ([PASS][37], [PASS][38]) -> [SKIP][39] ([fdo#109271])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb6/igt@tools_test@tools_test.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb2/igt@tools_test@tools_test.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-snb1/igt@tools_test@tools_test.html

#### Possible fixes ####

* igt@gem_eio@in-flight-10ms:
- shard-skl: ([PASS][40], [DMESG-WARN][41]) ([fdo#110913 ]) -> [PASS][42] +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl9/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl7/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-snb: ([PASS][43], [FAIL][44]) ([fdo#109661]) -> [PASS][45]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb7/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-snb2/igt@[email protected]

* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-apl: ([INCOMPLETE][46], [PASS][47]) ([fdo#103927]) -> [PASS][48]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl3/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl4/igt@[email protected]

* igt@gem_persistent_relocs@forked-thrashing:
- shard-glk: ([PASS][49], [DMESG-WARN][50]) ([fdo#110913 ]) -> [PASS][51] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk2/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk8/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-glk7/igt@[email protected]
- shard-skl: ([DMESG-WARN][52], [DMESG-WARN][53]) ([fdo#110913 ]) -> [PASS][54]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl5/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl8/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl10/igt@[email protected]
- shard-snb: ([PASS][55], [DMESG-WARN][56]) ([fdo#110789] / [fdo#110913 ]) -> [PASS][57]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb5/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-snb2/igt@[email protected]

* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-apl: ([PASS][58], [DMESG-WARN][59]) ([fdo#110913 ]) -> [PASS][60] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl4/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl8/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-apl: ([DMESG-WARN][61], [PASS][62]) ([fdo#108686]) -> [PASS][63]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl1/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl7/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: ([DMESG-WARN][64], [PASS][65]) ([fdo#110913 ]) -> [PASS][66]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-snb5/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: ([DMESG-WARN][67], [PASS][68]) ([fdo#110913 ]) -> [PASS][69] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw7/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw8/igt@[email protected]
- shard-kbl: ([DMESG-WARN][70], [PASS][71]) ([fdo#110913 ]) -> [PASS][72] +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl4/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl7/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-kbl: ([DMESG-WARN][73], [PASS][74]) ([fdo#108566]) -> [PASS][75] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl4/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-snb: ([SKIP][76], [PASS][77]) ([fdo#109271]) -> [PASS][78]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb4/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-snb7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-snb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][79] ([fdo#108566]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl5/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-hsw: ([FAIL][81], [PASS][82]) ([fdo#103355]) -> [PASS][83]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw6/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw8/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: ([FAIL][84], [PASS][85]) ([fdo#103184] / [fdo#103232] / [fdo#108472]) -> [PASS][86]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl4/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl10/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend:
- shard-hsw: [SKIP][87] ([fdo#109271]) -> [PASS][88] +8 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw7/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-hsw: ([PASS][89], [SKIP][90]) ([fdo#109271]) -> [PASS][91] +31 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw1/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: ([DMESG-WARN][92], [PASS][93]) ([fdo#108566]) -> [PASS][94] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl3/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-apl1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-apl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [FAIL][95] ([fdo#103167]) -> [PASS][96] +6 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-iclb6/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-skl: ([PASS][97], [INCOMPLETE][98]) ([fdo#104108]) -> [PASS][99]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-skl8/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-skl9/igt@[email protected]

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][100] ([fdo#109441]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

* igt@kms_setmode@basic:
- shard-kbl: ([FAIL][102], [FAIL][103]) ([fdo#99912]) -> [PASS][104]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl6/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl4/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl3/igt@[email protected]

* igt@perf_pmu@rc6-runtime-pm:
- shard-hsw: ([FAIL][105], [FAIL][106]) ([fdo#105010]) -> [PASS][107]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw2/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-hsw7/igt@[email protected]

#### Warnings ####

* igt@gem_eio@in-flight-suspend:
- shard-kbl: ([INCOMPLETE][108], [PASS][109]) ([fdo#103665]) -> [INCOMPLETE][110] ([fdo#103665])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl6/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-kbl7/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-kbl3/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-glk: ([DMESG-WARN][111], [PASS][112]) ([fdo#110913 ]) -> [DMESG-WARN][113] ([fdo#110913 ]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-glk4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/shard-glk7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
- shard-hsw: ([DMESG-WARN][114], [PASS][115]) ([fdo#110789] / [fdo#110913 ]) -> [DMESG-WARN][116] ([fdo#110789] / [fdo#110913 ])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6265/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[116]: https://intel-gfx-ci.01.org/tr

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13273/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Jani Nikula
Quoted 6 lines · Jani Nikula

From: Greg Kroah-Hartman <[email protected]>

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Quoted 9 lines

And pushed to drm-intel-next-queued, thanks for the patch.

BR,
Jani.

Quoted 39 lines
---
 drivers/gpu/drm/i915/i915_debugfs.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +7 -13
index 323863504111..41386c86ea65 100644
@@ -4442,23 +4442,17 @@ static const struct i915_debugfs_files {
 int i915_debugfs_register(struct drm_i915_private *dev_priv)
 {
 	struct drm_minor *minor = dev_priv->drm.primary;
-	struct dentry *ent;
 	int i;
 
-	ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
-				  minor->debugfs_root, to_i915(minor->dev),
-				  &i915_forcewake_fops);
-	if (!ent)
-		return -ENOMEM;
+	debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
+			    to_i915(minor->dev), &i915_forcewake_fops);
 
 	for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
-		ent = debugfs_create_file(i915_debugfs_files[i].name,
-					  S_IRUGO | S_IWUSR,
-					  minor->debugfs_root,
-					  to_i915(minor->dev),
-					  i915_debugfs_files[i].fops);
-		if (!ent)
-			return -ENOMEM;
+		debugfs_create_file(i915_debugfs_files[i].name,
+				    S_IRUGO | S_IWUSR,
+				    minor->debugfs_root,
+				    to_i915(minor->dev),
+				    i915_debugfs_files[i].fops);
 	}
 
 	return drm_debugfs_create_files(i915_debugfs_list,
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel