cache: do not populate the cache in case of flush ruleset command
Pablo Neira Ayuso
maintainerPATCH v2 1/1 cache: do not populate the cache in case of flush ruleset command
__CMD_FLUSH_RULESET is a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.
---
v2: check for __CMD_FLUSH_RULESET before dumping tables via netlink.
include/rule.h | 1 + src/cache.c | 3 +++ src/rule.c | 3 +++ 3 files changed, 7 insertions(+)
include/rule.h +1 -0
@@ -462,6 +462,7 @@ enum cmd_ops {CMD_EXPORT ,CMD_MONITOR ,CMD_DESCRIBE , + __CMD_FLUSH_RULESET, };/**
src/cache.c +3 -0
@@ -54,6 +54,9 @@ static unsigned int evaluate_cache_flush(struct cmd *cmd)unsigned int completeness =CMD_INVALID ;switch (cmd->obj) { +case CMD_OBJ_RULESET : + completeness = __CMD_FLUSH_RULESET; +break ;case CMD_OBJ_SET :case CMD_OBJ_MAP :case CMD_OBJ_METER :
src/rule.c +3 -0
@@ -210,6 +210,9 @@ static int cache_init(struct netlink_ctx *ctx, enum cmd_ops cmd) };int ret; +if (cmd == __CMD_FLUSH_RULESET) +return 0 ; + ret =cache_init_tables (ctx, &handle, &ctx->nft->cache);if (ret <0 )return ret;
Signature · 1 line
2.11.0
Phil Sutter
reviewerHi Pablo,
Quoted 3 lines · Pablo Neira Ayuso
__CMD_FLUSH_RULESETis a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.
I assumed the problem wouldn't exist anymore since we're populating the cache just once. Can you maybe elaborate a bit on the problem you're trying to solve with that workaround?
Cheers, Phil
Pablo Neira Ayuso
maintainerQuoted 10 lines · Phil Sutter
Hi Pablo,
Quoted 3 lines · Pablo Neira Ayuso
__CMD_FLUSH_RULESETis a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.I assumed the problem wouldn't exist anymore since we're populating the cache just once. Can you maybe elaborate a bit on the problem you're trying to solve with that workaround?
If nft segfaults to dump the cache, 'nft flush ruleset' will not work since it always fetches the cache, it will segfault too.
The flush ruleset command was still dumping the cache before this patch.
Pablo Neira Ayuso
maintainerQuoted 12 lines · Pablo Neira Ayuso
Quoted 10 lines · Phil Sutter
Hi Pablo,
Quoted 3 lines · Pablo Neira Ayuso
__CMD_FLUSH_RULESETis a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.I assumed the problem wouldn't exist anymore since we're populating the cache just once. Can you maybe elaborate a bit on the problem you're trying to solve with that workaround?
Quoted 5 lines
If nft segfaults to dump the cache, 'nft flush ruleset' will not work since it always fetches the cache, it will segfault too.
The flush ruleset command was still dumping the cache before this patch.
In general, we still need to improve the cache logic, to make it finer grain. Now that we have a single point to populate the cache, things will get more simple. We need to replace the cache command level to cache flags or our own cache level definitions. The existing approach that uses of commands to define the cache level completeness has its own limitations. We can discuss this during the NFWS :-).
Phil Sutter
reviewerHi Pablo,
Quoted 19 lines · Pablo Neira Ayuso
Quoted 12 lines · Pablo Neira Ayuso
Quoted 10 lines · Phil Sutter
Hi Pablo,
Quoted 3 lines · Pablo Neira Ayuso
__CMD_FLUSH_RULESETis a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.I assumed the problem wouldn't exist anymore since we're populating the cache just once. Can you maybe elaborate a bit on the problem you're trying to solve with that workaround?
Quoted 5 lines
If nft segfaults to dump the cache, 'nft flush ruleset' will not work since it always fetches the cache, it will segfault too.
The flush ruleset command was still dumping the cache before this patch.
Quoted 6 lines
In general, we still need to improve the cache logic, to make it finer grain. Now that we have a single point to populate the cache, things will get more simple. We need to replace the cache command level to cache flags or our own cache level definitions. The existing approach that uses of commands to define the cache level completeness has its own limitations. We can discuss this during the NFWS :-).
Yes, I had the same thought already. It is quite unintuitive how we link cache completeness to certain commands. :)
Regarding your problem, maybe cache_update() should exit immediately if passed cmd is CMD_INVALID? Unless I miss something, if cache_evaluate() returns that value, we don't need a cache at all.
Cheers, Phil
Pablo Neira Ayuso
maintainerHi Phil,
On Fri, Jun 14, 2019 at 03:41:24PM +0200, Phil Sutter wrote:
[...]
Quoted 27 lines · Pablo Neira Ayuso
Quoted 19 lines · Pablo Neira Ayuso
Quoted 12 lines · Phil Sutter
Quoted 10 lines
Hi Pablo,
Quoted 3 lines · Pablo Neira Ayuso
__CMD_FLUSH_RULESETis a dummy definition that used to skip the netlink dump to populate the cache. This patch is a workaround until we have a better infrastructure to track the state of the cache objects.I assumed the problem wouldn't exist anymore since we're populating the cache just once. Can you maybe elaborate a bit on the problem you're trying to solve with that workaround?
Quoted 5 lines
If nft segfaults to dump the cache, 'nft flush ruleset' will not work since it always fetches the cache, it will segfault too.
The flush ruleset command was still dumping the cache before this patch.
Quoted 6 lines
In general, we still need to improve the cache logic, to make it finer grain. Now that we have a single point to populate the cache, things will get more simple. We need to replace the cache command level to cache flags or our own cache level definitions. The existing approach that uses of commands to define the cache level completeness has its own limitations. We can discuss this during the NFWS :-).
Quoted 2 lines
Yes, I had the same thought already. It is quite unintuitive how we link cache completeness to certain commands. :)
Just sent a follow up patch to introduce cache level flags [1]. The existing approach is rather conservative in what we fetch from the kernel (sometimes more than needed) but it should be possible to review this logic incrementally.
Quoted 3 lines
Regarding your problem, maybe
cache_update()should exit immediately if passed cmd isCMD_INVALID? Unless I miss something, ifcache_evaluate()returns that value, we don't need a cache at all.
Problem is that CMD_INVALID does not mean empty cache.
With the new cache level infrastructure, now there is a NFT_CACHE_EMPTY that provides the semantics this workaround was providing in a clearer way I think.