drivers: firmware: efi: fix gcc warning -Wint-conversion
PATCH 1/1 drivers: firmware: efi: fix gcc warning -Wint-conversion
This patch fixes below warning
drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast [-Wint-conversion]
--- drivers/firmware/efi/tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/efi/tpm.c +1 -1
@@ -75,7 +75,7 @@ int __init efi_tpm_eventlog_init(void) goto out; } - tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log + tbl_size = tpm2_calc_event_log_size((void *)efi.tpm_final_log + sizeof(final_tbl->version) + sizeof(final_tbl->nr_events), final_tbl->nr_events,
Signature · 1 line
2.7.4
(+ Jarkko, tpmdd, Matthew)
Quoted 8 lines · Hariprasad Kelam
This patch fixes below warning
drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast [-Wint-conversion]Signed-off-by Hariprasad Kelam <[email protected]>
I think we already have a fix queued for this, no?
Quoted 20 lines
--- drivers/firmware/efi/tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/efi/tpm.c +1
-2@@ -75,7 +75,7 @@ int __init efi_tpm_eventlog_init(void) goto out; } - tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log + tbl_size = tpm2_calc_event_log_size((void *)efi.tpm_final_log + sizeof(final_tbl->version) + sizeof(final_tbl->nr_events), final_tbl->nr_events, --2.7.4
Quoted 8 lines · Ard Biesheuvel
(+ Jarkko, tpmdd, Matthew)
Quoted 3 lines · Hariprasad Kelam
This patch fixes below warning
Quoted 7 lines
Quoted 5 lines
drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast [-Wint-conversion]Signed-off-by Hariprasad Kelam <[email protected]>I think we already have a fix queued for this, no?
It looks like I fixed this in "Don't duplicate events from the final event log in the TCG2 log" rather than a separate patch - I'm fine merging this, based on Jarkko's preferences.
Quoted 14 lines · Matthew Garrett
Quoted 12 lines · Ard Biesheuvel
(+ Jarkko, tpmdd, Matthew)
Quoted 7 lines · Hariprasad Kelam
This patch fixes below warning
drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast [-Wint-conversion]
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Hariprasad Kelam <[email protected]>I think we already have a fix queued for this, no?
It looks like I fixed this in "Don't duplicate events from the final event log in the TCG2 log" rather than a separate patch - I'm fine merging this, based on Jarkko's preferences.
Right! OK, I squashed just the fix to the earlier patch. Master and next are updated. Can you take a peek of [1] and see if it looks legit given all the fuzz around these changes? Then I'm confident enough to do the 5.3 PR.
[1] git://git.infradead.org/users/jjs/linux-tpmdd.git
/Jarkko
Quoted 4 lines · Jarkko Sakkinen
Right! OK, I squashed just the fix to the earlier patch. Master and next are updated. Can you take a peek of [1] and see if it looks legit given all the fuzz around these changes? Then I'm confident enough to do the 5.3 PR.
All looks good to me. Thanks!
Quoted 8 lines · Matthew Garrett
Quoted 4 lines · Jarkko Sakkinen
Right! OK, I squashed just the fix to the earlier patch. Master and next are updated. Can you take a peek of [1] and see if it looks legit given all the fuzz around these changes? Then I'm confident enough to do the 5.3 PR.
All looks good to me. Thanks!
Thank you! I'll send the PR now.
/Jarkko