Skip to contentSkip to conversation

powerpc/4xx/uic: clear pending interrupt after irq type/pol change

PATCH Applied Christian Lamparter 2 participants 2 messages Jun 15, 2019 – Jul 8, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/4xx/uic: clear pending interrupt after irq type/pol change

When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time.

This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity.

---
 arch/powerpc/platforms/4xx/uic.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/4xx/uic.c +1 -0
index 31f12ad37a98..36fb66ce54cf 100644
@@ -154,6 +154,7 @@ static int uic_set_irq_type(struct irq_data *d, unsigned int flow_type)
 
 	mtdcr(uic->dcrbase + UIC_PR, pr);
 	mtdcr(uic->dcrbase + UIC_TR, tr);
+	mtdcr(uic->dcrbase + UIC_SR, ~mask);
 
 	raw_spin_unlock_irqrestore(&uic->lock, flags);
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 10 lines · Christian Lamparter

When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time.

This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity.

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3ab3a0689e74e6aa5b41360bc18861040ddef5b1

cheers