Skip to contentSkip to conversation

fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

PATCH New puranjay12 at gmail.com (Puranjay Mohan) 1 participant 1 message Jun 16, 2019

lore
Share & tools
lore

puranjay12 at gmail.com (Puranjay Mohan)

#0 lore raw

PATCH 1/1 fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed 32-bit value by 31 bits problem. This isn't a problem for kernel builds with gcc.

This could be problem since this header is part of public API which could be included for builds using compilers that don't handle this condition safely resulting in undefined behavior.

Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>
---
 include/uapi/linux/cramfs_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/cramfs_fs.h +1 -1
index 6713669aa2ed..31df3e185b62 100644
@@ -98,7 +98,7 @@ struct cramfs_super {
  *
  * That leaves room for 3 flag bits in the block pointer table.
  */
-#define CRAMFS_BLK_FLAG_UNCOMPRESSED	(1 << 31)
+#define CRAMFS_BLK_FLAG_UNCOMPRESSED	(1U << 31)
 #define CRAMFS_BLK_FLAG_DIRECT_PTR	(1 << 30)
 
 #define CRAMFS_BLK_FLAGS	( CRAMFS_BLK_FLAG_UNCOMPRESSED \
Signature · 1 line
2.21.0