selftests/net: fix warnings in TFO key rotation selftest
Subsystems (3)
PATCH 1/1 selftests/net: fix warnings in TFO key rotation selftest
From: Willem de Bruijn <[email protected]>
One warning each on signedness, unused variable and return type.
Fixes 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
Signed-off-by Willem de Bruijn <[email protected]>
--- tools/testing/selftests/net/tcp_fastopen_backup_key.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
tools/testing/selftests/net/tcp_fastopen_backup_key.c +2 -3
@@ -51,7 +51,7 @@ static const int PORT = 8891;static void get_keys (int fd,uint32_t *keys) {char buf[128 ]; -int len =KEY_LENGTH *2 ; +socklen_t len =KEY_LENGTH *2 ;if (do_sockopt) {if (getsockopt (fd,SOL_TCP ,TCP_FASTOPEN_KEY , keys, &len))
@@ -210,14 +210,13 @@ static bool is_listen_fd(int fd)return false; } -static int rotate_key (int fd) +static void rotate_key (int fd) {static int iter;static uint32_t new_key[4 ];uint32_t keys[8 ];uint32_t tmp_key[4 ];int i; -int len =KEY_LENGTH *2 ;if (iter <N_LISTEN ) {/* first set new key as backups */
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
From: Willem de Bruijn <[email protected]>
Date: Sun, 16 Jun 2019 13:15:01 -0400
Quoted 6 lines
From: Willem de Bruijn <[email protected]>
One warning each on signedness, unused variable and return type.
Fixes 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")Signed-off-by Willem de Bruijn <[email protected]>
Applied.