dt-bindings: pinctrl: qcom: Add SM8150 pinctrl binding
Subsystems (6)
PATCH 1/2 dt-bindings: pinctrl: qcom: Add SM8150 pinctrl binding
From: Prasad Sodagudi <[email protected]>
Add the binding for the TLMM pinctrl block found in the SM8150 platform.
--- .../bindings/pinctrl/qcom,sm8150-pinctrl | 200 ++++++++++++++++++ 1 file changed, 200 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +200 -0
@@ -0,0 +1,200 @@ +Qualcomm SM8150 TLMM block + +This binding describes the Top Level Mode Multiplexer block found in the +QCS404 platform. + +- compatible: + Usage: required + Value type: <string> + Definition: must be "qcom,sm8150-pinctrl" + +- reg: + Usage: required + Value type: <prop-encoded-array> + Definition: the base address and size of the north, south , west + and east TLMM tiles. + +- reg-names: + Usage: required + Value type: <prop-encoded-array> + Defintiion: names for the cells of reg, must contain "north", "south" + "west" and "east". + +- interrupts: + Usage: required + Value type: <prop-encoded-array> + Definition: should specify the TLMM summary IRQ. + +- interrupt-controller: + Usage: required + Value type: <none> + Definition: identifies this node as an interrupt controller + +- #interrupt-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/interrupt-controller/irq.h> + +- gpio-controller: + Usage: required + Value type: <none> + Definition: identifies this node as a gpio controller + +- #gpio-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/gpio/gpio.h> + +Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for +a general description of GPIO and interrupt bindings. + +Please refer to pinctrl-bindings.txt in this directory for details of the +common pinctrl bindings used by client devices, including the meaning of the +phrase "pin configuration node". + +The pin configuration nodes act as a container for an arbitrary number of +subnodes. Each of these subnodes represents some desired configuration for a +pin, a group, or a list of pins or groups. This configuration can include the +mux function to select on those pin(s)/group(s), and various pin configuration +parameters, such as pull-up, drive strength, etc. + + +PIN CONFIGURATION NODES: + +The name of each subnode is not important; all subnodes should be enumerated +and processed purely based on their content. + +Each subnode only affects those parameters that are explicitly listed. In +other words, a subnode that lists a mux function but no pin configuration +parameters implies no information about any pin configuration parameters. +Similarly, a pin subnode that describes a pullup parameter implies no +information about e.g. the mux function. + + +The following generic properties as defined in pinctrl-bindings.txt are valid +to specify in a pin configuration subnode: + +- pins: + Usage: required + Value type: <string-array> + Definition: List of gpio pins affected by the properties specified in + this subnode. + + Valid pins are: + gpio0-gpio149 + Supports mux, bias and drive-strength + + sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, + sdc2_data sdc1_rclk + Supports bias and drive-strength + + ufs_reset + Supports bias and drive-strength + +- function: + Usage: required + Value type: <string> + Definition: Specify the alternative function to be configured for the + specified pins. Functions are only valid for gpio pins. + Valid values are: + + blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens, + bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8, + qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b, + dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10, + blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12, + mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11, + atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char, + cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b, + pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c, + qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4, + qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5, + atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6, + atest_usb20, atest_char0, dac_calib10, qdss_stm10, + qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6, + blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11, + qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1, + qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11, + dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6, + qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14, + dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem, + dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto, + dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0, + dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25, + sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2, + qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3, + uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9, + blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7, + qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11, + blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0, + cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4, + blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4, + qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus, + isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s, + qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b, + sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b, + gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12, + qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29, + tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27, + qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk, + sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b, + sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b, + ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b, + blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt, + pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11, + qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx, + qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3, + gpio + +- bias-disable: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as no pull. + +- bias-pull-down: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull down. + +- bias-pull-up: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull up. + +- output-high: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + high. + Not valid for sdc pins. + +- output-low: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + low. + Not valid for sdc pins. + +- drive-strength: + Usage: optional + Value type: <u32> + Definition: Selects the drive strength for the specified pins, in mA. + Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16 + +Example: + + tlmm: pinctrl@3000000 { + compatible = "qcom,sm8150-pinctrl"; + reg = <0x03100000 0x300000>, + <0x03500000 0x300000>, + <0x03900000 0x300000>, + <0x03D00000 0x300000>; + reg-names = "west", "east", "north", "south"; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + };
Signature · 1 line
2.20.1
PATCH 2/2 pinctrl: qcom: Add SM8150 pinctrl driver
From: Prasad Sodagudi <[email protected]>
Add initial pinctrl driver to support pin configuration with pinctrl framework for SM8150
--- drivers/pinctrl/qcom/Kconfig | 9 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sm8150.c | 1803 +++++++++++++++++++++++++ 3 files changed, 1813 insertions(+) create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8150.c
drivers/pinctrl/qcom/Kconfig +9 -0
@@ -175,4 +175,13 @@ config PINCTRL_SDM845 Qualcomm Technologies Inc TLMM block found on the Qualcomm Technologies Inc SDM845 platform. +config PINCTRL_SM8150 + tristate "Qualcomm Technologies Inc SM8150 pin controller driver" + depends on GPIOLIB && OF + select PINCTRL_MSM + help + This is the pinctrl, pinmux, pinconf and gpiolib driver for the + Qualcomm Technologies Inc TLMM block found on the Qualcomm + Technologies Inc SM8150 platform. + endif
drivers/pinctrl/qcom/Makefile +1 -0
@@ -22,3 +22,4 @@ obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o obj-$(CONFIG_PINCTRL_SDM660) += pinctrl-sdm660.o obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o +obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o
drivers/pinctrl/qcom/pinctrl-sm8150.c new file +1803 -0
1,803 lines not on this page · raw message
Signature · 1 line
2.20.1
Re: [PATCH 2/2] pinctrl: qcom: Add SM8150 pinctrl driver
Quoted 7 lines · Vinod Koul
From: Prasad Sodagudi <[email protected]>
Add initial pinctrl driver to support pin configuration with pinctrl framework for SM8150
Signed-off-by Prasad Sodagudi <[email protected]>Signed-off-by Isaac J. Manjarres <[email protected]>
I presume you did stuff to make it fit with my upstream tiling, mention that here.
[..]
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +0
-0
[..]
Quoted 1 line
+static const struct
pinctrl_pin_descsm8150_pins[] = {
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 305
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +1
-0+ PINCTRL_PIN(178, "UFS_RESET"),
Please follow
https://lore.kernel.org/linux-arm-msm/[email protected]/
for ufs_reset.
Quoted 1 line
+};
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 492
Quoted 2 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +2
-0+enum sm8150_functions { + msm_mux_phase_flag8,
Please sort these alphabetically and please squash all the phase_flag* into msm_mux_phase_flag.
drivers/pinctrl/qcom/pinctrl-sm8150.c line 497
Quoted 5 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +5
-0+ msm_mux_phase_flag7, + msm_mux_emac_pps, + msm_mux_qup12, + msm_mux_qup16, + msm_mux_tsif1_clk,
Please squash all tsif1 into msm_mux_tsif1.
drivers/pinctrl/qcom/pinctrl-sm8150.c line 510
Quoted 13 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +13
-0+ msm_mux_qup8, + msm_mux_qspi_cs, + msm_mux_tgu_ch3, + msm_mux_tsif1_en, + msm_mux_qspi0, + msm_mux_mdp_vsync0, + msm_mux_mdp_vsync1, + msm_mux_mdp_vsync2, + msm_mux_mdp_vsync3, + msm_mux_tgu_ch0, + msm_mux_tsif1_data, + msm_mux_qspi1, + msm_mux_sdc4_cmd,
Squash sdc4_cmd, sdc4_clk and sdc4{0,1,2,3} into msm_mux_sdc4.
drivers/pinctrl/qcom/pinctrl-sm8150.c line 521
Quoted 11 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +11
-0+ msm_mux_phase_flag31, + msm_mux_tgu_ch1, + msm_mux_wlan1_adc1, + msm_mux_tsif1_sync, + msm_mux_qspi2, + msm_mux_sdc43, + msm_mux_vfr_1, + msm_mux_phase_flag30, + msm_mux_tgu_ch2, + msm_mux_wlan1_adc0, + msm_mux_tsif2_clk,
Please squash all tsif2
Quoted 22 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +22
-0+ msm_mux_qup11, + msm_mux_qspi_clk, + msm_mux_sdc4_clk, + msm_mux_phase_flag27, + msm_mux_wlan2_adc1, + msm_mux_tsif2_en, + msm_mux_qspi3, + msm_mux_sdc42, + msm_mux_phase_flag26, + msm_mux_wlan2_adc0, + msm_mux_tsif2_data, + msm_mux_sdc41, + msm_mux_phase_flag25, + msm_mux_tsif2_sync, + msm_mux_sdc40, + msm_mux_tsif2_error, + msm_mux_phase_flag11, + msm_mux_sd_write, + msm_mux_tsif1_error, + msm_mux_qup7, + msm_mux_ddr_bist, + msm_mux_ddr_pxi3,
drivers/pinctrl/qcom/pinctrl-sm8150.c line 553
Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +10
-0+ msm_mux_atest_usb13, + msm_mux_ddr_pxi1, + msm_mux_pll_bypassnl, + msm_mux_atest_usb12, + msm_mux_pll_reset, + msm_mux_pci_e1, + msm_mux_uim2_data, + msm_mux_uim2_clk, + msm_mux_uim2_reset, + msm_mux_uim2_present,
Please squash uim2.
drivers/pinctrl/qcom/pinctrl-sm8150.c line 557
Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +4
-0+ msm_mux_uim1_data, + msm_mux_uim1_clk, + msm_mux_uim1_reset, + msm_mux_uim1_present,
Please squash uim1.
drivers/pinctrl/qcom/pinctrl-sm8150.c line 562
Quoted 5 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +5
-0+ msm_mux_uim_batt, + msm_mux_usb2phy_ac, + msm_mux_aoss_cti, + msm_mux_qup1, + msm_mux_rgmii_txc,
Please squash all the rmiii_*
Quoted 69 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +69
-0+ msm_mux_phase_flag20, + msm_mux_rgmii_rxc, + msm_mux_phase_flag19, + msm_mux_adsp_ext, + msm_mux_rgmii_rx, + msm_mux_phase_flag18, + msm_mux_rgmii_rxd0, + msm_mux_phase_flag17, + msm_mux_rgmii_rxd1, + msm_mux_phase_flag16, + msm_mux_qup5, + msm_mux_rgmii_rxd2, + msm_mux_phase_flag15, + msm_mux_rgmii_rxd3, + msm_mux_phase_flag14, + msm_mux_rgmii_tx, + msm_mux_phase_flag13, + msm_mux_rgmii_txd0, + msm_mux_phase_flag12, + msm_mux_atest_usb22, + msm_mux_emac_phy, + msm_mux_hs3_mi2s, + msm_mux_sec_mi2s, + msm_mux_qup2, + msm_mux_phase_flag9, + msm_mux_phase_flag4, + msm_mux_phase_flag21, + msm_mux_jitter_bist, + msm_mux_atest_usb21, + msm_mux_pll_bist, + msm_mux_atest_usb20, + msm_mux_atest_char0, + msm_mux_ter_mi2s, + msm_mux_gcc_gp1, + msm_mux_atest_char1, + msm_mux_atest_char2, + msm_mux_atest_char3, + msm_mux_qua_mi2s, + msm_mux_pri_mi2s, + msm_mux_qup3, + msm_mux_phase_flag29, + msm_mux_ddr_pxi0, + msm_mux_pri_mi2s_ws, + msm_mux_phase_flag28, + msm_mux_vsense_trigger, + msm_mux_atest_usb1, + msm_mux_atest_usb11, + msm_mux_ddr_pxi2, + msm_mux_dbg_out, + msm_mux_atest_usb10, + msm_mux_spkr_i2s, + msm_mux_audio_ref, + msm_mux_lpass_slimbus, + msm_mux_tsense_pwm1, + msm_mux_tsense_pwm2, + msm_mux_btfm_slimbus, + msm_mux_hs1_mi2s, + msm_mux_cri_trng0, + msm_mux_hs2_mi2s, + msm_mux_cri_trng1, + msm_mux_cri_trng, + msm_mux_sp_cmu, + msm_mux_prng_rosc, + msm_mux_qup0, + msm_mux_gpio, + msm_mux_qup6, + msm_mux_rgmii_txd1, + msm_mux_rgmii_txd2, + msm_mux_rgmii_txd3,
drivers/pinctrl/qcom/pinctrl-sm8150.c line 641
Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +10
-0+ msm_mux_qup_l6, + msm_mux_rgmii_mdc, + msm_mux_qup_l5, + msm_mux_mdp_vsync, + msm_mux_edp_lcd, + msm_mux_qup10, + msm_mux_m_voc, + msm_mux_edp_hot, + msm_mux_cam_mclk, + msm_mux_qdss_gpio0,
Please squash all qdss_gpio into msm_mux_qdss (iirc qdss_cti is a separate thing).
Quoted 60 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +60
-0+ msm_mux_qdss_gpio1, + msm_mux_qdss_gpio2, + msm_mux_qdss_gpio3, + msm_mux_cci_i2c, + msm_mux_qdss_gpio4, + msm_mux_phase_flag3, + msm_mux_qdss_gpio5, + msm_mux_phase_flag2, + msm_mux_qdss_gpio6, + msm_mux_phase_flag1, + msm_mux_qdss_gpio7, + msm_mux_cci_timer0, + msm_mux_gcc_gp2, + msm_mux_qdss_gpio8, + msm_mux_cci_timer1, + msm_mux_gcc_gp3, + msm_mux_qdss_gpio, + msm_mux_cci_timer2, + msm_mux_qup18, + msm_mux_qdss_gpio9, + msm_mux_cci_timer3, + msm_mux_cci_async, + msm_mux_qdss_gpio10, + msm_mux_cci_timer4, + msm_mux_qdss_gpio11, + msm_mux_qdss_gpio12, + msm_mux_qup15, + msm_mux_qdss_gpio15, + msm_mux_qdss_gpio13, + msm_mux_qdss_gpio14, + msm_mux_pci_e0, + msm_mux_qup_l4, + msm_mux_agera_pll, + msm_mux_usb_phy, + msm_mux_qup9, + msm_mux_qup13, + msm_mux_qdss_cti, + msm_mux_qup14, + msm_mux_qup4, + msm_mux_qup17, + msm_mux_qup19, + msm_mux_phase_flag5, + msm_mux_phase_flag0, + msm_mux_phase_flag22, + msm_mux_rgmii_mdio, + msm_mux_phase_flag10, + msm_mux_atest_char, + msm_mux_nav_pps, + msm_mux_atest_usb2, + msm_mux_qlink_request, + msm_mux_qlink_enable, + msm_mux_wmss_reset, + msm_mux_atest_usb23, + msm_mux_phase_flag6, + msm_mux_pa_indicator, + msm_mux_phase_flag23, + msm_mux_mss_lte, + msm_mux_phase_flag24, + msm_mux__, +};
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1359
Quoted 2 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +2
-0+static const struct msm_function sm8150_functions[] = { +FUNCTION (phase_flag8),
Please sort this array as well.
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +1
-0+ FUNCTION(phase_flag7),
[..]
Quoted 9 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +9
-0+}; + +/* +* Every pin is maintained as a single group, and missing or non-existing pin +* would be maintained as dummy group to synchronize pin group index with +* pin descriptor registered with pinctrl core. +* Clients would not be able to request these dummy pin groups. +*/ +static const struct msm_pingroup sm8150_groups[] = {
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1634
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +1
-0+ [58] = PINGROUP(58, SOUTH, qup17, qup19, qdss_cti, qdss_cti, _, _, _, _, _),
qdss_cti can't be both function 3 and 4 of a single pin.
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1782
Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +4
-0+static struct platform_driver sm8150_pinctrl_driver = { + .driver = { + .name ="sm8150-pinctrl" , + .owner =THIS_MODULE ,
No .owner in platform_driver
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1787
Quoted 5 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +5
-0+ .of_match_table = sm8150_pinctrl_of_match, + }, + .probe = sm8150_pinctrl_probe, + .remove = msm_pinctrl_remove, +};
Regards,
Bjorn
Re: [PATCH 2/2] pinctrl: qcom: Add SM8150 pinctrl driver
Quoted 4 lines · Bjorn Andersson
Quoted 2 lines · Vinod Koul
From: Prasad Sodagudi <[email protected]>
Quoted 8 lines
Quoted 5 lines
Add initial pinctrl driver to support pin configuration with pinctrl framework for SM8150
Signed-off-by Prasad Sodagudi <[email protected]>Signed-off-by Isaac J. Manjarres <[email protected]>I presume you did stuff to make it fit with my upstream tiling, mention that here.
Thanks for pointing I did miss the changes I did
Quoted 11 lines
[..]
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +0
-0[..]
Quoted 1 line
+static const struct
pinctrl_pin_descsm8150_pins[] = {[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 305
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +1
-0+ PINCTRL_PIN(178, "UFS_RESET"),Please follow
https://lore.kernel.org/linux-arm-msm/[email protected]/
forufs_reset.
Sure will update
Quoted 8 lines
Quoted 2 lines
+};
[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 492
Quoted 2 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +2
-0+enum sm8150_functions { + msm_mux_phase_flag8,Please sort these alphabetically and please squash all the phase_flag* into
msm_mux_phase_flag.
Will do, is there a reason why we want to squash them?
Quoted 8 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c line 497
Quoted 6 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +5
-0+ msm_mux_phase_flag7, + msm_mux_emac_pps, + msm_mux_qup12, + msm_mux_qup16, + msm_mux_tsif1_clk,Please squash all tsif1 into
msm_mux_tsif1.
Will do
Quoted 16 lines
Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +3
-0+ msm_mux_qup8, + msm_mux_qspi_cs, + msm_mux_tgu_ch3,drivers/pinctrl/qcom/pinctrl-sm8150.c line 510
Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +10
-0+ msm_mux_tsif1_en, + msm_mux_qspi0, + msm_mux_mdp_vsync0, + msm_mux_mdp_vsync1, + msm_mux_mdp_vsync2, + msm_mux_mdp_vsync3, + msm_mux_tgu_ch0, + msm_mux_tsif1_data, + msm_mux_qspi1, + msm_mux_sdc4_cmd,Squash
sdc4_cmd,sdc4_clkand sdc4{0,1,2,3} intomsm_mux_sdc4.
Sure will do on all and again what is the motivation. I am trying to understand the reasoning so that next time I know what to do :-)
Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1359
Quoted 2 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +2
-0+static const struct msm_function sm8150_functions[] = { +FUNCTION (phase_flag8),Please sort this array as well.
okay
Quoted 5 lines
Quoted 1 line
+static const struct
msm_pingroupsm8150_groups[] = {[..]
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1634
Quoted 1 line
drivers/pinctrl/qcom/pinctrl-sm8150.c +1
-0+ [58] = PINGROUP(58, SOUTH, qup17, qup19, qdss_cti, qdss_cti, _, _, _, _, _),
qdss_ctican't be both function 3 and 4 of a single pin.
Let me check, maybe error in downstream code
Quoted 6 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c line 1782
Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-sm8150.c +4
-0+static struct platform_driver sm8150_pinctrl_driver = { + .driver = { + .name ="sm8150-pinctrl" , + .owner =THIS_MODULE ,No .owner in
platform_driver
Yeah missed to remove
Signature · 1 line
~Vinod
Quoted 22 lines · Vinod Koul
From: Prasad Sodagudi <[email protected]>
Add the binding for the TLMM pinctrl block found in the SM8150 platform.
Signed-off-by Prasad Sodagudi <[email protected]>Signed-off-by Isaac J. Manjarres <[email protected]>Signed-off-by Vinod Koul <[email protected]>--- .../bindings/pinctrl/qcom,sm8150-pinctrl | 200 ++++++++++++++++++ 1 file changed, 200 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrlDocumentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +4
-0@@ -0,0 +1,200 @@ +Qualcomm SM8150 TLMM block + +This binding describes the Top Level Mode Multiplexer block found in the +QCS404 platform.
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 14
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +10
-0+ +- compatible: + Usage: required + Value type: <string> + Definition: must be "qcom,sm8150-pinctrl" + +- reg: + Usage: required + Value type: <prop-encoded-array> + Definition: the base address and size of the north, south , west
Extra space after south.
Quoted 25 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +25
-0+ and east TLMM tiles. + +- reg-names: + Usage: required + Value type: <prop-encoded-array> + Defintiion: names for the cells of reg, must contain "north", "south" + "west" and "east". + +- interrupts: + Usage: required + Value type: <prop-encoded-array> + Definition: should specify the TLMM summary IRQ. + +- interrupt-controller: + Usage: required + Value type: <none> + Definition: identifies this node as an interrupt controller + +- #interrupt-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/interrupt-controller/irq.h> + +- gpio-controller:
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 49
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +10
-0+ Usage: required + Value type: <none> + Definition: identifies this node as a gpio controller + +- #gpio-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/gpio/gpio.h> +
Please also document gpio-ranges and gpio-reserved-ranges.
Quoted 140 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +140
-0+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for +a general description of GPIO and interrupt bindings. + +Please refer to pinctrl-bindings.txt in this directory for details of the +common pinctrl bindings used by client devices, including the meaning of the +phrase "pin configuration node". + +The pin configuration nodes act as a container for an arbitrary number of +subnodes. Each of these subnodes represents some desired configuration for a +pin, a group, or a list of pins or groups. This configuration can include the +mux function to select on those pin(s)/group(s), and various pin configuration +parameters, such as pull-up, drive strength, etc. + + +PIN CONFIGURATION NODES: + +The name of each subnode is not important; all subnodes should be enumerated +and processed purely based on their content. + +Each subnode only affects those parameters that are explicitly listed. In +other words, a subnode that lists a mux function but no pin configuration +parameters implies no information about any pin configuration parameters. +Similarly, a pin subnode that describes a pullup parameter implies no +information about e.g. the mux function. + + +The following generic properties as defined in pinctrl-bindings.txt are valid +to specify in a pin configuration subnode: + +- pins: + Usage: required + Value type: <string-array> + Definition: List of gpio pins affected by the properties specified in + this subnode. + + Valid pins are: + gpio0-gpio149 + Supports mux, bias and drive-strength + + sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, + sdc2_data sdc1_rclk + Supports bias and drive-strength + + ufs_reset + Supports bias and drive-strength + +- function: + Usage: required + Value type: <string> + Definition: Specify the alternative function to be configured for the + specified pins. Functions are only valid for gpio pins. + Valid values are: + + blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens, + bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8, + qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b, + dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10, + blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12, + mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11, + atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char, + cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b, + pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c, + qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4, + qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5, + atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6, + atest_usb20, atest_char0, dac_calib10, qdss_stm10, + qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6, + blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11, + qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1, + qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11, + dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6, + qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14, + dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem, + dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto, + dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0, + dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25, + sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2, + qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3, + uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9, + blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7, + qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11, + blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0, + cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4, + blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4, + qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus, + isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s, + qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b, + sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b, + gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12, + qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29, + tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27, + qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk, + sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b, + sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b, + ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b, + blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt, + pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11, + qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx, + qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3, + gpio + +- bias-disable: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as no pull. + +- bias-pull-down: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull down. + +- bias-pull-up: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull up. + +- output-high: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + high. + Not valid for sdc pins. + +- output-low: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + low. + Not valid for sdc pins. + +- drive-strength: + Usage: optional + Value type: <u32> + Definition: Selects the drive strength for the specified pins, in mA. + Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16 + +Example: + + tlmm: pinctrl@3000000 { + compatible = "qcom,sm8150-pinctrl";
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 199
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +10
-0+ reg = <0x03100000 0x300000>, + <0x03500000 0x300000>, + <0x03900000 0x300000>, + <0x03D00000 0x300000>; + reg-names = "west", "east", "north", "south"; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>;
You're missing the required gpio-ranges from the example, see e.g. msm8996 (and please send a patch to the binding you based this on).
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 200
Quoted 1 line
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +1
-0+ };
Regards,
Bjorn
Quoted 8 lines · Bjorn Andersson
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 14
Quoted 4 lines · Vinod Koul
+- reg:
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +3
-0+ Usage: required + Value type: <prop-encoded-array> + Definition: the base address and size of the north, south , westExtra space after south.
Thanks will fix that
Quoted 8 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 49
Quoted 6 lines
+- #gpio-cells:
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +5
-0+ Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/gpio/gpio.h> +Please also document gpio-ranges and gpio-reserved-ranges.
Will add
Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +9
-0+Example: + + tlmm: pinctrl@3000000 { + compatible = "qcom,sm8150-pinctrl"; + reg = <0x03100000 0x300000>, + <0x03500000 0x300000>, + <0x03900000 0x300000>, + <0x03D00000 0x300000>; + reg-names = "west", "east", "north", "south";
Quoted 8 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl line 199
Quoted 5 lines
Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +5
-0+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>;You're missing the required gpio-ranges from the example, see e.g. msm8996 (and please send a patch to the binding you based this on).
I ported this from downstream but did look at existing upstream examples so will do that
Signature · 1 line
~Vinod
Hey Vinod,
Quoted 9 lines · Vinod Koul
From: Prasad Sodagudi <[email protected]>
Add the binding for the TLMM pinctrl block found in the SM8150 platform.
Signed-off-by Prasad Sodagudi <[email protected]>Signed-off-by Isaac J. Manjarres <[email protected]>Signed-off-by Vinod Koul <[email protected]>--- .../bindings/pinctrl/qcom,sm8150-pinctrl | 200 ++++++++++++++++++
Looks like you missed the .txt extension for binding :-)
Regards,
Mani
Quoted 212 lines
1 file changed, 200 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrlDocumentation/devicetree/bindings/pinctrl/qcom,sm8150-pinctrl new file +200
-0@@ -0,0 +1,200 @@ +Qualcomm SM8150 TLMM block + +This binding describes the Top Level Mode Multiplexer block found in the +QCS404 platform. + +- compatible: + Usage: required + Value type: <string> + Definition: must be "qcom,sm8150-pinctrl" + +- reg: + Usage: required + Value type: <prop-encoded-array> + Definition: the base address and size of the north, south , west + and east TLMM tiles. + +- reg-names: + Usage: required + Value type: <prop-encoded-array> + Defintiion: names for the cells of reg, must contain "north", "south" + "west" and "east". + +- interrupts: + Usage: required + Value type: <prop-encoded-array> + Definition: should specify the TLMM summary IRQ. + +- interrupt-controller: + Usage: required + Value type: <none> + Definition: identifies this node as an interrupt controller + +- #interrupt-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/interrupt-controller/irq.h> + +- gpio-controller: + Usage: required + Value type: <none> + Definition: identifies this node as a gpio controller + +- #gpio-cells: + Usage: required + Value type: <u32> + Definition: must be 2. Specifying the pin number and flags, as defined + in <dt-bindings/gpio/gpio.h> + +Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for +a general description of GPIO and interrupt bindings. + +Please refer to pinctrl-bindings.txt in this directory for details of the +common pinctrl bindings used by client devices, including the meaning of the +phrase "pin configuration node". + +The pin configuration nodes act as a container for an arbitrary number of +subnodes. Each of these subnodes represents some desired configuration for a +pin, a group, or a list of pins or groups. This configuration can include the +mux function to select on those pin(s)/group(s), and various pin configuration +parameters, such as pull-up, drive strength, etc. + + +PIN CONFIGURATION NODES: + +The name of each subnode is not important; all subnodes should be enumerated +and processed purely based on their content. + +Each subnode only affects those parameters that are explicitly listed. In +other words, a subnode that lists a mux function but no pin configuration +parameters implies no information about any pin configuration parameters. +Similarly, a pin subnode that describes a pullup parameter implies no +information about e.g. the mux function. + + +The following generic properties as defined in pinctrl-bindings.txt are valid +to specify in a pin configuration subnode: + +- pins: + Usage: required + Value type: <string-array> + Definition: List of gpio pins affected by the properties specified in + this subnode. + + Valid pins are: + gpio0-gpio149 + Supports mux, bias and drive-strength + + sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, + sdc2_data sdc1_rclk + Supports bias and drive-strength + + ufs_reset + Supports bias and drive-strength + +- function: + Usage: required + Value type: <string> + Definition: Specify the alternative function to be configured for the + specified pins. Functions are only valid for gpio pins. + Valid values are: + + blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens, + bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8, + qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b, + dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10, + blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12, + mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11, + atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char, + cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b, + pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c, + qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4, + qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5, + atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6, + atest_usb20, atest_char0, dac_calib10, qdss_stm10, + qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6, + blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11, + qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1, + qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11, + dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6, + qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14, + dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem, + dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto, + dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0, + dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25, + sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2, + qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3, + uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9, + blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7, + qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11, + blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0, + cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4, + blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4, + qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus, + isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s, + qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b, + sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b, + gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12, + qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29, + tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27, + qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk, + sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b, + sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b, + ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b, + blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt, + pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11, + qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx, + qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3, + gpio + +- bias-disable: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as no pull. + +- bias-pull-down: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull down. + +- bias-pull-up: + Usage: optional + Value type: <none> + Definition: The specified pins should be configued as pull up. + +- output-high: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + high. + Not valid for sdc pins. + +- output-low: + Usage: optional + Value type: <none> + Definition: The specified pins are configured in output mode, driven + low. + Not valid for sdc pins. + +- drive-strength: + Usage: optional + Value type: <u32> + Definition: Selects the drive strength for the specified pins, in mA. + Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16 + +Example: + + tlmm: pinctrl@3000000 { + compatible = "qcom,sm8150-pinctrl"; + reg = <0x03100000 0x300000>, + <0x03500000 0x300000>, + <0x03900000 0x300000>, + <0x03D00000 0x300000>; + reg-names = "west", "east", "north", "south"; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + };Signature · 1 line
2.20.1
Quoted 7 lines · Manivannan Sadhasivam
Hey Vinod,
Quoted 4 lines · Vinod Koul
From: Prasad Sodagudi <[email protected]>
Add the binding for the TLMM pinctrl block found in the SM8150 platform.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Prasad Sodagudi <[email protected]>Signed-off-by Isaac J. Manjarres <[email protected]>Signed-off-by Vinod Koul <[email protected]>--- .../bindings/pinctrl/qcom,sm8150-pinctrl | 200 ++++++++++++++++++Looks like you missed the .txt extension for binding :-)
Looks like I did :( Thanks for pointing Mani!
Signature · 1 line
~Vinod