ipoib: correcly show a VF hardware address
Subsystems (3)
PATCH 1/2 ipoib: correcly show a VF hardware address
in the case of IPoIB with SRIOV enabled hardware
ip link show command incorrecly prints
0 instead of a VF hardware address.
Before:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 MAC 00:00:00:00:00:00, spoof checking off, link-state disable,
trust off, query_rss off
...
After with iproute2 patch[0]
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off
[0]: https://patchwork.kernel.org/patch/10997111/
v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelogv3->v4: update the changelog: add a link to the patch for iproute2
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -0
@@ -1998,6 +1998,7 @@ static int ipoib_get_vf_config(struct net_device *dev, int vf,return err; ivf->vf = vf; +memcpy (ivf->mac, dev->dev_addr, dev->addr_len);return 0 ; }
Signature · 1 line
2.12.3
PATCH 2/2 ipoib: show VF broadcast address
in IPoIB case we can't see a VF broadcast address for but can see for PF
Before:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 MAC 14:80:00:00:66:fe, spoof checking off, link-state disable,
trust off, query_rss off
...
After with iproute2 patch[0]:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off
[0]: https://patchwork.kernel.org/patch/10997111
v1->v2: add the IFLA_VF_BROADCAST constantv2->v3: put IFLA_VF_BROADCAST at the end
to avoid KABI breakage and set NLA_REJECTdev_setlinkv3->v4: update the changelog: add a link to the patch for iproute2
--- include/uapi/linux/if_link.h | 5 +++++ net/core/rtnetlink.c | 5 +++++ 2 files changed, 10 insertions(+)
include/uapi/linux/if_link.h +5 -0
@@ -694,6 +694,7 @@ enum {IFLA_VF_IB_NODE_GUID ,/* VF Infiniband node GUID */ IFLA_VF_IB_PORT_GUID ,/* VF Infiniband port GUID */ IFLA_VF_VLAN_LIST ,/* nested list of vlans, option for QinQ */ +IFLA_VF_BROADCAST ,/* VF broadcast */ __IFLA_VF_MAX, };
@@ -704,6 +705,10 @@ struct ifla_vf_mac {__u8 mac[32 ];/* MAX_ADDR_LEN */ }; +struct ifla_vf_broadcast { +__u8 broadcast[32 ]; +}; +struct ifla_vf_vlan {__u32 vf;__u32 vlan;/* 0 - 4095, 0 disables VLAN filter */
net/core/rtnetlink.c +5 -0
@@ -908,6 +908,7 @@ static inline int rtnl_vfinfo_size(const struct net_device *dev, size += num_vfs * (nla_total_size (0 ) +nla_total_size (sizeof (struct ifla_vf_mac )) + +nla_total_size (sizeof (struct ifla_vf_broadcast )) +nla_total_size (sizeof (struct ifla_vf_vlan )) +nla_total_size (0 ) +/* nest IFLA_VF_VLAN_LIST */ nla_total_size(MAX_VLAN_LIST_LEN *
@@ -1197,6 +1198,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,struct ifla_vf_vlan vf_vlan;struct ifla_vf_rate vf_rate;struct ifla_vf_mac vf_mac; +struct ifla_vf_broadcast vf_broadcast;struct ifla_vf_info ivi;memset (&ivi,0 ,sizeof (ivi));
@@ -1231,6 +1233,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, vf_trust.vf = ivi.vf;memcpy (vf_mac.mac, ivi.mac,sizeof (ivi.mac)); +memcpy (vf_broadcast.broadcast, dev->broadcast, dev->addr_len); vf_vlan.vlan = ivi.vlan; vf_vlan.qos = ivi.qos; vf_vlan_info.vlan = ivi.vlan;
@@ -1247,6 +1250,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,if (!vf) goto nla_put_vfinfo_failure; if (nla_put(skb, IFLA_VF_MAC, sizeof(vf_mac), &vf_mac) || + nla_put(skb, IFLA_VF_BROADCAST, sizeof(vf_broadcast), &vf_broadcast) || nla_put(skb, IFLA_VF_VLAN, sizeof(vf_vlan), &vf_vlan) || nla_put(skb, IFLA_VF_RATE, sizeof(vf_rate), &vf_rate) ||
@@ -1753,6 +1757,7 @@ static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX +1 ] = { [IFLA_VF_MAC ] = { .len =sizeof (struct ifla_vf_mac ) }, + [IFLA_VF_BROADCAST ] = { .type =NLA_REJECT }, [IFLA_VF_VLAN ] = { .len =sizeof (struct ifla_vf_vlan ) }, [IFLA_VF_VLAN_LIST ] = { .type =NLA_NESTED }, [IFLA_VF_TX_RATE ] = { .len =sizeof (struct ifla_vf_tx_rate ) },
Signature · 1 line
2.12.3
PATCH v4 1/2 ipoib: correcly show a VF hardware address
In reply to Denis Kirjanovin the case of IPoIB with SRIOV enabled hardware
ip link show command incorrecly prints
0 instead of a VF hardware address.
Before:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 MAC 00:00:00:00:00:00, spoof checking off, link-state disable,
trust off, query_rss off
...
After:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off
v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelog
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -0
@@ -1998,6 +1998,7 @@ static int ipoib_get_vf_config(struct net_device *dev, int vf,return err; ivf->vf = vf; +memcpy (ivf->mac, dev->dev_addr, dev->addr_len);return 0 ; }
Signature · 1 line
2.12.3
PATCH v4 2/2 ipoib: show VF broadcast address
In reply to Denis Kirjanovin IPoIB case we can't see a VF broadcast address for but can see for PF
Before:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 MAC 14:80:00:00:66:fe, spoof checking off, link-state disable,
trust off, query_rss off
...
After:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off
v1->v2: add the IFLA_VF_BROADCAST constantv2->v3: put IFLA_VF_BROADCAST at the end
to avoid KABI breakage and set NLA_REJECTdev_setlink
--- include/uapi/linux/if_link.h | 5 +++++ net/core/rtnetlink.c | 5 +++++ 2 files changed, 10 insertions(+)
include/uapi/linux/if_link.h +5 -0
@@ -694,6 +694,7 @@ enum {IFLA_VF_IB_NODE_GUID ,/* VF Infiniband node GUID */ IFLA_VF_IB_PORT_GUID ,/* VF Infiniband port GUID */ IFLA_VF_VLAN_LIST ,/* nested list of vlans, option for QinQ */ +IFLA_VF_BROADCAST ,/* VF broadcast */ __IFLA_VF_MAX, };
@@ -704,6 +705,10 @@ struct ifla_vf_mac {__u8 mac[32 ];/* MAX_ADDR_LEN */ }; +struct ifla_vf_broadcast { +__u8 broadcast[32 ]; +}; +struct ifla_vf_vlan {__u32 vf;__u32 vlan;/* 0 - 4095, 0 disables VLAN filter */
net/core/rtnetlink.c +5 -0
@@ -908,6 +908,7 @@ static inline int rtnl_vfinfo_size(const struct net_device *dev, size += num_vfs * (nla_total_size (0 ) +nla_total_size (sizeof (struct ifla_vf_mac )) + +nla_total_size (sizeof (struct ifla_vf_broadcast )) +nla_total_size (sizeof (struct ifla_vf_vlan )) +nla_total_size (0 ) +/* nest IFLA_VF_VLAN_LIST */ nla_total_size(MAX_VLAN_LIST_LEN *
@@ -1197,6 +1198,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,struct ifla_vf_vlan vf_vlan;struct ifla_vf_rate vf_rate;struct ifla_vf_mac vf_mac; +struct ifla_vf_broadcast vf_broadcast;struct ifla_vf_info ivi;memset (&ivi,0 ,sizeof (ivi));
@@ -1231,6 +1233,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, vf_trust.vf = ivi.vf;memcpy (vf_mac.mac, ivi.mac,sizeof (ivi.mac)); +memcpy (vf_broadcast.broadcast, dev->broadcast, dev->addr_len); vf_vlan.vlan = ivi.vlan; vf_vlan.qos = ivi.qos; vf_vlan_info.vlan = ivi.vlan;
@@ -1247,6 +1250,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,if (!vf) goto nla_put_vfinfo_failure; if (nla_put(skb, IFLA_VF_MAC, sizeof(vf_mac), &vf_mac) || + nla_put(skb, IFLA_VF_BROADCAST, sizeof(vf_broadcast), &vf_broadcast) || nla_put(skb, IFLA_VF_VLAN, sizeof(vf_vlan), &vf_vlan) || nla_put(skb, IFLA_VF_RATE, sizeof(vf_rate), &vf_rate) ||
@@ -1753,6 +1757,7 @@ static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX +1 ] = { [IFLA_VF_MAC ] = { .len =sizeof (struct ifla_vf_mac ) }, + [IFLA_VF_BROADCAST ] = { .type =NLA_REJECT }, [IFLA_VF_VLAN ] = { .len =sizeof (struct ifla_vf_vlan ) }, [IFLA_VF_VLAN_LIST ] = { .type =NLA_NESTED }, [IFLA_VF_TX_RATE ] = { .len =sizeof (struct ifla_vf_tx_rate ) },
Signature · 1 line
2.12.3
David Miller
maintainerRe: [PATCH net-next v4 2/2] ipoib: show VF broadcast address
From: Denis Kirjanov <[email protected]>
Date: Mon, 17 Jun 2019 10:53:41 +0200
Quoted 2 lines
in IPoIB case we can't see a VF broadcast address for but can see for PF
I just want to understand why this need to see the VF broadcast address is IPoIB specific?
Re: [PATCH net-next v4 2/2] ipoib: show VF broadcast address
Quoted 8 lines · David Miller
From: Denis Kirjanov <[email protected]>
Date: Mon, 17 Jun 2019 10:53:41 +0200Quoted 2 lines
in IPoIB case we can't see a VF broadcast address for but can see for PF
I just want to understand why this need to see the VF broadcast address is IPoIB specific?
A VF might or might not have the same security domain (P_Key) as the parent, and the P_Key is encoded in the broadcast address. In the event that two vfs or a vf and a pf can't see each other over the IPoIB network, it is necessary to be able to see the broadcast address in use by each to make sure they are the same and not that they shouldn't be able to see each other because they are on different P_Keys and therefore different broadcast multicast groups.
Signature · 4 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
David Miller
maintainerRe: [PATCH net-next v4 2/2] ipoib: show VF broadcast address
From: Doug Ledford <[email protected]>
Date: Tue, 18 Jun 2019 13:29:59 -0400
Quoted 10 lines · David Miller
Quoted 8 lines
From: Denis Kirjanov <[email protected]>
Date: Mon, 17 Jun 2019 10:53:41 +0200Quoted 2 lines
in IPoIB case we can't see a VF broadcast address for but can see for PF
I just want to understand why this need to see the VF broadcast address is IPoIB specific?
Quoted 7 lines
A VF might or might not have the same security domain (
P_Key) as the parent, and theP_Keyis encoded in the broadcast address. In the event that two vfs or a vf and a pf can't see each other over the IPoIB network, it is necessary to be able to see the broadcast address in use by each to make sure they are the same and not that they shouldn't be able to see each other because they are on differentP_Keysand therefore different broadcast multicast groups.
Thanks for explaining.
I'll apply these to net-next right now then.
Thanks again.
Quoted 25 lines · Denis Kirjanov
in the case of IPoIB with SRIOV enabled hardware
ip link show command incorrecly prints
0 instead of a VF hardware address.Before:
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdiscpfifo_faststate UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ffvf 0 MAC 00:00:00:00:00:00, spoof checking off, link-statedisable,
trust off,query_rssoff
...
After with iproute2 patch[0]
11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdiscpfifo_faststate UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
vf 0 link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off,query_rssoff
Quoted 7 lines
[0]: https://patchwork.kernel.org/patch/10997111/
v1->v2: just copy an address without modifingifla_vf_macv2->v3: update the changelogv3->v4: update the changelog: add a link to the patch for iproute2Signed-off-by Denis Kirjanov <[email protected]>
I assume you want this to go as a series through netdev, so you can add my:
Signature · 4 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD