datatype: fix print of raw numerical symbol values
Florian Westphal
maintainerPATCH v2 1/1 datatype: fix print of raw numerical symbol values
The two rules:
arp operation 1-2 accept
arp operation 256-512 accept
are both shown as 256-512:
chain in_public {
arp operation 256-512 accept
arp operation 256-512 accept
meta mark "1"
tcp flags 2,4
}
This is because range expression enforces numeric output, yet nft_print doesn't respect byte order.
Behave as if we had no symbol in the first place and call the base type print function instead.
This means we now respect format specifier as well:
chain in_public {
arp operation 1-2 accept
arp operation 256-512 accept
meta mark 0x00000001
tcp flags 0x2,0x4
}Without fix, added test case will fail:
'add rule arp test-arp input arp operation 1-2': 'arp operation 1-2' mismatches 'arp operation 256-512'
v2: in case of -n, also elide quotation marks, just as if we would not have found a symbolic name.
--- src/datatype.c | 14 +++----------- tests/py/arp/arp.t | 1 + tests/py/arp/arp.t.payload | 6 ++++++ tests/py/arp/arp.t.payload.netdev | 8 ++++++++ 4 files changed, 18 insertions(+), 11 deletions(-)
src/datatype.c +3 -11
@@ -191,19 +191,11 @@ void symbolic_constant_print(const struct symbol_table *tbl,break ; } -if (s->identifier ==NULL ) +if (s->identifier ==NULL || +nft_output_numeric_symbol (octx))return expr_basetype (expr)->if (quotes) -nft_print (octx,"\"" ); - -if (nft_output_numeric_symbol (octx)) -nft_print (octx,"%" PRIu64"" , val); -else -nft_print (octx,"%s" , s->identifier); - -if (quotes) -nft_print (octx,"\"" ); +nft_print (octx, quotes ?"\"%s\"" :"%s" , s->identifier); }static void switch_byteorder (void *data,unsigned int len)
tests/py/arp/arp.t +1 -0
@@ -38,6 +38,7 @@ arp plen != {33-55};ok arp operation {nak, inreply, inrequest, rreply, rrequest, reply, request};ok arp operation != {nak, inreply, inrequest, rreply, rrequest, reply, request};ok +arp operation 1-2;ok arp operation request;ok arp operation reply;ok arp operation rrequest;ok
tests/py/arp/arp.t.payload +6 -0
@@ -188,6 +188,12 @@ arp test-arp input [ payload load 2b @ network header + 6 => reg 1 ] [ lookup reg 1 set __set%d 0x1 ] +# arp operation 1-2 +arp test-arp input + [ payload load 2b @ network header + 6 => reg 1 ] + [ cmp gte reg 1 0x00000100 ] + [ cmp lte reg 1 0x00000200 ] + # arp operation request arp test-arp input [ payload load 2b @ network header + 6 => reg 1 ]
tests/py/arp/arp.t.payload.netdev +8 -0
@@ -246,6 +246,14 @@ netdev test-netdev ingress [ payload load 2b @ network header + 6 => reg 1 ] [ lookup reg 1 set __set%d 0x1 ] +# arp operation 1-2 +netdev test-netdev ingress + [ meta load protocol => reg 1 ] + [ cmp eq reg 1 0x00000608 ] + [ payload load 2b @ network header + 6 => reg 1 ] + [ cmp gte reg 1 0x00000100 ] + [ cmp lte reg 1 0x00000200 ] + # arp operation request netdev test-netdev ingress [ meta load protocol => reg 1 ]
Signature · 1 line
2.21.0
Quoted 27 lines · Florian Westphal
The two rules:
arp operation 1-2 accept
arp operation 256-512 acceptare both shown as 256-512:
chain
in_public{
arp operation 256-512 accept
arp operation 256-512 accept
meta mark "1"
tcp flags 2,4
}This is because range expression enforces numeric output, yet
nft_printdoesn't respect byte order.Behave as if we had no symbol in the first place and call the base type print function instead.
This means we now respect format specifier as well:
chain in_public { arp operation 1-2 accept arp operation 256-512 accept meta mark 0x00000001 tcp flags 0x2,0x4 }
Quoted 7 lines
Without fix, added test case will fail:
'add rule arp test-arp input arp operation 1-2': 'arp operation 1-2' mismatches 'arp operation 256-512'v2: in case of -n, also elide quotation marks, just as if we would not have found a symbolic name.
Signed-off-by Florian Westphal <[email protected]>
Thanks Florian.