Skip to contentSkip to conversation

configure: use valid args testing sem_timedwait

PATCH Applied Daniel P. Berrangé 2 participants 3 messages Jun 17, 2019 – Jun 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: use valid args testing sem_timedwait

The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release.

This causes configure to fail when -Werror is used:

config-temp/qemu-conf.c: In function ‘main’:
config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]

    2 | int main(void) { return sem_timedwait(0, 0); }
      |                         ^~~~~~~~~~~~~

config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index b091b82cb3..6632d05fc7 100755
@@ -5139,7 +5139,7 @@ fi
 sem_timedwait=no
 cat > $TMPC << EOF
 #include <semaphore.h>
-int main(void) { return sem_timedwait(0, 0); }
+int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
 EOF
 if compile_prog "" "" ; then
     sem_timedwait=yes
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw

Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit :

Quoted 23 lines

The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release.

This causes configure to fail when -Werror is used:

config-temp/qemu-conf.c: In function ‘main’:
config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]

    2 | int main(void) { return sem_timedwait(0, 0); }
      |                         ^~~~~~~~~~~~~

config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index b091b82cb3..6632d05fc7 100755

configure fi · line 5145

Quoted 8 lines
configure +1 -1
@@ -5139,7 +5139,7 @@ fi
 sem_timedwait=no
 cat > $TMPC << EOF
 #include <semaphore.h>
-int main(void) { return sem_timedwait(0, 0); }
+int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
 EOF
 if compile_prog "" "" ; then
     sem_timedwait=yes
#2 lore raw
In reply to Daniel P. Berrangé

Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit :

Quoted 23 lines

The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release.

This causes configure to fail when -Werror is used:

config-temp/qemu-conf.c: In function ‘main’:
config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]

    2 | int main(void) { return sem_timedwait(0, 0); }
      |                         ^~~~~~~~~~~~~

config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index b091b82cb3..6632d05fc7 100755

configure fi · line 5145

Quoted 8 lines
configure +1 -1
@@ -5139,7 +5139,7 @@ fi
 sem_timedwait=no
 cat > $TMPC << EOF
 #include <semaphore.h>
-int main(void) { return sem_timedwait(0, 0); }
+int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
 EOF
 if compile_prog "" "" ; then
     sem_timedwait=yes

Applied to my trivial-patches branch.

Thanks,
Laurent