drm/amd/display: include missing linux/delay.h
Subsystems (3)
PATCH 1/1 drm/amd/display: include missing linux/delay.h
Some randconfig builds fail to compile the dcn10 code because of a missing declaration:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
Include the appropriate kernel header.
--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +1 -0
@@ -22,6 +22,7 @@* Authors: AMD * */ +#include <linux/delay.h> #include <linux/delay.h> #include "dm_services.h"
Signature · 1 line
2.20.0
Hi Arnd.
Quoted 19 lines · Arnd Bergmann
Some randconfig builds fail to compile the dcn10 code because of a missing declaration:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]Include the appropriate kernel header.
Fixes 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +0
-0
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c line 28
Quoted 7 lines
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +1
-0@@ -22,6 +22,7 @@* Authors: AMD * */ +#include <linux/delay.h> #include <linux/delay.h> #include "dm_services.h"
Something has gone wrong here, as you add a second include of linux/delay.h.
We had this problem before, which Alex fixed by applying a patch to include linux/delay.h
Sam
Quoted 25 lines · Sam Ravnborg
Quoted 24 lines · Arnd Bergmann
Some randconfig builds fail to compile the dcn10 code because of a missing declaration:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]Include the appropriate kernel header.
Fixes 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +1
-0@@ -22,6 +22,7 @@* Authors: AMD * */ +#include <linux/delay.h>
Quoted 7 lines
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c line 28
Quoted 2 lines
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +0
-0#include <linux/delay.h> #include "dm_services.h" Something has gone wrong here, as you add a second include of
linux/delay.h.We had this problem before, which Alex fixed by applying a patch to include
linux/delay.h
My mistake, sorry about that. I had written and tested the patch on last week's linux-next ernel and sent it out today after rebasing it, but did not closely look at the resulting patch after the rebase.
Arnd