e1000e: Make watchdog use delayed work
Subsystems (3)
PATCH 1/1 e1000e: Make watchdog use delayed work
Use delayed work instead of timers to run the watchdog of the e1000e driver.
Simplify the code with one less middle function.
--- drivers/net/ethernet/intel/e1000e/e1000.h | 3 +- drivers/net/ethernet/intel/e1000e/netdev.c | 52 +++++++++++----------- 2 files changed, 28 insertions(+), 27 deletions(-)
drivers/net/ethernet/intel/e1000e/e1000.h +1 -2
@@ -186,12 +186,11 @@ struct e1000_phy_regs {/* board specific private data structure */ struct e1000_adapter { -struct timer_list watchdog_timer;struct timer_list phy_info_timer;struct timer_list blink_timer;struct work_struct reset_task; -struct work_struct watchdog_task; +struct delayed_work watchdog_task;const struct e1000_info *ei;
drivers/net/ethernet/intel/e1000e/netdev.c +27 -25
126 lines not on this page · raw message
Signature · 1 line
2.22.0
kbuild test robot
build bot[RFC PATCH] e1000e: e1000_workqueue can be static
Fixes: ef431cc0a6a5 ("e1000e: Make watchdog use delayed work")
--- netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/e1000e/netdev.c +1 -1
@@ -39,7 +39,7 @@ static int debug = -1;module_param (debug, int,0 );MODULE_PARM_DESC (debug,"Debug level (0=none,...,16=all)" ); -struct workqueue_struct *e1000_workqueue; +static struct workqueue_struct *e1000_workqueue;static const struct e1000_info *e1000_info_tbl[] = { [board_82571] = &e1000_82571_info,
kbuild test robot
build botThank you for the patch! Perhaps something to improve:
Hi Detlev,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jkirsher-next-queue/dev-queue]
[also build test WARNING on v5.2-rc5 next-20190617]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Detlev-Casanova/e1000e-Make-watchdog-use-delayed-work/20190617-154840 base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation