Fix build of Xen support + cleanup
cover Fix build of Xen support + cleanup
Hi,
Fix the build in osstest and some cleanup
For reference:
Recent flight failure:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01022.html
Bisect result:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01029.html
Thanks.
Anthony PERARD (4):
xen: Fix build with public headers
xen: Import other xen/io/*.h
xen: Import Xen public headers used by xen-hvm.c
xen: Avoid VLA
hw/9pfs/xen-9pfs.h | 4 +-
hw/block/xen_blkif.h | 5 +-
hw/char/xen_console.c | 2 +-
hw/display/xenfb.c | 7 +-
hw/i386/xen/xen-hvm.c | 17 +-
hw/i386/xen/xen-mapcache.c | 2 -
hw/net/xen_nic.c | 2 +-
hw/usb/xen-usb.c | 3 +-
hw/xen/xen-legacy-backend.c | 2 -
include/hw/xen/interface/grant_table.h | 36 +
include/hw/xen/interface/hvm/e820.h | 28 +
include/hw/xen/interface/hvm/ioreq.h | 101 +++
include/hw/xen/interface/hvm/params.h | 33 +
include/hw/xen/interface/io/blkif.h | 712 +++++++++++++++
include/hw/xen/interface/io/console.h | 46 +
include/hw/xen/interface/io/fbif.h | 156 ++++
include/hw/xen/interface/io/kbdif.h | 566 ++++++++++++
include/hw/xen/interface/io/netif.h | 1010 ++++++++++++++++++++++
include/hw/xen/interface/io/protocols.h | 42 +
include/hw/xen/{ => interface}/io/ring.h | 0
include/hw/xen/interface/io/usbif.h | 254 ++++++
include/hw/xen/interface/io/xenbus.h | 70 ++
include/hw/xen/xen_common.h | 2 +-
23 files changed, 3076 insertions(+), 24 deletions(-)
create mode 100644 include/hw/xen/interface/grant_table.h
create mode 100644 include/hw/xen/interface/hvm/e820.h
create mode 100644 include/hw/xen/interface/hvm/ioreq.h
create mode 100644 include/hw/xen/interface/hvm/params.h
create mode 100644 include/hw/xen/interface/io/blkif.h
create mode 100644 include/hw/xen/interface/io/console.h
create mode 100644 include/hw/xen/interface/io/fbif.h
create mode 100644 include/hw/xen/interface/io/kbdif.h
create mode 100644 include/hw/xen/interface/io/netif.h
create mode 100644 include/hw/xen/interface/io/protocols.h
rename include/hw/xen/{ => interface}/io/ring.h (100%)
create mode 100644 include/hw/xen/interface/io/usbif.h
create mode 100644 include/hw/xen/interface/io/xenbus.hSignature · 7 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 1/4 xen: Fix build with public headers
Following 37677d7db3 "Clean up a few header guard symbols", QEMU start to fail to build:
In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0,
from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5,
from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:~/xen/tools/../tools/include/xen/io/ring.h:68:0: error: "__CONST_RING_SIZE" redefined [-Werror]
#define __CONST_RING_SIZE(_s, _sz) \
In file included from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:4:0,
from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/qemu-xen-dir/include/hw/xen/io/ring.h:66:0: note: this is the location of the previous definition
#define __CONST_RING_SIZE(_s, _sz) \
The issue is that some public xen headers have been imported (by f65eadb639 "xen: import ring.h from xen") but not all. With the change in the guards symbole, the ring.h header start to be imported twice.
Fix the build by importing blkif.h and usbif.h and there dependencies. Some cleanup have been done on those files.
Subsequent patches will import other Xen public headers.
ring.h have been moved to "hw/xen/interface/" along with blkif.h and usbif.h as those describe interface (and would allow to also import a xen.h header if that was necessary).
xen-mapcache.c doesn't needs grant_table.h.
---
hw/9pfs/xen-9pfs.h | 2 +-
hw/block/xen_blkif.h | 3 +-
hw/usb/xen-usb.c | 3 +-
hw/xen/xen-legacy-backend.c | 2 -
include/hw/xen/interface/grant_table.h | 36 ++
include/hw/xen/interface/io/blkif.h | 712 +++++++++++++++++++++++
include/hw/xen/{ => interface}/io/ring.h | 0
include/hw/xen/interface/io/usbif.h | 254 ++++++++
8 files changed, 1005 insertions(+), 7 deletions(-)
create mode 100644 include/hw/xen/interface/grant_table.h
create mode 100644 include/hw/xen/interface/io/blkif.h
rename include/hw/xen/{ => interface}/io/ring.h (100%)
create mode 100644 include/hw/xen/interface/io/usbif.hhw/9pfs/xen-9pfs.h +1 -1
@@ -14,7 +14,7 @@#define HW_9PFS_XEN_9PFS_H #include <xen/io/protocols.h> -#include "hw/xen/io/ring.h" +#include "hw/xen/interface/io/ring.h" /* * Do not merge into xen-9p-backend.c: clang doesn't allow unused static
hw/block/xen_blkif.h +1 -2
@@ -1,8 +1,7 @@#ifndef XEN_BLKIF_H #define XEN_BLKIF_H -#include "hw/xen/io/ring.h" -#include <xen/io/blkif.h> +#include "hw/xen/interface/io/blkif.h" #include <xen/io/protocols.h> /*
hw/usb/xen-usb.c +1 -2
@@ -32,8 +32,7 @@#include "qapi/qmp/qdict.h" #include "qapi/qmp/qstring.h" -#include "hw/xen/io/ring.h" -#include <xen/io/usbif.h> +#include "hw/xen/interface/io/usbif.h" /* * Check for required support of usbif.h: USBIF_SHORT_NOT_OK was the last
hw/xen/xen-legacy-backend.c +0 -2
@@ -34,8 +34,6 @@#include "hw/xen/xen_pvdev.h" #include "monitor/qdev.h" -#include <xen/grant_table.h> -DeviceState *xen_sysdev;BusState *xen_sysbus;
include/hw/xen/interface/grant_table.h new file +36 -0
@@ -0,0 +1,36 @@ +/****************************************************************************** +* grant_table.h +* +* Interface for granting foreign access to page frames, and receiving +* page-ownership transfers. +* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +* +* Copyright (c) 2004, K A Fraser +*/ + +#ifndef XEN_PUBLIC_GRANT_TABLE_H +#define XEN_PUBLIC_GRANT_TABLE_H + +/* +* Reference to a grant entry in a specified domain's grant table. +*/ +typedef uint32_t grant_ref_t ; + +#endif /* XEN_PUBLIC_GRANT_TABLE_H */
include/hw/xen/interface/io/blkif.h new file +712 -0
712 lines not on this page · raw message
include/hw/xen/interface/io/ring.h renamed from include/hw/xen/io/ring.h +0 -0
include/hw/xen/interface/io/usbif.h new file +254 -0
254 lines not on this page · raw message
Signature · 7 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 1/4] xen: Fix build with public headers
Quoted 32 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 1/4] xen: Fix build with public headersFollowing
37677d7db3"Clean up a few header guard symbols", QEMU start to fail to build:In file included from
~/xen/tools/../tools/include/xen/io/blkif.h:31:0,from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5, from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/../tools/include/xen/io/ring.h:68:0: error: "__CONST_RING_SIZE" redefined [-Werror]
#define__CONST_RING_SIZE(_s, _sz)\In file included from
~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:4:0,from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/qemu-xen-dir/include/hw/xen/io/ring.h:66:0: note: this is the location of the previous definition
#define__CONST_RING_SIZE(_s, _sz)\The issue is that some public xen headers have been imported (by
f65eadb639"xen: importring.hfrom xen") but not all. With the change in the guards symbole, thering.hheader start to be imported twice.Fix the build by importing
blkif.handusbif.hand there dependencies. Some cleanup have been done on those files.Subsequent patches will import other Xen public headers.
Quoted 7 lines
ring.hhave been moved to "hw/xen/interface/" along withblkif.handusbif.has those describe interface (and would allow to also import axen.hheader if that was necessary).
xen-mapcache.cdoesn't needsgrant_table.h.Signed-off-by Anthony PERARD <[email protected]>
Quoted 1,094 lines
--- hw/9pfs/xen-9pfs.h | 2 +- hw/block/xen_blkif.h | 3 +- hw/usb/xen-usb.c | 3 +- hw/xen/xen-legacy-backend.c | 2 - include/hw/xen/interface/grant_table.h | 36 ++ include/hw/xen/interface/io/blkif.h | 712 +++++++++++++++++++++++ include/hw/xen/{ => interface}/io/ring.h | 0 include/hw/xen/interface/io/usbif.h | 254 ++++++++ 8 files changed, 1005 insertions(+), 7 deletions(-) create mode 100644 include/hw/xen/interface/grant_table.h create mode 100644 include/hw/xen/interface/io/blkif.h rename include/hw/xen/{ => interface}/io/ring.h (100%) create mode 100644 include/hw/xen/interface/io/usbif.hhw/9pfs/xen-9pfs.h +1
-1@@ -14,7 +14,7 @@#define HW_9PFS_XEN_9PFS_H #include <xen/io/protocols.h> -#include "hw/xen/io/ring.h" +#include "hw/xen/interface/io/ring.h" /* * Do not merge into xen-9p-backend.c: clang doesn't allow unused static hw/block/xen_blkif.h +1
-2@@ -1,8 +1,7 @@#ifndef XEN_BLKIF_H #define XEN_BLKIF_H -#include "hw/xen/io/ring.h" -#include <xen/io/blkif.h> +#include "hw/xen/interface/io/blkif.h" #include <xen/io/protocols.h> /* hw/usb/xen-usb.c +1
-2@@ -32,8 +32,7 @@#include "qapi/qmp/qdict.h" #include "qapi/qmp/qstring.h" -#include "hw/xen/io/ring.h" -#include <xen/io/usbif.h> +#include "hw/xen/interface/io/usbif.h" /* * Check for required support of usbif.h: USBIF_SHORT_NOT_OK was the last hw/xen/xen-legacy-backend.c +0
-2@@ -34,8 +34,6 @@#include "hw/xen/xen_pvdev.h" #include "monitor/qdev.h" -#include <xen/grant_table.h> -DeviceState *xen_sysdev;BusState *xen_sysbus;include/hw/xen/interface/grant_table.h new file +36
-0@@ -0,0 +1,36 @@ +/****************************************************************************** +* grant_table.h +* +* Interface for granting foreign access to page frames, and receiving +* page-ownership transfers. +* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +* +* Copyright (c) 2004, K A Fraser +*/ + +#ifndef XEN_PUBLIC_GRANT_TABLE_H +#define XEN_PUBLIC_GRANT_TABLE_H + +/* +* Reference to a grant entry in a specified domain's grant table. +*/ +typedef uint32_t grant_ref_t ; + +#endif /* XEN_PUBLIC_GRANT_TABLE_H */ include/hw/xen/interface/io/blkif.h new file +712
-0@@ -0,0 +1,712 @@ +/****************************************************************************** +* blkif.h +* +* Unified block-device I/O interface for Xen guest OSes. +* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +* +* Copyright (c) 2003-2004, Keir Fraser +* Copyright (c) 2012, Spectra Logic Corporation +*/ + +#ifndef XEN_PUBLIC_IO_BLKIF_H +#define XEN_PUBLIC_IO_BLKIF_H + +#include "ring.h" +#include "../grant_table.h" + +/* +* Front->back notifications: When enqueuing a new request, sending a +* notification can be made conditional on req_event (i.e., the generic +* hold-off mechanism provided by the ring macros). Backends must set +* req_event appropriately (e.g., using RING_FINAL_CHECK_FOR_REQUESTS()). +* +* Back->front notifications: When enqueuing a new response, sending a +* notification can be made conditional on rsp_event (i.e., the generic +* hold-off mechanism provided by the ring macros). Frontends must set +* rsp_event appropriately (e.g., using RING_FINAL_CHECK_FOR_RESPONSES()). +*/ + +#ifndef blkif_vdev_t +#define blkif_vdev_t uint16_t +#endif +#define blkif_sector_t uint64_t + +/* +* Feature and Parameter Negotiation +* ================================= +* The two halves of a Xen block driver utilize nodes within the XenStore to +* communicate capabilities and to negotiate operating parameters. This +* section enumerates these nodes which reside in the respective front and +* backend portions of the XenStore, following the XenBus convention. +* +* All data in the XenStore is stored as strings. Nodes specifying numeric +* values are encoded in decimal. Integer value ranges listed below are +* expressed as fixed sized integer types capable of storing the conversion +* of a properly formated node string, without loss of information. +* +* Any specified default value is in effect if the corresponding XenBus node +* is not present in the XenStore. +* +* XenStore nodes in sections marked "PRIVATE" are solely for use by the +* driver side whose XenBus tree contains them. +* +* XenStore nodes marked "DEPRECATED" in their notes section should only be +* used to provide interoperability with legacy implementations. +* +* See the XenBus state transition diagram below for details on when XenBus +* nodes must be published and when they can be queried. +* +***************************************************************************** +* Backend XenBus Nodes +***************************************************************************** +* +*------------------ Backend Device Identification (PRIVATE) ------------------ +* +* mode +* Values: "r" (read only), "w" (writable) +* +* The read or write access permissions to the backing store to be +* granted to the frontend. +* +* params +* Values: string +* +* A free formatted string providing sufficient information for the +* hotplug script to attach the device and provide a suitable +* handler (ie: a block device) for blkback to use. +* +* physical-device +* Values: "MAJOR:MINOR" +* Notes: 11 +* +* MAJOR and MINOR are the major number and minor number of the +* backing device respectively. +* +* physical-device-path +* Values: path string +* +* A string that contains the absolute path to the disk image. On +* NetBSD and Linux this is always a block device, while on FreeBSD +* it can be either a block device or a regular file. +* +* type +* Values: "file", "phy", "tap" +* +* The type of the backing device/object. +* +* +* direct-io-safe +* Values: 0/1 (boolean) +* Default Value: 0 +* +* The underlying storage is not affected by the direct IO memory +* lifetime bug. See: +* http://lists.xen.org/archives/html/xen-devel/2012-12/msg01154.html +* +* Therefore this option gives the backend permission to use +* O_DIRECT, notwithstanding that bug. +* +* That is, if this option is enabled, use of O_DIRECT is safe, +* in circumstances where we would normally have avoided it as a +* workaround for that bug. This option is not relevant for all +* backends, and even not necessarily supported for those for +* which it is relevant. A backend which knows that it is not +* affected by the bug can ignore this option. +* +* This option doesn't require a backend to use O_DIRECT, so it +* should not be used to try to control the caching behaviour. +* +*--------------------------------- Features --------------------------------- +* +* feature-barrier +* Values: 0/1 (boolean) +* Default Value: 0 +* +* A value of "1" indicates that the backend can process requests +* containing the BLKIF_OP_WRITE_BARRIER request opcode. Requests +* of this type may still be returned at any time with the +* BLKIF_RSP_EOPNOTSUPP result code. +* +* feature-flush-cache +* Values: 0/1 (boolean) +* Default Value: 0 +* +* A value of "1" indicates that the backend can process requests +* containing the BLKIF_OP_FLUSH_DISKCACHE request opcode. Requests +* of this type may still be returned at any time with the +* BLKIF_RSP_EOPNOTSUPP result code. +* +* feature-discard +* Values: 0/1 (boolean) +* Default Value: 0 +* +* A value of "1" indicates that the backend can process requests +* containing the BLKIF_OP_DISCARD request opcode. Requests +* of this type may still be returned at any time with the +* BLKIF_RSP_EOPNOTSUPP result code. +* +* feature-persistent +* Values: 0/1 (boolean) +* Default Value: 0 +* Notes: 7 +* +* A value of "1" indicates that the backend can keep the grants used +* by the frontend driver mapped, so the same set of grants should be +* used in all transactions. The maximum number of grants the backend +* can map persistently depends on the implementation, but ideally it +* should be RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST. Using this +* feature the backend doesn't need to unmap each grant, preventing +* costly TLB flushes. The backend driver should only map grants +* persistently if the frontend supports it. If a backend driver chooses +* to use the persistent protocol when the frontend doesn't support it, +* it will probably hit the maximum number of persistently mapped grants +* (due to the fact that the frontend won't be reusing the same grants), +* and fall back to non-persistent mode. Backend implementations may +* shrink or expand the number of persistently mapped grants without +* notifying the frontend depending on memory constraints (this might +* cause a performance degradation). +* +* If a backend driver wants to limit the maximum number of persistently +* mapped grants to a value less than RING_SIZE * +* BLKIF_MAX_SEGMENTS_PER_REQUEST a LRU strategy should be used to +* discard the grants that are less commonly used. Using a LRU in the +* backend driver paired with a LIFO queue in the frontend will +* allow us to have better performance in this scenario. +* +*----------------------- Request Transport Parameters ------------------------ +* +* max-ring-page-order +* Values: <uint32_t> +* Default Value: 0 +* Notes: 1, 3 +* +* The maximum supported size of the request ring buffer in units of +* lb(machine pages). (e.g. 0 == 1 page, 1 = 2 pages, 2 == 4 pages, +* etc.). +* +* max-ring-pages +* Values: <uint32_t> +* Default Value: 1 +* Notes: DEPRECATED, 2, 3 +* +* The maximum supported size of the request ring buffer in units of +* machine pages. The value must be a power of 2. +* +*------------------------- Backend Device Properties ------------------------- +* +* discard-enable +* Values: 0/1 (boolean) +* Default Value: 1 +* +* This optional property, set by the toolstack, instructs the backend +* to offer (or not to offer) discard to the frontend. If the property +* is missing the backend should offer discard if the backing storage +* actually supports it. +* +* discard-alignment +* Values: <uint32_t> +* Default Value: 0 +* Notes: 4, 5 +* +* The offset, in bytes from the beginning of the virtual block device, +* to the first, addressable, discard extent on the underlying device. +* +* discard-granularity +* Values: <uint32_t> +* Default Value: <"sector-size"> +* Notes: 4 +* +* The size, in bytes, of the individually addressable discard extents +* of the underlying device. +* +* discard-secure +* Values: 0/1 (boolean) +* Default Value: 0 +* Notes: 10 +* +* A value of "1" indicates that the backend can process BLKIF_OP_DISCARD +* requests with the BLKIF_DISCARD_SECURE flag set. +* +* info +* Values: <uint32_t> (bitmap) +* +* A collection of bit flags describing attributes of the backing +* device. The VDISK_* macros define the meaning of each bit +* location. +* +* sector-size +* Values: <uint32_t> +* +* The logical block size, in bytes, of the underlying storage. This +* must be a power of two with a minimum value of 512. +* +* NOTE: Because of implementation bugs in some frontends this must be +* set to 512, unless the frontend advertizes a non-zero value +* in its "feature-large-sector-size" xenbus node. (See below). +* +* physical-sector-size +* Values: <uint32_t> +* Default Value: <"sector-size"> +* +* The physical block size, in bytes, of the backend storage. This +* must be an integer multiple of "sector-size". +* +* sectors +* Values: <uint64_t> +* +* The size of the backend device, expressed in units of "sector-size". +* The product of "sector-size" and "sectors" must also be an integer +* multiple of "physical-sector-size", if that node is present. +* +***************************************************************************** +* Frontend XenBus Nodes +***************************************************************************** +* +*----------------------- Request Transport Parameters ----------------------- +* +* event-channel +* Values: <uint32_t> +* +* The identifier of the Xen event channel used to signal activity +* in the ring buffer. +* +* ring-ref +* Values: <uint32_t> +* Notes: 6 +* +* The Xen grant reference granting permission for the backend to map +* the sole page in a single page sized ring buffer. +* +* ring-ref%u +* Values: <uint32_t> +* Notes: 6 +* +* For a frontend providing a multi-page ring, a "number of ring pages" +* sized list of nodes, each containing a Xen grant reference granting +* permission for the backend to map the page of the ring located +* at page index "%u". Page indexes are zero based. +* +* protocol +* Values: string (XEN_IO_PROTO_ABI_*) +* Default Value: XEN_IO_PROTO_ABI_NATIVE +* +* The machine ABI rules governing the format of all ring request and +* response structures. +* +* ring-page-order +* Values: <uint32_t> +* Default Value: 0 +* Maximum Value: MAX(ffs(max-ring-pages) - 1, max-ring-page-order) +* Notes: 1, 3 +* +* The size of the frontend allocated request ring buffer in units +* of lb(machine pages). (e.g. 0 == 1 page, 1 = 2 pages, 2 == 4 pages, +* etc.). +* +* num-ring-pages +* Values: <uint32_t> +* Default Value: 1 +* Maximum Value: MAX(max-ring-pages,(0x1 << max-ring-page-order)) +* Notes: DEPRECATED, 2, 3 +* +* The size of the frontend allocated request ring buffer in units of +* machine pages. The value must be a power of 2. +* +*--------------------------------- Features --------------------------------- +* +* feature-persistent +* Values: 0/1 (boolean) +* Default Value: 0 +* Notes: 7, 8, 9 +* +* A value of "1" indicates that the frontend will reuse the same grants +* for all transactions, allowing the backend to map them with write +* access (even when it should be read-only). If the frontend hits the +* maximum number of allowed persistently mapped grants, it can fallback +* to non persistent mode. This will cause a performance degradation, +* since the the backend driver will still try to map those grants +* persistently. Since the persistent grants protocol is compatible with +* the previous protocol, a frontend driver can choose to work in +* persistent mode even when the backend doesn't support it. +* +* It is recommended that the frontend driver stores the persistently +* mapped grants in a LIFO queue, so a subset of all persistently mapped +* grants gets used commonly. This is done in case the backend driver +* decides to limit the maximum number of persistently mapped grants +* to a value less than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST. +* +* feature-large-sector-size +* Values: 0/1 (boolean) +* Default Value: 0 +* +* A value of "1" indicates that the frontend will correctly supply and +* interpret all sector-based quantities in terms of the "sector-size" +* value supplied in the backend info, whatever that may be set to. +* If this node is not present or its value is "0" then it is assumed +* that the frontend requires that the logical block size is 512 as it +* is hardcoded (which is the case in some frontend implementations). +* +*------------------------- Virtual Device Properties ------------------------- +* +* device-type +* Values: "disk", "cdrom", "floppy", etc. +* +* virtual-device +* Values: <uint32_t> +* +* A value indicating the physical device to virtualize within the +* frontend's domain. (e.g. "The first ATA disk", "The third SCSI +* disk", etc.) +* +* See docs/misc/vbd-interface.txt for details on the format of this +* value. +* +* Notes +* ----- +* (1) Multi-page ring buffer scheme first developed in the Citrix XenServer +* PV drivers. +* (2) Multi-page ring buffer scheme first used in some RedHat distributions +* including a distribution deployed on certain nodes of the Amazon +* EC2 cluster. +* (3) Support for multi-page ring buffers was implemented independently, +* in slightly different forms, by both Citrix and RedHat/Amazon. +* For full interoperability, block front and backends should publish +* identical ring parameters, adjusted for unit differences, to the +* XenStore nodes used in both schemes. +* (4) Devices that support discard functionality may internally allocate space +* (discardable extents) in units that are larger than the exported logical +* block size. If the backing device has such discardable extents the +* backend should provide both discard-granularity and discard-alignment. +* Providing just one of the two may be considered an error by the frontend. +* Backends supporting discard should include discard-granularity and +* discard-alignment even if it supports discarding individual sectors. +* Frontends should assume discard-alignment == 0 and discard-granularity +* == sector size if these keys are missing. +* (5) The discard-alignment parameter allows a physical device to be +* partitioned into virtual devices that do not necessarily begin or +* end on a discardable extent boundary. +* (6) When there is only a single page allocated to the request ring, +* 'ring-ref' is used to communicate the grant reference for this +* page to the backend. When using a multi-page ring, the 'ring-ref' +* node is not created. Instead 'ring-ref0' - 'ring-refN' are used. +* (7) When using persistent grants data has to be copied from/to the page +* where the grant is currently mapped. The overhead of doing this copy +* however doesn't suppress the speed improvement of not having to unmap +* the grants. +* (8) The frontend driver has to allow the backend driver to map all grants +* with write access, even when they should be mapped read-only, since +* further requests may reuse these grants and require write permissions. +* (9) Linux implementation doesn't have a limit on the maximum number of +* grants that can be persistently mapped in the frontend driver, but +* due to the frontent driver implementation it should never be bigger +* than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST. +*(10) The discard-secure property may be present and will be set to 1 if the +* backing device supports secure discard. +*(11) Only used by Linux and NetBSD. +*/ + +/* +* Multiple hardware queues/rings: +* If supported, the backend will write the key "multi-queue-max-queues" to +* the directory for that vbd, and set its value to the maximum supported +* number of queues. +* Frontends that are aware of this feature and wish to use it can write the +* key "multi-queue-num-queues" with the number they wish to use, which must be +* greater than zero, and no more than the value reported by the backend in +* "multi-queue-max-queues". +* +* For frontends requesting just one queue, the usual event-channel and +* ring-ref keys are written as before, simplifying the backend processing +* to avoid distinguishing between a frontend that doesn't understand the +* multi-queue feature, and one that does, but requested only one queue. +* +* Frontends requesting two or more queues must not write the toplevel +* event-channel and ring-ref keys, instead writing those keys under sub-keys +* having the name "queue-N" where N is the integer ID of the queue/ring for +* which those keys belong. Queues are indexed from zero. +* For example, a frontend with two queues must write the following set of +* queue-related keys: +* +* /local/domain/1/device/vbd/0/multi-queue-num-queues = "2" +* /local/domain/1/device/vbd/0/queue-0 = "" +* /local/domain/1/device/vbd/0/queue-0/ring-ref = "<ring-ref#0>" +* /local/domain/1/device/vbd/0/queue-0/event-channel = "<evtchn#0>" +* /local/domain/1/device/vbd/0/queue-1 = "" +* /local/domain/1/device/vbd/0/queue-1/ring-ref = "<ring-ref#1>" +* /local/domain/1/device/vbd/0/queue-1/event-channel = "<evtchn#1>" +* +* It is also possible to use multiple queues/rings together with +* feature multi-page ring buffer. +* For example, a frontend requests two queues/rings and the size of each ring +* buffer is two pages must write the following set of related keys: +* +* /local/domain/1/device/vbd/0/multi-queue-num-queues = "2" +* /local/domain/1/device/vbd/0/ring-page-order = "1" +* /local/domain/1/device/vbd/0/queue-0 = "" +* /local/domain/1/device/vbd/0/queue-0/ring-ref0 = "<ring-ref#0>" +* /local/domain/1/device/vbd/0/queue-0/ring-ref1 = "<ring-ref#1>" +* /local/domain/1/device/vbd/0/queue-0/event-channel = "<evtchn#0>" +* /local/domain/1/device/vbd/0/queue-1 = "" +* /local/domain/1/device/vbd/0/queue-1/ring-ref0 = "<ring-ref#2>" +* /local/domain/1/device/vbd/0/queue-1/ring-ref1 = "<ring-ref#3>" +* /local/domain/1/device/vbd/0/queue-1/event-channel = "<evtchn#1>" +* +*/ + +/* +* STATE DIAGRAMS +* +***************************************************************************** +* Startup * +***************************************************************************** +* +* Tool stack creates front and back nodes with state XenbusStateInitialising. +* +* Front Back +* ================================= ===================================== +* XenbusStateInitialising XenbusStateInitialising +* o Query virtual device o Query backend device identification +* properties. data. +* o Setup OS device instance. o Open and validate backend device. +* o Publish backend features and +* transport parameters. +* | +* | +* V +* XenbusStateInitWait +* +* o Query backend features and +* transport parameters. +* o Allocate and initialize the +* request ring. +* o Publish transport parameters +* that will be in effect during +* this connection. +* | +* | +* V +* XenbusStateInitialised +* +* o Query frontend transport parameters. +* o Connect to the request ring and +* event channel. +* o Publish backend device properties. +* | +* | +* V +* XenbusStateConnected +* +* o Query backend device properties. +* o Finalize OS virtual device +* instance. +* | +* | +* V +* XenbusStateConnected +* +* Note: Drivers that do not support any optional features, or the negotiation +* of transport parameters, can skip certain states in the state machine: +* +* o A frontend may transition to XenbusStateInitialised without +* waiting for the backend to enter XenbusStateInitWait. In this +* case, default transport parameters are in effect and any +* transport parameters published by the frontend must contain +* their default values. +* +* o A backend may transition to XenbusStateInitialised, bypassing +* XenbusStateInitWait, without waiting for the frontend to first +* enter the XenbusStateInitialised state. In this case, default +* transport parameters are in effect and any transport parameters +* published by the backend must contain their default values. +* +* Drivers that support optional features and/or transport parameter +* negotiation must tolerate these additional state transition paths. +* In general this means performing the work of any skipped state +* transition, if it has not already been performed, in addition to the +* work associated with entry into the current state. +*/ + +/* +* REQUEST CODES. +*/ +#define BLKIF_OP_READ 0 +#define BLKIF_OP_WRITE 1 +/* +* All writes issued prior to a request with the BLKIF_OP_WRITE_BARRIER +* operation code ("barrier request") must be completed prior to the +* execution of the barrier request. All writes issued after the barrier +* request must not execute until after the completion of the barrier request. +* +* Optional. See "feature-barrier" XenBus node documentation above. +*/ +#define BLKIF_OP_WRITE_BARRIER 2 +/* +* Commit any uncommitted contents of the backing device's volatile cache +* to stable storage. +* +* Optional. See "feature-flush-cache" XenBus node documentation above. +*/ +#define BLKIF_OP_FLUSH_DISKCACHE 3 +/* +* Used in SLES sources for device specific command packet +* contained within the request. Reserved for that purpose. +*/ +#define BLKIF_OP_RESERVED_1 4 +/* +* Indicate to the backend device that a region of storage is no longer in +* use, and may be discarded at any time without impact to the client. If +* the BLKIF_DISCARD_SECURE flag is set on the request, all copies of the +* discarded region on the device must be rendered unrecoverable before the +* command returns. +* +* This operation is analogous to performing a trim (ATA) or unamp (SCSI), +* command on a native device. +* +* More information about trim/unmap operations can be found at: +* http://t13.org/Documents/UploadedDocuments/docs2008/ +* e07154r6-Data_Set_Management_Proposal_for_ATA-ACS2.doc +* http://www.seagate.com/staticfiles/support/disc/manuals/ +* Interface%20manuals/100293068c.pdf +* +* Optional. See "feature-discard", "discard-alignment", +* "discard-granularity", and "discard-secure" in the XenBus node +* documentation above. +*/ +#define BLKIF_OP_DISCARD 5 + +/* +* Recognized if "feature-max-indirect-segments" in present in the backend +* xenbus info. The "feature-max-indirect-segments" node contains the maximum +* number of segments allowed by the backend per request. If the node is +* present, the frontend might use blkif_request_indirect structs in order to +* issue requests with more than BLKIF_MAX_SEGMENTS_PER_REQUEST (11). The +* maximum number of indirect segments is fixed by the backend, but the +* frontend can issue requests with any number of indirect segments as long as +* it's less than the number provided by the backend. The indirect_grefs field +* in blkif_request_indirect should be filled by the frontend with the +* grant references of the pages that are holding the indirect segments. +* These pages are filled with an array of blkif_request_segment that hold the +* information about the segments. The number of indirect pages to use is +* determined by the number of segments an indirect request contains. Every +* indirect page can contain a maximum of +* (PAGE_SIZE / sizeof(struct blkif_request_segment)) segments, so to +* calculate the number of indirect pages to use we have to do +* ceil(indirect_segments / (PAGE_SIZE / sizeof(struct blkif_request_segment))). +* +* If a backend does not recognize BLKIF_OP_INDIRECT, it should *not* +* create the "feature-max-indirect-segments" node! +*/ +#define BLKIF_OP_INDIRECT 6 + +/* +* Maximum scatter/gather segments per request. +* This is carefully chosen so that sizeof(blkif_ring_t) <= PAGE_SIZE. +* NB. This could be 12 if the ring indexes weren't stored in the same page. +*/ +#define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 + +/* +* Maximum number of indirect pages to use per request. +*/ +#define BLKIF_MAX_INDIRECT_PAGES_PER_REQUEST 8 + +/* +* NB. 'first_sect' and 'last_sect' in blkif_request_segment, as well as +* 'sector_number' in blkif_request, blkif_request_discard and +* blkif_request_indirect are sector-based quantities. See the description +* of the "feature-large-sector-size" frontend xenbus node above for +* more information. +*/ +struct blkif_request_segment { +grant_ref_t gref;/* reference to I/O buffer frame */ +/* @first_sect: first sector in frame to transfer (inclusive). */ +/* @last_sect: last sector in frame to transfer (inclusive). */ +uint8_t first_sect, last_sect; +}; + +/* +* Starting ring element for any I/O request. +*/ +struct blkif_request { +uint8_t operation;/* BLKIF_OP_??? */ +uint8_t nr_segments;/* number of segments */ +blkif_vdev_t handle;/* only for read/write requests */ +uint64_t id;/* private guest value, echoed in resp */ +blkif_sector_t sector_number;/* start sector idx on disk (r/w only) */ +struct blkif_request_segment seg[BLKIF_MAX_SEGMENTS_PER_REQUEST ]; +}; +typedef struct blkif_request blkif_request_t ; + +/* +* Cast to this structure when blkif_request.operation == BLKIF_OP_DISCARD +* sizeof(struct blkif_request_discard) <= sizeof(struct blkif_request) +*/ +struct blkif_request_discard { +uint8_t operation;/* BLKIF_OP_DISCARD */ +uint8_t flag;/* BLKIF_DISCARD_SECURE or zero */ +#define BLKIF_DISCARD_SECURE (1<<0)/* ignored if discard-secure=0 */ +blkif_vdev_t handle;/* same as for read/write requests */ +uint64_t id;/* private guest value, echoed in resp */ +blkif_sector_t sector_number;/* start sector idx on disk */ +uint64_t nr_sectors;/* number of contiguous sectors to discard*/ +}; +typedef struct blkif_request_discard blkif_request_discard_t ; + +struct blkif_request_indirect { +uint8_t operation;/* BLKIF_OP_INDIRECT */ +uint8_t indirect_op;/* BLKIF_OP_{READ/WRITE} */ +uint16_t nr_segments;/* number of segments */ +uint64_t id;/* private guest value, echoed in resp */ +blkif_sector_t sector_number;/* start sector idx on disk (r/w only) */ +blkif_vdev_t handle;/* same as for read/write requests */ +grant_ref_t indirect_grefs[BLKIF_MAX_INDIRECT_PAGES_PER_REQUEST ]; +#ifdef __i386__ +uint64_t pad;/* Make it 64 byte aligned on i386 */ +#endif +}; +typedef struct blkif_request_indirect blkif_request_indirect_t ; + +struct blkif_response { +uint64_t id;/* copied from request */ +uint8_t operation;/* copied from request */ +int16_t status;/* BLKIF_RSP_??? */ +}; +typedef struct blkif_response blkif_response_t ; + +/* +* STATUS RETURN CODES. +*/ +/* Operation not supported (only happens on barrier writes). */ +#define BLKIF_RSP_EOPNOTSUPP -2 +/* Operation failed for some unspecified reason (-EIO). */ +#define BLKIF_RSP_ERROR -1 +/* Operation completed successfully. */ +#define BLKIF_RSP_OKAY 0 + +/* +* Generate blkif ring structures and types. +*/ +DEFINE_RING_TYPES(blkif, struct blkif_request, struct blkif_response); + +#define VDISK_CDROM 0x1 +#define VDISK_REMOVABLE 0x2 +#define VDISK_READONLY 0x4 + +#endif /* XEN_PUBLIC_IO_BLKIF_H */ include/hw/xen/interface/io/ring.h renamed from include/hw/xen/io/ring.h +0
-0include/hw/xen/interface/io/usbif.h new file +254
-1@@ -0,0 +1,254 @@ +/* +* usbif.h +* +* USB I/O interface for Xen guest OSes. +* +* Copyright (C) 2009, FUJITSU LABORATORIES LTD. +* Author: Noboru Iwamatsu <[email protected]> +* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +*/ + +#ifndef XEN_PUBLIC_IO_USBIF_H +#define XEN_PUBLIC_IO_USBIF_H + +#include "ring.h" +#include "../grant_table.h" + +/* +* Feature and Parameter Negotiation +* ================================= +* The two halves of a Xen pvUSB driver utilize nodes within the XenStore to +* communicate capabilities and to negotiate operating parameters. This +* section enumerates these nodes which reside in the respective front and +* backend portions of the XenStore, following the XenBus convention. +* +* Any specified default value is in effect if the corresponding XenBus node +* is not present in the XenStore. +* +* XenStore nodes in sections marked "PRIVATE" are solely for use by the +* driver side whose XenBus tree contains them. +* +***************************************************************************** +* Backend XenBus Nodes +***************************************************************************** +* +*------------------ Backend Device Identification (PRIVATE) ------------------ +* +* num-ports +* Values: unsigned [1...31] +* +* Number of ports for this (virtual) USB host connector. +* +* usb-ver +* Values: unsigned [1...2] +* +* USB version of this host connector: 1 = USB 1.1, 2 = USB 2.0. +* +* port/[1...31] +* Values: string +* +* Physical USB device connected to the given port, e.g. "3-1.5". +* +***************************************************************************** +* Frontend XenBus Nodes +***************************************************************************** +* +*----------------------- Request Transport Parameters ----------------------- +* +* event-channel +* Values: unsigned +* +* The identifier of the Xen event channel used to signal activity +* in the ring buffer. +* +* urb-ring-ref +* Values: unsigned +* +* The Xen grant reference granting permission for the backend to map +* the sole page in a single page sized ring buffer. This is the ring +* buffer for urb requests. +* +* conn-ring-ref +* Values: unsigned +* +* The Xen grant reference granting permission for the backend to map +* the sole page in a single page sized ring buffer. This is the ring +* buffer for connection/disconnection requests. +* +* protocol +* Values: string (XEN_IO_PROTO_ABI_*) +* Default Value: XEN_IO_PROTO_ABI_NATIVE +* +* The machine ABI rules governing the format of all ring request and +* response structures. +* +*/ + +enum usb_spec_version { +USB_VER_UNKNOWN =0 , +USB_VER_USB11 , +USB_VER_USB20 , +USB_VER_USB30 ,/* not supported yet */ +}; + +/* +* USB pipe in usbif_request +* +* - port number: bits 0-4 +* (USB_MAXCHILDREN is 31) +* +* - operation flag: bit 5 +* (0 = submit urb, +* 1 = unlink urb) +* +* - direction: bit 7 +* (0 = Host-to-Device [Out] +* 1 = Device-to-Host [In]) +* +* - device address: bits 8-14 +* +* - endpoint: bits 15-18 +* +* - pipe type: bits 30-31 +* (00 = isochronous, 01 = interrupt, +* 10 = control, 11 = bulk) +*/ + +#define USBIF_PIPE_PORT_MASK 0x0000001f +#define USBIF_PIPE_UNLINK 0x00000020 +#define USBIF_PIPE_DIR 0x00000080 +#define USBIF_PIPE_DEV_MASK 0x0000007f +#define USBIF_PIPE_DEV_SHIFT 8 +#define USBIF_PIPE_EP_MASK 0x0000000f +#define USBIF_PIPE_EP_SHIFT 15 +#define USBIF_PIPE_TYPE_MASK 0x00000003 +#define USBIF_PIPE_TYPE_SHIFT 30 +#define USBIF_PIPE_TYPE_ISOC 0 +#define USBIF_PIPE_TYPE_INT 1 +#define USBIF_PIPE_TYPE_CTRL 2 +#define USBIF_PIPE_TYPE_BULK 3 + +#define usbif_pipeportnum (pipe) ((pipe) & USBIF_PIPE_PORT_MASK) +#define usbif_setportnum_pipe (pipe, portnum) ((pipe) | (portnum)) + +#define usbif_pipeunlink (pipe) ((pipe) & USBIF_PIPE_UNLINK) +#define usbif_pipesubmit (pipe) (!usbif_pipeunlink(pipe)) +#define usbif_setunlink_pipe (pipe) ((pipe) | USBIF_PIPE_UNLINK) + +#define usbif_pipein (pipe) ((pipe) & USBIF_PIPE_DIR) +#define usbif_pipeout (pipe) (!usbif_pipein(pipe)) + +#define usbif_pipedevice (pipe) \ + (((pipe) >> USBIF_PIPE_DEV_SHIFT) & USBIF_PIPE_DEV_MASK) + +#define usbif_pipeendpoint (pipe) \ + (((pipe) >> USBIF_PIPE_EP_SHIFT) & USBIF_PIPE_EP_MASK) + +#define usbif_pipetype (pipe) \ + (((pipe) >> USBIF_PIPE_TYPE_SHIFT) & USBIF_PIPE_TYPE_MASK) +#define usbif_pipeisoc (pipe) (usbif_pipetype(pipe) == USBIF_PIPE_TYPE_ISOC) +#define usbif_pipeint (pipe) (usbif_pipetype(pipe) == USBIF_PIPE_TYPE_INT) +#define usbif_pipectrl (pipe) (usbif_pipetype(pipe) == USBIF_PIPE_TYPE_CTRL) +#define usbif_pipebulk (pipe) (usbif_pipetype(pipe) == USBIF_PIPE_TYPE_BULK) + +#define USBIF_MAX_SEGMENTS_PER_REQUEST (16) +#define USBIF_MAX_PORTNR 31 +#define USBIF_RING_SIZE 4096 + +/* +* RING for transferring urbs. +*/ +struct usbif_request_segment { +grant_ref_t gref; +uint16_t offset; +uint16_t length; +}; + +struct usbif_urb_request { +uint16_t id;/* request id */ +uint16_t nr_buffer_segs;/* number of urb->transfer_buffer segments */ + +/* basic urb parameter */ +uint32_t pipe; +uint16_t transfer_flags; +#define USBIF_SHORT_NOT_OK 0x0001 +uint16_t buffer_length; +union { +uint8_t ctrl[8 ];/* setup_packet (Ctrl) */ + +struct { +uint16_t interval;/* maximum (1024*8) in usb core */ +uint16_t start_frame;/* start frame */ +uint16_t number_of_packets;/* number of ISO packet */ +uint16_t nr_frame_desc_segs;/* number of iso_frame_desc segments */ + } isoc; + +struct { +uint16_t interval;/* maximum (1024*8) in usb core */ +uint16_t pad[3 ]; + } intr; + +struct { +uint16_t unlink_id;/* unlink request id */ +uint16_t pad[3 ]; + } unlink; + + } u; + +/* urb data segments */ +struct usbif_request_segment seg[USBIF_MAX_SEGMENTS_PER_REQUEST ]; +}; +typedef struct usbif_urb_request usbif_urb_request_t ; + +struct usbif_urb_response { +uint16_t id;/* request id */ +uint16_t start_frame;/* start frame (ISO) */ +int32_t status;/* status (non-ISO) */ +int32_t actual_length;/* actual transfer length */ +int32_t error_count;/* number of ISO errors */ +}; +typedef struct usbif_urb_response usbif_urb_response_t ; + +DEFINE_RING_TYPES(usbif_urb, struct usbif_urb_request, struct usbif_urb_response); +#define USB_URB_RING_SIZE __CONST_RING_SIZE(usbif_urb, USBIF_RING_SIZE) + +/* +* RING for notifying connect/disconnect events to frontend +*/ +struct usbif_conn_request { +uint16_t id; +}; +typedef struct usbif_conn_request usbif_conn_request_t ; + +struct usbif_conn_response { +uint16_t id;/* request id */ +uint8_t portnum;/* port number */ +uint8_t speed;/* usb_device_speed */ +#define USBIF_SPEED_NONE 0 +#define USBIF_SPEED_LOW 1 +#define USBIF_SPEED_FULL 2 +#define USBIF_SPEED_HIGH 3 +}; +typedef struct usbif_conn_response usbif_conn_response_t ; + +DEFINE_RING_TYPES(usbif_conn, struct usbif_conn_request, struct usbif_conn_response); +#define USB_CONN_RING_SIZE __CONST_RING_SIZE(usbif_conn, USBIF_RING_SIZE) + +#endif /* XEN_PUBLIC_IO_USBIF_H */ --
Quoted 1 line
Anthony PERARD
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 2/4 xen: Import other xen/io/*.h
In reply to Anthony PERARDFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
Import fbif.h, kbdif.h, netif.h, console.h, xenbus.h, protocols.h.
While editing xenfb.c, remove the include of event_channel.h as it isn't needed.
The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the file that QEMU doesn't use are removed.
--- hw/9pfs/xen-9pfs.h | 2 +- hw/block/xen_blkif.h | 2 +- hw/char/xen_console.c | 2 +- hw/display/xenfb.c | 7 +- hw/net/xen_nic.c | 2 +- include/hw/xen/interface/io/console.h | 46 ++ include/hw/xen/interface/io/fbif.h | 156 ++++ include/hw/xen/interface/io/kbdif.h | 566 +++++++++++++ include/hw/xen/interface/io/netif.h | 1010 +++++++++++++++++++++++ include/hw/xen/interface/io/protocols.h | 42 + include/hw/xen/interface/io/xenbus.h | 70 ++ include/hw/xen/xen_common.h | 2 +- 12 files changed, 1898 insertions(+), 9 deletions(-) create mode 100644 include/hw/xen/interface/io/console.h create mode 100644 include/hw/xen/interface/io/fbif.h create mode 100644 include/hw/xen/interface/io/kbdif.h create mode 100644 include/hw/xen/interface/io/netif.h create mode 100644 include/hw/xen/interface/io/protocols.h create mode 100644 include/hw/xen/interface/io/xenbus.h
hw/9pfs/xen-9pfs.h +1 -1
@@ -13,7 +13,7 @@#ifndef HW_9PFS_XEN_9PFS_H #define HW_9PFS_XEN_9PFS_H -#include <xen/io/protocols.h> +#include "hw/xen/interface/io/protocols.h" #include "hw/xen/interface/io/ring.h" /*
hw/block/xen_blkif.h +1 -1
@@ -2,7 +2,7 @@#define XEN_BLKIF_H #include "hw/xen/interface/io/blkif.h" -#include <xen/io/protocols.h> +#include "hw/xen/interface/io/protocols.h" /* * Not a real protocol. Used to generate ring structs which contain
hw/char/xen_console.c +1 -1
@@ -28,7 +28,7 @@#include "chardev/char-fe.h" #include "hw/xen/xen-legacy-backend.h" -#include <xen/io/console.h> +#include "hw/xen/interface/io/console.h" struct buffer {uint8_t *data;
hw/display/xenfb.c +3 -4
@@ -32,10 +32,9 @@#include "ui/console.h" #include "hw/xen/xen-legacy-backend.h" -#include <xen/event_channel.h> -#include <xen/io/fbif.h> -#include <xen/io/kbdif.h> -#include <xen/io/protocols.h> +#include "hw/xen/interface/io/fbif.h" +#include "hw/xen/interface/io/kbdif.h" +#include "hw/xen/interface/io/protocols.h" #include "trace.h"
hw/net/xen_nic.c +1 -1
@@ -30,7 +30,7 @@#include "net/util.h" #include "hw/xen/xen-legacy-backend.h" -#include <xen/io/netif.h> +#include "hw/xen/interface/io/netif.h" /* ------------------------------------------------------------- */
include/hw/xen/interface/io/console.h new file +46 -0
46 lines not on this page · raw message
include/hw/xen/interface/io/fbif.h new file +156 -0
156 lines not on this page · raw message
include/hw/xen/interface/io/kbdif.h new file +566 -0
566 lines not on this page · raw message
include/hw/xen/interface/io/netif.h new file +1010 -0
1,010 lines not on this page · raw message
include/hw/xen/interface/io/protocols.h new file +42 -0
42 lines not on this page · raw message
include/hw/xen/interface/io/xenbus.h new file +70 -0
70 lines not on this page · raw message
include/hw/xen/xen_common.h +1 -1
@@ -12,7 +12,7 @@#include <xenctrl.h> #include <xenstore.h> -#include <xen/io/xenbus.h> +#include "hw/xen/interface/io/xenbus.h" #include "hw/hw.h" #include "hw/xen/xen.h"
Signature · 7 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 2/4] xen: Import other xen/io/*.h
Quoted 13 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 2/4] xen: Import other xen/io/*.hFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
Import
fbif.h,kbdif.h,netif.h,console.h,xenbus.h,protocols.h.
Quoted 8 lines
While editing
xenfb.c, remove the include ofevent_channel.has it isn't needed.The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the file that QEMU doesn't use are removed.
Signed-off-by Anthony PERARD <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 3/4 xen: Import Xen public headers used by xen-hvm.c
In reply to Anthony PERARDFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the files that QEMU doesn't use are removed.
xen-mapcache.c doesn't needs params.h, so remove the include.
--- hw/i386/xen/xen-hvm.c | 6 +- hw/i386/xen/xen-mapcache.c | 2 - include/hw/xen/interface/hvm/e820.h | 28 +++++++ include/hw/xen/interface/hvm/ioreq.h | 101 ++++++++++++++++++++++++++ include/hw/xen/interface/hvm/params.h | 33 +++++++++ 5 files changed, 165 insertions(+), 5 deletions(-) create mode 100644 include/hw/xen/interface/hvm/e820.h create mode 100644 include/hw/xen/interface/hvm/ioreq.h create mode 100644 include/hw/xen/interface/hvm/params.h
hw/i386/xen/xen-hvm.c +3 -3
@@ -26,9 +26,9 @@#include "trace.h" #include "exec/address-spaces.h" -#include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> -#include <xen/hvm/e820.h> +#include "hw/xen/interface/hvm/ioreq.h" +#include "hw/xen/interface/hvm/params.h" +#include "hw/xen/interface/hvm/e820.h" //#define DEBUG_XEN_HVM
hw/i386/xen/xen-mapcache.c +0 -2
@@ -17,8 +17,6 @@#include "hw/xen/xen-legacy-backend.h" #include "qemu/bitmap.h" -#include <xen/hvm/params.h> -#include "sysemu/xen-mapcache.h" #include "trace.h"
include/hw/xen/interface/hvm/e820.h new file +28 -0
@@ -0,0 +1,28 @@ +/* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +* +* Copyright (c) 2006, Keir Fraser +*/ + +#ifndef XEN_PUBLIC_HVM_E820_H +#define XEN_PUBLIC_HVM_E820_H + +#define HVM_BELOW_4G_RAM_END 0xF0000000 + +#endif /* XEN_PUBLIC_HVM_E820_H */
include/hw/xen/interface/hvm/ioreq.h new file +101 -0
101 lines not on this page · raw message
include/hw/xen/interface/hvm/params.h new file +33 -0
@@ -0,0 +1,33 @@ +/* +* Permission is hereby granted, free of charge, to any person obtaining a copy +* of this software and associated documentation files (the "Software"), to +* deal in the Software without restriction, including without limitation the +* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +* sell copies of the Software, and to permit persons to whom the Software is +* furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +* DEALINGS IN THE SOFTWARE. +* +* Copyright (c) 2007, Keir Fraser +*/ + +#ifndef XEN_PUBLIC_HVM_PARAMS_H +#define XEN_PUBLIC_HVM_PARAMS_H + +/* +* Parameter space for HVMOP_{set,get}_param. +*/ + +/* ACPI S state: currently support S0 and S3 on x86. */ +#define HVM_PARAM_ACPI_S_STATE 14 + +#endif /* XEN_PUBLIC_HVM_PARAMS_H */
Signature · 7 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Quoted 34 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 3/4] xen: Import Xen public headers used byxen-hvm.cFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the files that QEMU doesn't use are removed.
xen-mapcache.cdoesn't needsparams.h, so remove the include.Signed-off-by Anthony PERARD <[email protected]>--- hw/i386/xen/xen-hvm.c | 6 +- hw/i386/xen/xen-mapcache.c | 2 - include/hw/xen/interface/hvm/e820.h | 28 +++++++ include/hw/xen/interface/hvm/ioreq.h | 101 ++++++++++++++++++++++++++ include/hw/xen/interface/hvm/params.h | 33 +++++++++ 5 files changed, 165 insertions(+), 5 deletions(-) create mode 100644 include/hw/xen/interface/hvm/e820.h create mode 100644 include/hw/xen/interface/hvm/ioreq.h create mode 100644 include/hw/xen/interface/hvm/params.hhw/i386/xen/xen-hvm.c +0
-0
hw/i386/xen/xen-hvm.c line 30
Quoted 8 lines
hw/i386/xen/xen-hvm.c +2
-3@@ -26,9 +26,9 @@#include "trace.h" #include "exec/address-spaces.h" -#include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> -#include <xen/hvm/e820.h> +#include "hw/xen/interface/hvm/ioreq.h" +#include "hw/xen/interface/hvm/params.h"
AFAICT the only place (apart from legacy code in xen_common.h) that params.h is necessary is in xen_suspend_notifier(). I wonder whether that would be better moved into xen_common.h too (since it's just a wrapper round xc_set_hvm_param() and then the inclusion of params.h can be moved there as well.
Paul
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Quoted 37 lines · Paul Durrant
Quoted 37 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 3/4] xen: Import Xen public headers used byxen-hvm.cFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the files that QEMU doesn't use are removed.
xen-mapcache.cdoesn't needsparams.h, so remove the include.Signed-off-by Anthony PERARD <[email protected]>--- hw/i386/xen/xen-hvm.c | 6 +- hw/i386/xen/xen-mapcache.c | 2 - include/hw/xen/interface/hvm/e820.h | 28 +++++++ include/hw/xen/interface/hvm/ioreq.h | 101 ++++++++++++++++++++++++++ include/hw/xen/interface/hvm/params.h | 33 +++++++++ 5 files changed, 165 insertions(+), 5 deletions(-) create mode 100644 include/hw/xen/interface/hvm/e820.h create mode 100644 include/hw/xen/interface/hvm/ioreq.h create mode 100644 include/hw/xen/interface/hvm/params.hhw/i386/xen/xen-hvm.c +0
-0@@ -26,9 +26,9 @@#include "trace.h" #include "exec/address-spaces.h"
Quoted 11 lines
hw/i386/xen/xen-hvm.c line 30
Quoted 5 lines
hw/i386/xen/xen-hvm.c +2
-3-#include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> -#include <xen/hvm/e820.h> +#include "hw/xen/interface/hvm/ioreq.h" +#include "hw/xen/interface/hvm/params.h" AFAICT the only place (apart from legacy code in
xen_common.h) thatparams.his necessary is inxen_suspend_notifier(). I wonder whether that would be better moved intoxen_common.htoo (since it's just a wrapper roundxc_set_hvm_param()and then the inclusion ofparams.hcan be moved there as well.
:(, I didn't realised that xen_common.h needed params.h too. That patch series might not build on older version of Xen. I'll move the inclusion of params.h to xen_common.h, and fix params.h to have all the needed #defines.
About xen_suspend_notifier(), it's actually more than a wrapper, it's also a function. A pointer to the function is given to a notifier. So I don't think using "inline" will work, and I don't think it makes sense to have a function without "inline" in xen_common.h. So I think xen_{suspend,wakeup}_notifier are fine where there are, do you agree?
Thanks,
Signature · 6 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Quoted 62 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 17:46
To: Paul Durrant <[email protected]>
Cc: [email protected]; [email protected]; Stefano Stabellini <[email protected]>
Subject: Re: [PATCH 3/4] xen: Import Xen public headers used byxen-hvm.cQuoted 37 lines · Paul Durrant
Quoted 37 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 3/4] xen: Import Xen public headers used byxen-hvm.cFollowing "xen: Fix build with public headers", import other Xen public headers that are describing interfaces.
The headers are cleaned up a bit while importing them. The header guard symbols are changed to match QEMU's coding style, some other part of the files that QEMU doesn't use are removed.
xen-mapcache.cdoesn't needsparams.h, so remove the include.Signed-off-by Anthony PERARD <[email protected]>--- hw/i386/xen/xen-hvm.c | 6 +- hw/i386/xen/xen-mapcache.c | 2 - include/hw/xen/interface/hvm/e820.h | 28 +++++++ include/hw/xen/interface/hvm/ioreq.h | 101 ++++++++++++++++++++++++++ include/hw/xen/interface/hvm/params.h | 33 +++++++++ 5 files changed, 165 insertions(+), 5 deletions(-) create mode 100644 include/hw/xen/interface/hvm/e820.h create mode 100644 include/hw/xen/interface/hvm/ioreq.h create mode 100644 include/hw/xen/interface/hvm/params.hhw/i386/xen/xen-hvm.c +0
-0@@ -26,9 +26,9 @@#include "trace.h" #include "exec/address-spaces.h" Quoted 11 lines
hw/i386/xen/xen-hvm.c line 30
Quoted 5 lines
hw/i386/xen/xen-hvm.c +2
-3-#include <xen/hvm/ioreq.h> -#include <xen/hvm/params.h> -#include <xen/hvm/e820.h> +#include "hw/xen/interface/hvm/ioreq.h" +#include "hw/xen/interface/hvm/params.h" AFAICT the only place (apart from legacy code in
xen_common.h) thatparams.his necessary is inxen_suspend_notifier(). I wonder whether that would be better moved intoxen_common.htoo (since it's just a wrapper roundxc_set_hvm_param()and then the inclusion ofparams.hcan be moved there as well.:(, I didn't realised that
xen_common.hneededparams.htoo. That patch series might not build on older version of Xen. I'll move the inclusion ofparams.htoxen_common.h, and fixparams.hto have all the needed #defines.
Quoted 5 lines
About
xen_suspend_notifier(), it's actually more than a wrapper, it's also a function. A pointer to the function is given to a notifier. So I don't think using "inline" will work, and I don't think it makes sense to have a function without "inline" inxen_common.h. So I think xen_{suspend,wakeup}_notifier are fine where there are, do you agree?
Oh, I hadn't realized they were callbacks. In that case, leave the functions where they are. We really ought to have a stable API rather than a params interface... Not something you can address here though.
Cheers,
Paul
Quoted 5 lines
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
In reply to Anthony PERARDQuoted 11 lines · Anthony PERARD
Quoted 5 lines · Paul Durrant
AFAICT the only place (apart from legacy code in
xen_common.h) thatparams.his necessary is inxen_suspend_notifier(). I wonder whether that would be better moved intoxen_common.htoo (since it's just a wrapper roundxc_set_hvm_param()and then the inclusion ofparams.hcan be moved there as well.:(, I didn't realised that
xen_common.hneededparams.htoo. That patch series might not build on older version of Xen. I'll move the inclusion ofparams.htoxen_common.h, and fixparams.hto have all the needed #defines.
Actually, it works fine without including hvm/params.h in xen_common.h because xen_common.h includes xenctrl.h which includes hvm/params.h.
So I think instead I'll remove all includes of params.h, because HVM_PARAM_* are parameters for xc_hvm_param_{get,set}, which is in a library and not an interface with a guest. Including xenctrl.h should be enough.
Signature · 6 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Quoted 20 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 18:19
To: Paul Durrant <[email protected]>
Cc: [email protected]; Stefano Stabellini <[email protected]>; [email protected]
Subject: Re: [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used byxen-hvm.cQuoted 11 lines · Anthony PERARD
Quoted 5 lines · Paul Durrant
AFAICT the only place (apart from legacy code in
xen_common.h) thatparams.his necessary is inxen_suspend_notifier(). I wonder whether that would be better moved intoxen_common.htoo (since it's just a wrapper roundxc_set_hvm_param()and then the inclusion ofparams.hcan be moved there as well.:(, I didn't realised that
xen_common.hneededparams.htoo. That patch series might not build on older version of Xen. I'll move the inclusion ofparams.htoxen_common.h, and fixparams.hto have all the needed #defines.
Quoted 7 lines
Actually, it works fine without including
hvm/params.hinxen_common.hbecausexen_common.hincludesxenctrl.hwhich includeshvm/params.h.So I think instead I'll remove all includes of
params.h, because HVM_PARAM_* are parameters for xc_hvm_param_{get,set}, which is in a library and not an interface with a guest. Includingxenctrl.hshould be enough.
The guest/tools separation is messy. ioreq.h is also an interface with Xen and not with a guest, so really I think it should be treated the same way as params.h. e820.h is referring to guest memory layout, which IMO shouldn't really be hardcoded at all.
Paul
Quoted 3 lines
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c
Quoted 19 lines · Paul Durrant
Quoted 19 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]Quoted 11 lines · Anthony PERARD
Quoted 5 lines · Paul Durrant
AFAICT the only place (apart from legacy code in
xen_common.h) thatparams.his necessary is inxen_suspend_notifier(). I wonder whether that would be better moved intoxen_common.htoo (since it's just a wrapper roundxc_set_hvm_param()and then the inclusion ofparams.hcan be moved there as well.:(, I didn't realised that
xen_common.hneededparams.htoo. That patch series might not build on older version of Xen. I'll move the inclusion ofparams.htoxen_common.h, and fixparams.hto have all the needed #defines.Actually, it works fine without including
hvm/params.hinxen_common.hbecausexen_common.hincludesxenctrl.hwhich includeshvm/params.h.
Quoted 8 lines
Quoted 4 lines
So I think instead I'll remove all includes of
params.h, because HVM_PARAM_* are parameters for xc_hvm_param_{get,set}, which is in a library and not an interface with a guest. Includingxenctrl.hshould be enough.The guest/tools separation is messy.
ioreq.his also an interface with Xen and not with a guest, so really I think it should be treated the same way asparams.h.
Yes, I'll drop this patch, and replace it with a patch that just removes includes of params.h.
Quoted 2 lines
e820.his referring to guest memory layout,
which IMO shouldn't really be hardcoded at all.
I'll leave e820.h include alone.
Signature · 6 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 4/4 xen: Avoid VLA
In reply to Anthony PERARDAvoid using a variable length array.
---
Notes:
Was suggested by Peter here:
<CAFEAcA88+A2oCkQnxKDEdpmfCZSmPzWMBg01wDDV68bMZoY5Jg@mail.gmail.com> "should we try to stop using variable length arrays?"
hw/i386/xen/xen-hvm.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
hw/i386/xen/xen-hvm.c +8 -3
@@ -615,7 +615,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, {hwaddr npages = size >>TARGET_PAGE_BITS ;const int width =sizeof (unsigned long ) *8 ; -unsigned long bitmap[DIV_ROUND_UP (npages, width)]; +unsigned long *bitmap =NULL ; +size_t bitmap_size =DIV_ROUND_UP (npages, width);int rc, i, j;const XenPhysmap *physmap =NULL ;
@@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,return ; } + bitmap = g_new0(unsigned long, bitmap_size); + rc =xen_track_dirty_vram (xen_domid, start_addr >>TARGET_PAGE_BITS , npages, bitmap);if (rc <0 ) {
@@ -644,10 +647,10 @@ static void xen_sync_dirty_bitmap(XenIOState *state,", 0x" TARGET_FMT_plx"): %s\n" , start_addr, start_addr + size, strerror(errno)); } -return ; + goto out; } -for (i =0 ; i <ARRAY_SIZE (bitmap); i++) { +for (i =0 ; i < bitmap_size; i++) {unsigned long map = bitmap[i];while (map !=0 ) { j =ctzl (map);
@@ -657,6 +660,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, TARGET_PAGE_SIZE); }; } +out: +g_free (bitmap); } static void xen_log_start(MemoryListener *listener,
Signature · 7 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA
Quoted 36 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 16:41
To: [email protected]
Cc: [email protected]; Anthony Perard <[email protected]>; Stefano Stabellini <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH 4/4] xen: Avoid VLAAvoid using a variable length array.
Signed-off-by Anthony PERARD <[email protected]>---
Notes:
Was suggested by Peter here:
<CAFEAcA88+A2oCkQnxKDEdpmfCZSmPzWMBg01wDDV68bMZoY5Jg@mail.gmail.com> "should we try to stop using variable length arrays?"hw/i386/xen/xen-hvm.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)hw/i386/xen/xen-hvm.c +2
-1@@ -615,7 +615,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, {hwaddr npages = size >>TARGET_PAGE_BITS ;const int width =sizeof (unsigned long ) *8 ; -unsigned long bitmap[DIV_ROUND_UP (npages, width)]; +unsigned long *bitmap =NULL ; +size_t bitmap_size =DIV_ROUND_UP (npages, width);int rc, i, j;const XenPhysmap *physmap =NULL ;
hw/i386/xen/xen-hvm.c static void xen_sync_dirty_bitmap(XenIOState *state, · line 637
Quoted 5 lines
hw/i386/xen/xen-hvm.c +2
-0@@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,return ; } + bitmap = g_new0(unsigned long, bitmap_size); +
How hot is this function? It looks (unsurprisingly) like the section size determines the map size so I wonder whether it can instead be allocated once when the section is added?
Paul
Quoted 26 lines
hw/i386/xen/xen-hvm.c +4
-3rc =xen_track_dirty_vram (xen_domid, start_addr >>TARGET_PAGE_BITS , npages, bitmap);if (rc <0 ) {@@ -644,10 +647,10 @@ static void xen_sync_dirty_bitmap(XenIOState *state,", 0x" TARGET_FMT_plx"): %s\n" , start_addr, start_addr + size, strerror(errno)); } -return ; + goto out; } -for (i =0 ; i <ARRAY_SIZE (bitmap); i++) { +for (i =0 ; i < bitmap_size; i++) {unsigned long map = bitmap[i];while (map !=0 ) { j =ctzl (map);@@ -657,6 +660,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, TARGET_PAGE_SIZE); }; } +out: +g_free (bitmap); } static void xen_log_start(MemoryListener *listener, --
Quoted 1 line
Anthony PERARD
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA
Quoted 10 lines · Paul Durrant
hw/i386/xen/xen-hvm.c static void xen_sync_dirty_bitmap(XenIOState *state, · line 637
Quoted 6 lines
hw/i386/xen/xen-hvm.c +2
-0@@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,return ; } + bitmap = g_new0(unsigned long, bitmap_size); +How hot is this function? It looks (unsurprisingly) like the section size determines the map size so I wonder whether it can instead be allocated once when the section is added?
I think we can store the bitmap buffer into the state' where log_for_dirtybit' is already present, and free the bitmap when `log_for_dirtybit' is cleared.
Thanks,
Signature · 6 lines
Anthony PERARD _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA
Quoted 19 lines
-----Original Message-----
From: Anthony PERARD [mailto:[email protected]]
Sent: 17 June 2019 18:37
To: Paul Durrant <[email protected]>
Cc: [email protected]; [email protected]; Stefano Stabellini <[email protected]>
Subject: Re: [PATCH 4/4] xen: Avoid VLAQuoted 10 lines · Paul Durrant
hw/i386/xen/xen-hvm.c static void xen_sync_dirty_bitmap(XenIOState *state, · line 637
Quoted 6 lines
hw/i386/xen/xen-hvm.c +2
-0@@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,return ; } + bitmap = g_new0(unsigned long, bitmap_size); +How hot is this function? It looks (unsurprisingly) like the section size determines the map size so I wonder whether it can instead be allocated once when the section is added?
Quoted 3 lines
I think we can store the bitmap buffer into the
state' wherelog_for_dirtybit' is already present, and free the bitmap when `log_for_dirtybit' is cleared.
That sounds better :-)
Cheers,
Paul
Quoted 5 lines
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Message-id: [email protected]
Type: series
Subject: [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
919708e xen: Avoid VLA
1d20f2a xen: Import Xen public headers used by xen-hvm.c 252595d xen: Import other xen/io/*.h
301a4be xen: Fix build with public headers
=== OUTPUT BEGIN ===
1/4 Checking commit 301a4be9fa06 (xen: Fix build with public headers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#99: FILE: include/hw/xen/interface/grant_table.h:1:
+/******************************************************************************
WARNING: Block comments use a leading /* on a separate line
#141: FILE: include/hw/xen/interface/io/blkif.h:1:
+/******************************************************************************
ERROR: spaces required around that '<<' (ctx:VxV) #804: FILE: include/hw/xen/interface/io/blkif.h:664:
+#define BLKIF_DISCARD_SECURE (1<<0) /* ignored if discard-secure=0 */
^
WARNING: architecture specific defines should be avoided #820: FILE: include/hw/xen/interface/io/blkif.h:680:
+#ifdef __i386__
ERROR: code indent should never use tabs #967: FILE: include/hw/xen/interface/io/usbif.h:105:
+^IUSB_VER_UNKNOWN = 0,$
ERROR: code indent should never use tabs #968: FILE: include/hw/xen/interface/io/usbif.h:106:
+^IUSB_VER_USB11,$
ERROR: code indent should never use tabs #969: FILE: include/hw/xen/interface/io/usbif.h:107:
+^IUSB_VER_USB20,$
ERROR: code indent should never use tabs #970: FILE: include/hw/xen/interface/io/usbif.h:108:
+^IUSB_VER_USB30,^I/* not supported yet */$
ERROR: code indent should never use tabs #976: FILE: include/hw/xen/interface/io/usbif.h:114:
+ * - port number:^Ibits 0-4$
ERROR: code indent should never use tabs #977: FILE: include/hw/xen/interface/io/usbif.h:115:
+ *^I^I^I^I(USB_MAXCHILDREN is 31)$
ERROR: code indent should never use tabs #979: FILE: include/hw/xen/interface/io/usbif.h:117:
+ * - operation flag:^Ibit 5$
ERROR: code indent should never use tabs #980: FILE: include/hw/xen/interface/io/usbif.h:118:
+ *^I^I^I^I(0 = submit urb,$
ERROR: code indent should never use tabs #981: FILE: include/hw/xen/interface/io/usbif.h:119:
+ *^I^I^I^I 1 = unlink urb)$
ERROR: code indent should never use tabs #983: FILE: include/hw/xen/interface/io/usbif.h:121:
+ * - direction:^I^Ibit 7$
ERROR: code indent should never use tabs #984: FILE: include/hw/xen/interface/io/usbif.h:122:
+ *^I^I^I^I(0 = Host-to-Device [Out]$
ERROR: code indent should never use tabs #985: FILE: include/hw/xen/interface/io/usbif.h:123:
+ *^I^I^I^I 1 = Device-to-Host [In])$
ERROR: code indent should never use tabs #987: FILE: include/hw/xen/interface/io/usbif.h:125:
+ * - device address:^Ibits 8-14$
ERROR: code indent should never use tabs #989: FILE: include/hw/xen/interface/io/usbif.h:127:
+ * - endpoint:^I^Ibits 15-18$
ERROR: code indent should never use tabs #991: FILE: include/hw/xen/interface/io/usbif.h:129:
+ * - pipe type:^Ibits 30-31$
ERROR: code indent should never use tabs #992: FILE: include/hw/xen/interface/io/usbif.h:130:
+ *^I^I^I^I(00 = isochronous, 01 = interrupt,$
ERROR: code indent should never use tabs #993: FILE: include/hw/xen/interface/io/usbif.h:131:
+ *^I^I^I^I 10 = control, 11 = bulk)$
ERROR: code indent should never use tabs #996: FILE: include/hw/xen/interface/io/usbif.h:134:
+#define USBIF_PIPE_PORT_MASK^I0x0000001f$
ERROR: code indent should never use tabs #997: FILE: include/hw/xen/interface/io/usbif.h:135:
+#define USBIF_PIPE_UNLINK^I0x00000020$
ERROR: code indent should never use tabs #998: FILE: include/hw/xen/interface/io/usbif.h:136:
+#define USBIF_PIPE_DIR^I^I0x00000080$
ERROR: code indent should never use tabs #999: FILE: include/hw/xen/interface/io/usbif.h:137:
+#define USBIF_PIPE_DEV_MASK^I0x0000007f$
ERROR: code indent should never use tabs #1000: FILE: include/hw/xen/interface/io/usbif.h:138:
+#define USBIF_PIPE_DEV_SHIFT^I8$
ERROR: code indent should never use tabs #1001: FILE: include/hw/xen/interface/io/usbif.h:139:
+#define USBIF_PIPE_EP_MASK^I0x0000000f$
ERROR: code indent should never use tabs #1002: FILE: include/hw/xen/interface/io/usbif.h:140:
+#define USBIF_PIPE_EP_SHIFT^I15$
ERROR: code indent should never use tabs #1003: FILE: include/hw/xen/interface/io/usbif.h:141:
+#define USBIF_PIPE_TYPE_MASK^I0x00000003$
ERROR: code indent should never use tabs #1004: FILE: include/hw/xen/interface/io/usbif.h:142:
+#define USBIF_PIPE_TYPE_SHIFT^I30$
ERROR: code indent should never use tabs #1005: FILE: include/hw/xen/interface/io/usbif.h:143:
+#define USBIF_PIPE_TYPE_ISOC^I0$
ERROR: code indent should never use tabs #1006: FILE: include/hw/xen/interface/io/usbif.h:144:
+#define USBIF_PIPE_TYPE_INT^I1$
ERROR: code indent should never use tabs #1007: FILE: include/hw/xen/interface/io/usbif.h:145:
+#define USBIF_PIPE_TYPE_CTRL^I2$
ERROR: code indent should never use tabs #1008: FILE: include/hw/xen/interface/io/usbif.h:146:
+#define USBIF_PIPE_TYPE_BULK^I3$
ERROR: code indent should never use tabs
#1010: FILE: include/hw/xen/interface/io/usbif.h:148:
+#define usbif_pipeportnum(pipe)^I^I^I((pipe) & USBIF_PIPE_PORT_MASK)$
ERROR: code indent should never use tabs
#1011: FILE: include/hw/xen/interface/io/usbif.h:149:
+#define usbif_setportnum_pipe(pipe, portnum)^I((pipe) | (portnum))$
ERROR: code indent should never use tabs
#1013: FILE: include/hw/xen/interface/io/usbif.h:151:
+#define usbif_pipeunlink(pipe)^I^I^I((pipe) & USBIF_PIPE_UNLINK)$
ERROR: code indent should never use tabs
#1014: FILE: include/hw/xen/interface/io/usbif.h:152:
+#define usbif_pipesubmit(pipe)^I^I^I(!usbif_pipeunlink(pipe))$
ERROR: code indent should never use tabs
#1015: FILE: include/hw/xen/interface/io/usbif.h:153:
+#define usbif_setunlink_pipe(pipe)^I^I((pipe) | USBIF_PIPE_UNLINK)$
ERROR: code indent should never use tabs
#1017: FILE: include/hw/xen/interface/io/usbif.h:155:
+#define usbif_pipein(pipe)^I^I^I((pipe) & USBIF_PIPE_DIR)$
ERROR: code indent should never use tabs
#1018: FILE: include/hw/xen/interface/io/usbif.h:156:
+#define usbif_pipeout(pipe)^I^I^I(!usbif_pipein(pipe))$
ERROR: code indent should never use tabs #1020: FILE: include/hw/xen/interface/io/usbif.h:158:
+#define usbif_pipedevice(pipe)^I^I^I\$
ERROR: code indent should never use tabs
#1021: FILE: include/hw/xen/interface/io/usbif.h:159:
+^I^I(((pipe) >> USBIF_PIPE_DEV_SHIFT) & USBIF_PIPE_DEV_MASK)$
ERROR: code indent should never use tabs #1023: FILE: include/hw/xen/interface/io/usbif.h:161:
+#define usbif_pipeendpoint(pipe)^I^I\$
ERROR: code indent should never use tabs
#1024: FILE: include/hw/xen/interface/io/usbif.h:162:
+^I^I(((pipe) >> USBIF_PIPE_EP_SHIFT) & USBIF_PIPE_EP_MASK)$
ERROR: code indent should never use tabs #1026: FILE: include/hw/xen/interface/io/usbif.h:164:
+#define usbif_pipetype(pipe)^I^I^I\$
ERROR: code indent should never use tabs
#1027: FILE: include/hw/xen/interface/io/usbif.h:165:
+^I^I(((pipe) >> USBIF_PIPE_TYPE_SHIFT) & USBIF_PIPE_TYPE_MASK)$
ERROR: code indent should never use tabs
#1028: FILE: include/hw/xen/interface/io/usbif.h:166:
+#define usbif_pipeisoc(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_ISOC)$
ERROR: code indent should never use tabs
#1029: FILE: include/hw/xen/interface/io/usbif.h:167:
+#define usbif_pipeint(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_INT)$
ERROR: code indent should never use tabs
#1030: FILE: include/hw/xen/interface/io/usbif.h:168:
+#define usbif_pipectrl(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_CTRL)$
ERROR: code indent should never use tabs
#1031: FILE: include/hw/xen/interface/io/usbif.h:169:
+#define usbif_pipebulk(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_BULK)$
ERROR: code indent should never use tabs #1034: FILE: include/hw/xen/interface/io/usbif.h:172:
+#define USBIF_MAX_PORTNR^I31$
ERROR: code indent should never use tabs #1035: FILE: include/hw/xen/interface/io/usbif.h:173:
+#define USBIF_RING_SIZE^I4096$
ERROR: code indent should never use tabs #1041: FILE: include/hw/xen/interface/io/usbif.h:179:
+^Igrant_ref_t gref;$
ERROR: code indent should never use tabs #1042: FILE: include/hw/xen/interface/io/usbif.h:180:
+^Iuint16_t offset;$
ERROR: code indent should never use tabs #1043: FILE: include/hw/xen/interface/io/usbif.h:181:
+^Iuint16_t length;$
ERROR: code indent should never use tabs #1047: FILE: include/hw/xen/interface/io/usbif.h:185:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs
#1048: FILE: include/hw/xen/interface/io/usbif.h:186:
+^Iuint16_t nr_buffer_segs; /* number of urb->transfer_buffer segments */$
ERROR: code indent should never use tabs #1050: FILE: include/hw/xen/interface/io/usbif.h:188:
+^I/* basic urb parameter */$
ERROR: code indent should never use tabs #1051: FILE: include/hw/xen/interface/io/usbif.h:189:
+^Iuint32_t pipe;$
ERROR: code indent should never use tabs #1052: FILE: include/hw/xen/interface/io/usbif.h:190:
+^Iuint16_t transfer_flags;$
ERROR: code indent should never use tabs #1053: FILE: include/hw/xen/interface/io/usbif.h:191:
+#define USBIF_SHORT_NOT_OK^I0x0001$
ERROR: code indent should never use tabs #1054: FILE: include/hw/xen/interface/io/usbif.h:192:
+^Iuint16_t buffer_length;$
ERROR: code indent should never use tabs #1055: FILE: include/hw/xen/interface/io/usbif.h:193:
+^Iunion {$
ERROR: code indent should never use tabs #1056: FILE: include/hw/xen/interface/io/usbif.h:194:
+^I^Iuint8_t ctrl[8]; /* setup_packet (Ctrl) */$
ERROR: code indent should never use tabs #1058: FILE: include/hw/xen/interface/io/usbif.h:196:
+^I^Istruct {$
ERROR: code indent should never use tabs
#1059: FILE: include/hw/xen/interface/io/usbif.h:197:
+^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$
ERROR: code indent should never use tabs #1060: FILE: include/hw/xen/interface/io/usbif.h:198:
+^I^I^Iuint16_t start_frame; /* start frame */$
ERROR: code indent should never use tabs
#1061: FILE: include/hw/xen/interface/io/usbif.h:199:
+^I^I^Iuint16_t number_of_packets; /* number of ISO packet */$
ERROR: line over 90 characters
#1062: FILE: include/hw/xen/interface/io/usbif.h:200:
+ uint16_t nr_frame_desc_segs; /* number of iso_frame_desc segments */
ERROR: code indent should never use tabs
#1062: FILE: include/hw/xen/interface/io/usbif.h:200:
+^I^I^Iuint16_t nr_frame_desc_segs; /* number of iso_frame_desc segments */$
ERROR: code indent should never use tabs #1063: FILE: include/hw/xen/interface/io/usbif.h:201:
+^I^I} isoc;$
ERROR: code indent should never use tabs #1065: FILE: include/hw/xen/interface/io/usbif.h:203:
+^I^Istruct {$
ERROR: code indent should never use tabs
#1066: FILE: include/hw/xen/interface/io/usbif.h:204:
+^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$
ERROR: code indent should never use tabs #1067: FILE: include/hw/xen/interface/io/usbif.h:205:
+^I^I^Iuint16_t pad[3];$
ERROR: code indent should never use tabs #1068: FILE: include/hw/xen/interface/io/usbif.h:206:
+^I^I} intr;$
ERROR: code indent should never use tabs #1070: FILE: include/hw/xen/interface/io/usbif.h:208:
+^I^Istruct {$
ERROR: code indent should never use tabs #1071: FILE: include/hw/xen/interface/io/usbif.h:209:
+^I^I^Iuint16_t unlink_id; /* unlink request id */$
ERROR: code indent should never use tabs #1072: FILE: include/hw/xen/interface/io/usbif.h:210:
+^I^I^Iuint16_t pad[3];$
ERROR: code indent should never use tabs #1073: FILE: include/hw/xen/interface/io/usbif.h:211:
+^I^I} unlink;$
ERROR: code indent should never use tabs #1075: FILE: include/hw/xen/interface/io/usbif.h:213:
+^I} u;$
ERROR: code indent should never use tabs #1077: FILE: include/hw/xen/interface/io/usbif.h:215:
+^I/* urb data segments */$
ERROR: code indent should never use tabs
#1078: FILE: include/hw/xen/interface/io/usbif.h:216:
+^Istruct usbif_request_segment seg[USBIF_MAX_SEGMENTS_PER_REQUEST];$
ERROR: code indent should never use tabs #1083: FILE: include/hw/xen/interface/io/usbif.h:221:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs #1084: FILE: include/hw/xen/interface/io/usbif.h:222:
+^Iuint16_t start_frame; /* start frame (ISO) */$
ERROR: code indent should never use tabs #1085: FILE: include/hw/xen/interface/io/usbif.h:223:
+^Iint32_t status; /* status (non-ISO) */$
ERROR: code indent should never use tabs #1086: FILE: include/hw/xen/interface/io/usbif.h:224:
+^Iint32_t actual_length; /* actual transfer length */$
ERROR: code indent should never use tabs #1087: FILE: include/hw/xen/interface/io/usbif.h:225:
+^Iint32_t error_count; /* number of ISO errors */$
WARNING: line over 80 characters
#1091: FILE: include/hw/xen/interface/io/usbif.h:229:
+DEFINE_RING_TYPES(usbif_urb, struct usbif_urb_request, struct usbif_urb_response);
ERROR: code indent should never use tabs #1098: FILE: include/hw/xen/interface/io/usbif.h:236:
+^Iuint16_t id;$
ERROR: code indent should never use tabs #1103: FILE: include/hw/xen/interface/io/usbif.h:241:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs #1104: FILE: include/hw/xen/interface/io/usbif.h:242:
+^Iuint8_t portnum; /* port number */$
ERROR: code indent should never use tabs #1105: FILE: include/hw/xen/interface/io/usbif.h:243:
+^Iuint8_t speed; /* usb_device_speed */$
ERROR: code indent should never use tabs #1106: FILE: include/hw/xen/interface/io/usbif.h:244:
+#define USBIF_SPEED_NONE^I0$
ERROR: code indent should never use tabs #1107: FILE: include/hw/xen/interface/io/usbif.h:245:
+#define USBIF_SPEED_LOW^I^I1$
ERROR: code indent should never use tabs #1108: FILE: include/hw/xen/interface/io/usbif.h:246:
+#define USBIF_SPEED_FULL^I2$
ERROR: code indent should never use tabs #1109: FILE: include/hw/xen/interface/io/usbif.h:247:
+#define USBIF_SPEED_HIGH^I3$
WARNING: line over 80 characters
#1113: FILE: include/hw/xen/interface/io/usbif.h:251:
+DEFINE_RING_TYPES(usbif_conn, struct usbif_conn_request, struct usbif_conn_response);
total: 93 errors, 6 warnings, 1036 lines checked
Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
2/4 Checking commit 252595d3e0db (xen: Import other xen/io/*.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#98: FILE: include/hw/xen/interface/io/console.h:1:
+/******************************************************************************
ERROR: spaces required around that '-' (ctx:VxV) #129: FILE: include/hw/xen/interface/io/console.h:32:
+#define MASK_XENCONS_IDX(idx, ring) ((idx) & (sizeof(ring)-1))
^
ERROR: open brace '{' following struct go on the same line #194: FILE: include/hw/xen/interface/io/fbif.h:45:
+struct xenfb_update
+{
ERROR: open brace '{' following struct go on the same line #209: FILE: include/hw/xen/interface/io/fbif.h:60:
+struct xenfb_resize
+{
ERROR: open brace '{' following union go on the same line #221: FILE: include/hw/xen/interface/io/fbif.h:72:
+union xenfb_out_event
+{
ERROR: open brace '{' following struct go on the same line #247: FILE: include/hw/xen/interface/io/fbif.h:98:
+struct xenfb_refresh_period
+{
WARNING: Block comments use a leading /* on a separate line #249: FILE: include/hw/xen/interface/io/fbif.h:100:
+ uint32_t period; /* period of refresh, in ms,
WARNING: Block comments use a trailing */ on a separate line #250: FILE: include/hw/xen/interface/io/fbif.h:101:
+ * XENFB_NO_REFRESH if no refresh is needed */
ERROR: open brace '{' following union go on the same line #256: FILE: include/hw/xen/interface/io/fbif.h:107:
+union xenfb_in_event
+{
ERROR: open brace '{' following struct go on the same line #281: FILE: include/hw/xen/interface/io/fbif.h:132:
+struct xenfb_page
+{
ERROR: open brace '{' following struct go on the same line #582: FILE: include/hw/xen/interface/io/kbdif.h:271:
+struct xenkbd_motion
+{
ERROR: open brace '{' following struct go on the same line #609: FILE: include/hw/xen/interface/io/kbdif.h:298:
+struct xenkbd_key
+{
ERROR: open brace '{' following struct go on the same line #640: FILE: include/hw/xen/interface/io/kbdif.h:329:
+struct xenkbd_position
+{
ERROR: open brace '{' following union go on the same line #814: FILE: include/hw/xen/interface/io/kbdif.h:503:
+union xenkbd_in_event
+{
ERROR: open brace '{' following union go on the same line #844: FILE: include/hw/xen/interface/io/kbdif.h:533:
+union xenkbd_out_event
+{
ERROR: open brace '{' following struct go on the same line #872: FILE: include/hw/xen/interface/io/kbdif.h:561:
+struct xenkbd_page
+{
WARNING: Block comments use a leading /* on a separate line
#884: FILE: include/hw/xen/interface/io/netif.h:1:
+/******************************************************************************
ERROR: spaces required around that '<<' (ctx:VxV) #1256: FILE: include/hw/xen/interface/io/netif.h:373:
+#define XEN_NETIF_CTRLF_GREF_readonly (1U<<_XEN_NETIF_CTRLF_GREF_readonly)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1771: FILE: include/hw/xen/interface/io/netif.h:888:
+#define NETTXF_csum_blank (1U<<_NETTXF_csum_blank)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1775: FILE: include/hw/xen/interface/io/netif.h:892:
+#define NETTXF_data_validated (1U<<_NETTXF_data_validated)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1779: FILE: include/hw/xen/interface/io/netif.h:896:
+#define NETTXF_more_data (1U<<_NETTXF_more_data)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1783: FILE: include/hw/xen/interface/io/netif.h:900:
+#define NETTXF_extra_info (1U<<_NETTXF_extra_info)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1805: FILE: include/hw/xen/interface/io/netif.h:922:
+#define XEN_NETIF_EXTRA_FLAG_MORE (1U<<_XEN_NETIF_EXTRA_FLAG_MORE)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1854: FILE: include/hw/xen/interface/io/netif.h:971:
+#define NETRXF_data_validated (1U<<_NETRXF_data_validated)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1858: FILE: include/hw/xen/interface/io/netif.h:975:
+#define NETRXF_csum_blank (1U<<_NETRXF_csum_blank)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1862: FILE: include/hw/xen/interface/io/netif.h:979:
+#define NETRXF_more_data (1U<<_NETRXF_more_data)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1866: FILE: include/hw/xen/interface/io/netif.h:983:
+#define NETRXF_extra_info (1U<<_NETRXF_extra_info)
^
ERROR: spaces required around that '<<' (ctx:VxV) #1870: FILE: include/hw/xen/interface/io/netif.h:987:
+#define NETRXF_gso_prefix (1U<<_NETRXF_gso_prefix)
^
WARNING: Block comments use a leading /* on a separate line
#1900: FILE: include/hw/xen/interface/io/protocols.h:1:
+/******************************************************************************
WARNING: architecture specific defines should be avoided #1931: FILE: include/hw/xen/interface/io/protocols.h:32:
+#if defined(__i386__)
WARNING: Block comments use a leading /* on a separate line
#1948: FILE: include/hw/xen/interface/io/xenbus.h:1:
+/*****************************************************************************
total: 24 errors, 8 warnings, 1943 lines checked
Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
3/4 Checking commit 1d20f2a619b4 (xen: Import Xen public headers used by xen-hvm.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line #148: FILE: include/hw/xen/interface/hvm/ioreq.h:60:
+ uint8_t data_is_ptr:1; /* if 1, data above is the guest paddr
WARNING: Block comments use a trailing */ on a separate line #149: FILE: include/hw/xen/interface/hvm/ioreq.h:61:
+ * of the real data to use. */
WARNING: architecture specific defines should be avoided #174: FILE: include/hw/xen/interface/hvm/ioreq.h:86:
+#ifdef __XEN__
WARNING: architecture specific defines should be avoided #180: FILE: include/hw/xen/interface/hvm/ioreq.h:92:
+#ifdef __XEN__
total: 0 errors, 5 warnings, 182 lines checked
Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
4/4 Checking commit 919708ec26d3 (xen: Avoid VLA)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel