Skip to contentSkip to conversation

arm64: dts: qcom: msm8998: Add ANOC1 SMMU node

PATCH In review Marc Gonzalez 2 participants 6 messages Apr 1, 2019 – Jun 17, 2019 2 messages not in the archive

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 arm64: dts: qcom: msm8998: Add ANOC1 SMMU node

The MSM8998 ANOC1(*) SMMU services BLSP2, PCIe, UFS, and USB. (*) Aggregate Network-on-Chip #1

Based on the following DTS downstream:
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm-arm-smmu-8998.dtsi?h=LE.UM.1.3.r3.25#n18

---
Changes from v1:

	Split off from "PCIe and AR8151 on APQ8098/MSM8998" series
	Change compatible string to use qcom,msm8998-smmu-v2
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm64/boot/dts/qcom/msm8998.dtsi +15 -0
index ef71e8f1d102..f807ea3e2c6e 100644
@@ -606,6 +606,21 @@
 			#thermal-sensor-cells = <1>;
 		};
 
+		anoc1_smmu: arm,smmu@1680000 {
+			compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2";
+			reg = <0x01680000 0x10000>;
+			#iommu-cells = <1>;
+
+			#global-interrupts = <0>;
+			interrupts =
+				<GIC_SPI 364 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 365 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 366 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 367 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 368 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 369 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		tcsr_mutex_regs: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): edade219-aa77-e7f0-af68-1c192632b2ca-GANU6spQydw@public.gmane.org

#2 lore raw

PATCH v2 2/2 dt-bindings: arm-smmu: Add qcom,msm8998-smmu-v2 binding

Unused at the moment, just future-proofing the DTS.

---
 Documentation/devicetree/bindings/iommu/arm,smmu.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iommu/arm,smmu.txt +1 -0
index 3133f3ba7567..75d8487fd86f 100644
@@ -25,6 +25,7 @@ conditions.
                   Qcom SoCs must contain, as below, SoC-specific compatibles
                   along with "qcom,smmu-v2":
                   "qcom,msm8996-smmu-v2", "qcom,smmu-v2",
+                  "qcom,msm8998-smmu-v2", "qcom,smmu-v2",
                   "qcom,sdm845-smmu-v2", "qcom,smmu-v2".
 
                   Qcom SoCs implementing "arm,mmu-500" must also include,
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): f5029889-6aaa-1315-0225-9b0e46e0697c-GANU6spQydw@public.gmane.org

#4 lore raw

Re: [PATCH v2 2/2] dt-bindings: arm-smmu: Add qcom,msm8998-smmu-v2 binding

+robh, +mrutland for DT

Quoted 19 lines · Marc Gonzalez

Unused at the moment, just future-proofing the DTS.

---
 Documentation/devicetree/bindings/iommu/arm,smmu.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iommu/arm,smmu.txt +1 -0
index 3133f3ba7567..75d8487fd86f 100644
@@ -25,6 +25,7 @@ conditions.
                   Qcom SoCs must contain, as below, SoC-specific compatibles
                   along with "qcom,smmu-v2":
                   "qcom,msm8996-smmu-v2", "qcom,smmu-v2",
+                  "qcom,msm8998-smmu-v2", "qcom,smmu-v2",
                   "qcom,sdm845-smmu-v2", "qcom,smmu-v2".
 
                   Qcom SoCs implementing "arm,mmu-500" must also include,
#5 lore raw
In reply to a message not in the archive
Quoted 20 lines · Marc Gonzalez

The MSM8998 ANOC1(*) SMMU services BLSP2, PCIe, UFS, and USB. (*) Aggregate Network-on-Chip #1

Based on the following DTS downstream:
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm-arm-smmu-8998.dtsi?h=LE.UM.1.3.r3.25#n18

---
Changes from v1:

	Split off from "PCIe and AR8151 on APQ8098/MSM8998" series
	Change compatible string to use qcom,msm8998-smmu-v2
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm64/boot/dts/qcom/msm8998.dtsi +0 -0
index ef71e8f1d102..f807ea3e2c6e 100644

arch/arm64/boot/dts/qcom/msm8998.dtsi line 609

Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8998.dtsi +1 -0
@@ -606,6 +606,21 @@
 			#thermal-sensor-cells = <1>;
 		};
 
+		anoc1_smmu: arm,smmu@1680000 {

Doh! This should probably be anoc1_smmu: iommu@1680000

Bjorn, can you fix it up when you pick up the patch, or do you need me to respin?

Regards.

#6 lore raw
In reply to a message not in the archive

+robh, +mrutland for DT

Quoted 20 lines · Marc Gonzalez

The MSM8998 ANOC1(*) SMMU services BLSP2, PCIe, UFS, and USB. (*) Aggregate Network-on-Chip #1

Based on the following DTS downstream:
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm-arm-smmu-8998.dtsi?h=LE.UM.1.3.r3.25#n18

---
Changes from v1:

	Split off from "PCIe and AR8151 on APQ8098/MSM8998" series
	Change compatible string to use qcom,msm8998-smmu-v2
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm64/boot/dts/qcom/msm8998.dtsi +0 -0
index ef71e8f1d102..f807ea3e2c6e 100644

arch/arm64/boot/dts/qcom/msm8998.dtsi line 609

Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8998.dtsi +1 -0
@@ -606,6 +606,21 @@
 			#thermal-sensor-cells = <1>;
 		};
 
+		anoc1_smmu: arm,smmu@1680000 {

As discussed with Arnd, this should probably be anoc1_smmu: iommu@1680000

Quoted 17 lines
arch/arm64/boot/dts/qcom/msm8998.dtsi +14 -0
+			compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2";
+			reg = <0x01680000 0x10000>;
+			#iommu-cells = <1>;
+
+			#global-interrupts = <0>;
+			interrupts =
+				<GIC_SPI 364 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 365 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 366 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 367 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 368 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 369 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		tcsr_mutex_regs: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;
#7 lore raw
In reply to Marc Gonzalez
Quoted 7 lines · Marc Gonzalez

The MSM8998 ANOC1(*) SMMU services BLSP2, PCIe, UFS, and USB. (*) Aggregate Network-on-Chip #1

Based on the following DTS downstream:
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm-arm-smmu-8998.dtsi?h=LE.UM.1.3.r3.25#n18

Patch 1 applied

Thanks,
Bjorn

Quoted 36 lines

---
Changes from v1:

	Split off from "PCIe and AR8151 on APQ8098/MSM8998" series
	Change compatible string to use qcom,msm8998-smmu-v2
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm64/boot/dts/qcom/msm8998.dtsi +15 -0
index ef71e8f1d102..f807ea3e2c6e 100644
@@ -606,6 +606,21 @@
 			#thermal-sensor-cells = <1>;
 		};
 
+		anoc1_smmu: arm,smmu@1680000 {
+			compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2";
+			reg = <0x01680000 0x10000>;
+			#iommu-cells = <1>;
+
+			#global-interrupts = <0>;
+			interrupts =
+				<GIC_SPI 364 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 365 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 366 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 367 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 368 IRQ_TYPE_EDGE_RISING>,
+				<GIC_SPI 369 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		tcsr_mutex_regs: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;
Signature · 1 line
2.17.1