Skip to contentSkip to conversation

package/flatbuffers: bump version to v1.11.0

PATCH New Bernd Kuhls 2 participants 4 messages Jun 16, 2019 – Jun 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 package/flatbuffers: bump version to v1.11.0

---
v2: initial version

 package/flatbuffers/flatbuffers.hash | 2 +-
 package/flatbuffers/flatbuffers.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/flatbuffers/flatbuffers.hash +1 -1
index 7afe849cd7..3cd737273a 100644
@@ -1,3 +1,3 @@
 # Locally computed:
-sha256	3714e3db8c51e43028e10ad7adffb9a36fc4aa5b1a363c2d0c4303dd1be59a7c	flatbuffers-v1.10.0.tar.gz
+sha256	3f4a286642094f45b1b77228656fbd7ea123964f19502f9ecfd29933fd23a50b	flatbuffers-v1.11.0.tar.gz
 sha256	7ec9661a8afafab1eee3523d6f1a193eff76314a5ab10b4ce96aefd87621b0c3	LICENSE.txt
package/flatbuffers/flatbuffers.mk +1 -1
index 69054885ea..8252a1616c 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FLATBUFFERS_VERSION = v1.10.0
+FLATBUFFERS_VERSION = v1.11.0
 FLATBUFFERS_SITE = $(call github,google,flatbuffers,$(FLATBUFFERS_VERSION))
 FLATBUFFERS_LICENSE = Apache-2.0
 FLATBUFFERS_LICENSE_FILES = LICENSE.txt
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 2/2 package/flatbuffers: Enable host build

Host version of flatc compiler is needed for Kodi 18.x:
https://github.com/xbmc/xbmc/blob/master/cmake/modules/FindFlatBuffers.cmake#L51

---
v2: removed upstream patch after version bump to v1.11.0

 package/flatbuffers/flatbuffers.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)
package/flatbuffers/flatbuffers.mk +10 -0
index 8252a1616c..3664cc79cb 100644
@@ -20,4 +20,14 @@ else
 FLATBUFFERS_CONF_OPTS += -DFLATBUFFERS_BUILD_SHAREDLIB=ON
 endif
 
+HOST_FLATBUFFERS_CONF_OPTS += \
+	-DCMAKE_CXX_FLAGS="-std=c++11" \
+	-DFLATBUFFERS_BUILD_FLATLIB=OFF \
+	-DFLATBUFFERS_BUILD_FLATC=ON \
+	-DFLATBUFFERS_BUILD_FLATHASH=OFF \
+	-DFLATBUFFERS_BUILD_GRPCTEST=OFF \
+	-DFLATBUFFERS_BUILD_SHAREDLIB=OFF \
+	-DFLATBUFFERS_BUILD_TESTS=OFF
+
 $(eval $(cmake-package))
+$(eval $(host-cmake-package))
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 2/2 package/flatbuffers: Enable host build

Hello Bernd,

Quoted 6 lines · On Sun, 16 Jun 2019 22:23:37 +0200 Bernd Kuhls <[email protected]> wrote:

Host version of flatc compiler is needed for Kodi 18.x:
https://github.com/xbmc/xbmc/blob/master/cmake/modules/FindFlatBuffers.cmake#L51

---
v2: removed upstream patch after version bump to v1.11.0

I've applied, but I have a comment, see below.

package/flatbuffers/flatbuffers.mk else · line 24

Quoted 2 lines
package/flatbuffers/flatbuffers.mk +2 -0
+HOST_FLATBUFFERS_CONF_OPTS += \
+	-DCMAKE_CXX_FLAGS="-std=c++11" \

This line means you will have to change the dependency of Kodi to require host gcc >= 4.8 instead of host gcc >= 4.6 as is done today.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com