ASoC: rsnd: fixup mod ID calculation in rsnd_ctu_probe_
Subsystems (3)
PATCH 1/1 ASoC: rsnd: fixup mod ID calculation in rsnd_ctu_probe_
From: Nilkanth Ahirrao <[email protected]>
commit 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub") introduces rsnd_ctu_id which calcualates and gives the main Device id of the CTU by dividing the id by 4. rsnd_mod_id uses this interface to get the CTU main Device id. But this commit forgets to revert the main Device id calcution previously done in rsnd_ctu_probe_ which also divides the id by 4. This path corrects the same to get the correct main Device id.
The issue is observered when rsnd_ctu_probe_ is done for CTU1
--- sound/soc/sh/rcar/ctu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sh/rcar/ctu.c +1 -1
@@ -108,7 +108,7 @@ static int rsnd_ctu_probe_(struct rsnd_mod *mod,struct rsnd_dai_stream *io, struct rsnd_priv *priv) { - return rsnd_cmd_attach(io, rsnd_mod_id(mod) / 4); + return rsnd_cmd_attach(io, rsnd_mod_id(mod)); } static void rsnd_ctu_value_init(struct rsnd_dai_stream *io,
Signature · 1 line
2.19.2
Hi Jiada
Quoted 11 lines
From: Nilkanth Ahirrao <[email protected]>
commit
7e4f3419ebfe("ASoC: rsnd: add .get_id/.get_id_sub") introducesrsnd_ctu_idwhich calcualates and gives the main Device id of the CTU by dividing the id by 4.rsnd_mod_iduses this interface to get the CTU main Device id. But this commit forgets to revert the main Device id calcution previously done inrsnd_ctu_probe_which also divides the id by 4. This path corrects the same to get the correct main Device id.
Quoted 8 lines
The issue is observered when
rsnd_ctu_probe_is done for CTU1Fixes 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")Signed-off-by Nilkanth Ahirrao <[email protected]>Signed-off-by Suresh Udipi <[email protected]>Signed-off-by Jiada Wang <[email protected]>---
Thanks !!
But, I guess commit ID is this for upstream ?
c16015f36cc128244c910152663de45c3b99f551
("ASoC: rsnd: add .get_id/.get_id_sub")
Quoted 19 lines
sound/soc/sh/rcar/ctu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/sh/rcar/ctu.c +1
-1@@ -108,7 +108,7 @@ static int rsnd_ctu_probe_(struct rsnd_mod *mod,struct rsnd_dai_stream *io, struct rsnd_priv *priv) { - return rsnd_cmd_attach(io, rsnd_mod_id(mod) / 4); + return rsnd_cmd_attach(io, rsnd_mod_id(mod)); } static void rsnd_ctu_value_init(struct rsnd_dai_stream *io,Signature · 1 line
2.19.2