Skip to contentSkip to conversation

ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC

PATCH In review Tzung-Bi Shih 3 participants 3 messages Jun 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC

Change the memory allocation flag from GFP_ATOMIC to GFP_KERNEL because probe of platform device is unlikely a place where cannot sleep.

---
It might be a typo introduced from copied-and-pasted.

 sound/soc/intel/boards/sof_rt5682.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/sof_rt5682.c +1 -1
index e2e5f97d9920..02138aa8a850 100644
@@ -498,7 +498,7 @@ static int sof_audio_probe(struct platform_device *pdev)
 	int dmic_num, hdmi_num;
 	int ret, ssp_amp, ssp_codec;
 
-	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
+	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
 	if (!ctx)
 		return -ENOMEM;
 
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tzung-Bi Shih

Change the memory allocation flag from GFP_ATOMIC to GFP_KERNEL because probe of platform device is unlikely a place where cannot sleep.

---
It might be a typo introduced from copied-and-pasted.

We noticed this issue yesterday while reviewing additional changes for this machine driver but you beat us to it. Thanks!

Quoted 18 lines
  sound/soc/intel/boards/sof_rt5682.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/sof_rt5682.c +1 -1
index e2e5f97d9920..02138aa8a850 100644
@@ -498,7 +498,7 @@ static int sof_audio_probe(struct platform_device *pdev)
  	int dmic_num, hdmi_num;
  	int ret, ssp_amp, ssp_codec;
 
-	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
+	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
  	if (!ctx)
  		return -ENOMEM;
 
maintainer
#2 lore raw

Applied "ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC" to the asoc tree

In reply to Tzung-Bi Shih

The patch

ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 281c443f1e8e25ebc46aaebf48c73e0545a0830e Mon Sep 17 00:00:00 2001

From: Tzung-Bi Shih <[email protected]>
Date: Tue, 18 Jun 2019 15:04:26 +0800
Subject: [PATCH] ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC

Change the memory allocation flag from GFP_ATOMIC to GFP_KERNEL because probe of platform device is unlikely a place where cannot sleep.

---
 sound/soc/intel/boards/sof_rt5682.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/sof_rt5682.c +1 -1
index 3343dbcd506f..90d262ebeb10 100644
@@ -494,7 +494,7 @@ static int sof_audio_probe(struct platform_device *pdev)
 	int dmic_num, hdmi_num;
 	int ret, ssp_amp, ssp_codec;
 
-	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
+	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
 	if (!ctx)
 		return -ENOMEM;
 
Signature · 1 line
2.20.1