Skip to contentSkip to conversation

pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

PATCH New Eugeniu Rosca 6 participants 15 messages Jun 17, 2019 – Jul 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

In spite of the summary line, U-Boot commits [1-2] seem to have aligned the U-Boot PFC tables to Linux v5.1 rather than to v5.0, since they also imported the Linux 5.1 commits listed in [3].

What current commit tries to accomplish is to align the Gen2 and Gen3 pinctrl tables to Linux v5.2-rc5. Importing these updates in two steps as done before (i.e. separately for Gen2 and Gen3) is somewhat difficult due to Linux commits like [5-6] which atomically update both Gen2/3 platforms and whose breakdown would not be easily possible.

The detailed list of Linux commits squashed into this U-Boot patch is shown in [4]. The second column in [4] depicts the patch id mismatch between the original Linux and the resulted U-Boot commit. The exclamation mark means that manual conflict resolution was involved during cherry picking Linux commit into U-Boot repository (this is mainly caused by dropped changes in files like pfc-r8a7795-es1.c and pfc-r8a77980.c which are missing in U-Boot).

This patch has been applied on top of v2019.07-rc4-155-g8754656680b6 and boot-tested on:
- H3-ES2.0-Salvator-X
- M3-ES1.1-Salvator-XS
- M3N-ES1.1-ULCB

[1] 8719ca81136474 ("pinctrl: renesas: Synchronize Gen3 tables with Linux 5.0")
[2] a6a743df242a50 ("pinctrl: renesas: Synchronize Gen2 tables with Linux 5.0")
[3] Linux 5.1 commits already contained in [1-2]:
79dbbdbeccc6784 pinctrl: sh-pfc: r8a77965: Add DRIF pins, groups and functions 729257d674bc2e6 pinctrl: sh-pfc: r8a77965: Add TMU pins, groups and functions b9fd50488b4939c pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b pin group a4b0350047f1b10 pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group fdbbd6b74c9278f pinctrl: sh-pfc: r8a77990: Add DRIF pins, groups and functions 16978e7d40f73be pinctrl: sh-pfc: r8a77990: Add TMU pins, groups and functions 86c045c2e4201e9 pinctrl: sh-pfc: r8a77965: Replace DU_DOTCLKIN2 by DU_DOTCLKIN3 b8ba194ca5f4ca2 pinctrl: sh-pfc: r8a7791: Fix VIN1 versioned groups 81c585c96b7dd47 pinctrl: sh-pfc: r8a77970: Deduplicate VIN[01] pin definitions 08b7e2112a9b19c pinctrl: sh-pfc: r8a7796: Deduplicate VIN5 pin definitions 99fdb920f5534d1 pinctrl: sh-pfc: r8a7795: Deduplicate VIN5 pin definitions 85ccae133bde425 Revert "pinctrl: sh-pfc: r8a77990: Add support for pull-up only pins" f7d8b568e204d29 pinctrl: sh-pfc: r8a77990: GP6_9 does not have pull-down capability 5219aa33caec2f7 pinctrl: sh-pfc: r8a77995: Fix MOD_SEL bit numbering 3e3eebeacad79bd pinctrl: sh-pfc: r8a77990: Fix MOD_SEL bit numbering 7219a4b64520873 pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 bit2 when using RX2, TX2 and SCK2 699c7d1346fbef6 pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 bit3 when using TX0

[4] Linux 5.2-rc5 commits backported and squashed into this U-Boot patch

Linux commit id   Linux commit summary line
9925e8795726801   pinctrl: sh-pfc: Validate pins/marks in pin groups at build time
f83f97684a737f6   pinctrl: sh-pfc: Make pinmux_cfg_reg.var_field_width[] variable-length
5e8588c86d71e78   pinctrl: sh-pfc: Validate fixed-size field widths at build time
1c5c1101755c5ed   pinctrl: sh-pfc: r8a77970: Rename IOCTRLx registers
3df892fdbfe6919   pinctrl: sh-pfc: r8a77990: Rename IOCTRLx registers
dcd24e098d8df8b   pinctrl: sh-pfc: r8a7796: Move CANFD pin groups and functions
2cee6cb290ab30f   pinctrl: sh-pfc: r8a77990: Move CANFD pin groups and functions

d92ee9cf8ec8d7f ! pinctrl: sh-pfc: rcar-gen3: Retain TDSELCTRL register across suspend/resume efca8da0c5fcc7f ! pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG() macro 69f7be1c6314fb0 ! pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG_VAR() macro 19b593a1cf068ef ! pinctrl: sh-pfc: Absorb enum IDs in PINMUX_DATA_REG() macro
c481c8178420b8c pinctrl: sh-pfc: Validate enum IDs for regs with fixed-width fields
fa4d36712f20e24 ! pinctrl: sh-pfc: Validate enum IDs for regs with variable-width fields

360328c7dc15f48   pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation
943ff71281c6ce4   pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 bit16 when using NFALE and NFRB_N
e167d723e1a472d   pinctrl: sh-pfc: r8a77990: Fix MOD_SEL1 bit31 when using SIM0_D
e87882eb9be10b2   pinctrl: sh-pfc: r8a77990: Fix MOD_SEL1 bit30 when using SSI_SCK2 and SSI_WS2

5671f8e0270ad5e ! pinctrl: sh-pfc: rcar-gen3: Remove HDMI CEC pins, groups, and functions 662dc924a05e9df ! pinctrl: sh-pfc: rcar-gen3: Remove CC5_OSCOUT pin 624a7a12cc0cc77 ! pinctrl: sh-pfc: rcar-gen3: Rename RTS{0,1,3,4}# pin function definitions
a040f3dec8eb7b1 pinctrl: sh-pfc: rcar-gen3: Rename SEL_ADG_{A,B,C} to SEL_ADG{A,B,C}
e551122cdb7fcb9 pinctrl: sh-pfc: rcar-gen3: Rename SEL_NDFC to SEL_NDF
baaa2effc684e49 pinctrl: sh-pfc: r8a77970: Fix spacing
f05603fa6aa3043 pinctrl: sh-pfc: r8a7796: Remove placeholder I2C pin data
0a042b355e60269 pinctrl: sh-pfc: r8a77965: Add I2C{0,3,5} pins, groups and functions

[5] efca8da0c5fcc7 ("pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG() macro")
[6] 69f7be1c6314fb ("pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG_VAR() macro")

---
 drivers/pinctrl/renesas/pfc-r8a7790.c  | 131 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7791.c  | 155 +++++++------
 drivers/pinctrl/renesas/pfc-r8a7792.c  | 134 +++++------
 drivers/pinctrl/renesas/pfc-r8a7794.c  | 126 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7795.c  | 200 ++++++++---------
 drivers/pinctrl/renesas/pfc-r8a7796.c  | 224 +++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77965.c | 293 +++++++++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77970.c | 122 +++++-----
 drivers/pinctrl/renesas/pfc-r8a77990.c | 213 +++++++++---------
 drivers/pinctrl/renesas/pfc-r8a77995.c | 119 +++++-----
 drivers/pinctrl/renesas/sh_pfc.h       |  71 +++---
 11 files changed, 959 insertions(+), 829 deletions(-)
drivers/pinctrl/renesas/pfc-r8a7790.c +75 -56
index ef23ca278ab3..5e1502ed9696 100644
@@ -4745,7 +4745,7 @@ static const struct sh_pfc_function pinmux_functions[] = {
 };
 
 static const struct pinmux_cfg_reg pinmux_config_regs[] = {
-	{ PINMUX_CFG_REG("GPSR0", 0xE6060004, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR0", 0xE6060004, 32, 1, GROUP(
 		GP_0_31_FN, FN_IP3_17_15,
 		GP_0_30_FN, FN_IP3_14_12,
 		GP_0_29_FN, FN_IP3_11_8,
@@ -4777,9 +4777,9 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_0_3_FN, FN_IP0_11_9,
 		GP_0_2_FN, FN_IP0_8_6,
 		GP_0_1_FN, FN_IP0_5_3,
-		GP_0_0_FN, FN_IP0_2_0 }
+		GP_0_0_FN, FN_IP0_2_0 ))
 	},
-	{ PINMUX_CFG_REG("GPSR1", 0xE6060008, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR1", 0xE6060008, 32, 1, GROUP(
 		0, 0,
 		0, 0,
 		GP_1_29_FN, FN_IP6_13_11,
@@ -4811,9 +4811,9 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_1_3_FN, FN_IP3_28_26,
 		GP_1_2_FN, FN_IP3_25_23,
 		GP_1_1_FN, FN_IP3_22_20,
-		GP_1_0_FN, FN_IP3_19_18, }
+		GP_1_0_FN, FN_IP3_19_18, ))
 	},
-	{ PINMUX_CFG_REG("GPSR2", 0xE606000C, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR2", 0xE606000C, 32, 1, GROUP(
 		0, 0,
 		0, 0,
 		GP_2_29_FN, FN_IP7_15_13,
@@ -4845,9 +4845,9 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_2_3_FN, FN_IP8_3_2,
 		GP_2_2_FN, FN_IP8_1_0,
 		GP_2_1_FN, FN_IP7_30_29,
-		GP_2_0_FN, FN_IP7_28_27 }
+		GP_2_0_FN, FN_IP7_28_27 ))
 	},
-	{ PINMUX_CFG_REG("GPSR3", 0xE6060010, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR3", 0xE6060010, 32, 1, GROUP(
 		GP_3_31_FN, FN_IP11_21_18,
 		GP_3_30_FN, FN_IP11_17_15,
 		GP_3_29_FN, FN_IP11_14_13,
@@ -4879,9 +4879,9 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_3_3_FN, FN_IP9_3_2,
 		GP_3_2_FN, FN_IP9_1_0,
 		GP_3_1_FN, FN_IP8_30_29,
-		GP_3_0_FN, FN_IP8_28 }
+		GP_3_0_FN, FN_IP8_28 ))
 	},
-	{ PINMUX_CFG_REG("GPSR4", 0xE6060014, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR4", 0xE6060014, 32, 1, GROUP(
 		GP_4_31_FN, FN_IP14_18_16,
 		GP_4_30_FN, FN_IP14_15_12,
 		GP_4_29_FN, FN_IP14_11_9,
@@ -4913,9 +4913,9 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_4_3_FN, FN_IP11_31_30,
 		GP_4_2_FN, FN_IP11_29_27,
 		GP_4_1_FN, FN_IP11_26_24,
-		GP_4_0_FN, FN_IP11_23_22 }
+		GP_4_0_FN, FN_IP11_23_22 ))
 	},
-	{ PINMUX_CFG_REG("GPSR5", 0xE6060018, 32, 1) {
+	{ PINMUX_CFG_REG("GPSR5", 0xE6060018, 32, 1, GROUP(
 		GP_5_31_FN, FN_IP7_24_22,
 		GP_5_30_FN, FN_IP7_21_19,
 		GP_5_29_FN, FN_IP7_18_16,
@@ -4947,10 +4947,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		GP_5_3_FN, FN_IP14_30_28,
 		GP_5_2_FN, FN_IP14_27_25,
 		GP_5_1_FN, FN_IP14_24_22,
-		GP_5_0_FN, FN_IP14_21_19 }
+		GP_5_0_FN, FN_IP14_21_19 ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR0", 0xE6060020, 32,
-			     1, 4, 4, 3, 4, 4, 3, 3, 3, 3) {
+			     GROUP(1, 4, 4, 3, 4, 4, 3, 3, 3, 3),
+			     GROUP(
 		/* IP0_31 [1] */
 		0, 0,
 		/* IP0_30_27 [4] */
@@ -4983,10 +4984,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		0, 0, 0,
 		/* IP0_2_0 [3] */
 		FN_D0, FN_MSIOF3_SCK_B, FN_VI3_DATA0, FN_VI0_G4, FN_VI0_G4_B,
-		0, 0, 0, }
+		0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR1", 0xE6060024, 32,
-			     2, 2, 2, 4, 4, 3, 3, 4, 4, 4) {
+			     GROUP(2, 2, 2, 4, 4, 3, 3, 4, 4, 4),
+			     GROUP(
 		/* IP1_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP1_29_28 [2] */
@@ -5020,10 +5022,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP1_3_0 [4] */
 		FN_D9, FN_SCIFA1_RXD_C, FN_AVB_TXD1, 0,
 		FN_VI0_G1, FN_VI0_G1_B, FN_VI2_DATA1_VI2_B1,
-		0, 0, 0, 0, 0, 0, 0, 0, 0, }
+		0, 0, 0, 0, 0, 0, 0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR2", 0xE6060028, 32,
-			     3, 3, 4, 4, 3, 3, 3, 3, 3, 3) {
+			     GROUP(3, 3, 4, 4, 3, 3, 3, 3, 3, 3),
+			     GROUP(
 		/* IP2_31_29 [3] */
 		0, 0, 0, 0, 0, 0, 0, 0,
 		/* IP2_28_26 [3] */
@@ -5049,10 +5052,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP2_5_3 [3] */
 		FN_A3, FN_PWM6, FN_MSIOF1_SS2_B, 0, 0, 0, 0, 0,
 		/* IP2_2_0 [3] */
-		FN_A2, FN_PWM5, FN_MSIOF1_SS1_B, 0, 0, 0, 0, 0,	}
+		FN_A2, FN_PWM5, FN_MSIOF1_SS1_B, 0, 0, 0, 0, 0,	))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR3", 0xE606002C, 32,
-			     3, 3, 3, 3, 2, 3, 3, 4, 4, 4) {
+			     GROUP(3, 3, 3, 3, 2, 3, 3, 4, 4, 4),
+			     GROUP(
 		/* IP3_31_29 [3] */
 		FN_A20, FN_SPCLK, FN_VI1_R3, FN_VI1_R3_B, FN_VI2_G4,
 		0, 0, 0,
@@ -5082,10 +5086,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP3_3_0 [4] */
 		FN_A11, FN_SCIFB2_CTS_N_B, FN_MSIOF2_SCK, FN_VI1_R0,
 		FN_VI1_R0_B, FN_VI2_G0, FN_VI2_DATA3_VI2_B3_B, 0,
-		0, 0, 0, 0, 0, 0, 0, 0, }
+		0, 0, 0, 0, 0, 0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR4", 0xE6060030, 32,
-			     2, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3) {
+			     GROUP(2, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3),
+			     GROUP(
 		/* IP4_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP4_29_27 [3] */
@@ -5115,10 +5120,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_A22, FN_MISO_IO1, FN_VI1_R5, FN_VI1_R5_B, FN_VI2_G6, 0, 0, 0,
 		/* IP4_2_0 [3] */
 		FN_A21, FN_MOSI_IO0, FN_VI1_R4, FN_VI1_R4_B, FN_VI2_G5, 0, 0, 0,
-		}
+		))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR5", 0xE6060034, 32,
-			     2, 3, 3, 3, 3, 3, 2, 3, 4, 3, 3) {
+			     GROUP(2, 3, 3, 3, 3, 3, 2, 3, 4, 3, 3),
+			     GROUP(
 		/* IP5_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP5_29_27 [3] */
@@ -5152,10 +5158,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_INTC_EN0_N, FN_I2C1_SCL,
 		/* IP5_2_0 [3] */
 		FN_EX_CS3_N, FN_GPS_MAG, FN_VI3_FIELD, FN_VI1_G1, FN_VI1_G1_B,
-		FN_VI2_R3, 0, 0, }
+		FN_VI2_R3, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR6", 0xE6060038, 32,
-			     3, 3, 3, 3, 3, 3, 3, 2, 3, 3, 3) {
+			     GROUP(3, 3, 3, 3, 3, 3, 3, 2, 3, 3, 3),
+			     GROUP(
 		/* IP6_31_29 [3] */
 		FN_ETH_REF_CLK, 0, FN_HCTS0_N_E,
 		FN_STP_IVCXO27_1_B, FN_HRX0_F, 0, 0, 0,
@@ -5188,10 +5195,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_SSI_SDATA7_C, FN_SSI_SCK78_B, 0, 0, 0,
 		/* IP6_2_0 [3] */
 		FN_DACK0, FN_IRQ0, FN_INTC_IRQ0_N, FN_SSI_SCK6_B,
-		FN_VI1_VSYNC_N, FN_VI1_VSYNC_N_B, FN_SSI_WS78_C, 0, }
+		FN_VI1_VSYNC_N, FN_VI1_VSYNC_N_B, FN_SSI_WS78_C, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR7", 0xE606003C, 32,
-			     1, 2, 2, 2, 3, 3, 3, 3, 3, 2, 2, 3, 3) {
+			     GROUP(1, 2, 2, 2, 3, 3, 3, 3, 3, 2, 2, 3, 3),
+			     GROUP(
 		/* IP7_31 [1] */
 		0, 0,
 		/* IP7_30_29 [2] */
@@ -5223,11 +5231,12 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_ETH_TXD1, 0, FN_HTX0_F, FN_BPFCLK_G, 0, 0, 0, 0,
 		/* IP7_2_0 [3] */
 		FN_ETH_MDIO, 0, FN_HRTS0_N_E,
-		FN_SIM0_D_C, FN_HCTS0_N_F, 0, 0, 0, }
+		FN_SIM0_D_C, FN_HCTS0_N_F, 0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR8", 0xE6060040, 32,
-			     1, 2, 1, 1, 1, 2, 2, 2, 2, 2, 2,
-			     2, 2, 2, 2, 2, 2, 2) {
+			     GROUP(1, 2, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2,
+				   2, 2, 2, 2, 2, 2),
+			     GROUP(
 		/* IP8_31 [1] */
 		0, 0,
 		/* IP8_30_29 [2] */
@@ -5264,10 +5273,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP8_3_2 [2] */
 		FN_VI0_DATA2_VI0_B2, FN_ATAWR0_N, FN_AVB_RXD4, 0,
 		/* IP8_1_0 [2] */
-		FN_VI0_DATA1_VI0_B1, FN_ATARD0_N, FN_AVB_RXD3, 0, }
+		FN_VI0_DATA1_VI0_B1, FN_ATARD0_N, FN_AVB_RXD3, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR9", 0xE6060044, 32,
-			     4, 2, 2, 2, 2, 2, 2, 4, 4, 2, 2, 2, 2) {
+			     GROUP(4, 2, 2, 2, 2, 2, 2, 4, 4, 2, 2, 2, 2),
+			     GROUP(
 		/* IP9_31_28 [4] */
 		FN_SD1_CD, FN_MMC1_D6, FN_TS_SDEN1, FN_USB1_EXTP,
 		FN_GLO_SS, FN_VI0_CLK_B, FN_IIC2_SCL_D, FN_I2C2_SCL_D,
@@ -5299,10 +5309,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP9_3_2 [2] */
 		FN_SD0_DAT1, FN_SCIFB1_TXD_B, FN_VI1_DATA3_VI1_B3_B, 0,
 		/* IP9_1_0 [2] */
-		FN_SD0_DAT0, FN_SCIFB1_RXD_B, FN_VI1_DATA2_VI1_B2_B, 0, }
+		FN_SD0_DAT0, FN_SCIFB1_RXD_B, FN_VI1_DATA2_VI1_B2_B, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR10", 0xE6060048, 32,
-			     2, 4, 3, 4, 4, 4, 4, 3, 4) {
+			     GROUP(2, 4, 3, 4, 4, 4, 4, 3, 4),
+			     GROUP(
 		/* IP10_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP10_29_26 [4] */
@@ -5338,10 +5349,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP10_3_0 [4] */
 		FN_SD1_WP, FN_MMC1_D7, FN_TS_SPSYNC1, FN_USB1_IDIN,
 		FN_GLO_RFON, FN_VI1_CLK_B, FN_IIC2_SDA_D, FN_I2C2_SDA_D,
-		FN_SIM0_D_B, 0, 0, 0, 0, 0, 0, 0, }
+		FN_SIM0_D_B, 0, 0, 0, 0, 0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR11", 0xE606004C, 32,
-			     2, 3, 3, 2, 4, 3, 2, 2, 2, 2, 2, 1, 4) {
+			     GROUP(2, 3, 3, 2, 4, 3, 2, 2, 2, 2, 2, 1, 4),
+			     GROUP(
 		/* IP11_31_30 [2] */
 		FN_SSI_SCK0129, FN_CAN_CLK_B, FN_MOUT0, 0,
 		/* IP11_29_27 [3] */
@@ -5373,10 +5385,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP11_3_0 [4] */
 		FN_SD2_WP, FN_MMC0_D5, FN_TS_SCK0_B, FN_USB2_IDIN,
 		FN_GLO_I1, FN_VI0_DATA7_VI0_B7_B, FN_HRTS0_N_D,
-		FN_TS_SCK1_B, FN_GLO_I1_B, FN_VI3_DATA7_B, 0, 0, 0, 0, 0, 0, }
+		FN_TS_SCK1_B, FN_GLO_I1_B, FN_VI3_DATA7_B, 0, 0, 0, 0, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR12", 0xE6060050, 32,
-			     1, 3, 3, 2, 3, 3, 3, 3, 3, 2, 2, 2, 2) {
+			     GROUP(1, 3, 3, 2, 3, 3, 3, 3, 3, 2, 2, 2, 2),
+			     GROUP(
 		/* IP12_31 [1] */
 		0, 0,
 		/* IP12_30_28 [3] */
@@ -5412,10 +5425,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP12_3_2 [2] */
 		FN_SSI_SDATA0, FN_CAN0_RX_B, FN_MOUT2, 0,
 		/* IP12_1_0 [2] */
-		FN_SSI_WS0129, FN_CAN0_TX_B, FN_MOUT1, 0, }
+		FN_SSI_WS0129, FN_CAN0_TX_B, FN_MOUT1, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR13", 0xE6060054, 32,
-			     1, 2, 3, 3, 4, 3, 3, 3, 3, 4, 3) {
+			     GROUP(1, 2, 3, 3, 4, 3, 3, 3, 3, 4, 3),
+			     GROUP(
 		/* IP13_31 [1] */
 		0, 0,
 		/* IP13_30_29 [2] */
@@ -5448,10 +5462,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_BPFCLK_F, 0, 0, 0, 0, 0, 0, 0, 0,
 		/* IP13_2_0 [3] */
 		FN_SSI_SDATA5, FN_SCIFB1_TXD, FN_IETX_B, FN_DU2_DR2,
-		FN_LCDOUT2, FN_CAN_DEBUGOUT5, 0, 0, }
+		FN_LCDOUT2, FN_CAN_DEBUGOUT5, 0, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR14", 0xE6060058, 32,
-			     1, 3, 3, 3, 3, 3, 4, 3, 3, 3, 3) {
+			     GROUP(1, 3, 3, 3, 3, 3, 4, 3, 3, 3, 3),
+			     GROUP(
 		/* IP14_30 [1] */
 		0, 0,
 		/* IP14_30_28 [3] */
@@ -5486,10 +5501,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* IP14_2_0 [3] */
 		FN_AUDIO_CLKB, FN_SCIF_CLK, FN_CAN0_RX_D,
 		FN_DVC_MUTE, FN_CAN0_RX_C, FN_CAN_DEBUGOUT15,
-		FN_REMOCON, 0, }
+		FN_REMOCON, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR15", 0xE606005C, 32,
-			     2, 2, 2, 3, 3, 2, 2, 2, 2, 3, 3, 3, 3) {
+			     GROUP(2, 2, 2, 3, 3, 2, 2, 2, 2, 3, 3, 3, 3),
+			     GROUP(
 		/* IP15_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP15_29_28 [2] */
@@ -5521,10 +5537,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_IIC2_SCL, FN_I2C2_SCL, 0,
 		/* IP15_2_0 [3] */
 		FN_SCIFA2_SCK, FN_FMCLK, FN_SCK2, FN_MSIOF3_SCK, FN_DU2_DG7,
-		FN_LCDOUT15, FN_SCIF_CLK_B, 0, }
+		FN_LCDOUT15, FN_SCIF_CLK_B, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR16", 0xE6060160, 32,
-			     4, 4, 4, 4, 4, 4, 1, 1, 3, 3) {
+			     GROUP(4, 4, 4, 4, 4, 4, 1, 1, 3, 3),
+			     GROUP(
 		/* IP16_31_28 [4] */
 		0, 0, 0, 0, 0, 0, 0, 0,
 		0, 0, 0, 0, 0, 0, 0, 0,
@@ -5552,11 +5569,12 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_ADICS_SAMP, FN_DU2_CDE, FN_QPOLB, FN_SCIFA2_RXD_B, 0,
 		/* IP16_2_0 [3] */
 		FN_MSIOF0_SS2, FN_AUDIO_CLKOUT, FN_ADICHS2,
-		FN_DU2_DISP, FN_QPOLA, FN_HTX0_C, FN_SCIFA2_TXD_B, 0, }
+		FN_DU2_DISP, FN_QPOLA, FN_HTX0_C, FN_SCIFA2_TXD_B, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("MOD_SEL", 0xE6060090, 32,
-			     3, 2, 2, 3, 2, 1, 1, 1, 2, 1,
-			     2, 1, 1, 1, 1, 2, 1, 1, 2, 1, 1) {
+			     GROUP(3, 2, 2, 3, 2, 1, 1, 1, 2, 1, 2, 1,
+				   1, 1, 1, 2, 1, 1, 2, 1, 1),
+			     GROUP(
 		/* SEL_SCIF1 [3] */
 		FN_SEL_SCIF1_0, FN_SEL_SCIF1_1, FN_SEL_SCIF1_2, FN_SEL_SCIF1_3,
 		FN_SEL_SCIF1_4, 0, 0, 0,
@@ -5602,11 +5620,12 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* SEL_SOF3 [1] */
 		FN_SEL_SOF3_0, FN_SEL_SOF3_1,
 		/* SEL_SOF0 [1] */
-		FN_SEL_SOF0_0, FN_SEL_SOF0_1, }
+		FN_SEL_SOF0_0, FN_SEL_SOF0_1, ))
 	},
 	{ PINMUX_CFG_REG_VAR("MOD_SEL2", 0xE6060094, 32,
-			     3, 1, 1, 1, 2, 1, 2, 1, 2,
-			     1, 1, 1, 3, 3, 2, 3, 2, 2) {
+			     GROUP(3, 1, 1, 1, 2, 1, 2, 1, 2, 1, 1, 1,
+				   3, 3, 2, 3, 2, 2),
+			     GROUP(
 		/* RESERVED [3] */
 		0, 0, 0, 0, 0, 0, 0, 0,
 		/* SEL_TMU1 [1] */
@@ -5644,11 +5663,11 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		/* SEL_SIM [2] */
 		FN_SEL_SIM_0, FN_SEL_SIM_1, FN_SEL_SIM_2, 0,
 		/* SEL_SSI8 [2] */
-		FN_SEL_SSI8_0, FN_SEL_SSI8_1, FN_SEL_SSI8_2, 0, }
+		FN_SEL_SSI8_0, FN_SEL_SSI8_1, FN_SEL_SSI8_2, 0, ))
 	},
 	{ PINMUX_CFG_REG_VAR("MOD_SEL3", 0xE6060098, 32,
-			     1, 1, 2, 4, 4, 2, 2,
-			     4, 2, 3, 2, 3, 2) {
+			     GROUP(1, 1, 2, 4, 4, 2, 2, 4, 2, 3, 2, 3, 2),
+			     GROUP(
 		/* SEL_IICDVFS [1] */
 		FN_SEL_IICDVFS_0, FN_SEL_IICDVFS_1,
 		/* SEL_IIC0 [1] */
@@ -5679,7 +5698,7 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 		FN_SEL_I2C2_0, FN_SEL_I2C2_1, FN_SEL_I2C2_2, FN_SEL_I2C2_3,
 		FN_SEL_I2C2_4, 0, 0, 0,
 		/* SEL_I2C1 [2] */
-		FN_SEL_I2C1_0, FN_SEL_I2C1_1, FN_SEL_I2C1_2, 0, }
+		FN_SEL_I2C1_0, FN_SEL_I2C1_1, FN_SEL_I2C1_2, 0, ))
 	},
 	{ },
 };
drivers/pinctrl/renesas/pfc-r8a7791.c +90 -65

384 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a7792.c +71 -63

287 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a7794.c +72 -54

316 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a7795.c +88 -112

546 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a7796.c +104 -120

657 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a77965.c +180 -113

472 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a77970.c +62 -60

122 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a77990.c +107 -106

213 lines not on this page · raw message

drivers/pinctrl/renesas/pfc-r8a77995.c +65 -54

119 lines not on this page · raw message

drivers/pinctrl/renesas/sh_pfc.h +45 -26

71 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.21.0

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 3 lines · Eugeniu Rosca

In spite of the summary line, U-Boot commits [1-2] seem to have aligned the U-Boot PFC tables to Linux v5.1 rather than to v5.0, since they also imported the Linux 5.1 commits listed in [3].

Damn, I must've forgotten to update the commit message :-(

Quoted 5 lines

What current commit tries to accomplish is to align the Gen2 and Gen3 pinctrl tables to Linux v5.2-rc5. Importing these updates in two steps as done before (i.e. separately for Gen2 and Gen3) is somewhat difficult due to Linux commits like [5-6] which atomically update both Gen2/3 platforms and whose breakdown would not be easily possible.

Yep, the resync is no fun. Can we wait for 5.2 final with this ? I would very much like that, since it would align with 2019.07 release too.

Quoted 7 lines

The detailed list of Linux commits squashed into this U-Boot patch is shown in [4]. The second column in [4] depicts the patch id mismatch between the original Linux and the resulted U-Boot commit. The exclamation mark means that manual conflict resolution was involved during cherry picking Linux commit into U-Boot repository (this is mainly caused by dropped changes in files like pfc-r8a7795-es1.c and pfc-r8a77980.c which are missing in U-Boot).

Nice, thanks.

[...]

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Hi Marek,

On Mon, Jun 17, 2019 at 05:46:09PM +0200, Marek Vasut wrote:
[..]

Quoted 2 lines

Yep, the resync is no fun. Can we wait for 5.2 final with this ? I would very much like that, since it would align with 2019.07 release too.

Sure, thanks.

Signature · 2 lines
Best Regards,
Eugeniu.
#3 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 8 lines · Eugeniu Rosca

Hi Marek,

On Mon, Jun 17, 2019 at 05:46:09PM +0200, Marek Vasut wrote:
[..]

Quoted 2 lines

Yep, the resync is no fun. Can we wait for 5.2 final with this ? I would very much like that, since it would align with 2019.07 release too.

Sure, thanks.

I can leave it up to you to submit it again once 5.2 is out, so it won't get lost, right ?

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Eugeniu Rosca

Hi Marek,

On Mon, Jun 17, 2019 at 05:46:09PM +0200, Marek Vasut wrote:
[..]

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Yep, the resync is no fun. Can we wait for 5.2 final with this ? I would very much like that, since it would align with 2019.07 release too.

Sure, thanks.

I can leave it up to you to submit it again once 5.2 is out, so it won't get lost, right ?

v5.2 will likely be out in ~2-3 weeks from now.
I will resubmit the patch then, if you want it at the release boundary.

Signature · 2 lines
Best regards,
Eugeniu.
#5 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 9 lines · Eugeniu Rosca
Quoted 8 lines · Marek Vasut
Quoted 7 lines · Eugeniu Rosca

Hi Marek,

On Mon, Jun 17, 2019 at 05:46:09PM +0200, Marek Vasut wrote:
[..]

Quoted 2 lines

Yep, the resync is no fun. Can we wait for 5.2 final with this ? I would very much like that, since it would align with 2019.07 release too.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Sure, thanks.

I can leave it up to you to submit it again once 5.2 is out, so it won't get lost, right ?

v5.2 will likely be out in ~2-3 weeks from now.
I will resubmit the patch then, if you want it at the release boundary.

That's perfect, thanks.

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 4 lines · Marek Vasut
Quoted 2 lines

v5.2 will likely be out in ~2-3 weeks from now.
I will resubmit the patch then, if you want it at the release boundary.

That's perfect, thanks.

I wonder if the list of R-Car-relevant files kept in sync with Linux is documented anywhere? Is there anything else besides below?
- arch/arm/dts/
- include/dt-bindings/
- drivers/clk/renesas/
- drivers/pinctrl/

Signature · 2 lines
Best Regards,
Eugeniu.
#7 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 4 lines · Eugeniu Rosca
Quoted 3 lines · Marek Vasut
Quoted 2 lines

v5.2 will likely be out in ~2-3 weeks from now.
I will resubmit the patch then, if you want it at the release boundary.

Quoted 8 lines
Quoted 1 line

That's perfect, thanks.

I wonder if the list of R-Car-relevant files kept in sync with Linux is documented anywhere? Is there anything else besides below?
- arch/arm/dts/
- include/dt-bindings/
- drivers/clk/renesas/
- drivers/pinctrl/

That's it.

Also keep in mind that the U-Boot binary cannot grow over 1 MiB, that's a limit imposed by the flash layout, and we're getting close.

Signature · 2 lines
Best regards,
Marek Vasut
#8 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 2 lines · Marek Vasut

Also keep in mind that the U-Boot binary cannot grow over 1 MiB, that's a limit imposed by the flash layout, and we're getting close.

I hope enough space will be available in future for enabling such compile flags as -fsanitize=address and -fsanitize=undefined (known to be memory hungry), since these reveal real bugs which are hard to see with the naked eye [1].

[1] http://patchwork.ozlabs.org/patch/1090094/#2212555

Signature · 2 lines
Best Regards,
Eugeniu.
#9 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

In reply to Eugeniu Rosca

Jeremy, Stephen,
cc: Tom

FYI, another patchwork glitch is apparently showing up in
https://patchwork.ozlabs.org/patch/1117783/ , where none of the messages visible in https://marc.info/?t=156078655700002&r=1&w=4 is being rendered.

Quoted 3 lines · Eugeniu Rosca

In spite of the summary line, U-Boot commits [1-2] seem to have aligned the U-Boot PFC tables to Linux v5.1 rather than to v5.0, since they also imported the Linux 5.1 commits listed in [3].

[..]

Quoted 14 lines
---
 drivers/pinctrl/renesas/pfc-r8a7790.c  | 131 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7791.c  | 155 +++++++------
 drivers/pinctrl/renesas/pfc-r8a7792.c  | 134 +++++------
 drivers/pinctrl/renesas/pfc-r8a7794.c  | 126 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7795.c  | 200 ++++++++---------
 drivers/pinctrl/renesas/pfc-r8a7796.c  | 224 +++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77965.c | 293 +++++++++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77970.c | 122 +++++-----
 drivers/pinctrl/renesas/pfc-r8a77990.c | 213 +++++++++---------
 drivers/pinctrl/renesas/pfc-r8a77995.c | 119 +++++-----
 drivers/pinctrl/renesas/sh_pfc.h       |  71 +++---
 11 files changed, 959 insertions(+), 829 deletions(-)

[..]

Signature · 2 lines
Best Regards,
Eugeniu.
#10 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Quoted 7 lines · Eugeniu Rosca

Jeremy, Stephen,
cc: Tom

FYI, another patchwork glitch is apparently showing up in
https://patchwork.ozlabs.org/patch/1117783/ , where none of the messages visible in https://marc.info/?t=156078655700002&r=1&w=4 is being rendered.

Looking at [1], it seems this is base64 encoded. Did you send this with 'git-send-email' and, if so, did you do anything funky? I guess we could attempt to decode these, though that's arguably a new feature so I'm not sure if we could backport it to 'stable/2.1'. In any case, could you provide an mbox replete with all the headers so I can see if there are any heuristics we can use to identify these emails?

Stephen

[1] https://marc.info/?l=u-boot&m=156085461011871&q=mbox

Quoted 24 lines · Eugeniu Rosca
Quoted 3 lines

In spite of the summary line, U-Boot commits [1-2] seem to have aligned the U-Boot PFC tables to Linux v5.1 rather than to v5.0, since they also imported the Linux 5.1 commits listed in [3].

[..]

Quoted 14 lines
---
 drivers/pinctrl/renesas/pfc-r8a7790.c  | 131 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7791.c  | 155 +++++++------
 drivers/pinctrl/renesas/pfc-r8a7792.c  | 134 +++++------
 drivers/pinctrl/renesas/pfc-r8a7794.c  | 126 ++++++-----
 drivers/pinctrl/renesas/pfc-r8a7795.c  | 200 ++++++++---------
 drivers/pinctrl/renesas/pfc-r8a7796.c  | 224 +++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77965.c | 293 +++++++++++++++----------
 drivers/pinctrl/renesas/pfc-r8a77970.c | 122 +++++-----
 drivers/pinctrl/renesas/pfc-r8a77990.c | 213 +++++++++---------
 drivers/pinctrl/renesas/pfc-r8a77995.c | 119 +++++-----
 drivers/pinctrl/renesas/sh_pfc.h       |  71 +++---
 11 files changed, 959 insertions(+), 829 deletions(-)

[..]

#11 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Hi Stephen,

Many thanks for your feedback.

Quoted 10 lines · Stephen Finucane
Quoted 7 lines · Eugeniu Rosca

Jeremy, Stephen,
cc: Tom

FYI, another patchwork glitch is apparently showing up in
https://patchwork.ozlabs.org/patch/1117783/ , where none of the messages visible in https://marc.info/?t=156078655700002&r=1&w=4 is being rendered.

Looking at [1], it seems this is base64 encoded.

Is this concluded from the non-ASCII format of the mbox file returned by
https://marc.info? FWIW, my other U-Boot contributions look similar:
https://marc.info/?l=u-boot&m=155862561809782&q=mbox
https://marc.info/?l=u-boot&m=155680022731874&q=mbox

Nevertheless, patchwork didn't experience issues displaying the subsequent replies in those threads.

Quoted 2 lines

Did you send this with
'git-send-email' and, if so, did you do anything funky?

I did use 'git' to submit all the above patches passing the usual
parameters: git send-email --to A --to B --cc C my.patch.

FWIW, u-boot-bounces at lists.denx.de replied below to [1]:

-------8<------------
Your message to U-Boot awaits moderator approval
Your mail to 'U-Boot' with the subject
[PATCH] pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Is being held until the list moderator can review it for approval. The reason it is being held:
Message body is too big: 192878 bytes with a limit of 100 KB
Either the message will get posted to the list, or you will receive notification of the moderator's decision. If you would like to cancel this posting, please visit the following URL:
-------8<------------

Replicating the chronology of the issue, do you think it could be related to 1) the patch size or to 2) the moderator's approval event?

  +--------------+
  |1. Patch sent |
  +------+-------+
         |   
  +------v----------------------------------------+
  |2. U-Boot reports awaiting moderator's approval|
  |   (the patch does not show up in patchwork)   |
  +------+----------------------------------------+
         |   
  +------v-------------------------------+
  |3. Reply A (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-------------------------------+
  |4. Reply B (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-----------------------------+
  |5. Patch approved by moderator      |
  |   (the patch shows up in patchwork)|
  +------+-----------------------------+
         |   
  +------v---------------------------+
  |6. Reply C (rendered by patchwork)|
  +------+---------------------------+
         |
  +------v---------------------------+
  |7. Reply D (rendered by patchwork)|
  +----------------------------------+
Quoted 5 lines

I guess we
could attempt to decode these, though that's arguably a new feature so I'm not sure if we could backport it to 'stable/2.1'. In any case, could you provide an mbox replete with all the headers so I can see if there are any heuristics we can use to identify these emails?

Do you mean https://patchwork.ozlabs.org/patch/1117783/mbox/ ?

Quoted 4 lines

Stephen

[1] https://marc.info/?l=u-boot&m=156085461011871&q=mbox

Thanks again!

Signature · 2 lines
Best Regards,
Eugeniu.
#12 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Hi Eugeniu,

Quoted 24 lines

Replicating the chronology of the issue, do you think it could be related to 1) the patch size or to 2) the moderator's approval event?

  +--------------+
  |1. Patch sent |
  +------+-------+
         |   
  +------v----------------------------------------+
  |2. U-Boot reports awaiting moderator's approval|
  |   (the patch does not show up in patchwork)   |
  +------+----------------------------------------+
         |   
  +------v-------------------------------+
  |3. Reply A (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-------------------------------+
  |4. Reply B (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-----------------------------+
  |5. Patch approved by moderator      |
  |   (the patch shows up in patchwork)|
  +------+-----------------------------+
Quoted 8 lines
         |   
  +------v---------------------------+
  |6. Reply C (rendered by patchwork)|
  +------+---------------------------+
         |
  +------v---------------------------+
  |7. Reply D (rendered by patchwork)|
  +----------------------------------+

Ah, that would explain it. If an incoming email is not a patch, then patchwork will assume it is a follow-up to a patch, and try to find the relevant patch (through the References: and In-Reply-To headers). If no suitable patch is found, then patchwork does not save the email.

It sounds like that's what's happening here. Since reply A and reply B are referencing a patch that does not (yet) exist, then the comments are not kept.

The alternative would be to keep *every* submission to the list, in case a relevant patch arrives later...

Cheers,

Jeremy

Quoted 16 lines
Quoted 7 lines

I guess we
could attempt to decode these, though that's arguably a new feature so
I'm not sure if we could backport it to 'stable/2.1'. In any case, could you provide an mbox replete with all the headers so I can see if
there are any heuristics we can use to identify these emails?

Do you mean https://patchwork.ozlabs.org/patch/1117783/mbox/ ?

Quoted 3 lines

Stephen

[1] https://marc.info/?l=u-boot&m=156085461011871&q=mbox

Thanks again!

#13 lore raw

PATCH 1/1 pinctrl: renesas: Synchronize Gen2/Gen3 tables with Linux 5.2-rc5

Hi Jeremy,

Quoted 35 lines · Jeremy Kerr

Hi Eugeniu,

Quoted 24 lines

Replicating the chronology of the issue, do you think it could be related to 1) the patch size or to 2) the moderator's approval event?

  +--------------+
  |1. Patch sent |
  +------+-------+
         |   
  +------v----------------------------------------+
  |2. U-Boot reports awaiting moderator's approval|
  |   (the patch does not show up in patchwork)   |
  +------+----------------------------------------+
         |   
  +------v-------------------------------+
  |3. Reply A (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-------------------------------+
  |4. Reply B (not rendered by patchwork)|
  +------+-------------------------------+
         |   
  +------v-----------------------------+
  |5. Patch approved by moderator      |
  |   (the patch shows up in patchwork)|
  +------+-----------------------------+
Quoted 8 lines
         |   
  +------v---------------------------+
  |6. Reply C (rendered by patchwork)|
  +------+---------------------------+
         |
  +------v---------------------------+
  |7. Reply D (rendered by patchwork)|
  +----------------------------------+
Quoted 8 lines

Ah, that would explain it. If an incoming email is not a patch, then patchwork will assume it is a follow-up to a patch, and try to find the relevant patch (through the References: and In-Reply-To headers). If no suitable patch is found, then patchwork does not save the email.

It sounds like that's what's happening here. Since reply A and reply B are referencing a patch that does not (yet) exist, then the comments are not kept.

To be honest, that sounds like sensible behavior, but I wonder how marc.info (and presumably other front-ends) achieve to still display the replies sent/received at a point in time when the original patch is still expecting moderator's Ack.

Quoted 2 lines

The alternative would be to keep *every* submission to the list, in case a relevant patch arrives later...

Seems like this or similar solution is employed by https://marc.info/ ? My 2 cents is that it is more user-friendly and would definitely improve the patchwork as a tool if it displayed any replies which were submitted between the push of the original patch and the moderator's Ack of the latter.

Signature · 2 lines
Best Regards,
Eugeniu.