Skip to contentSkip to conversation

ath11k: fix extended stats update issue

PATCH In review Karthikeyan Periyasamy 3 participants 3 messages Jun 17, 2019 – Jun 18, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: fix extended stats update issue

user not able to see the valid tx stats. htt stats update process get failed due to the wrong argument pass to ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not the pdev index. so avoid the conversion logic of pdev id to pdev index in htt stats update process.

---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +0 -1
index 1d9892e..971c437 100644
@@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
 
 	len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
 	pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
-	pdev_id = DP_HW2SW_MACID(pdev_id);
 	ppdu_id = *((u32 *)data + 1);
 
 	rcu_read_lock();
Signature · 7 lines
1.9.1


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 7 lines · Karthikeyan Periyasamy

user not able to see the valid tx stats. htt stats update process get failed due to the wrong argument pass to ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not the pdev index. so avoid the conversion logic of pdev id to pdev index in htt stats update process.

Hi,

thanks, i just ran into this problem an hour ago :-)

    John

Quoted 9 lines
---
  drivers/net/wireless/ath/ath11k/dp_rx.c | 1 -
  1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +0 -0
index 1d9892e..971c437 100644

drivers/net/wireless/ath/ath11k/dp_rx.c static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab, · line 1299

Quoted 7 lines
drivers/net/wireless/ath/ath11k/dp_rx.c +0 -1
@@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
 
  	len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
  	pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
-	pdev_id = DP_HW2SW_MACID(pdev_id);
  	ppdu_id = *((u32 *)data + 1);
 
  	rcu_read_lock();

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k

#2 lore raw
In reply to Karthikeyan Periyasamy
Quoted 8 lines · Karthikeyan Periyasamy

user not able to see the valid tx stats. htt stats update process get failed due to the wrong argument pass to ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not the pdev index. so avoid the conversion logic of pdev id to pdev index in htt stats update process.

Patch applied to ath11k-bringup branch of ath.git, thanks.

b24d6461d9cf ath11k: fix extended stats update issue

Signature · 9 lines
https://patchwork.kernel.org/patch/10999267/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k