ipv6: Default fib6_type to RTN_UNICAST when not set
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Default fib6_type to RTN_UNICAST when not set
From: David Ahern <[email protected]>
A user reported that routes are getting installed with type 0 (RTN_UNSPEC) where before the routes were RTN_UNICAST. One example is from accel-ppp which apparently still uses the ioctl interface and does not set rtmsg_type. Another is the netlink interface where ipv6 does not require rtm_type to be set (v4 does). Prior to the commit in the Fixes tag the ipv6 stack converted type 0 to RTN_UNICAST, so restore that behavior.
--- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/route.c +1 -1
@@ -3184,7 +3184,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg, rt->fib6_table = table; rt->fib6_metric = cfg->fc_metric; - rt->fib6_type = cfg->fc_type; + rt->fib6_type = cfg->fc_type ? :RTN_UNICAST ; rt->fib6_flags = cfg->fc_flags & ~RTF_GATEWAY ;ipv6_addr_prefix (&rt->fib6_dst.addr, &cfg->fc_dst, cfg->fc_dst_len);
Signature · 1 line
2.11.0
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Wed, 19 Jun 2019 10:50:24 -0700
Quoted 11 lines
From: David Ahern <[email protected]>
A user reported that routes are getting installed with type 0 (
RTN_UNSPEC) where before the routes wereRTN_UNICAST. One example is from accel-ppp which apparently still uses the ioctl interface and does not setrtmsg_type. Another is the netlink interface where ipv6 does not requirertm_typeto be set (v4 does). Prior to the commit in the Fixes tag the ipv6 stack converted type 0 toRTN_UNICAST, so restore that behavior.Fixes e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")Signed-off-by David Ahern <[email protected]>
Applied and queued up for -stable, thanks David.