i40e: Add macvlan support on i40e
Subsystems (2)
PATCH v6 1/1 i40e: Add macvlan support on i40e
This patch enables macvlan offloads for i40e. The idea is to use channels as macvlan interfaces. The channels are VSIs of type VMDQ. When the first macvlan is created, the maximum number of channels possible are created. From then on, as a macvlan interface is created, a macvlan filter is added to these already created channels (VSIs).
This patch utilizes subordinate device traffic classes to make queue groups(channels) available for an upper device like a macvlan.
Steps to configure macvlan offloads:
1. ethtool -K ethx l2-fwd-offload on
2. ip link add link ethx name macvlan1 type macvlan
3. ip addr add <address> dev macvlan1
4. ip link set macvlan1 up
---
v6: Fixed a bug in calculation of macvlans to enable when there are
smaller number of vectors
v5: updated patch description based on community feedback
v4: Added code to check for a non-empty list of macvlans before deleting
them
v3: Renamed i40e_remove_macvlan_channels() to
i40e_free_macvlan_channels()
Fixed an indentation issue and added some comments Removed a code name from the commit message Addressed some more of Shannon's comments
v2: Addressed Shannon's comments
Added a new function to remove all macvlan VSIs
drivers/net/ethernet/intel/i40e/i40e.h | 27 ++ drivers/net/ethernet/intel/i40e/i40e_main.c | 491 +++++++++++++++++++- 2 files changed, 516 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +27 -0
@@ -27,6 +27,7 @@#include <net/ip6_checksum.h> #include <linux/ethtool.h> #include <linux/if_vlan.h> +#include <linux/if_macvlan.h> #include <linux/if_bridge.h> #include <linux/clocksource.h> #include <linux/net_tstamp.h>
@@ -412,6 +413,11 @@ struct i40e_flex_pit {u8 pit_index; }; +struct i40e_fwd_adapter { +struct net_device *netdev; +int bit_no; +}; +struct i40e_channel {struct list_head list;bool initialized;
@@ -426,11 +432,25 @@ struct i40e_channel {struct i40e_aqc_vsi_properties_data info;u64 max_tx_rate; +struct i40e_fwd_adapter *fwd;/* track this channel belongs to which VSI */ struct i40e_vsi *parent_vsi; }; +static inline bool i40e_is_channel_macvlan (struct i40e_channel *ch) +{ +return !!ch->fwd; +} + +static inline u8 *i40e_channel_mac (struct i40e_channel *ch) +{ +if (i40e_is_channel_macvlan (ch)) +return ch->fwd->netdev->dev_addr; +else +return NULL ; +} +/* struct that defines the Ethernet device */ struct i40e_pf {struct pci_dev *pdev;
@@ -813,6 +833,13 @@ struct i40e_vsi {struct list_head ch_list;u16 tc_seid_map[I40E_MAX_TRAFFIC_CLASS ]; +/* macvlan fields */ +#define I40E_MAX_MACVLANS 128/* Max HW vectors - 1 on FVL */ +#define I40E_MIN_MACVLAN_VECTORS 2/* Min vectors to enable macvlans */ +DECLARE_BITMAP (fwd_bitmask,I40E_MAX_MACVLANS ); +struct list_head macvlan_list; +int macvlan_cnt; +void *priv;/* client driver data reference. */ /* VSI specific handlers */
drivers/net/ethernet/intel/i40e/i40e_main.c +489 -2
521 lines not on this page · raw message
Signature · 1 line
2.17.1
Bowers
PATCH v6 1/1 i40e: Add macvlan support on i40e
Quoted 38 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Harshitha Ramamurthy
Sent: Wednesday, June 19, 2019 11:46 AM
To: intel-wired-lan at lists.osuosl.org
Cc: harshitha.ramamurthy at gmail.com
Subject: [Intel-wired-lan] [PATCH v6] i40e: Add macvlan support on i40eThis patch enables macvlan offloads for i40e. The idea is to use channels as macvlan interfaces. The channels are VSIs of type VMDQ. When the first macvlan is created, the maximum number of channels possible are created. From then on, as a macvlan interface is created, a macvlan filter is added to these already created channels (VSIs).
This patch utilizes subordinate device traffic classes to make queue groups(channels) available for an upper device like a macvlan.
Steps to configure macvlan offloads:
1. ethtool -K ethx l2-fwd-offload on
2. ip link add link ethx name macvlan1 type macvlan 3. ip addr add <address> dev macvlan1 4. ip link set macvlan1 upSigned-off-by Harshitha Ramamurthy <[email protected]>---
v6: Fixed a bug in calculation of macvlans to enable when there are
smaller number of vectorsv5: updated patch description based on community feedback
v4: Added code to check for a non-empty list of macvlans before deleting
themv3: Renamed
i40e_remove_macvlan_channels()to
i40e_free_macvlan_channels()
Fixed an indentation issue and added some comments Removed a code name from the commit message Addressed some more of Shannon's comments
Quoted 6 lines
v2: Addressed Shannon's comments
Added a new function to remove all macvlan VSIsdrivers/net/ethernet/intel/i40e/i40e.h | 27 ++ drivers/net/ethernet/intel/i40e/i40e_main.c | 491 +++++++++++++++++++- 2 files changed, 516 insertions(+), 2 deletions(-)