Skip to contentSkip to conversation

treewide: remove CONFIG_DEBUG_INFO from defconfigs

PATCH In review Antony Pavlov 4 participants 6 messages Jun 20, 2019 – Jul 1, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 treewide: remove CONFIG_DEBUG_INFO from defconfigs

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

---

Changes since v1:

* drop out-of-tree arch/riscv/configs/qemu-sifive-u500_defconfig changes.

 arch/arm/configs/a9m2410_defconfig                   | 1 -
 arch/arm/configs/a9m2440_defconfig                   | 1 -
 arch/arm/configs/cfa10036_defconfig                  | 1 -
 arch/arm/configs/chumbyone_defconfig                 | 1 -
 arch/arm/configs/duckbill_defconfig                  | 1 -
 arch/arm/configs/freescale-mx23-evk_defconfig        | 1 -
 arch/arm/configs/freescale-mx28-evk_defconfig        | 1 -
 arch/arm/configs/freescale-mx53-smd_defconfig        | 1 -
 arch/arm/configs/friendlyarm_mini2440_defconfig      | 1 -
 arch/arm/configs/friendlyarm_mini6410_defconfig      | 1 -
 arch/arm/configs/friendlyarm_tiny6410_defconfig      | 1 -
 arch/arm/configs/imx233-olinuxino_defconfig          | 1 -
 arch/arm/configs/lubbock_defconfig                   | 1 -
 arch/arm/configs/mainstone_defconfig                 | 1 -
 arch/arm/configs/microchip_ksz9477_evb_defconfig     | 1 -
 arch/arm/configs/mioa701_defconfig                   | 1 -
 arch/arm/configs/omap3430_sdp3430_per_uart_defconfig | 1 -
 arch/arm/configs/omap_defconfig                      | 1 -
 arch/arm/configs/phytec-phycore-pxa270_defconfig     | 1 -
 arch/arm/configs/qemu_virt64_defconfig               | 1 -
 arch/arm/configs/rk3288_defconfig                    | 1 -
 arch/arm/configs/sama5d4_xplained_defconfig          | 1 -
 arch/arm/configs/sama5d4ek_defconfig                 | 1 -
 arch/arm/configs/socfpga-arria10_defconfig           | 1 -
 arch/arm/configs/tqma53_defconfig                    | 1 -
 arch/arm/configs/tx28stk5_defconfig                  | 1 -
 arch/arm/configs/zedboard_defconfig                  | 1 -
 arch/arm/configs/zylonite310_defconfig               | 1 -
 arch/mips/configs/loongson-ls1b_defconfig            | 1 -
 arch/mips/configs/qemu-malta_defconfig               | 1 -
 arch/sandbox/configs/sandbox_defconfig               | 1 -
 arch/x86/configs/efi_defconfig                       | 1 -
 arch/x86/configs/generic_defconfig                   | 1 -
 33 files changed, 33 deletions(-)
arch/arm/configs/a9m2410_defconfig +0 -1
index 44d1edfc03..ea70a121af 100644
@@ -8,7 +8,6 @@ CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/a9m2410/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/a9m2440_defconfig +0 -1
index d1ae580571..5843d29d7f 100644
@@ -10,7 +10,6 @@ CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/a9m2440/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/cfa10036_defconfig +0 -1
index 2283658364..c34af8319a 100644
@@ -14,7 +14,6 @@ CONFIG_BOOTM_OFTREE=y
 CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/crystalfontz-cfa10036/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_GO=y
 CONFIG_CMD_RESET=y
arch/arm/configs/chumbyone_defconfig +0 -1
index bb7473fc89..2b38b8cf88 100644
@@ -10,7 +10,6 @@ CONFIG_HUSH_FANCY_PROMPT=y
 CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/chumby_falconwing/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/duckbill_defconfig +0 -1
index 28ea405fe1..6f80e15bb8 100644
@@ -21,7 +21,6 @@ CONFIG_BOOTM_INITRD=y
 CONFIG_BLSPEC=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/freescale-mx23-evk_defconfig +0 -1
index 3dc8cc46a2..2b12e297b3 100644
@@ -5,7 +5,6 @@ CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_RESET=y
 CONFIG_CMD_PARTITION=y
arch/arm/configs/freescale-mx28-evk_defconfig +0 -1
index 6c0bb02891..03457a4a95 100644
@@ -20,7 +20,6 @@ CONFIG_BOOTM_INITRD=y
 CONFIG_BLSPEC=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/freescale-mx53-smd_defconfig +0 -1
index 4677e07099..b292b972a3 100644
@@ -19,7 +19,6 @@ CONFIG_BOOTM_INITRD=y
 CONFIG_BOOTM_OFTREE=y
 CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/friendlyarm_mini2440_defconfig +0 -1
index 19a5a4ed3d..1b2c363f51 100644
@@ -10,7 +10,6 @@ CONFIG_GLOB=y
 CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/friendlyarm-mini2440/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/friendlyarm_mini6410_defconfig +0 -1
index 209e3f8bf6..8beee6f194 100644
@@ -8,7 +8,6 @@ CONFIG_AUTO_COMPLETE=y
 CONFIG_BOOTM_SHOW_TYPE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/friendlyarm_tiny6410_defconfig +0 -1
index 85ae78129f..12dbea1317 100644
@@ -9,7 +9,6 @@ CONFIG_AUTO_COMPLETE=y
 CONFIG_BOOTM_SHOW_TYPE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_GO=y
arch/arm/configs/imx233-olinuxino_defconfig +0 -1
index 47d485b4e9..d683c8f9de 100644
@@ -24,7 +24,6 @@ CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_COMPRESSION_LZO=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/lubbock_defconfig +0 -1
index a45d723879..9f4f904235 100644
@@ -24,7 +24,6 @@ CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/lubbock/env"
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/mainstone_defconfig +0 -1
index c8e4f780a6..80e72b27ab 100644
@@ -25,7 +25,6 @@ CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/mainstone/env"
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/microchip_ksz9477_evb_defconfig +0 -1
index e7d05bd13b..4189b2c039 100644
@@ -16,7 +16,6 @@ CONFIG_BOOTM_OFTREE=y
 CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_CONSOLE_ALLOW_COLOR=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/arm/configs/mioa701_defconfig +0 -1
index 99430112ff..a786d1618e 100644
@@ -24,7 +24,6 @@ CONFIG_BOOTM_OFTREE=y
 CONFIG_FLEXIBLE_BOOTARGS=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/mioa701/env"
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/omap3430_sdp3430_per_uart_defconfig +0 -1
index 1c30933261..1944340516 100644
@@ -6,7 +6,6 @@ CONFIG_SHELL_SIMPLE=y
 # CONFIG_ERRNO_MESSAGES is not set
 # CONFIG_TIMESTAMP is not set
 # CONFIG_DEFAULT_ENVIRONMENT is not set
-CONFIG_DEBUG_INFO=y
 # CONFIG_CMD_HELP is not set
 # CONFIG_CMD_BOOTM is not set
 CONFIG_CMD_GO=y
arch/arm/configs/omap_defconfig +0 -1
index 8615283453..10305b27aa 100644
@@ -34,7 +34,6 @@ CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_STATE=y
 CONFIG_BOOTCHOOSER=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/phytec-phycore-pxa270_defconfig +0 -1
index ed1116940b..370902c3c1 100644
@@ -19,7 +19,6 @@ CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/phytec-phycore-pxa270/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/qemu_virt64_defconfig +0 -1
index 9b7e11ff73..557ac1ffbe 100644
@@ -11,7 +11,6 @@ CONFIG_AUTO_COMPLETE=y
 CONFIG_MENU=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_BOOTU is not set
arch/arm/configs/rk3288_defconfig +0 -1
index 15e6c15a03..3f956519d0 100644
@@ -24,7 +24,6 @@ CONFIG_CONSOLE_ACTIVATE_NONE=y
 CONFIG_DEFAULT_COMPRESSION_LZO=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_LL=y
 CONFIG_DEBUG_ROCKCHIP_UART_PORT=2
 CONFIG_CMD_DMESG=y
arch/arm/configs/sama5d4_xplained_defconfig +0 -1
index 648c813c49..d20239cd94 100644
@@ -22,7 +22,6 @@ CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/sama5d4_xplained/env"
-CONFIG_DEBUG_INFO=y
 # CONFIG_CMD_ARM_CPUINFO is not set
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/sama5d4ek_defconfig +0 -1
index 2aa38baf87..881836e3c5 100644
@@ -21,7 +21,6 @@ CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_CONSOLE_ACTIVATE_ALL=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/sama5d4ek/env"
-CONFIG_DEBUG_INFO=y
 # CONFIG_CMD_ARM_CPUINFO is not set
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/socfpga-arria10_defconfig +0 -1
index 53e932d64b..bbaef311ff 100644
@@ -21,7 +21,6 @@ CONFIG_DEFAULT_COMPRESSION_LZO=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_POLLER=y
 CONFIG_STATE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/tqma53_defconfig +0 -1
index f2025c8326..e5e4d60de5 100644
@@ -23,7 +23,6 @@ CONFIG_BOOTM_OFTREE_UIMAGE=y
 CONFIG_BLSPEC=y
 CONFIG_CONSOLE_ACTIVATE_NONE=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/tx28stk5_defconfig +0 -1
index 504501524a..f717a16f87 100644
@@ -24,7 +24,6 @@ CONFIG_PBL_CONSOLE=y
 CONFIG_DEFAULT_COMPRESSION_LZO=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_LL=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
arch/arm/configs/zedboard_defconfig +0 -1
index bcd604f341..cc03368751 100644
@@ -17,7 +17,6 @@ CONFIG_BOOTM_INITRD=y
 CONFIG_BOOTM_OFTREE=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/avnet-zedboard/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_LL=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
arch/arm/configs/zylonite310_defconfig +0 -1
index f1cd92af84..e81566565b 100644
@@ -26,7 +26,6 @@ CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/zylonite/env"
 CONFIG_RESET_SOURCE=y
 CONFIG_DEFAULT_LOGLEVEL=8
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/mips/configs/loongson-ls1b_defconfig +0 -1
index 25444e373e..b800f95c5c 100644
@@ -14,7 +14,6 @@ CONFIG_PARTITION=y
 # CONFIG_DEFAULT_ENVIRONMENT is not set
 CONFIG_POLLER=y
 CONFIG_RESET_SOURCE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
 CONFIG_CMD_MEMINFO=y
arch/mips/configs/qemu-malta_defconfig +0 -1
index 69c7b0b10a..ea49e37553 100644
@@ -13,7 +13,6 @@ CONFIG_CONSOLE_ALLOW_COLOR=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_POLLER=y
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/sandbox/configs/sandbox_defconfig +0 -1
index 68fe40f40a..f8341644b4 100644
@@ -6,7 +6,6 @@ CONFIG_PARTITION=y
 CONFIG_DEFAULT_COMPRESSION_GZIP=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/sandbox/board/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_CMD_DMESG=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IMD=y
arch/x86/configs/efi_defconfig +0 -1
index f489770eba..dab299fa5e 100644
@@ -16,7 +16,6 @@ CONFIG_PARTITION_DISK_EFI=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_POLLER=y
 CONFIG_STATE=y
-CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_LL=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_IOMEM=y
arch/x86/configs/generic_defconfig +0 -1
index 3b94e02a7e..4620280136 100644
@@ -7,7 +7,6 @@ CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_PARTITION=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/x86/boards/x86_generic/env"
-CONFIG_DEBUG_INFO=y
 CONFIG_LONGHELP=y
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_BOOTM is not set
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Hi Antony

Quoted 7 lines · Antony Pavlov

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

Another approach could be to regenerate all defconfigs. A little scripting around savedefconfig should do it.

Then we would get rid of all obsolete symbols in one go - for all defconfigs.

The generated defconfig would be the one that people would be using anyway, so there should be only a little risk to introduce new issues doing it this way.

Willing to try this approcah - maybe across all architectures?

Sam

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

maintainer
#2 lore raw
Quoted 13 lines · Sam Ravnborg

Hi Antony

Quoted 7 lines · Antony Pavlov

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

Another approach could be to regenerate all defconfigs. A little scripting around savedefconfig should do it.

Quoted 8 lines

Then we would get rid of all obsolete symbols in one go - for all defconfigs.

The generated defconfig would be the one that people would be using anyway, so there should be only a little risk to introduce new issues doing it this way.

Willing to try this approcah - maybe across all architectures?

I once thought the same and came up with this little thing:

#!/bin/bash

for a in arch/*; do

        arch=$(basename $a)
        for c in $a/configs/*; do
                config=$(basename $c)
		export ARCH=$arch
		make $config && make savedefconfig && mv defconfig $c
        done

done

Just tested, still works. Maybe I should just run this from time to time and commit the result. What do you think?

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw
Quoted 17 lines · On Thu, 20 Jun 2019 16:29:45 +0200 Sascha Hauer <[email protected]> wrote:
Quoted 16 lines · Sam Ravnborg

Hi Antony

Quoted 7 lines · Antony Pavlov

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

Another approach could be to regenerate all defconfigs. A little scripting around savedefconfig should do it.

Then we would get rid of all obsolete symbols in one go - for all defconfigs.

Quoted 7 lines
Quoted 5 lines

The generated defconfig would be the one that people would be using anyway, so there should be only a little risk to introduce new issues doing it this way.

Willing to try this approcah - maybe across all architectures?

I once thought the same and came up with this little thing:

Hi!

I propose to add two error handling features:

Quoted 2 lines

#!/bin/bash

add 'set -e' here (or just use 'bash -e')

The -e option means "if any script command ever ends with a non-zero ('error') exit status, terminate the script immediately".

Quoted 7 lines

for a in arch/*; do

        arch=$(basename $a)
        for c in $a/configs/*; do
                config=$(basename $c)
		export ARCH=$arch
		make $config && make savedefconfig && mv defconfig $c

add 'echo $config' or use 'mv -i' instead of 'mv'. It is reasonable to see which config file processing lead to error situation.

Quoted 5 lines

done
done

Just tested, still works. Maybe I should just run this from time to time and commit the result. What do you think?

Signature · 7 lines
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#4 lore raw
In reply to Sascha Hauer

Hi Sascha.

Quoted 34 lines · Sascha Hauer
Quoted 13 lines · Sam Ravnborg

Hi Antony

Quoted 7 lines · Antony Pavlov

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

Another approach could be to regenerate all defconfigs. A little scripting around savedefconfig should do it.

Quoted 8 lines

Then we would get rid of all obsolete symbols in one go - for all defconfigs.

The generated defconfig would be the one that people would be using anyway, so there should be only a little risk to introduce new issues doing it this way.

Willing to try this approcah - maybe across all architectures?

I once thought the same and came up with this little thing:

#!/bin/bash

for a in arch/*; do

        arch=$(basename $a)
        for c in $a/configs/*; do
                config=$(basename $c)
		export ARCH=$arch
		make $config && make savedefconfig && mv defconfig $c
        done
Quoted 4 lines

done

Just tested, still works. Maybe I should just run this from time to time and commit the result. What do you think?

Me like.
Much better than removing individual CONFIG symbols. The diff is not scary:

84 files changed, 38 insertions(+), 129 deletions(-)

Maybe part of your release scripts - then you could evaluate if the changes are worth it?

Or maybe add the script to barebox so anyone could do it, when they want to get rid of a symbol.
that would be better than sed scripts.
Actually I like the latter idea the best, then we could better distribute the task and let anyone do it.
I'm a bit occupied, so hope someone else jumps to do it.

Sam

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#5 lore raw
In reply to Sascha Hauer
Quoted 35 lines · Sascha Hauer
Quoted 13 lines · Sam Ravnborg

Hi Antony

Quoted 7 lines · Antony Pavlov

The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") has dropped Kconfig DEBUG_INFO option however we still have very many DEBUG_INFO mentions in defconfig files. Drop them using sed:

  find -iname '*defconfig' -type f -exec \
      sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'

Another approach could be to regenerate all defconfigs. A little scripting around savedefconfig should do it.

Quoted 8 lines

Then we would get rid of all obsolete symbols in one go - for all defconfigs.

The generated defconfig would be the one that people would be using anyway, so there should be only a little risk to introduce new issues doing it this way.

Willing to try this approcah - maybe across all architectures?

I once thought the same and came up with this little thing:

#!/bin/bash

for a in arch/*; do

        arch=$(basename $a)
        for c in $a/configs/*; do
                config=$(basename $c)
                export ARCH=$arch
                make $config && make savedefconfig && mv defconfig $c
        done
Quoted 4 lines

done

Just tested, still works. Maybe I should just run this from time to time and commit the result. What do you think?

U-Boot does this every release.

Linux does not do this much,
but it depends on the arch maintainer.
(I sometimes saw this re-sync for arm64)

Personally, I do not want to see savedefconfig much. Even without sorting, "make defconfig" still produces the same .config file.
It is a boundary of "clean-up" and "just a noise commit".

In summary, it is up to you since you are the maintainer.

Signature · 7 lines
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox