Add SPDX identifiers
PATCH 1/1 Add SPDX identifiers
From: Yegor Yefremov <[email protected]>
Software Package Data Exchange identifiers help to detect source file licenses and hence simplify the FOSS compliance process.
--- ap.c | 2 ++ bitrate.c | 2 ++ bloom.c | 2 ++ coalesce.c | 2 ++ connect.c | 2 ++ cqm.c | 2 ++ event.c | 2 ++ ftm.c | 2 ++ genl.c | 2 ++ hwsim.c | 2 ++ ibss.c | 2 ++ ieee80211.h | 2 ++ info.c | 2 ++ interface.c | 2 ++ iw.c | 2 ++ iw.h | 2 ++ link.c | 2 ++ measurements.c | 2 ++ mesh.c | 2 ++ mgmt.c | 2 ++ mpath.c | 2 ++ mpp.c | 2 ++ nan.c | 2 ++ nl80211.h | 2 ++ ocb.c | 2 ++ offch.c | 2 ++ p2p.c | 2 ++ phy.c | 2 ++ ps.c | 2 ++ reason.c | 2 ++ reg.c | 2 ++ roc.c | 2 ++ scan.c | 2 ++ sections.c | 2 ++ sha256.c | 2 ++ sha256.h | 2 ++ station.c | 2 ++ status.c | 2 ++ survey.c | 2 ++ util.c | 2 ++ vendor.c | 2 ++ wowlan.c | 2 ++ 42 files changed, 84 insertions(+)
ap.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <netlink/genl/genl.h> #include <netlink/genl/family.h>
bitrate.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include "nl80211.h"
bloom.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <inttypes.h> #include "iw.h"
coalesce.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h> #include <stdio.h>
connect.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <netlink/genl/genl.h>
cqm.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <netlink/genl/genl.h>
event.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <stdint.h> #include <stdbool.h> #include <net/if.h>
ftm.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <netlink/genl/genl.h>
genl.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +/* * This ought to be provided by libnl */
hwsim.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
ibss.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h> #include <strings.h>
ieee80211.h +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#ifndef __IEEE80211#define __IEEE80211
info.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <stdbool.h> #include <netlink/genl/genl.h>
interface.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h> #include <stdbool.h>
iw.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +/* * nl80211 userspace tool *
iw.h +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#ifndef __IW_H#define __IW_H
link.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h> #include <string.h>
measurements.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include "nl80211.h"
mesh.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
mgmt.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <string.h> #include <errno.h>
mpath.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h> #include <string.h>
mpp.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h>
nan.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h> #include <string.h>
nl80211.h +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#ifndef __LINUX_NL80211_H#define __LINUX_NL80211_H/*
ocb.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
offch.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <netlink/genl/genl.h>
p2p.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <netlink/genl/genl.h> #include <netlink/genl/family.h> #include <netlink/genl/ctrl.h>
phy.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <stdbool.h> #include <errno.h> #include <strings.h>
ps.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
reason.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <stdint.h> #include "iw.h"
reg.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h> #include <stdbool.h>
roc.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
scan.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h> #include <string.h>
sections.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include "iw.h" SECTION (get);
sha256.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include "sha256.h" /**
sha256.h +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#ifndef SHA256 #define SHA256
station.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <errno.h> #include <string.h>
status.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <stdint.h> #include "iw.h"
survey.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <net/if.h> #include <netlink/genl/genl.h>
util.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <ctype.h> #include <netlink/attr.h> #include <errno.h>
vendor.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h>
wowlan.c +2 -0
@@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: ISC */ +#include <errno.h> #include <string.h> #include <stdio.h>
Signature · 1 line
2.17.0
Quoted 6 lines · [email protected] writes:
From: Yegor Yefremov <[email protected]>
Software Package Data Exchange identifiers help to detect source file licenses and hence simplify the FOSS compliance process.
Signed-off-by Yegor Yefremov <[email protected]>
For patches to iw it's good practise to prefix the title with "iw: ", that way people can immediately see for which component it is. But no need to resend because of this.
Signature · 1 line
Kalle Valo
Quoted 4 lines · On Thu, 2019-06-20 at 15:01 +0200, [email protected] wrote:
From: Yegor Yefremov <[email protected]>
Software Package Data Exchange identifiers help to detect source file licenses and hence simplify the FOSS compliance process.
Well that's nice and all, but it's also wrong.
You haven't included any documentation that says what the SPDX identifier, and specifically the "ISC" tag means in the context of the project, and it's not even the same license text as on spdx.org.
johannes
Quoted 4 lines · Johannes Berg
Quoted 2 lines · On Thu, 2019-06-20 at 15:01 +0200, [email protected] wrote:
From: Yegor Yefremov <[email protected]>
Quoted 8 lines
Quoted 2 lines
Software Package Data Exchange identifiers help to detect source file licenses and hence simplify the FOSS compliance process.
Well that's nice and all, but it's also wrong.
You haven't included any documentation that says what the SPDX identifier, and specifically the "ISC" tag means in the context of the project, and it's not even the same license text as on spdx.org.
What about such definition?
SPDX short-form identifiers provide information about licenses that apply to the source file.
As for the exact license I wasn't sure myself. Buildroot identifies it as ISC [1]. How do you define its license in SPDX terms?
[1] https://git.busybox.net/buildroot/tree/package/iw/iw.mk
Yegor
Quoted 9 lines
Quoted 4 lines
You haven't included any documentation that says what the SPDX identifier, and specifically the "ISC" tag means in the context of the project, and it's not even the same license text as on spdx.org.
What about such definition?
SPDX short-form identifiers provide information about licenses that apply to the source file.
It just bothers me that this isn't self-contained - you always have to go to spdx.org to really figure out what it means.
Quoted 2 lines
As for the exact license I wasn't sure myself. Buildroot identifies it as ISC [1]. How do you define its license in SPDX terms?
Not sure. Maybe you cannot?
spdx.org says "ISC" is the license that says:
[...] THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS [...]
while the license here says:
[...] THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS [...]
(and the same in one other place)
This might just be an oversight on spdx.org, since the license with "THE AUTHOR" *is* typically referred to as "ISC" (e.g.
https://opensource.org/licenses/ISC), but it still means it's not actually identical?
Maybe spdx.org should switch, but then it changing the license text ... what if anyone refers to it already?
It's all not very obvious to me.
The kernel side-stepped it and said "let's make it all self-contained", which seems saner to me.
johannes
Quoted 35 lines · Johannes Berg
Quoted 10 lines
Quoted 5 lines
You haven't included any documentation that says what the SPDX identifier, and specifically the "ISC" tag means in the context of the project, and it's not even the same license text as on spdx.org.
What about such definition?
SPDX short-form identifiers provide information about licenses that apply to the source file.
It just bothers me that this isn't self-contained - you always have to go to spdx.org to really figure out what it means.
Quoted 2 lines
As for the exact license I wasn't sure myself. Buildroot identifies it as ISC [1]. How do you define its license in SPDX terms?
Not sure. Maybe you cannot?
spdx.org says "ISC" is the license that says:
[...] THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS [...]
while the license here says:
[...] THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS [...]
(and the same in one other place)
This might just be an oversight on spdx.org, since the license with "THE AUTHOR" *is* typically referred to as "ISC" (e.g.
https://opensource.org/licenses/ISC), but it still means it's not actually identical?
Quoted 7 lines
Maybe spdx.org should switch, but then it changing the license text ... what if anyone refers to it already?
It's all not very obvious to me.
The kernel side-stepped it and said "let's make it all self-contained", which seems saner to me.
I have asked SPDX and this is their answer:
https://lists.spdx.org/g/Spdx-legal/message/2631
Quoted 3 lines · Yegor Yefremov
I have asked SPDX and this is their answer:
https://lists.spdx.org/g/Spdx-legal/message/2631
Alright, thanks. I guess I can apply that then.
johannes
Quoted 7 lines · Johannes Berg
Quoted 3 lines · Yegor Yefremov
I have asked SPDX and this is their answer:
https://lists.spdx.org/g/Spdx-legal/message/2631Alright, thanks. I guess I can apply that then.
Should I change the patch or are you OK with it?
Regards,
Yegor
Quoted 8 lines · Yegor Yefremov
Quoted 5 lines · Johannes Berg
Quoted 2 lines · Yegor Yefremov
I have asked SPDX and this is their answer:
https://lists.spdx.org/g/Spdx-legal/message/2631Alright, thanks. I guess I can apply that then.
Should I change the patch or are you OK with it?
I'll take it, but I've been backlogged with merge work, sorry about that.
johannes