Skip to contentSkip to conversation

No invalid histogram error

DISCUSSION Masami Hiramatsu 2 participants 2 messages Jun 20, 2019

lore
Share & tools
lore
#0 lore raw

Hi Tom,

I'm trying to use histogram on a synthetic event, but faced an odd situation.

There is a synthetic event, which has foo and bar.

/sys/kernel/debug/tracing # cat synthetic_events
testevent int foo; int bar

And when I tried to add hist on trigger, both foo and bar can be used as below.

/sys/kernel/debug/tracing # echo "hist:keys=bar" > events/synthetic/testevent/trigger /sys/kernel/debug/tracing # echo "hist:keys=foo" > events/synthetic/testevent/trigger

And, when I missed to specify the sort key, it failed

/sys/kernel/debug/tracing # echo "hist:keys=foo:sort=bar" > events/synthetic/testevent/trigger
sh: write error: Invalid argument

But no error on error_log file.

/sys/kernel/debug/tracing # cat error_log
/sys/kernel/debug/tracing #

Could you add some error message? What about below?

[ 5422.134656] hist:synthetic:testevent: error: Sort key must be one of keys.
  Command: keys=foo;sort=bar
                               ^

Thank you,

Signature · 1 line
Masami Hiramatsu <[email protected]>
#1 lore raw

Hi Masami,

Quoted 21 lines · Masami Hiramatsu

Hi Tom,

I'm trying to use histogram on a synthetic event, but faced an odd situation.

There is a synthetic event, which has foo and bar.

/sys/kernel/debug/tracing # cat synthetic_events
testevent int foo; int bar

And when I tried to add hist on trigger, both foo and bar can be used as below.

/sys/kernel/debug/tracing # echo "hist:keys=bar" > events/synthetic/testevent/trigger /sys/kernel/debug/tracing # echo "hist:keys=foo" > events/synthetic/testevent/trigger

And, when I missed to specify the sort key, it failed

/sys/kernel/debug/tracing # echo "hist:keys=foo:sort=bar" > events/synthetic/testevent/trigger
sh: write error: Invalid argument

But no error on error_log file.

Quoted 8 lines

/sys/kernel/debug/tracing # cat error_log
/sys/kernel/debug/tracing #

Could you add some error message? What about below?

[ 5422.134656] hist:synthetic:testevent: error: Sort key must be one of keys.
   Command: keys=foo;sort=bar
                                ^

Sure, I'll submit a fix for this.  Thanks for pointing it out.

Tom

Quoted 3 lines

Thank you,