Skip to contentSkip to conversation

jbd2: drop declaration of journal_sync_buffer()

PATCH In review Theodore Ts'o 2 participants 2 messages Jun 20, 2019 Journalling layer for block devices (JBD2)

lore
Share & tools
lore

Theodore Ts'o

author maintainer
#0 lore raw

PATCH 1/1 jbd2: drop declaration of journal_sync_buffer()

The journal_sync_buffer() function was never carried over from jbd to jbd2. So get rid of the vestigal declaration of this (non-existent) function.

---
 fs/jbd2/journal.c    | 3 ---
 include/linux/jbd2.h | 1 -
 2 files changed, 4 deletions(-)
fs/jbd2/journal.c +0 -3
index 17f679aeba7c..953990eb70a9 100644
@@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
 EXPORT_SYMBOL(jbd2_journal_set_triggers);
 EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
 EXPORT_SYMBOL(jbd2_journal_forget);
-#if 0
-EXPORT_SYMBOL(journal_sync_buffer);
-#endif
 EXPORT_SYMBOL(jbd2_journal_flush);
 EXPORT_SYMBOL(jbd2_journal_revoke);
 
include/linux/jbd2.h +0 -1
index 0e0393e7f41a..df03825ad1a1 100644
@@ -1373,7 +1373,6 @@ void		 jbd2_journal_set_triggers(struct buffer_head *,
 					   struct jbd2_buffer_trigger_type *type);
 extern int	 jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
 extern int	 jbd2_journal_forget (handle_t *, struct buffer_head *);
-extern void	 journal_sync_buffer (struct buffer_head *);
 extern int	 jbd2_journal_invalidatepage(journal_t *,
 				struct page *, unsigned int, unsigned int);
 extern int	 jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
Signature · 1 line
2.22.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Theodore Ts'o

The journal_sync_buffer() function was never carried over from jbd to jbd2. So get rid of the vestigal declaration of this (non-existent) function.

Looks ok,

--D

Quoted 34 lines
---
 fs/jbd2/journal.c    | 3 ---
 include/linux/jbd2.h | 1 -
 2 files changed, 4 deletions(-)
fs/jbd2/journal.c +0 -3
index 17f679aeba7c..953990eb70a9 100644
@@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
 EXPORT_SYMBOL(jbd2_journal_set_triggers);
 EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
 EXPORT_SYMBOL(jbd2_journal_forget);
-#if 0
-EXPORT_SYMBOL(journal_sync_buffer);
-#endif
 EXPORT_SYMBOL(jbd2_journal_flush);
 EXPORT_SYMBOL(jbd2_journal_revoke);
 
include/linux/jbd2.h +0 -1
index 0e0393e7f41a..df03825ad1a1 100644
@@ -1373,7 +1373,6 @@ void		 jbd2_journal_set_triggers(struct buffer_head *,
 					   struct jbd2_buffer_trigger_type *type);
 extern int	 jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
 extern int	 jbd2_journal_forget (handle_t *, struct buffer_head *);
-extern void	 journal_sync_buffer (struct buffer_head *);
 extern int	 jbd2_journal_invalidatepage(journal_t *,
 				struct page *, unsigned int, unsigned int);
 extern int	 jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
Signature · 1 line
2.22.0