arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
Subsystems (5)
PATCH 1/4 arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
From: Anson Huang <[email protected]>
ARCH_MXC platforms needs system counter as broadcast timer to support cpuidle, enable it by default.
--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +1 -0
@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTR help This enables support for the ARMv8 based SoCs in the NXP i.MX family.
Signature · 1 line
2.7.4
PATCH 2/4 dt-bindings: clock: imx8mm: Add system counter clock
From: Anson Huang <[email protected]>
Add i.MX8MM system counter clock macro definition.
--- include/dt-bindings/clock/imx8mm-clock.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
include/dt-bindings/clock/imx8mm-clock.h +3 -1
@@ -248,6 +248,8 @@#define IMX8MM_CLK_SNVS_ROOT 228#define IMX8MM_CLK_GIC 229 -#define IMX8MM_CLK_END 230 +#define IMX8MM_CLK_SYS_CTR 230 + +#define IMX8MM_CLK_END 231#endif
Signature · 1 line
2.7.4
Re: [PATCH 2/4] dt-bindings: clock: imx8mm: Add system counter clock
Quoted 9 lines · On Fri, 21 Jun 2019 15:07:18 +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
Add i.MX8MM system counter clock macro definition.
Signed-off-by Anson Huang <[email protected]>--- include/dt-bindings/clock/imx8mm-clock.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
PATCH 3/4 clk: imx8mm: Add system counter to clock tree
In reply to [email protected]From: Anson Huang <[email protected]>
i.MX8MM timer-imx-sysctr driver needs system counter clock for proper function, add it into clock tree.
--- drivers/clk/imx/clk-imx8mm.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/imx/clk-imx8mm.c +2 -0
@@ -645,6 +645,8 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node) clks[IMX8MM_CLK_DRAM_ALT_ROOT ] =imx_clk_fixed_factor ("dram_alt_root" ,"dram_alt" ,1 ,4 ); clks[IMX8MM_CLK_DRAM_CORE ] =imx_clk_mux2_flags ("dram_core_clk" , base +0x9800 ,24 ,1 , imx8mm_dram_core_sels,ARRAY_SIZE (imx8mm_dram_core_sels),CLK_IS_CRITICAL ); + clks[IMX8MM_CLK_SYS_CTR ] =imx_clk_fixed_factor ("sys_ctr" ,"osc_24m" ,1 ,3 ); + clks[IMX8MM_CLK_ARM] = imx_clk_cpu("arm", "arm_a53_div", clks[IMX8MM_CLK_A53_DIV], clks[IMX8MM_CLK_A53_SRC],
Signature · 1 line
2.7.4
Re: [PATCH 3/4] clk: imx8mm: Add system counter to clock tree
Quoted 6 lines · On 19-06-21 15:07:19, [email protected] wrote:
From: Anson Huang <[email protected]>
i.MX8MM timer-imx-sysctr driver needs system counter clock for proper function, add it into clock tree.
Signed-off-by Anson Huang <[email protected]>
Quoted 20 lines
--- drivers/clk/imx/clk-imx8mm.c | 2 ++ 1 file changed, 2 insertions(+)drivers/clk/imx/clk-imx8mm.c +2
-0@@ -645,6 +645,8 @@ static int __init imx8mm_clocks_init(struct device_node *ccm_node) clks[IMX8MM_CLK_DRAM_ALT_ROOT ] =imx_clk_fixed_factor ("dram_alt_root" ,"dram_alt" ,1 ,4 ); clks[IMX8MM_CLK_DRAM_CORE ] =imx_clk_mux2_flags ("dram_core_clk" , base +0x9800 ,24 ,1 , imx8mm_dram_core_sels,ARRAY_SIZE (imx8mm_dram_core_sels),CLK_IS_CRITICAL ); + clks[IMX8MM_CLK_SYS_CTR ] =imx_clk_fixed_factor ("sys_ctr" ,"osc_24m" ,1 ,3 ); + clks[IMX8MM_CLK_ARM] = imx_clk_cpu("arm", "arm_a53_div", clks[IMX8MM_CLK_A53_DIV], clks[IMX8MM_CLK_A53_SRC],Signature · 1 line
2.7.4
PATCH 4/4 arm64: dts: imx8mm: Add system counter node
In reply to [email protected]From: Anson Huang <[email protected]>
Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast timer driver.
--- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm.dtsi +9 -0
@@ -510,6 +510,15 @@ #pwm-cells = <2>; status = "disabled"; }; + + system_counter: timer@306a0000 { + compatible = "nxp,sysctr-timer"; + reg = <0x306a0000 0x30000>; + interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SYS_CTR>; + clock-names = "per"; + }; }; aips3: bus@30800000 {
Signature · 1 line
2.7.4
Re: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
Quoted 5 lines · On 21.06.19 09:07, [email protected] wrote:
From: Anson Huang <[email protected]>
Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast timer driver.
do we need similar additions to imx8mq? If so, I think these would fit in here too.
thanks,
martin
RE: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node
Hi, Martin
Quoted 19 lines
-----Original Message-----
From: Martin Kepplinger <[email protected]>
Sent: Saturday, June 22, 2019 8:10 PM
To: Anson Huang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leonard Crestez <[email protected]>; Aisheng Dong <[email protected]>; Jacky Bai <[email protected]>; Daniel Baluta <[email protected]>; Peng Fan <[email protected]>; Abel Vesa <[email protected]>; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]
Cc: dl-linux-imx <[email protected]>
Subject: Re: [PATCH 4/4] arm64: dts: imx8mm: Add system counter nodeQuoted 2 lines · On 21.06.19 09:07, [email protected] wrote:
From: Anson Huang <[email protected]>
Quoted 7 lines
Quoted 3 lines
Add i.MX8MM system counter node to enable timer-imx-sysctr broadcast timer driver.
do we need similar additions to imx8mq? If so, I think these would fit in here too.
i.MX8MQ has something different about system counter driver enablement, I did it in another patch series.
Anson.
Quoted 3 lines
thanks,
martin
Quoted 15 lines · On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)arch/arm64/Kconfig.platforms +0
-0
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 4 lines
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTR
Where is that driver?
Shawn
Quoted 6 lines
arch/arm64/Kconfig.platforms +0
-0help This enables support for the ARMv8 based SoCs in the NXP i.MX family.Signature · 1 line
2.7.4
Hi, Shawn
Quoted 27 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, June 24, 2019 10:22 AM
To: Anson Huang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Leonard Crestez <[email protected]>; Aisheng Dong <[email protected]>; Jacky Bai <[email protected]>; Daniel Baluta <[email protected]>; Peng Fan <[email protected]>; Abel Vesa <[email protected]>; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]; dl-linux-imx <[email protected]>
Subject: Re: [PATCH 1/4] arm64: EnableTIMER_IMX_SYS_CTRforARCH_MXCplatformsQuoted 10 lines · On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 9 lines
(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
The driver is drivers/clocksource/timer-imx-sysctr.c, similar function as GPT.
Thanks,
Anson
Quoted 9 lines
Shawn
Quoted 6 lines
arch/arm64/Kconfig.platforms +0
-1help This enables support for the ARMv8 based SoCs in the NXP i.MX family. --2.7.4
Quoted 11 lines · Shawn Guo
Quoted 10 lines · On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 9 lines
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
Okay, just found it in the mailbox. They seem to be sent in the wrong order. Really, you should send this series only after the driver lands on mainline.
Shawn
Hi, Shawn
Quoted 40 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, June 24, 2019 10:27 AM
To: Anson Huang <[email protected]>
Cc: [email protected]; Aisheng Dong <[email protected]>; Peng Fan <[email protected]>; [email protected]; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; Daniel Baluta <[email protected]>; linux- [email protected]; [email protected]; dl-linux-imx <linux- [email protected]>; [email protected]; Leonard Crestez <[email protected]>; [email protected]; [email protected]; [email protected]; Abel Vesa <[email protected]>
Subject: Re: [PATCH 1/4] arm64: EnableTIMER_IMX_SYS_CTRforARCH_MXCplatformsQuoted 11 lines · Shawn Guo
Quoted 10 lines · On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)Quoted 11 lines
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 9 lines
(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
Quoted 2 lines
Okay, just found it in the mailbox. They seem to be sent in the wrong order. Really, you should send this series only after the driver lands on mainline.
OK, just noticed that mainline does NOT have it, since I did it based on next tree. I will resend the patch series after the system counter driver landing on mainline.
Thanks,
Anson.
Quoted 2 lines
Shawn
Quoted 42 lines · Anson Huang
Hi, Shawn
Quoted 40 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, June 24, 2019 10:27 AM
To: Anson Huang <[email protected]>
Cc: [email protected]; Aisheng Dong <[email protected]>; Peng Fan <[email protected]>; [email protected]; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; Daniel Baluta <[email protected]>; linux- [email protected]; [email protected]; dl-linux-imx <linux- [email protected]>; [email protected]; Leonard Crestez <[email protected]>; [email protected]; [email protected]; [email protected]; Abel Vesa <[email protected]>
Subject: Re: [PATCH 1/4] arm64: EnableTIMER_IMX_SYS_CTRforARCH_MXCplatformsQuoted 22 lines · Shawn Guo
Quoted 15 lines · On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected] wrote:
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 4 lines
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
Quoted 5 lines
Quoted 2 lines
Okay, just found it in the mailbox. They seem to be sent in the wrong order. Really, you should send this series only after the driver lands on mainline.
OK, just noticed that mainline does NOT have it, since I did it based on next tree. I will resend the patch series after the system counter driver landing on mainline.
I just picked the series up, so no need to resend.
Shawn
Hi, Shawn
Quoted 47 lines · Anson Huang
Quoted 7 lines
Hi, Shawn
Quoted 5 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, June 24, 2019 10:27 AM
To: Anson Huang <[email protected]>
Cc: [email protected]; Aisheng Dong <[email protected]>;Peng
Quoted 13 lines
Quoted 13 lines
Fan <[email protected]>; [email protected]; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; Daniel Baluta <[email protected]>; linux- [email protected]; [email protected]; dl-linux-imx <linux- [email protected]>; [email protected]; Leonard Crestez <[email protected]>; [email protected]; [email protected]; [email protected]; Abel Vesa <[email protected]>
Subject: Re: [PATCH 1/4] arm64: EnableTIMER_IMX_SYS_CTRforARCH_MXCplatformsQuoted 1 line · Shawn Guo
On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected]
Quoted 22 lines · wrote:
Quoted 22 lines
Quoted 21 lines
Quoted 15 lines
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 4 lines
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
Quoted 1 line
Quoted 1 line
Okay, just found it in the mailbox. They seem to be sent in the wrong
order.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Really, you should send this series only after the driver lands on mainline.
OK, just noticed that mainline does NOT have it, since I did it based on next
tree.
Quoted 1 line
I will resend the patch series after the system counter driver landing on
mainline.
I just picked the series up, so no need to resend.
Something changed for this series, the system counter clock related implementation are changed after some comments from maintainer, so I think you should picked up below patch series instead, and drop this series,
https://patchwork.kernel.org/patch/11037953/
thanks,
Anson
Quoted 56 lines · Anson Huang
Hi, Shawn
Quoted 54 lines · Anson Huang
Quoted 7 lines
Hi, Shawn
Quoted 5 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, June 24, 2019 10:27 AM
To: Anson Huang <[email protected]>
Cc: [email protected]; Aisheng Dong <[email protected]>;Peng
Quoted 13 lines
Quoted 13 lines
Fan <[email protected]>; [email protected]; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; Daniel Baluta <[email protected]>; linux- [email protected]; [email protected]; dl-linux-imx <linux- [email protected]>; [email protected]; Leonard Crestez <[email protected]>; [email protected]; [email protected]; [email protected]; Abel Vesa <[email protected]>
Subject: Re: [PATCH 1/4] arm64: EnableTIMER_IMX_SYS_CTRforARCH_MXCplatformsQuoted 1 line · Shawn Guo
On Fri, Jun 21, 2019 at 03:07:17PM +0800, [email protected]
Quoted 22 lines · wrote:
Quoted 22 lines
Quoted 21 lines
Quoted 15 lines
From: Anson Huang <[email protected]>
ARCH_MXCplatforms needs system counter as broadcast timer to support cpuidle, enable it by default.Signed-off-by Anson Huang <[email protected]>--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644
arch/arm64/Kconfig.platforms config ARCH_MXC · line 176
Quoted 4 lines
arch/arm64/Kconfig.platforms +1
-0@@ -173,6 +173,7 @@ config ARCH_MXC select PM select PM_GENERIC_DOMAINS select SOC_BUS + select TIMER_IMX_SYS_CTRWhere is that driver?
Quoted 1 line
Quoted 1 line
Okay, just found it in the mailbox. They seem to be sent in the wrong
order.
Quoted 3 lines
Quoted 1 line
Really, you should send this series only after the driver lands on mainline.
OK, just noticed that mainline does NOT have it, since I did it based on next
tree.
Quoted 1 line
I will resend the patch series after the system counter driver landing on
mainline.
Quoted 7 lines
Quoted 1 line
I just picked the series up, so no need to resend.
Something changed for this series, the system counter clock related implementation are changed after some comments from maintainer, so I think you should picked up below patch series instead, and drop this series,
Okay, dropped clk and dts patches. arch/arm64/Kconfig.platforms one is kept.
Shawn