media: mtk-mdp: fix reference count on old device tree
Subsystems (3)
Matthias Brugger
maintainerPATCH 1/1 media: mtk-mdp: fix reference count on old device tree
of_get_next_child() increments the reference count of the returning device_node. Decrement it in the check if we are using the old or the new DTB.
--- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/platform/mtk-mdp/mtk_mdp_core.c +3 -1
@@ -118,7 +118,9 @@ static int mtk_mdp_probe(struct platform_device *pdev)mutex_init (&mdp->vpulock);/* Old dts had the components as child nodes */ -if (of_get_next_child (dev->of_node,NULL )) { + parent =of_get_next_child (dev->of_node,NULL ); +if (parent) { +of_node_put (parent); parent = dev->of_node;dev_warn (dev,"device tree is out of date\n" ); }else {
Signature · 1 line
2.21.0
Greg KH
maintainerQuoted 9 lines · Matthias Brugger
of_get_next_child()increments the reference count of the returningdevice_node. Decrement it in the check if we are using the old or the new DTB.Fixes ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree")Signed-off-by Matthias Brugger <[email protected]>--- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Matthias Brugger
maintainerQuoted 6 lines · Matthias Brugger
of_get_next_child()increments the reference count of the returningdevice_node. Decrement it in the check if we are using the old or the new DTB.Fixes ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree")Signed-off-by Matthias Brugger <[email protected]>
Any comments on that?
Quoted 20 lines
--- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/platform/mtk-mdp/mtk_mdp_core.c +3
-1@@ -118,7 +118,9 @@ static int mtk_mdp_probe(struct platform_device *pdev)mutex_init (&mdp->vpulock);/* Old dts had the components as child nodes */ -if (of_get_next_child (dev->of_node,NULL )) { + parent =of_get_next_child (dev->of_node,NULL ); +if (parent) { +of_node_put (parent); parent = dev->of_node;dev_warn (dev,"device tree is out of date\n" ); }else {
houlong wei
Acked-byQuoted 11 lines · Matthias Brugger
Quoted 6 lines · Matthias Brugger
of_get_next_child()increments the reference count of the returningdevice_node. Decrement it in the check if we are using the old or the new DTB.Fixes ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree")Signed-off-by Matthias Brugger <[email protected]>Any comments on that?
Hi Matthias,
Thanks for fixing the bug. Sorry to reply late~
Quoted 20 lines
Quoted 20 lines
--- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/platform/mtk-mdp/mtk_mdp_core.c +3
-1@@ -118,7 +118,9 @@ static int mtk_mdp_probe(struct platform_device *pdev)mutex_init (&mdp->vpulock);/* Old dts had the components as child nodes */ -if (of_get_next_child (dev->of_node,NULL )) { + parent =of_get_next_child (dev->of_node,NULL ); +if (parent) { +of_node_put (parent); parent = dev->of_node;dev_warn (dev,"device tree is out of date\n" ); }else {