Skip to contentSkip to conversation

rtc: Add DM support to ds3231

PATCH New Chuanhua Han 3 participants 7 messages Jun 21, 2019 – Jul 18, 2019 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 rtc: Add DM support to ds3231

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the ds3231_rtc_get
function, return 0 successfully, and return -EINVAL directly
when the RTC oscillator is stopped.
Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with "#if !CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 107 insertions(+)
drivers/rtc/ds3231.c +107 -0
index 9352ff87a2..79b026af4b 100644
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz Output  */
 
 
+#if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read (uchar reg);
 static void rtc_write (uchar reg, uchar val);
 
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar val)
 {
 	i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);
 }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time *tmp)
+{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR)
+						& ~RTC_STAT_BIT_OSF);
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ? 2000 : 1900);
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME: %2d:%02d:%02d\n",
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct rtc_time *tmp)
+{
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME: %2d:%02d:%02d\n",
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR, bin2bcd(tmp->tm_year % 100));
+
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR, bin2bcd(tmp->tm_mon) | century);
+
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR, bin2bcd(tmp->tm_wday + 1));
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR, bin2bcd(tmp->tm_mday));
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR, bin2bcd(tmp->tm_hour));
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR, bin2bcd(tmp->tm_min));
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR, bin2bcd(tmp->tm_sec));
+
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev)
+{
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS2);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev)
+{
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/1 rtc: Add DM support to ds3231

Quoted 153 lines · On Fri, 21 Jun 2019 16:21:53 +0800 Chuanhua Han <[email protected]> wrote:

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the ds3231_rtc_get
function, return 0 successfully, and return -EINVAL directly when the RTC oscillator is stopped.
Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with
"#if !CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107

+++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)

drivers/rtc/ds3231.c +4 -0
index 9352ff87a2..79b026af4b 100644
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz

Output */

drivers/rtc/ds3231.c +20 -0
+#if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read (uchar reg);
 static void rtc_write (uchar reg, uchar val);
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar val)
 {
 	i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);
 }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time *tmp)
+{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev,

RTC_STAT_REG_ADDR)

drivers/rtc/ds3231.c +10 -0
+						& ~RTC_STAT_BIT_OSF);
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ? 2000 :

1900);

drivers/rtc/ds3231.c +5 -0
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +7 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct rtc_time

*tmp) +{

drivers/rtc/ds3231.c +3 -0
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +4 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR, bin2bcd(tmp->tm_year

% 100)); +

drivers/rtc/ds3231.c +2 -0
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR, bin2bcd(tmp->tm_mon)

| century); +

drivers/rtc/ds3231.c +3 -0
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR, bin2bcd(tmp->tm_wday
+ 1));
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR,

bin2bcd(tmp->tm_mday));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR,

bin2bcd(tmp->tm_hour));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR,

bin2bcd(tmp->tm_min));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR,

bin2bcd(tmp->tm_sec)); +

drivers/rtc/ds3231.c +33 -0
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev)
+{
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS2);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev)
+{
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }

drivers/rtc/ds3231.c static void rtc_write (uchar reg, uchar val) · line 273

Quoted 10 lines
drivers/rtc/ds3231.c +10 -0
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190621/1da83cbd/attachment.sig>

#2 lore raw
Quoted 166 lines

-----Original Message-----
From: Lukasz Majewski <[email protected]>
Sent: 2019年6月21日 19:33
To: Chuanhua Han <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de
Subject: [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

Quoted 108 lines · On Fri, 21 Jun 2019 16:21:53 +0800 Chuanhua Han <[email protected]> wrote:

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the ds3231_rtc_get function,
return 0 successfully, and return -EINVAL directly when the RTC oscillator is stopped.
Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with "#if
!CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107

+++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)

drivers/rtc/ds3231.c index renamed from drivers/rtc/ds3231.c +0 -0

9352ff87a2..79b026af4b 100644

drivers/rtc/ds3231.c +4 -0
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz

Output */

drivers/rtc/ds3231.c +35 -0
+#if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read (uchar reg);
 static void rtc_write (uchar reg, uchar val);
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar val)  {
 	i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);  }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time *tmp)
+{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev,
 RTC_STAT_REG_ADDR)
+						& ~RTC_STAT_BIT_OSF);
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ? 2000 :
 1900);
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +7 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct rtc_time

*tmp) +{

drivers/rtc/ds3231.c +3 -0
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +4 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR, bin2bcd(tmp->tm_year

% 100)); +

drivers/rtc/ds3231.c +2 -0
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR, bin2bcd(tmp->tm_mon)

| century); +

drivers/rtc/ds3231.c

Quoted 1 line
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR, bin2bcd(tmp->tm_wday

1));

Quoted 43 lines
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR,

bin2bcd(tmp->tm_mday));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR,

bin2bcd(tmp->tm_hour));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR,

bin2bcd(tmp->tm_min));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR,

bin2bcd(tmp->tm_sec)); +

drivers/rtc/ds3231.c +35 -0
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev) {
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS2);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev) {
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
Quoted 8 lines

drivers/rtc/ds3231.c static void rtc_write (uchar reg, uchar val) · line 273

Quoted 6 lines
drivers/rtc/ds3231.c +6 -0
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif

Hi, Any other questions? Whether can merge into the uboot mainlines? Thanks!

Quoted 12 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

#3 lore raw
In reply to Lukasz Majewski

Hi, Lukasz Majewski

Quoted 164 lines

-----Original Message-----
From: Lukasz Majewski <[email protected]>
Sent: 2019年6月21日 19:33
To: Chuanhua Han <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de
Subject: [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

Quoted 108 lines · On Fri, 21 Jun 2019 16:21:53 +0800 Chuanhua Han <[email protected]> wrote:

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the ds3231_rtc_get function,
return 0 successfully, and return -EINVAL directly when the RTC oscillator is stopped.
Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with "#if
!CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107

+++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)

drivers/rtc/ds3231.c index renamed from drivers/rtc/ds3231.c +0 -0

9352ff87a2..79b026af4b 100644

drivers/rtc/ds3231.c +4 -0
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz

Output */

drivers/rtc/ds3231.c +35 -0
+#if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read (uchar reg);
 static void rtc_write (uchar reg, uchar val);
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar val)  {
 	i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);  }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time *tmp)
+{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev,
 RTC_STAT_REG_ADDR)
+						& ~RTC_STAT_BIT_OSF);
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ? 2000 :
 1900);
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +7 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct rtc_time

*tmp) +{

drivers/rtc/ds3231.c +3 -0
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +4 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR, bin2bcd(tmp->tm_year

% 100)); +

drivers/rtc/ds3231.c +2 -0
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR, bin2bcd(tmp->tm_mon)

| century); +

drivers/rtc/ds3231.c

Quoted 1 line
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR, bin2bcd(tmp->tm_wday

1));

Quoted 43 lines
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR,

bin2bcd(tmp->tm_mday));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR,

bin2bcd(tmp->tm_hour));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR,

bin2bcd(tmp->tm_min));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR,

bin2bcd(tmp->tm_sec)); +

drivers/rtc/ds3231.c +35 -0
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev) {
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS2);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev) {
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
Quoted 8 lines

drivers/rtc/ds3231.c static void rtc_write (uchar reg, uchar val) · line 273

Quoted 6 lines
drivers/rtc/ds3231.c +6 -0
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif

Does this patch need to be modified?
Can this patch be merged with the mainline of uboot? Looking forward to your reply. Thank you very much!

Quoted 12 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

#4 lore raw

Hi Chuanhua,

Quoted 180 lines

Hi, Lukasz Majewski

Quoted 170 lines

-----Original Message-----
From: Lukasz Majewski <[email protected]>
Sent: 2019年6月21日 19:33
To: Chuanhua Han <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de
Subject: [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

Quoted 113 lines · On Fri, 21 Jun 2019 16:21:53 +0800 Chuanhua Han <[email protected]> wrote:

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the
ds3231_rtc_get function, return 0 successfully, and return -EINVAL directly when the RTC oscillator is stopped. Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with "#if
!CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107

+++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)

drivers/rtc/ds3231.c index renamed from drivers/rtc/ds3231.c +0 -0

9352ff87a2..79b026af4b 100644

drivers/rtc/ds3231.c +4 -0
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz

Output */

drivers/rtc/ds3231.c +19 -0
+#if !CONFIG_IS_ENABLED(DM_RTC)
 static uchar rtc_read (uchar reg);
 static void rtc_write (uchar reg, uchar val);
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar
 val)  { i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);  }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time
 *tmp) +{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has
 stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev,

RTC_STAT_REG_ADDR)

drivers/rtc/ds3231.c +1 -0
+						&

~RTC_STAT_BIT_OSF);

drivers/rtc/ds3231.c +9 -0
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ?

2000 : 1900);

drivers/rtc/ds3231.c +5 -0
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +1 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday,

tmp->tm_wday,

drivers/rtc/ds3231.c +6 -0
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct

rtc_time *tmp) +{

drivers/rtc/ds3231.c +3 -0
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +1 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday,

tmp->tm_wday,

drivers/rtc/ds3231.c +3 -0
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR,

bin2bcd(tmp->tm_year % 100)); +

drivers/rtc/ds3231.c +2 -0
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR,

bin2bcd(tmp->tm_mon) | century); +

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR,
Quoted 1 line

bin2bcd(tmp->tm_wday

1));

Quoted 44 lines
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR,

bin2bcd(tmp->tm_mday));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR,

bin2bcd(tmp->tm_hour));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR,

bin2bcd(tmp->tm_min));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR,

bin2bcd(tmp->tm_sec)); +

drivers/rtc/ds3231.c +8 -0
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev) {
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 |

RTC_CTL_BIT_RS2);

drivers/rtc/ds3231.c +27 -0
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev) {
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
Quoted 8 lines

drivers/rtc/ds3231.c static void rtc_write (uchar reg, uchar val) · line 273

Quoted 6 lines
drivers/rtc/ds3231.c +6 -0
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif  
Quoted 2 lines

Does this patch need to be modified?
Can this patch be merged with the mainline of uboot?

If there are no other comments, then yes - this patch is eligible for upstreaming.

Quoted 1 line

Looking forward to your reply. Thank you very much!

In the patchwork [1] - there is a delegate assigned - in this case Tom Rini is supposed to pull this patch.

I've added Tom to CC, so maybe he will pull this code soon.

Note:

[1] - https://patchwork.ozlabs.org/patch/1120001/

Quoted 4 lines
Quoted 4 lines

Best regards,

Quoted 8 lines
Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190716/7c03310f/attachment.sig>

#5 lore raw

Hi,tom and Lukasz

Quoted 197 lines

-----Original Message-----
From: Lukasz Majewski <[email protected]>
Sent: 2019年7月16日 15:07
To: Chuanhua Han <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de; Tom Rini <[email protected]>
Subject: Re: [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

Hi Chuanhua,

Quoted 30 lines

Hi, Lukasz Majewski

Quoted 28 lines

-----Original Message-----
From: Lukasz Majewski <[email protected]>
Sent: 2019年6月21日 19:33
To: Chuanhua Han <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; u-boot at lists.denx.de
Subject: [EXT] Re: [PATCH v4] rtc: Add DM support to ds3231

Quoted 17 lines · On Fri, 21 Jun 2019 16:21:53 +0800 Chuanhua Han <[email protected]> wrote:

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

---
Changes in v4:
- Delete the original 'rel' variable in the ds3231_rtc_get
function, return 0 successfully, and return -EINVAL directly when the RTC oscillator is stopped.
Changes in v3:
- Update copyright information.
Changes in v2:
- Replace "#ifndef CONFIG_DM_RTC" with "#if
!CONFIG_IS_ENABLED(DM_RTC)".

 drivers/rtc/ds3231.c | 107

+++++++++++++++++++++++++++++++++++++++++++ 1 file changed,

107

Quoted 150 lines
Quoted 142 lines
Quoted 96 lines

insertions(+)

drivers/rtc/ds3231.c index renamed from drivers/rtc/ds3231.c +0 -0

9352ff87a2..79b026af4b 100644

drivers/rtc/ds3231.c +4 -0
@@ -2,6 +2,9 @@
 /*
  * (C) Copyright 2006
  * Markus Klotzbuecher, mk at denx.de
+ *
+ * (C) Copyright 2019 NXP
+ * Chuanhua Han <[email protected]>
  */
 
 /*
@@ -13,6 +16,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <rtc.h>
 #include <i2c.h>
 
@@ -50,6 +54,7 @@
 #define RTC_STAT_BIT_EN32KHZ	0x8	/* Enable 32KHz

Output */

+#if !CONFIG_IS_ENABLED(DM_RTC)
static uchar rtc_read (uchar reg); static void rtc_write (uchar
reg, uchar val);

drivers/rtc/ds3231.c +18 -0
@@ -164,3 +169,105 @@ static void rtc_write (uchar reg, uchar
 val)  { i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val);  }
+#else
+static int ds3231_rtc_get(struct udevice *dev, struct rtc_time
 *tmp) +{
+	uchar sec, min, hour, mday, wday, mon_cent, year, status;
+
+	status = dm_i2c_reg_read(dev, RTC_STAT_REG_ADDR);
+	sec = dm_i2c_reg_read(dev, RTC_SEC_REG_ADDR);
+	min = dm_i2c_reg_read(dev, RTC_MIN_REG_ADDR);
+	hour = dm_i2c_reg_read(dev, RTC_HR_REG_ADDR);
+	wday = dm_i2c_reg_read(dev, RTC_DAY_REG_ADDR);
+	mday = dm_i2c_reg_read(dev, RTC_DATE_REG_ADDR);
+	mon_cent = dm_i2c_reg_read(dev, RTC_MON_REG_ADDR);
+	year = dm_i2c_reg_read(dev, RTC_YR_REG_ADDR);
+
+	if (status & RTC_STAT_BIT_OSF) {
+		printf("### Warning: RTC oscillator has
 stopped\n");
+		/* clear the OSF flag */
+		dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
+				 dm_i2c_reg_read(dev,

RTC_STAT_REG_ADDR)

drivers/rtc/ds3231.c +1 -0
+						&

~RTC_STAT_BIT_OSF);

drivers/rtc/ds3231.c +9 -0
+		return -EINVAL;
+	}
+
+	tmp->tm_sec  = bcd2bin(sec & 0x7F);
+	tmp->tm_min  = bcd2bin(min & 0x7F);
+	tmp->tm_hour = bcd2bin(hour & 0x3F);
+	tmp->tm_mday = bcd2bin(mday & 0x3F);
+	tmp->tm_mon  = bcd2bin(mon_cent & 0x1F);
+	tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ?

2000 : 1900);

drivers/rtc/ds3231.c +5 -0
+	tmp->tm_wday = bcd2bin((wday - 1) & 0x07);
+	tmp->tm_yday = 0;
+	tmp->tm_isdst = 0;
+
+	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +1 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday,

tmp->tm_wday,

drivers/rtc/ds3231.c +6 -0
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	return 0;
+}
+
+static int ds3231_rtc_set(struct udevice *dev, const struct

rtc_time *tmp) +{

drivers/rtc/ds3231.c +3 -0
+	uchar century;
+
+	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME:

%2d:%02d:%02d\n",

drivers/rtc/ds3231.c +1 -0
+	      tmp->tm_year, tmp->tm_mon, tmp->tm_mday,

tmp->tm_wday,

drivers/rtc/ds3231.c +3 -0
+	      tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
+
+	dm_i2c_reg_write(dev, RTC_YR_REG_ADDR,

bin2bcd(tmp->tm_year % 100)); +

drivers/rtc/ds3231.c +2 -0
+	century = (tmp->tm_year >= 2000) ? 0x80 : 0;
+	dm_i2c_reg_write(dev, RTC_MON_REG_ADDR,

bin2bcd(tmp->tm_mon) | century); +

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DAY_REG_ADDR,
Quoted 1 line

bin2bcd(tmp->tm_wday

1));

Quoted 44 lines
drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_DATE_REG_ADDR,

bin2bcd(tmp->tm_mday));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_HR_REG_ADDR,

bin2bcd(tmp->tm_hour));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_MIN_REG_ADDR,

bin2bcd(tmp->tm_min));

drivers/rtc/ds3231.c +1 -0
+	dm_i2c_reg_write(dev, RTC_SEC_REG_ADDR,

bin2bcd(tmp->tm_sec)); +

drivers/rtc/ds3231.c +8 -0
+	return 0;
+}
+
+static int ds3231_rtc_reset(struct udevice *dev) {
+	int ret;
+
+	ret = dm_i2c_reg_write(dev, RTC_CTL_REG_ADDR,
+			       RTC_CTL_BIT_RS1 |

RTC_CTL_BIT_RS2);

drivers/rtc/ds3231.c +27 -0
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static int ds3231_probe(struct udevice *dev) {
+	i2c_set_chip_flags(dev, DM_I2C_CHIP_RD_ADDRESS |
+			DM_I2C_CHIP_WR_ADDRESS);
+
+	return 0;
+}
+
+static const struct rtc_ops ds3231_rtc_ops = {
+	.get = ds3231_rtc_get,
+	.set = ds3231_rtc_set,
+	.reset = ds3231_rtc_reset,
+};
+
+static const struct udevice_id ds3231_rtc_ids[] = {
+	{ .compatible = "dallas,ds3231" },
+	{ .compatible = "dallas,ds3232" },
+	{ }
+};
+
+U_BOOT_DRIVER(rtc_ds3231) = {
+	.name   = "rtc-ds3231",
Quoted 8 lines

drivers/rtc/ds3231.c static void rtc_write (uchar reg, uchar val) · line 273

Quoted 6 lines
drivers/rtc/ds3231.c +6 -0
+	.id     = UCLASS_RTC,
+	.probe  = ds3231_probe,
+	.of_match = ds3231_rtc_ids,
+	.ops    = &ds3231_rtc_ops,
+};
+#endif
Quoted 2 lines

Does this patch need to be modified?
Can this patch be merged with the mainline of uboot?

If there are no other comments, then yes - this patch is eligible for upstreaming.

Quoted 6 lines
Quoted 1 line

Looking forward to your reply. Thank you very much!

In the patchwork [1] - there is a delegate assigned - in this case Tom Rini is supposed to pull this patch.

I've added Tom to CC, so maybe he will pull this code soon.

Thank you very much!!!

Quoted 31 lines

Note:

[1] - https://patchwork.ozlabs.org/patch/1120001/

Quoted 4 lines
Quoted 4 lines

Best regards,

Quoted 8 lines
Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

#6 lore raw

PATCH v4 1/1 rtc: Add DM support to ds3231

In reply to Chuanhua Han
Quoted 5 lines · Chuanhua Han

Add an implementation of the ds3231 driver that uses the driver model i2c APIs.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190718/5df3235a/attachment.sig>