Skip to contentSkip to conversation

pinctrl: Add device link between pin controller and GPIO

PATCH In review Thierry Reding 2 participants 2 messages Jun 21, 2019 – Jun 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: Add device link between pin controller and GPIO

From: Thierry Reding <[email protected]>

When a GPIO controller registers a pin range with a pin controller, establish a device link between them in order to keep track of the dependency, which will help keep the right suspend/resume ordering.

---
 drivers/pinctrl/core.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/pinctrl/core.c +16 -1
index b70df27874d1..5079e8a5de61 100644
@@ -404,6 +404,17 @@ void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,
 	mutex_lock(&pctldev->mutex);
 	list_add_tail(&range->node, &pctldev->gpio_ranges);
 	mutex_unlock(&pctldev->mutex);
+
+	if (range->gc) {
+		struct device_link *link;
+
+		link = device_link_add(range->gc->parent, pctldev->dev,
+				       DL_FLAG_AUTOREMOVE_CONSUMER);
+		if (!link)
+			dev_err(pctldev->dev,
+				"failed to add device link to %s\n",
+				dev_name(range->gc->parent));
+	}
 }
 EXPORT_SYMBOL_GPL(pinctrl_add_gpio_range);
 
@@ -2136,8 +2147,12 @@ void pinctrl_unregister(struct pinctrl_dev *pctldev)
 	pinctrl_free_pindescs(pctldev, pctldev->desc->pins,
 			      pctldev->desc->npins);
 	/* remove gpio ranges map */
-	list_for_each_entry_safe(range, n, &pctldev->gpio_ranges, node)
+	list_for_each_entry_safe(range, n, &pctldev->gpio_ranges, node) {
+		if (range->gc)
+			device_link_remove(range->gc->parent, pctldev->dev);
+
 		list_del(&range->node);
+	}
 
 	mutex_unlock(&pctldev->mutex);
 	mutex_destroy(&pctldev->mutex);
Signature · 1 line
2.21.0
#1 lore raw
Quoted 7 lines · Thierry Reding

From: Thierry Reding <[email protected]>

When a GPIO controller registers a pin range with a pin controller, establish a device link between them in order to keep track of the dependency, which will help keep the right suspend/resume ordering.

This make sense.

drivers/pinctrl/core.c void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev, · line 412

Quoted 2 lines
drivers/pinctrl/core.c +2 -0
+               link = device_link_add(range->gc->parent, pctldev->dev,
+                                      DL_FLAG_AUTOREMOVE_CONSUMER);

What about parentless GPIO chips now again?
The parent field is optional, sad to say (yes I wish I could just fix it all).

Quoted 1 line

+ device_link_remove(range->gc->parent, pctldev->dev);

And here again.

Yours,
Linus Walleij