Skip to contentSkip to conversation

drm/amdgpu: add sw_init to df_v1_7

PATCH In review Kim, Jonathan 2 participants 3 messages Jun 21, 2019 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: add sw_init to df_v1_7

change df_init to df_sw_init df 1.7 to prevent regression issues on pre-vega20 products when callback is called in sw_common_sw_init.

Change-Id I4941003ea4a99ba0ea736c7ecc8800148423c379
---
 drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/df_v1_7.c +2 -2
index 9935371db7ce..844c03868248 100644
@@ -29,7 +29,7 @@
 
 static u32 df_v1_7_channel_number[] = {1, 2, 0, 4, 0, 8, 0, 16, 2};
 
-static void df_v1_7_init (struct amdgpu_device *adev)
+static void df_v1_7_sw_init(struct amdgpu_device *adev)
 {
 }
 
@@ -110,7 +110,7 @@ static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev,
 }
 
 const struct amdgpu_df_funcs df_v1_7_funcs = {
-	.init = df_v1_7_init,
+	.sw_init = df_v1_7_sw_init,
 	.enable_broadcast_mode = df_v1_7_enable_broadcast_mode,
 	.get_fb_channel_number = df_v1_7_get_fb_channel_number,
 	.get_hbm_channel_number = df_v1_7_get_hbm_channel_number,
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Felix Kuehling
#2 lore raw
Quoted 5 lines · Jonathan

change df_init to df_sw_init df 1.7 to prevent regression issues on pre-vega20 products when callback is called in sw_common_sw_init.

Change-Id I4941003ea4a99ba0ea736c7ecc8800148423c379

So your previous patch broke the build. Please at least build test your code before you push. Breaking the build is not acceptable. It slows down everybody else. I'll take a look if anything else can be cleaned up with these callbacks later.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/df_v1_7.c +1 -1
index 9935371db7ce..844c03868248 100644
@@ -29,7 +29,7 @@
 
  static u32 df_v1_7_channel_number[] = {1, 2, 0, 4, 0, 8, 0, 16, 2};
 
-static void df_v1_7_init (struct amdgpu_device *adev)
+static void df_v1_7_sw_init(struct amdgpu_device *adev)
  {
  }
 

drivers/gpu/drm/amd/amdgpu/df_v1_7.c static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev, · line 116

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/df_v1_7.c +1 -1
@@ -110,7 +110,7 @@ static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev,
  }
 
  const struct amdgpu_df_funcs df_v1_7_funcs = {
-	.init = df_v1_7_init,
+	.sw_init = df_v1_7_sw_init,
  	.enable_broadcast_mode = df_v1_7_enable_broadcast_mode,
  	.get_fb_channel_number = df_v1_7_get_fb_channel_number,
  	.get_hbm_channel_number = df_v1_7_get_hbm_channel_number,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 8d2e2498-573d-d23a-62e3-3881c9b1c24e-5C7GfCeVMHo@public.gmane.org

author Reviewed-by Felix Kuehling
#4 lore raw

Thanks, sorry about this. I'll be more thorough next time. Patch verified with vega20 and vega10 systems.

Jon

-----Original Message-----
From: Kuehling, Felix <[email protected]>
Sent: Friday, June 21, 2019 12:10 PM
To: [email protected]; Kim, Jonathan <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: add sw_init to df_v1_7

Quoted 5 lines · Jonathan

change df_init to df_sw_init df 1.7 to prevent regression issues on pre-vega20 products when callback is called in sw_common_sw_init.

Change-Id I4941003ea4a99ba0ea736c7ecc8800148423c379

So your previous patch broke the build. Please at least build test your code before you push. Breaking the build is not acceptable. It slows down everybody else. I'll take a look if anything else can be cleaned up with these callbacks later.

Quoted 19 lines
---
  drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/df_v1_7.c +1 -1
index 9935371db7ce..844c03868248 100644
@@ -29,7 +29,7 @@
 
  static u32 df_v1_7_channel_number[] = {1, 2, 0, 4, 0, 8, 0, 16, 2};
 
-static void df_v1_7_init (struct amdgpu_device *adev)
+static void df_v1_7_sw_init(struct amdgpu_device *adev)
  {
  }
 

drivers/gpu/drm/amd/amdgpu/df_v1_7.c static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev, · line 116

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/df_v1_7.c +1 -1
@@ -110,7 +110,7 @@ static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev,
  }
 
  const struct amdgpu_df_funcs df_v1_7_funcs = {
-	.init = df_v1_7_init,
+	.sw_init = df_v1_7_sw_init,
  	.enable_broadcast_mode = df_v1_7_enable_broadcast_mode,
  	.get_fb_channel_number = df_v1_7_get_fb_channel_number,
  	.get_hbm_channel_number = df_v1_7_get_hbm_channel_number,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx