Skip to contentSkip to conversation

staging: rtl8723bs: replace symbolic permission with octal permission

PATCH New Sushma Unnibhavi 2 participants 2 messages Jun 21, 2019 – Jun 22, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: replace symbolic permission with octal permission

Resolved following checkpatch issue:
WARNING: symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +2 -2
index 5f950fda48ea..fd9dfb953ada 100644
@@ -21,7 +21,7 @@ inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_
 {
 	struct proc_dir_entry *entry;
 
-	entry = proc_mkdir_data(name, S_IRUGO|S_IXUGO, parent, data);
+	entry = proc_mkdir_data(name, 0444|S_IXUGO, parent, data);
 
 	return entry;
 }
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
 {
 	struct proc_dir_entry *entry;
 
-	entry = proc_create_data(name,  S_IFREG|S_IRUGO, parent, fops, data);
+	entry = proc_create_data(name,  S_IFREG|0444, parent, fops, data);
 
 	return entry;
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw

PATCH 1/1 staging: rtl8723bs: replace symbolic permission with octal permission

Quoted 13 lines · Sushma Unnibhavi

Resolved following checkpatch issue:
WARNING: symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +0 -0
index 5f950fda48ea..fd9dfb953ada 100644

drivers/staging/rtl8723bs/os_dep/rtw_proc.c inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_ · line 24

Quoted 5 lines
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +1 -1
@@ -21,7 +21,7 @@ inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_
 {
 	struct proc_dir_entry *entry;
 
-	entry = proc_mkdir_data(name, S_IRUGO|S_IXUGO, parent, data);
+	entry = proc_mkdir_data(name, 0444|S_IXUGO, parent, data);

Don't mix/match these, either use symbolic permissions or octal permissions, never both :)

thanks,

greg k-h