staging: rtl8732bs: replace symbolic permission with octal permission
sushmaunnibhavi425 at gmail.com (Sushma Unnibhavi)
PATCH 1/1 staging: rtl8732bs: replace symbolic permission with octal permission
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
--- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +1 -1
@@ -21,7 +21,7 @@ inline struct proc_dir_entry *rtw_proc_create_dir(const char *name, struct proc_ {struct proc_dir_entry *entry; - entry =proc_mkdir_data (name,0444 |S_IXUGO , parent, data); + entry =proc_mkdir_data (name,0444 |0111 , parent, data);return entry; }
Signature · 1 line
2.17.1
Greg KH
maintainerPATCH 1/1 staging: rtl8732bs: replace symbolic permission with octal permission
Quoted 7 lines · Sushma Unnibhavi
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>--- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Is this a "v2" patch? If so, you always have to say that as per the kernel documentation and put what changed below the --- line.
Also, you can not send patches based on top of a previous patch, unless that patch was accepted. And I don't think I accepted your previous patch, right?
thanks,
greg k-h