Skip to contentSkip to conversation

changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively

PATCH New Sushma Unnibhavi 2 participants 2 messages Jun 22, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively

Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +1 -1
index f4292a2fd011..5fcdcb47e657 100644
@@ -31,7 +31,7 @@ inline struct proc_dir_entry *rtw_proc_create_entry(const char *name, struct pro
 {
 	struct proc_dir_entry *entry;
 
-	entry = proc_create_data(name,  S_IFREG|0444, parent, fops, data);
+	entry = proc_create_data(name,  0100000|0444, parent, fops, data);
 
 	return entry;
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw

PATCH 1/1 changes in v2: changed both the symbolic permissions S_IFREG and S_IXUGO into octal permissions 0100000 and 0444 respectively

Quoted 4 lines · Sushma Unnibhavi
Signed-off-by Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Slow down, take a few hours off, and think about what you are doing here. Make a new patch, read the documentation for how to properly document a versioned patch, and then send it to yourself to ensure you have it right.

Then if it all looks ok, resend it here to everyone. There is no rush. Some of us are about to leave on 10+ plane rides anyway :)

thanks,

greg k-h