iio: SPDX headers for core + non device driver parts.

PATCH In review [email protected] 6 participants 22 messages Jun 22, 2019 – Aug 17, 2019

Subsystems (2)

IIO Licenses and spdx stuff

lore

Share & tools

lore

[email protected]

author maintainer

2019-06-22 14:57 UTC #0 lore raw

cover iio: SPDX headers for core + non device driver parts.

From: Jonathan Cameron <[email protected]>

There is a general movement towards ensuring all of the kernel source files have SPDX headers. I have previously expressed the view, that, like many cleanups it would be better to do these when otherwise touching the relevant part of the code, rather than creating noise throughout.

Time to change my mind on that, and push through adding these to IIO.

Even in the core code, I was less than entirely consistent with the existing license markings, so there are places where the file headers don't match with the MODULE_LICENSE macro.
There were also headers that gained default SPDX license markings that actually aren't quite correct given the related c files sometimes did have well stated licenses.

If someone has time to check my logic on the these that would be great.

For the drivers, my intent is to use random periods of boredom (I'm on some long haul flights in the near future) to see if I can plough through them. If anyone wants to get ahead of the game and do their own drivers that would be great. This is particularly true in the big octopus drivers that spread throughout the IIO directories and beyond. I'd love it if other people took those on.

If in doubt, don't do a given file or put out a clearly worded email to the list asking for help!

Jonathan Cameron (14):
iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE iio:configfs: SPDX headers.
iio: sw-device: SPDX headers
iio: sw-trigger: SPDX headers.
iio: triggered-event: Add SPDX and fix header license to match the
code.
iio:buffer-dma: SPDX headers.
iio: buffer-cb: SPDX headers
iio: kfifo-buf: Add SPDX header
iio: buffer-dmaengine: SPDX GPL-2.0+
iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
iio: trig-hrtimer: SPDX header GPLv2
iio: trig-interrupt: SPDX headers. GPLv2
iio: trig-loop: SPDX headers GPL-v2
iio: trig-sysfs: SPDX headers GPLv2.

 drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
 drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
 drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
 drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
 drivers/iio/buffer/kfifo_buf.c                     |  1 +
 drivers/iio/iio_core.h                             |  8 +++-----
 drivers/iio/iio_core_trigger.h                     |  2 +-
 drivers/iio/industrialio-buffer.c                  |  8 +++-----
 drivers/iio/industrialio-configfs.c                |  5 +----
 drivers/iio/industrialio-core.c                    | 10 ++++------
 drivers/iio/industrialio-event.c                   |  4 +++-
 drivers/iio/industrialio-sw-device.c               |  5 +----
 drivers/iio/industrialio-sw-trigger.c              |  5 +----
 drivers/iio/industrialio-trigger.c                 |  8 +++-----
 drivers/iio/industrialio-triggered-event.c         |  6 +-----
 drivers/iio/inkern.c                               |  8 +++-----
 drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
 drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
 drivers/iio/trigger/iio-trig-loop.c                |  3 +--
 drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
 include/linux/iio/buffer-dma.h                     |  3 +--
 include/linux/iio/buffer-dmaengine.h               |  3 +--
 include/linux/iio/buffer.h                         |  8 +++-----
 include/linux/iio/configfs.h                       |  5 +----
 include/linux/iio/consumer.h                       |  5 +----
 include/linux/iio/driver.h                         |  5 +----
 include/linux/iio/events.h                         |  8 +++-----
 include/linux/iio/iio.h                            |  9 +++------
 include/linux/iio/kfifo_buf.h                      |  2 +-
 include/linux/iio/machine.h                        |  5 +----
 include/linux/iio/sw_device.h                      |  5 +----
 include/linux/iio/sw_trigger.h                     |  5 +----
 include/linux/iio/sysfs.h                          | 10 ++++------
 include/linux/iio/trigger.h                        |  5 +----
 include/linux/iio/trigger_consumer.h               |  8 +++-----
 include/linux/iio/triggered_event.h                |  2 +-
 include/linux/iio/types.h                          |  8 +++-----
 37 files changed, 67 insertions(+), 140 deletions(-)

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #1 lore raw

PATCH 1/14 iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE

From: Jonathan Cameron <[email protected]>

There is a concerted push to ensure all of the kernel files have SPDX headers going on, so about time IIO caught up.

Given the large and mechanical nature of the changes + the need to actually check the changes are correct by hand, I'll split them down in to fairly bite sized chunks.

This first patch is those files that feed directly into industrialio.ko.

Note the visual inspection showed that MODULE_LICENSE(GPL) was different from the clearly file headers which did not have the or later text that implies. I have taken the code as having precedence and changed this to GPL v2.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/iio_core.h               |  8 +++-----
 drivers/iio/iio_core_trigger.h       |  2 +-
 drivers/iio/industrialio-buffer.c    |  8 +++-----
 drivers/iio/industrialio-core.c      | 10 ++++------
 drivers/iio/industrialio-event.c     |  4 +++-
 drivers/iio/industrialio-trigger.c   |  8 +++-----
 drivers/iio/inkern.c                 |  8 +++-----
 include/linux/iio/buffer.h           |  8 +++-----
 include/linux/iio/consumer.h         |  5 +----
 include/linux/iio/driver.h           |  5 +----
 include/linux/iio/events.h           |  8 +++-----
 include/linux/iio/iio.h              |  9 +++------
 include/linux/iio/machine.h          |  5 +----
 include/linux/iio/sysfs.h            | 10 ++++------
 include/linux/iio/trigger.h          |  5 +----
 include/linux/iio/trigger_consumer.h |  8 +++-----
 include/linux/iio/types.h            |  8 +++-----
 17 files changed, 43 insertions(+), 76 deletions(-)

drivers/iio/iio_core.h +3 -5

index c775fedbcaf6..62b3c436d367 100644
@@ -1,11 +1,9 @@
-/* The industrial I/O core function defs.
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core function defs.
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * These definitions are meant for use only within the IIO core, not individual
  * drivers.
  */

drivers/iio/iio_core_trigger.h +1 -1

index 1fdb1e4ea4a5..e945764da1b0 100644
@@ -1,4 +1,4 @@
-
+/* SPDX-License-Identifier: GPL-2.0 */
 /* The industrial I/O core, trigger consumer handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron

drivers/iio/industrialio-buffer.c +3 -5

index 4fa273002c03..698f650145a0 100644
@@ -1,11 +1,9 @@
-/* The industrial I/O core
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * Handling of buffer allocation / resizing.
  *
  *

drivers/iio/industrialio-core.c +4 -6

index 85a699b5ae96..518b654a248b 100644
@@ -1,11 +1,9 @@
-/* The industrial I/O core
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * Based on elements of hwmon and input subsystems.
  */

@@ -1821,4 +1819,4 @@ module_exit(iio_exit);
 
 MODULE_AUTHOR("Jonathan Cameron <[email protected]>");
 MODULE_DESCRIPTION("Industrial I/O core");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");

drivers/iio/industrialio-event.c +3 -1

index c6dfdf0aaac5..d32ebf47960f 100644
@@ -1,4 +1,6 @@
-/* Industrial I/O event handling
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Industrial I/O event handling
  *
  * Copyright (c) 2008 Jonathan Cameron
  *

drivers/iio/industrialio-trigger.c +3 -5

index e5b538379ed1..affe336842e0 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O core, trigger handling functions
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core, trigger handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>

drivers/iio/inkern.c +3 -5

index 4a5eff3f18bc..89684464b72a 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O core in kernel channel mapping
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core in kernel channel mapping
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #include <linux/err.h>
 #include <linux/export.h>

include/linux/iio/buffer.h +3 -5

index 48767c776119..50c645369544 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O core - generic buffer interfaces.
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core - generic buffer interfaces.
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_BUFFER_GENERIC_H_

include/linux/iio/consumer.h +1 -4

index b2d34831ed7c..25c5f932c03d 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel consumer interface
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _IIO_INKERN_CONSUMER_H_
 #define _IIO_INKERN_CONSUMER_H_

include/linux/iio/driver.h +1 -4

index f54a7bcdefe3..d5e63a832f49 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel access map interface.
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_INKERN_H_

include/linux/iio/events.h +3 -5

index 8ad87d1c5340..4ed5a1e4b3c0 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O - event passing to userspace
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O - event passing to userspace
  *
  * Copyright (c) 2008-2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _IIO_EVENTS_H_
 #define _IIO_EVENTS_H_

include/linux/iio/iio.h +3 -6

index bb10c1bee301..9a5d40874ed5 100644
@@ -1,11 +1,8 @@
-
-/* The industrial I/O core
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _INDUSTRIAL_IO_H_
 #define _INDUSTRIAL_IO_H_

include/linux/iio/machine.h +1 -4

index 5e1cfa75f652..3a2dfd43c8ef 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel access map definitions for board files.
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __LINUX_IIO_MACHINE_H__

include/linux/iio/sysfs.h +4 -6

index ce9426c507fd..e70291975d5b 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O core
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core
  *
- *Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
+ * Copyright (c) 2008 Jonathan Cameron
  *
  * General attributes
  */

include/linux/iio/trigger.h +1 -4

index b19b7204ef84..430b99f76081 100644
@@ -1,10 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /* The industrial I/O core, trigger handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #include <linux/irq.h>
 #include <linux/module.h>

include/linux/iio/trigger_consumer.h +3 -5

index c4f8c7409666..6c6d7da8d626 100644
@@ -1,10 +1,8 @@
-/* The industrial I/O core, trigger consumer functions
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core, trigger consumer functions
  *
  * Copyright (c) 2008-2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __LINUX_IIO_TRIGGER_CONSUMER_H__

include/linux/iio/types.h +3 -5

index 6eb3d683ef62..a4af165d6461 100644
@@ -1,10 +1,8 @@
-/* industrial I/O data types needed both in and out of kernel
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * industrial I/O data types needed both in and out of kernel
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_TYPES_H_

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #2 lore raw

PATCH 2/14 iio:configfs: SPDX headers.

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Simple removal of boilerplate and insertion of spdx for GPL v2.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Daniel Baluta <[email protected]>

---
 drivers/iio/industrialio-configfs.c | 5 +----
 include/linux/iio/configfs.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

drivers/iio/industrialio-configfs.c +1 -4

index 5a0aae119369..92b1ab4f159d 100644
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Industrial I/O configfs bits
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/configfs.h>

include/linux/iio/configfs.h +1 -4

index 93befd67c15c..75752e69916c 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O configfs support
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef __IIO_CONFIGFS
 #define __IIO_CONFIGFS

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #3 lore raw

PATCH 3/14 iio: sw-device: SPDX headers

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Simple GPLv2.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Daniel Baluta <[email protected]>

---
 drivers/iio/industrialio-sw-device.c | 5 +----
 include/linux/iio/sw_device.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

drivers/iio/industrialio-sw-device.c +1 -4

index 90df97c542f6..cefa6ce4555a 100644
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * The Industrial I/O core, software IIO devices functions
  *
  * Copyright (c) 2016 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/module.h>

include/linux/iio/sw_device.h +1 -4

index 8642b91a7577..253ae5fce3d0 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O software device interface
  *
  * Copyright (c) 2016 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __IIO_SW_DEVICE

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #4 lore raw

PATCH 4/14 iio: sw-trigger: SPDX headers.

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

GPLv2, add SPDX headers and remove boilerplate.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/industrialio-sw-trigger.c | 5 +----
 include/linux/iio/sw_trigger.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

drivers/iio/industrialio-sw-trigger.c +1 -4

index bc6b7fb43e3a..b8fcb4cd06f1 100644
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * The Industrial I/O core, software trigger functions
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/module.h>

include/linux/iio/sw_trigger.h +1 -4

index 0c43738a9e24..c8b9868b5e62 100644
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O software trigger interface
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __IIO_SW_TRIGGER

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #5 lore raw

PATCH 5/14 iio: triggered-event: Add SPDX and fix header license to match the code.

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

The c file had clear license text, this disgreed with the default GPL-2.0 added due to the header having no previous license text at all.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/industrialio-triggered-event.c | 6 +-----
 include/linux/iio/triggered_event.h        | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

drivers/iio/industrialio-triggered-event.c +1 -5

index 8cc254fac16a..77b59dbfe710 100644
@@ -1,10 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (C) 2015 Cogent Embedded, Inc.
- *
- * This program is free software; you can redistribute  it and/or modify it
- * under  the terms of  the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include <linux/kernel.h>

include/linux/iio/triggered_event.h +1 -1

index 13250fd99745..8f73190188ce 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0+ */
 #ifndef _LINUX_IIO_TRIGGERED_EVENT_H_
 #define _LINUX_IIO_TRIGGERED_EVENT_H_

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #6 lore raw

PATCH 6/14 iio:buffer-dma: SPDX headers.

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

GPLv2 as clearly stated in prior headers.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/buffer/industrialio-buffer-dma.c | 3 +--
 include/linux/iio/buffer-dma.h               | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

drivers/iio/buffer/industrialio-buffer-dma.c +1 -2

index b32bf57910ca..debe0f6c44fb 100644
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2013-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <[email protected]>
- *
- * Licensed under the GPL-2.
  */
 
 #include <linux/slab.h>

include/linux/iio/buffer-dma.h +1 -2

index 67c75372b691..b0fa722d0ccf 100644
@@ -1,8 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright 2013-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <[email protected]>
- *
- * Licensed under the GPL-2.
  */
 
 #ifndef __INDUSTRIALIO_DMA_BUFFER_H__

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #7 lore raw

PATCH 7/14 iio: buffer-cb: SPDX headers

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Another simple GPL v2 only.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/buffer/industrialio-buffer-cb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

drivers/iio/buffer/industrialio-buffer-cb.c +3 -5

index df21e7dbec40..1628ba36515c 100644
@@ -1,8 +1,6 @@
-/* The industrial I/O callback buffer
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O callback buffer
  */
 
 #include <linux/kernel.h>

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:57 UTC #8 lore raw

PATCH 8/14 iio: kfifo-buf: Add SPDX header

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Previously no license header, but there is a MODULE_LICENSE so match that with GPL-2.0+

Header was filled with default GPL-2.0 so update fix that as well.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/buffer/kfifo_buf.c | 1 +
 include/linux/iio/kfifo_buf.h  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

drivers/iio/buffer/kfifo_buf.c +1 -0

index 70c302a93d7f..041a8d0b9aac 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 #include <linux/slab.h>
 #include <linux/kernel.h>
 #include <linux/module.h>

include/linux/iio/kfifo_buf.h +1 -1

index 764659e01b68..4611bbcc37c3 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0+ */
 #ifndef __LINUX_IIO_KFIFO_BUF_H__
 #define __LINUX_IIO_KFIFO_BUF_H__

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:58 UTC #9 lore raw

PATCH 9/14 iio: buffer-dmaengine: SPDX GPL-2.0+

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Clearly stated in existing headers so just convert to SDPX.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
 include/linux/iio/buffer-dmaengine.h               | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

drivers/iio/buffer/industrialio-buffer-dmaengine.c +1 -2

index 2b5a320f42c5..9a0a02e89e9b 100644
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright 2014-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <[email protected]>
- *
- * Licensed under the GPL-2 or later.
  */
 
 #include <linux/slab.h>

include/linux/iio/buffer-dmaengine.h +1 -2

index 5dcddf427bb0..c7dbcd359213 100644
@@ -1,8 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright 2014-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <[email protected]>
- *
- * Licensed under the GPL-2 or later.
  */
 
 #ifndef __IIO_DMAENGINE_H__

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:58 UTC #10 lore raw

PATCH 10/14 iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

The licensing was inconsistent for this module, so gone with the clearly stated header text which had no "or later" element.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/buffer/industrialio-triggered-buffer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

drivers/iio/buffer/industrialio-triggered-buffer.c +3 -6

index d3db1fce54d2..0c413012f8e1 100644
@@ -1,10 +1,7 @@
- /*
+// SPDX-License-Identifier: GPL-2.0
+/*
  * Copyright (c) 2012 Analog Devices, Inc.
  *  Author: Lars-Peter Clausen <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>

@@ -142,4 +139,4 @@ EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_cleanup);
 
 MODULE_AUTHOR("Lars-Peter Clausen <[email protected]>");
 MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:58 UTC #11 lore raw

PATCH 11/14 iio: trig-hrtimer: SPDX header GPLv2

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Clearly stated license text so simple conversion.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Daniel Baluta <[email protected]>

---
 drivers/iio/trigger/iio-trig-hrtimer.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

drivers/iio/trigger/iio-trig-hrtimer.c +1 -5

index 7accd0187ba1..14cfb4074f64 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /**
  * The industrial I/O periodic hrtimer trigger driver
  *

@@ -6,11 +7,6 @@
  * Copyright (C) 2012, Analog Device Inc.
  *	Author: Lars-Peter Clausen <[email protected]>
  * Copyright (C) 2015, Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  */
 #include <linux/kernel.h>
 #include <linux/slab.h>

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:58 UTC #12 lore raw

PATCH 12/14 iio: trig-interrupt: SPDX headers. GPLv2

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/trigger/iio-trig-interrupt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

drivers/iio/trigger/iio-trig-interrupt.c +1 -4

index 171c4ed03543..04c38fad6a28 100644
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Industrial I/O - generic interrupt based trigger support
  *
  * Copyright (c) 2008-2013 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>

Signature · 1 line

2.22.0

[email protected]

author maintainer

2019-06-22 14:58 UTC #13 lore raw

PATCH 13/14 iio: trig-loop: SPDX headers GPL-v2

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Not exactly standard license text, but clear in intent and it's my copyright anyway.

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/trigger/iio-trig-loop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/iio/trigger/iio-trig-loop.c +1 -2

index 9258d3cf149b..f0205a9e47d0 100644
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2016 Jonathan Cameron <[email protected]>
  *
- * Licensed under the GPL-2.
- *
  * Based on a mashup of the hrtimer trigger and continuous sampling proposal of
  * Gregor Boirie <[email protected]>
  *

Signature · 1 line

2.22.0

Himanshu Jha

2019-07-17 17:58 UTC #14 lore raw

Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2

Quoted 15 lines · On Sat, Jun 22, 2019 at 03:55:15PM +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>
Not exactly standard license text, but clear in intent and it's my copyright anyway.
Signed-off-by Jonathan Cameron <[email protected]>
---
 drivers/iio/trigger/iio-trig-loop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/trigger/iio-trig-loop.c +0 -0
index 9258d3cf149b..f0205a9e47d0 100644

drivers/iio/trigger/iio-trig-loop.c line 1

Quoted 1 line

drivers/iio/trigger/iio-trig-loop.c +1 -0
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0

I think it should be:

	// SPDX-License-Identifier: GPL-2.0-only

https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html

I don't know if spdxcheck.py points out about
such a mismatch.

Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/

Quoted 11 lines

drivers/iio/trigger/iio-trig-loop.c +0 -2

 /*
  * Copyright 2016 Jonathan Cameron <[email protected]>
  *
- * Licensed under the GPL-2.
- *
  * Based on a mashup of the hrtimer trigger and continuous sampling proposal of
  * Gregor Boirie <[email protected]>
  *

Signature · 1 line

2.22.0

Signature · 4 lines

Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

Greg KH

maintainer

2019-07-17 21:12 UTC #15 lore raw

Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2

Quoted 22 lines · Himanshu Jha

Quoted 15 lines · On Sat, Jun 22, 2019 at 03:55:15PM +0100, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
Not exactly standard license text, but clear in intent and it's my copyright anyway.
Signed-off-by Jonathan Cameron <[email protected]>
---
 drivers/iio/trigger/iio-trig-loop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/trigger/iio-trig-loop.c +0 -0
index 9258d3cf149b..f0205a9e47d0 100644
drivers/iio/trigger/iio-trig-loop.c line 1
Quoted 1 line
drivers/iio/trigger/iio-trig-loop.c +1 -0
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
I think it should be:
	// SPDX-License-Identifier: GPL-2.0-only

Quoted 8 lines

https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html
I don't know if spdxcheck.py points out about
such a mismatch.
Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/

Please read the in-kernel documentation about this. We support both types of tags now and have done so since the beginning.

thanks,

greg k-h

J Lovejoy

2019-08-17 19:44 UTC #16 lore raw

Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2

Quoted 30 lines · Greg KH

Quoted 25 lines · Himanshu Jha
Quoted 15 lines · On Sat, Jun 22, 2019 at 03:55:15PM +0100, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
Not exactly standard license text, but clear in intent and it's my copyright anyway.
Signed-off-by Jonathan Cameron <[email protected]>
---
drivers/iio/trigger/iio-trig-loop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/trigger/iio-trig-loop.c +0 -0
index 9258d3cf149b..f0205a9e47d0 100644
drivers/iio/trigger/iio-trig-loop.c line 1
Quoted 1 line
drivers/iio/trigger/iio-trig-loop.c +1 -0
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
I think it should be:
	// SPDX-License-Identifier: GPL-2.0-only
https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html

Quoted 10 lines

Quoted 5 lines
I don't know if spdxcheck.py points out about
such a mismatch.
Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
Please read the in-kernel documentation about this. We support both types of tags now and have done so since the beginning.

While I understand that the previous SPDX License List and current version identifiers are supported here, it would be really helpful more generally if we could use the current ones now and going forward.

Thanks,
Jilayne
SPDX legal team co-lead

Greg KH

maintainer

2019-08-17 20:39 UTC #17 lore raw

Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2

Quoted 36 lines · J Lovejoy

Quoted 36 lines · Greg KH
Quoted 30 lines · Himanshu Jha
Quoted 15 lines · On Sat, Jun 22, 2019 at 03:55:15PM +0100, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
Not exactly standard license text, but clear in intent and it's my copyright anyway.
Signed-off-by Jonathan Cameron <[email protected]>
---
drivers/iio/trigger/iio-trig-loop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/trigger/iio-trig-loop.c +0 -0
index 9258d3cf149b..f0205a9e47d0 100644
drivers/iio/trigger/iio-trig-loop.c line 1
Quoted 1 line
drivers/iio/trigger/iio-trig-loop.c +1 -0
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
I think it should be:
	// SPDX-License-Identifier: GPL-2.0-only
https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html
I don't know if spdxcheck.py points out about
such a mismatch.
Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/

Quoted 7 lines

Quoted 4 lines
Please read the in-kernel documentation about this. We support both types of tags now and have done so since the beginning.
While I understand that the previous SPDX License List and current version identifiers are supported here, it would be really helpful more generally if we could use the current ones now and going forward.

That is fine, but for now, both are acceptable, it's up to the submitter to pick which they want to use, we have much bigger things to worry about here :)

thanks,

greg k-h

[email protected]

author maintainer

2019-06-22 14:58 UTC #18 lore raw

PATCH 14/14 iio: trig-sysfs: SPDX headers GPLv2.

In reply to [email protected]

From: Jonathan Cameron <[email protected]>

Non standard but clear statement of intent.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Michael Hennerich <[email protected]>

---
 drivers/iio/trigger/iio-trig-sysfs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/iio/trigger/iio-trig-sysfs.c +1 -3

index 45c4897295d6..c86a78baeba4 100644
@@ -1,8 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
- *
  */
 
 #include <linux/kernel.h>

Signature · 1 line

2.22.0

Jonathan Cameron

2019-07-17 16:07 UTC #19 lore raw

In reply to [email protected]

If anyone has time to sanity check these, it would be much appreciated.

At somepoint I'll take a view on them being too dull to garner review, but I really don't like applying stuff that hasn't had a second set of eyes on it.

Thanks,

Jonathan

Quoted 84 lines · On Sat, 22 Jun 2019 15:55:02 +0100 <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>
There is a general movement towards ensuring all of the kernel source files have SPDX headers. I have previously expressed the view, that, like many cleanups it would be better to do these when otherwise touching the relevant part of the code, rather than creating noise throughout.
Time to change my mind on that, and push through adding these to IIO.
Even in the core code, I was less than entirely consistent with the existing license markings, so there are places where the file headers don't match with the MODULE_LICENSE macro.
There were also headers that gained default SPDX license markings that actually aren't quite correct given the related c files sometimes did have well stated licenses.
If someone has time to check my logic on the these that would be great.
For the drivers, my intent is to use random periods of boredom (I'm on some long haul flights in the near future) to see if I can plough through them. If anyone wants to get ahead of the game and do their own drivers that would be great. This is particularly true in the big octopus drivers that spread throughout the IIO directories and beyond. I'd love it if other people took those on.
If in doubt, don't do a given file or put out a clearly worded email to the list asking for help!
Jonathan Cameron (14):
iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE iio:configfs: SPDX headers.
iio: sw-device: SPDX headers
iio: sw-trigger: SPDX headers.
iio: triggered-event: Add SPDX and fix header license to match the
code.
iio:buffer-dma: SPDX headers.
iio: buffer-cb: SPDX headers
iio: kfifo-buf: Add SPDX header
iio: buffer-dmaengine: SPDX GPL-2.0+
iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
iio: trig-hrtimer: SPDX header GPLv2
iio: trig-interrupt: SPDX headers. GPLv2
iio: trig-loop: SPDX headers GPL-v2
iio: trig-sysfs: SPDX headers GPLv2.
 drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
 drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
 drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
 drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
 drivers/iio/buffer/kfifo_buf.c                     |  1 +
 drivers/iio/iio_core.h                             |  8 +++-----
 drivers/iio/iio_core_trigger.h                     |  2 +-
 drivers/iio/industrialio-buffer.c                  |  8 +++-----
 drivers/iio/industrialio-configfs.c                |  5 +----
 drivers/iio/industrialio-core.c                    | 10 ++++------
 drivers/iio/industrialio-event.c                   |  4 +++-
 drivers/iio/industrialio-sw-device.c               |  5 +----
 drivers/iio/industrialio-sw-trigger.c              |  5 +----
 drivers/iio/industrialio-trigger.c                 |  8 +++-----
 drivers/iio/industrialio-triggered-event.c         |  6 +-----
 drivers/iio/inkern.c                               |  8 +++-----
 drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
 drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
 drivers/iio/trigger/iio-trig-loop.c                |  3 +--
 drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
 include/linux/iio/buffer-dma.h                     |  3 +--
 include/linux/iio/buffer-dmaengine.h               |  3 +--
 include/linux/iio/buffer.h                         |  8 +++-----
 include/linux/iio/configfs.h                       |  5 +----
 include/linux/iio/consumer.h                       |  5 +----
 include/linux/iio/driver.h                         |  5 +----
 include/linux/iio/events.h                         |  8 +++-----
 include/linux/iio/iio.h                            |  9 +++------
 include/linux/iio/kfifo_buf.h                      |  2 +-
 include/linux/iio/machine.h                        |  5 +----
 include/linux/iio/sw_device.h                      |  5 +----
 include/linux/iio/sw_trigger.h                     |  5 +----
 include/linux/iio/sysfs.h                          | 10 ++++------
 include/linux/iio/trigger.h                        |  5 +----
 include/linux/iio/trigger_consumer.h               |  8 +++-----
 include/linux/iio/triggered_event.h                |  2 +-
 include/linux/iio/types.h                          |  8 +++-----
 37 files changed, 67 insertions(+), 140 deletions(-)

Ardelean, Alexandru

2019-07-18 08:37 UTC #20 lore raw

Quoted 7 lines · Jonathan Cameron

[External]
If anyone has time to sanity check these, it would be much appreciated.
At somepoint I'll take a view on them being too dull to garner review, but I really don't like applying stuff that hasn't had a second set of eyes on it.

Found only one inconsistency in patch 07/14. MODULE_LICENSE("GPL") vs // SPDX-License-Identifier: GPL-2.0

Hopefully that email/reply comes through on the patch itself. If not, maybe this email comes through.

Quoted 93 lines

Thanks,
Jonathan
Quoted 84 lines · On Sat, 22 Jun 2019 15:55:02 +0100 <[email protected]> wrote:
From: Jonathan Cameron <[email protected]>
There is a general movement towards ensuring all of the kernel source files have SPDX headers. I have previously expressed the view, that, like many cleanups it would be better to do these when otherwise touching the relevant part of the code, rather than creating noise throughout.
Time to change my mind on that, and push through adding these to IIO.
Even in the core code, I was less than entirely consistent with the existing license markings, so there are places where the file headers don't match with the MODULE_LICENSE macro.
There were also headers that gained default SPDX license markings that actually aren't quite correct given the related c files sometimes did have well stated licenses.
If someone has time to check my logic on the these that would be great.
For the drivers, my intent is to use random periods of boredom (I'm on some long haul flights in the near future) to see if I can plough through them. If anyone wants to get ahead of the game and do their own drivers that would be great. This is particularly true in the big octopus drivers that spread throughout the IIO directories and beyond. I'd love it if other people took those on.
If in doubt, don't do a given file or put out a clearly worded email to the list asking for help!
Jonathan Cameron (14):
iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE iio:configfs: SPDX headers.
iio: sw-device: SPDX headers
iio: sw-trigger: SPDX headers.
iio: triggered-event: Add SPDX and fix header license to match the
code.
iio:buffer-dma: SPDX headers.
iio: buffer-cb: SPDX headers
iio: kfifo-buf: Add SPDX header
iio: buffer-dmaengine: SPDX GPL-2.0+
iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
iio: trig-hrtimer: SPDX header GPLv2
iio: trig-interrupt: SPDX headers. GPLv2
iio: trig-loop: SPDX headers GPL-v2
iio: trig-sysfs: SPDX headers GPLv2.
 drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
 drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
 drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
 drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
 drivers/iio/buffer/kfifo_buf.c                     |  1 +
 drivers/iio/iio_core.h                             |  8 +++-----
 drivers/iio/iio_core_trigger.h                     |  2 +-
 drivers/iio/industrialio-buffer.c                  |  8 +++-----
 drivers/iio/industrialio-configfs.c                |  5 +----
 drivers/iio/industrialio-core.c                    | 10 ++++------
 drivers/iio/industrialio-event.c                   |  4 +++-
 drivers/iio/industrialio-sw-device.c               |  5 +----
 drivers/iio/industrialio-sw-trigger.c              |  5 +----
 drivers/iio/industrialio-trigger.c                 |  8 +++-----
 drivers/iio/industrialio-triggered-event.c         |  6 +-----
 drivers/iio/inkern.c                               |  8 +++-----
 drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
 drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
 drivers/iio/trigger/iio-trig-loop.c                |  3 +--
 drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
 include/linux/iio/buffer-dma.h                     |  3 +--
 include/linux/iio/buffer-dmaengine.h               |  3 +--
 include/linux/iio/buffer.h                         |  8 +++-----
 include/linux/iio/configfs.h                       |  5 +----
 include/linux/iio/consumer.h                       |  5 +----
 include/linux/iio/driver.h                         |  5 +----
 include/linux/iio/events.h                         |  8 +++-----
 include/linux/iio/iio.h                            |  9 +++------
 include/linux/iio/kfifo_buf.h                      |  2 +-
 include/linux/iio/machine.h                        |  5 +----
 include/linux/iio/sw_device.h                      |  5 +----
 include/linux/iio/sw_trigger.h                     |  5 +----
 include/linux/iio/sysfs.h                          | 10 ++++------
 include/linux/iio/trigger.h                        |  5 +----
 include/linux/iio/trigger_consumer.h               |  8 +++-----
 include/linux/iio/triggered_event.h                |  2 +-
 include/linux/iio/types.h                          |  8 +++-----
 37 files changed, 67 insertions(+), 140 deletions(-)

Jonathan Cameron

author maintainer

2019-07-21 17:04 UTC #21 lore raw

Quoted 9 lines · Alexandru

Quoted 7 lines · Jonathan Cameron
[External]
If anyone has time to sanity check these, it would be much appreciated.
At somepoint I'll take a view on them being too dull to garner review, but I really don't like applying stuff that hasn't had a second set of eyes on it.

Quoted 5 lines

Found only one inconsistency in patch 07/14. MODULE_LICENSE("GPL") vs // SPDX-License-Identifier: GPL-2.0
Hopefully that email/reply comes through on the patch itself. If not, maybe this email comes through.

Seems Thomas Gleixner did a tree wide conversion anyway so this series is now defunct. Oh well. I'll do a set to cleanup the various inconsistencies next time I get really bored.

Jonathan

Quoted 95 lines

Quoted 95 lines
Thanks,
Jonathan
Quoted 84 lines · On Sat, 22 Jun 2019 15:55:02 +0100 <[email protected]> wrote:
From: Jonathan Cameron <[email protected]>
There is a general movement towards ensuring all of the kernel source files have SPDX headers. I have previously expressed the view, that, like many cleanups it would be better to do these when otherwise touching the relevant part of the code, rather than creating noise throughout.
Time to change my mind on that, and push through adding these to IIO.
Even in the core code, I was less than entirely consistent with the existing license markings, so there are places where the file headers don't match with the MODULE_LICENSE macro.
There were also headers that gained default SPDX license markings that actually aren't quite correct given the related c files sometimes did have well stated licenses.
If someone has time to check my logic on the these that would be great.
For the drivers, my intent is to use random periods of boredom (I'm on some long haul flights in the near future) to see if I can plough through them. If anyone wants to get ahead of the game and do their own drivers that would be great. This is particularly true in the big octopus drivers that spread throughout the IIO directories and beyond. I'd love it if other people took those on.
If in doubt, don't do a given file or put out a clearly worded email to the list asking for help!
Jonathan Cameron (14):
iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE iio:configfs: SPDX headers.
iio: sw-device: SPDX headers
iio: sw-trigger: SPDX headers.
iio: triggered-event: Add SPDX and fix header license to match the
code.
iio:buffer-dma: SPDX headers.
iio: buffer-cb: SPDX headers
iio: kfifo-buf: Add SPDX header
iio: buffer-dmaengine: SPDX GPL-2.0+
iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
iio: trig-hrtimer: SPDX header GPLv2
iio: trig-interrupt: SPDX headers. GPLv2
iio: trig-loop: SPDX headers GPL-v2
iio: trig-sysfs: SPDX headers GPLv2.
 drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
 drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
 drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
 drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
 drivers/iio/buffer/kfifo_buf.c                     |  1 +
 drivers/iio/iio_core.h                             |  8 +++-----
 drivers/iio/iio_core_trigger.h                     |  2 +-
 drivers/iio/industrialio-buffer.c                  |  8 +++-----
 drivers/iio/industrialio-configfs.c                |  5 +----
 drivers/iio/industrialio-core.c                    | 10 ++++------
 drivers/iio/industrialio-event.c                   |  4 +++-
 drivers/iio/industrialio-sw-device.c               |  5 +----
 drivers/iio/industrialio-sw-trigger.c              |  5 +----
 drivers/iio/industrialio-trigger.c                 |  8 +++-----
 drivers/iio/industrialio-triggered-event.c         |  6 +-----
 drivers/iio/inkern.c                               |  8 +++-----
 drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
 drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
 drivers/iio/trigger/iio-trig-loop.c                |  3 +--
 drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
 include/linux/iio/buffer-dma.h                     |  3 +--
 include/linux/iio/buffer-dmaengine.h               |  3 +--
 include/linux/iio/buffer.h                         |  8 +++-----
 include/linux/iio/configfs.h                       |  5 +----
 include/linux/iio/consumer.h                       |  5 +----
 include/linux/iio/driver.h                         |  5 +----
 include/linux/iio/events.h                         |  8 +++-----
 include/linux/iio/iio.h                            |  9 +++------
 include/linux/iio/kfifo_buf.h                      |  2 +-
 include/linux/iio/machine.h                        |  5 +----
 include/linux/iio/sw_device.h                      |  5 +----
 include/linux/iio/sw_trigger.h                     |  5 +----
 include/linux/iio/sysfs.h                          | 10 ++++------
 include/linux/iio/trigger.h                        |  5 +----
 include/linux/iio/trigger_consumer.h               |  8 +++-----
 include/linux/iio/triggered_event.h                |  2 +-
 include/linux/iio/types.h                          |  8 +++-----
 37 files changed, 67 insertions(+), 140 deletions(-)