Skip to contentSkip to conversation

rsa: reject images with unknown padding

PATCH New Patrick Doyle 2 participants 2 messages Jun 14, 2019 – Jun 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rsa: reject images with unknown padding

Previously we would store NULL in info->padding and jump to an illegal instruction if an unknown value for "padding" was specified in the device tree.

---
 common/image-sig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/image-sig.c +0 -0
index 4f6b4ec..004fbc5 100644
@@ -211,7 +211,7 @@ static int fit_image_setup_verify(struct

image_sign_info *info,

     info->required_keynode = required_keynode;
     printf("%s:%s", algo_name, info->keyname);
-    if (!info->checksum || !info->crypto) {
+    if (!info->checksum || !info->crypto || !info->padding) {
         *err_msgp = "Unknown signature algorithm";
         return -1;
     }
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 rsa: reject images with unknown padding

Quoted 5 lines · Patrick Doyle

Previously we would store NULL in info->padding and jump to an illegal instruction if an unknown value for "padding" was specified in the device tree.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190622/5b4544d1/attachment.sig>